51278 2010-12-17 15:36:33 -0800 Crash at WebCore::SplitElementCommand::SplitElementCommand 2010-12-20 15:58:24 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 enrica enrica abarth adele darin eric rniwa webkit.review.bot oldest_to_newest 324018 0 76920 enrica 2010-12-17 15:36:33 -0800 Created attachment 76920 test case Run the attached test case to see the crash. 324021 1 76921 enrica 2010-12-17 15:43:48 -0800 Created attachment 76921 Patch 324063 2 76921 rniwa 2010-12-17 17:55:01 -0800 Comment on attachment 76921 Patch Do we do the right thing (i.e. remove blockquote) with your patch? Although if the blockquote is inline, then the text isn't really indented so outdenting doesn't really have any visible effect. Also I'd like to see a test case where ul/ol and li are inline. 324437 3 enrica 2010-12-20 10:05:09 -0800 (In reply to comment #2) > (From update of attachment 76921 [details]) > Do we do the right thing (i.e. remove blockquote) with your patch? Although if the blockquote is inline, then the text isn't really indented so outdenting doesn't really have any visible effect. Also I'd like to see a test case where ul/ol and li are inline. I believe the answer is yes. My change is meant to take into account the fact that startOfEnclosingBlock doesn't handle properly a blockquote with inline style and returns a node outside the blockquote. What we want here, is to be able to fall into the first if statement (case in which the block quote is in its own paragraph). The other scenario you mention, is handled by the code after the if statement where we do the splitting. The ordered/unordered list case is handled by completely different code. 324504 4 76921 darin 2010-12-20 12:29:31 -0800 Comment on attachment 76921 Patch We should add more test cases as Ryosuke suggests. 324589 5 enrica 2010-12-20 14:55:32 -0800 Added additional tests, per Ryosuke's comments. Committed revision 74369. 324598 6 rniwa 2010-12-20 15:05:37 -0800 (In reply to comment #5) > Added additional tests, per Ryosuke's comments. > Committed revision 74369. Thanks for the test case. 324617 7 webkit.review.bot 2010-12-20 15:58:24 -0800 http://trac.webkit.org/changeset/74369 might have broken GTK Linux 64-bit Debug The following tests are not passing: inspector/extensions-audits.html 76920 2010-12-17 15:36:33 -0800 2010-12-17 15:36:33 -0800 test case mail.html text/html 666 enrica PGh0bWw+Cjxib2R5IGNvbnRlbnRlZGl0YWJsZT0idHJ1ZSI+Cjxicj4KPGJsb2NrcXVvdGUgaWQ9 InRlc3QiIHN0eWxlPSJkaXNwbGF5OiBpbmxpbmUiPkV4ZWN1dGluZyBPdXRkZW50IG9uIGFuIGlu bGluZSBibG9ja3F1b3RlIHRoYXQgaXMgbm90IHRoZSBmaXJzdCBlbGVtZW50IGluIHRoZSBkb2N1 bWVudCBzaG91bGQgbm90IGNyYXNoLjwvYmxvY2txdW90ZT4KPHAgaWQ9ImNvbnNvbGUiPjwvcD4K PHNjcmlwdD4KaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKICAgIGxheW91dFRlc3RD b250cm9sbGVyLmR1bXBBc1RleHQoKTsKCmZ1bmN0aW9uIGxvZyhtZXNzYWdlKSB7CiAgICB2YXIg Y29uc29sZSA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJjb25zb2xlIik7CiAgICB2YXIgdGV4 dCA9IGRvY3VtZW50LmNyZWF0ZVRleHROb2RlKG1lc3NhZ2UpOwogICAgY29uc29sZS5hcHBlbmRD aGlsZCh0ZXh0KTsKfQoKdmFyIHMgPSB3aW5kb3cuZ2V0U2VsZWN0aW9uKCk7CnZhciBwMSA9IGRv Y3VtZW50LmdldEVsZW1lbnRCeUlkKCJ0ZXN0Iik7CnMuc2V0UG9zaXRpb24ocDEsIDApOwpkb2N1 bWVudC5leGVjQ29tbWFuZCgiT3V0ZGVudCIsIGZhbHNlLCAwKTsKbG9nKCJUZXN0IHBhc3NlZDog bm8gY3Jhc2giKTsKCjwvc2NyaXB0Pgo8L2JvZHk+CjwvaHRtbD4K 76921 2010-12-17 15:43:48 -0800 2010-12-20 12:29:30 -0800 Patch outdent-crash.txt text/plain 4249 enrica SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3NDI5OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjEgQEAKKzIwMTAtMTItMTcgIEVucmljYSBDYXN1Y2NpICA8ZW5yaWNhQGFwcGxl LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBD cmFzaCBhdCBXZWJDb3JlOjpTcGxpdEVsZW1lbnRDb21tYW5kOjpTcGxpdEVsZW1lbnRDb21tYW5k CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MTI3OAor ICAgICAgICA8cmRhcjovL3Byb2JsZW0vNzM0NzEzOT4gCisKKyAgICAgICAgRXhlY3V0aW5nIG91 dGRlbnQgY29tbWFuZCBvbiBhbiBpbmxpbmUgYmxvY2txdW90ZSB0aGF0IGlzCisgICAgICAgIG5v dCB0aGUgZmlyc3QgZWxlbWVudCBpbiBhIGJsb2NrIGNhdXNlcyBhIGNyYXNoLgorICAgICAgICBU aGUgZml4IGNvbnNpc3RzIGluIGNoYWdpbmcgdGhlIHdhcyB0aGUgc3RhcnQgb2YgYmxvY2sgaXMK KyAgICAgICAgY2FsY3VsYXRlZCBpbiBjYXNlIG9mIHRoZSBpbmxpbmUgYmxvY2txdW90ZS4KKyAg ICAgICAgCisgICAgICAgIFRlc3Q6IGVkaXRpbmcvZXhlY0NvbW1hbmQvb3V0ZGVudC1pbmxpbmUt YmxvY2txdW90ZS5odG1sCisKKyAgICAgICAgKiBlZGl0aW5nL0luZGVudE91dGRlbnRDb21tYW5k LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkluZGVudE91dGRlbnRDb21tYW5kOjpvdXRkZW50UGFy YWdyYXBoKToKKwogMjAxMC0xMi0xNyAgQ2Fyb2wgU3phYm8gIDxjYXJvbC5zemFib0Bub2tpYS5j b20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBXZWJDb3JlL2Vk aXRpbmcvSW5kZW50T3V0ZGVudENvbW1hbmQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvZWRp dGluZy9JbmRlbnRPdXRkZW50Q29tbWFuZC5jcHAJKHJldmlzaW9uIDc0Mjk4KQorKysgV2ViQ29y ZS9lZGl0aW5nL0luZGVudE91dGRlbnRDb21tYW5kLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTM1 LDcgKzEzNSw5IEBAIHZvaWQgSW5kZW50T3V0ZGVudENvbW1hbmQ6Om91dGRlbnRQYXJhZ3IKICAg ICAKICAgICAvLyBUaGUgc2VsZWN0aW9uIGlzIGluc2lkZSBhIGJsb2NrcXVvdGUgaS5lLiBlbmNs b3NpbmdOb2RlIGlzIGEgYmxvY2txdW90ZQogICAgIFZpc2libGVQb3NpdGlvbiBwb3NpdGlvbklu RW5jbG9zaW5nQmxvY2sgPSBWaXNpYmxlUG9zaXRpb24oUG9zaXRpb24oZW5jbG9zaW5nTm9kZSwg MCkpOwotICAgIFZpc2libGVQb3NpdGlvbiBzdGFydE9mRW5jbG9zaW5nQmxvY2sgPSBzdGFydE9m QmxvY2socG9zaXRpb25JbkVuY2xvc2luZ0Jsb2NrKTsKKyAgICAvLyBJZiB0aGUgYmxvY2txdW90 ZSBpcyBpbmxpbmUsIHRoZSBzdGFydCBvZiB0aGUgZW5jbG9zaW5nIGJsb2NrIGNvaW5jaWRlcyB3 aXRoCisgICAgLy8gcG9zaXRpb25JbkVuY2xvc2luZ0Jsb2NrLgorICAgIFZpc2libGVQb3NpdGlv biBzdGFydE9mRW5jbG9zaW5nQmxvY2sgPSAoZW5jbG9zaW5nTm9kZS0+cmVuZGVyZXIoKSAmJiBl bmNsb3NpbmdOb2RlLT5yZW5kZXJlcigpLT5pc0lubGluZSgpKSA/IHBvc2l0aW9uSW5FbmNsb3Np bmdCbG9jayA6IHN0YXJ0T2ZCbG9jayhwb3NpdGlvbkluRW5jbG9zaW5nQmxvY2spOwogICAgIFZp c2libGVQb3NpdGlvbiBsYXN0UG9zaXRpb25JbkVuY2xvc2luZ0Jsb2NrID0gVmlzaWJsZVBvc2l0 aW9uKFBvc2l0aW9uKGVuY2xvc2luZ05vZGUsIGVuY2xvc2luZ05vZGUtPmNoaWxkTm9kZUNvdW50 KCkpKTsKICAgICBWaXNpYmxlUG9zaXRpb24gZW5kT2ZFbmNsb3NpbmdCbG9jayA9IGVuZE9mQmxv Y2sobGFzdFBvc2l0aW9uSW5FbmNsb3NpbmdCbG9jayk7CiAgICAgaWYgKHZpc2libGVTdGFydE9m UGFyYWdyYXBoID09IHN0YXJ0T2ZFbmNsb3NpbmdCbG9jayAmJgpJbmRleDogTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24g NzQyOTkpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyAr MSwxNCBAQAorMjAxMC0xMi0xNyAgRW5yaWNhIENhc3VjY2kgIDxlbnJpY2FAYXBwbGUuY29tPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENyYXNoIGF0 IFdlYkNvcmU6OlNwbGl0RWxlbWVudENvbW1hbmQ6OlNwbGl0RWxlbWVudENvbW1hbmQKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUxMjc4CisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS83MzQ3MTM5PiAKKworICAgICAgICAqIGVkaXRpbmcvZXhlY0NvbW1h bmQvb3V0ZGVudC1pbmxpbmUtYmxvY2txdW90ZS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAg ICAqIGVkaXRpbmcvZXhlY0NvbW1hbmQvb3V0ZGVudC1pbmxpbmUtYmxvY2txdW90ZS5odG1sOiBB ZGRlZC4KKwogMjAxMC0xMi0xNyAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IEdhdmluIEJhcnJhY2xvdWdoLgpJbmRleDogTGF5b3V0VGVzdHMv ZWRpdGluZy9leGVjQ29tbWFuZC9vdXRkZW50LWlubGluZS1ibG9ja3F1b3RlLWV4cGVjdGVkLnR4 dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL291dGRlbnQt aW5saW5lLWJsb2NrcXVvdGUtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVz dHMvZWRpdGluZy9leGVjQ29tbWFuZC9vdXRkZW50LWlubGluZS1ibG9ja3F1b3RlLWV4cGVjdGVk LnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwzIEBACisKK0V4ZWN1dGluZyBPdXRkZW50IG9u IGFuIGlubGluZSBibG9ja3F1b3RlIHRoYXQgaXMgbm90IHRoZSBmaXJzdCBlbGVtZW50IGluIHRo ZSBkb2N1bWVudCBzaG91bGQgbm90IGNyYXNoLgorVGVzdCBwYXNzZWQ6IG5vIGNyYXNoCkluZGV4 OiBMYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL291dGRlbnQtaW5saW5lLWJsb2NrcXVv dGUuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL291 dGRlbnQtaW5saW5lLWJsb2NrcXVvdGUuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3Rz L2VkaXRpbmcvZXhlY0NvbW1hbmQvb3V0ZGVudC1pbmxpbmUtYmxvY2txdW90ZS5odG1sCShyZXZp c2lvbiAwKQpAQCAtMCwwICsxLDI0IEBACis8aHRtbD4KKzxib2R5IGNvbnRlbnRlZGl0YWJsZT0i dHJ1ZSI+Cis8YnI+Cis8YmxvY2txdW90ZSBpZD0idGVzdCIgc3R5bGU9ImRpc3BsYXk6IGlubGlu ZSI+RXhlY3V0aW5nIE91dGRlbnQgb24gYW4gaW5saW5lIGJsb2NrcXVvdGUgdGhhdCBpcyBub3Qg dGhlIGZpcnN0IGVsZW1lbnQgaW4gdGhlIGRvY3VtZW50IHNob3VsZCBub3QgY3Jhc2guPC9ibG9j a3F1b3RlPgorPHAgaWQ9ImNvbnNvbGUiPjwvcD4KKzxzY3JpcHQ+CitpZiAod2luZG93LmxheW91 dFRlc3RDb250cm9sbGVyKQorICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsK KworZnVuY3Rpb24gbG9nKG1lc3NhZ2UpIHsKKyAgICB2YXIgY29uc29sZSA9IGRvY3VtZW50Lmdl dEVsZW1lbnRCeUlkKCJjb25zb2xlIik7CisgICAgdmFyIHRleHQgPSBkb2N1bWVudC5jcmVhdGVU ZXh0Tm9kZShtZXNzYWdlKTsKKyAgICBjb25zb2xlLmFwcGVuZENoaWxkKHRleHQpOworfQorCit2 YXIgcyA9IHdpbmRvdy5nZXRTZWxlY3Rpb24oKTsKK3ZhciBwMSA9IGRvY3VtZW50LmdldEVsZW1l bnRCeUlkKCJ0ZXN0Iik7CitzLnNldFBvc2l0aW9uKHAxLCAwKTsKK2RvY3VtZW50LmV4ZWNDb21t YW5kKCJPdXRkZW50IiwgZmFsc2UsIDApOworbG9nKCJUZXN0IHBhc3NlZDogbm8gY3Jhc2giKTsK KworPC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+Cg==