5127 2005-09-25 00:55:22 -0700 REGRESSION: problems making selection with left edge at right edge of image 2006-01-16 12:57:57 -0800 1 1 1 Unclassified WebKit Layout and Rendering 420+ Mac OS X 10.4 VERIFIED FIXED HasReduction, InRadar P1 Major --- 1 ap justin.garcia alice.barraclough darin sullivan oldest_to_newest 20591 0 ap 2005-09-25 00:55:22 -0700 Steps to reproduce: 1) Open the attached document in Blot 2) Position the caret at the end of text 3) Press Shift+Left Arrow three times Resuls: Not only the three rightmost letters, but also the image gets selected. After pressing Shift+Left Arrow for the fourth time, the visible selection doesn't change Regression: works fine with MacOS X 10.4.2/Safari 2.0.1, broken in ToT. 20592 1 4035 ap 2005-09-25 00:55:55 -0700 Created attachment 4035 test document 20620 2 ap 2005-09-26 03:26:49 -0700 This can also be reproduced in Safari: just open the test case and drag-select from right to left. When only the three letters "def" should be selected, the image also gets selected. 21654 3 darin 2005-10-09 20:08:22 -0700 I just tried, and I cannot reproduce this in my TOT build of Safari. 21706 4 darin 2005-10-10 08:05:32 -0700 My mistake, I can reproduce this. 28065 5 sullivan 2006-01-09 10:30:29 -0800 Note that bug 6451 is probably the same issue. 28167 6 alice.barraclough 2006-01-10 10:20:33 -0800 also see <rdar://problem/4402375> 28189 7 alice.barraclough 2006-01-10 14:37:42 -0800 *** Bug 6451 has been marked as a duplicate of this bug. *** 28553 8 5713 justin.garcia 2006-01-15 23:30:53 -0800 Created attachment 5713 patch + layout tests This is a bug in the painting code. It seems like it's always existed, but some change(s) in the last 6-8 months caused more selections to start/end on replaced elements. Here's a fix and 3 layout tests. Also fixes: <rdar://problem/4364427> triple-click includes first item on next line (www.apple.com, but I think I've seen it elsewhere) 28554 9 5713 darin 2006-01-15 23:33:22 -0800 Comment on attachment 5713 patch + layout tests Looks great. r=me 28608 10 justin.garcia 2006-01-16 12:23:06 -0800 fixed 4035 2005-09-25 00:55:55 -0700 2005-09-26 03:22:16 -0700 test document selection.html text/html 282 ap PEhUTUw+PEhFQUQ+PE1FVEEgaHR0cC1lcXVpdj0iQ29udGVudC1UeXBlIiBjb250ZW50PSJ0ZXh0 L2h0bWw7IGNoYXJzZXQ9VVRGLTgiPjwvSEVBRD48Qk9EWSBzdHlsZT0id29yZC13cmFwOiBicmVh ay13b3JkOyAta2h0bWwtbmJzcC1tb2RlOiBzcGFjZTsgLWtodG1sLWxpbmUtYnJlYWs6IGFmdGVy LXdoaXRlLXNwYWNlOyAiPmFiYzxJTUcgc3JjPSJmaWxlOi8vbG9jYWxob3N0L0xpYnJhcnkvVXNl ciUyMFBpY3R1cmVzL0FuaW1hbHMvQnV0dGVyZmx5LnRpZiI+ZGVmCjwvQk9EWT48L0hUTUw+ 5713 2006-01-15 23:30:53 -0800 2006-01-15 23:33:22 -0800 patch + layout tests 5127.txt text/plain 5914 justin.garcia SW5kZXg6IExheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL3JlcGxhY2VkLWJvdW5kYXJpZXMt My5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL3JlcGxh Y2VkLWJvdW5kYXJpZXMtMy5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZWRpdGlu Zy9zZWxlY3Rpb24vcmVwbGFjZWQtYm91bmRhcmllcy0zLmh0bWwJKHJldmlzaW9uIDApCkBAIC0w LDAgKzEsMjEgQEAKKzxodG1sPgorPGhlYWQ+PG1ldGEgaHR0cC1lcXVpdj0iQ29udGVudC1UeXBl IiBjb250ZW50PSJ0ZXh0L2h0bWw7IGNoYXJzZXQ9VVRGLTgiPgorPHNjcmlwdCBzcmM9Li4vZWRp dGluZy5qcyBsYW5ndWFnZT0iSmF2YVNjcmlwdCIgdHlwZT0idGV4dC9KYXZhU2NyaXB0IiA+PC9z Y3JpcHQ+Cis8c2NyaXB0PgorZnVuY3Rpb24gZWRpdGluZ1Rlc3QoKSB7CisgICAgc2VsZWN0QWxs Q29tbWFuZCgpOworICAgIG1vdmVTZWxlY3Rpb25CYWNrd2FyZEJ5Q2hhcmFjdGVyQ29tbWFuZCgp OworICAgIGV4dGVuZFNlbGVjdGlvbkZvcndhcmRCeUxpbmVDb21tYW5kKCk7Cit9Cis8L3Njcmlw dD4KKzwvaGVhZD4KKzxib2R5PgorPHA+VGhpcyB0ZXN0cyB0aGF0IHdoZW4gYSBzZWxlY3Rpb24g dGhhdCBlbmRzIGF0IFtyZXBsYWNlZCBlbGVtZW50LCAwXSBpcyBwYWludGVkLCB0aGUgcmVwbGFj ZWQgZWxlbWVudCBkb2Vzbid0IGFwcGVhciBzZWxlY3RlZC4gIFRoaXMgdGVzdCB1c2VzIGEgc2Vs ZWN0IGJveCBmb3IgdGhlIHJlcGxhY2VkIGVsZW1lbnQuPC9wPgorPGRpdiBpZD0idGVzdCIgY29u dGVudGVkaXRhYmxlPgorYWJjPGJyPgorPHNlbGVjdD48b3B0aW9uPnRoaXMgc2VsZWN0IGJveCBz aG91bGRuJ3QgYmUgc2VsZWN0ZWQ8L29wdGlvbj48b3B0aW9uPjI8L29wdGlvbj48L3NlbGVjdD4K KzwvZGl2PgorPHNjcmlwdD5ydW5FZGl0aW5nVGVzdCgpPC9zY3JpcHQ+Cis8L2JvZHk+CisKKzwv aHRtbD4KXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCkluZGV4OiBMYXlvdXRUZXN0cy9lZGl0 aW5nL3NlbGVjdGlvbi9yZXBsYWNlZC1ib3VuZGFyaWVzLTIuaHRtbAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBM YXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9yZXBsYWNlZC1ib3VuZGFyaWVzLTIuaHRtbAko cmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL3JlcGxhY2VkLWJv dW5kYXJpZXMtMi5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDIyIEBACis8aHRtbD4KKzxo ZWFkPjxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29udGVudD0idGV4dC9odG1sOyBj aGFyc2V0PVVURi04Ij4KKzxzY3JpcHQgc3JjPS4uL2VkaXRpbmcuanMgbGFuZ3VhZ2U9IkphdmFT Y3JpcHQiIHR5cGU9InRleHQvSmF2YVNjcmlwdCIgPjwvc2NyaXB0PgorPHNjcmlwdD4KK2Z1bmN0 aW9uIGVkaXRpbmdUZXN0KCkgeworICAgIHNlbGVjdEFsbENvbW1hbmQoKTsKKyAgICBtb3ZlU2Vs ZWN0aW9uQmFja3dhcmRCeUNoYXJhY3RlckNvbW1hbmQoKTsKKyAgICBleHRlbmRTZWxlY3Rpb25G b3J3YXJkQnlDaGFyYWN0ZXJDb21tYW5kKCk7CisgICAgZXh0ZW5kU2VsZWN0aW9uRm9yd2FyZEJ5 Q2hhcmFjdGVyQ29tbWFuZCgpOworICAgIGV4dGVuZFNlbGVjdGlvbkZvcndhcmRCeUNoYXJhY3Rl ckNvbW1hbmQoKTsKK30KKzwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+Cis8cD5UaGlzIHRlc3Rz IHRoYXQgd2hlbiBhIHNlbGVjdGlvbiB0aGF0IGVuZHMgYXQgW3JlcGxhY2VkIGVsZW1lbnQsIDBd IGlzIHBhaW50ZWQsIHRoZSByZXBsYWNlZCBlbGVtZW50IGRvZXNuJ3QgYXBwZWFyIHNlbGVjdGVk LiAgVGhpcyB0ZXN0IHVzZXMgYW4gaW1hZ2UgZm9yIHRoZSByZXBsYWNlZCBlbGVtZW50LjwvcD4K KzxkaXYgaWQ9InRlc3QiIGNvbnRlbnRlZGl0YWJsZT4KK2FiYzxpbWcgc3JjPSIuLi9hYmUuanBn Ij5kZWYKKzwvZGl2PgorPHNjcmlwdD5ydW5FZGl0aW5nVGVzdCgpPC9zY3JpcHQ+Cis8L2JvZHk+ CisKKzwvaHRtbD4KXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCkluZGV4OiBMYXlvdXRUZXN0 cy9lZGl0aW5nL3NlbGVjdGlvbi9yZXBsYWNlZC1ib3VuZGFyaWVzLTEuaHRtbAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9yZXBsYWNlZC1ib3VuZGFyaWVzLTEu aHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL3JlcGxh Y2VkLWJvdW5kYXJpZXMtMS5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDIyIEBACis8aHRt bD4KKzxoZWFkPjxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29udGVudD0idGV4dC9o dG1sOyBjaGFyc2V0PVVURi04Ij4KKzxzY3JpcHQgc3JjPS4uL2VkaXRpbmcuanMgbGFuZ3VhZ2U9 IkphdmFTY3JpcHQiIHR5cGU9InRleHQvSmF2YVNjcmlwdCIgPjwvc2NyaXB0PgorPHNjcmlwdD4K K2Z1bmN0aW9uIGVkaXRpbmdUZXN0KCkgeworICAgIHNlbGVjdEFsbENvbW1hbmQoKTsKKyAgICBt b3ZlU2VsZWN0aW9uRm9yd2FyZEJ5Q2hhcmFjdGVyQ29tbWFuZCgpOworICAgIGV4dGVuZFNlbGVj dGlvbkJhY2t3YXJkQnlDaGFyYWN0ZXJDb21tYW5kKCk7CisgICAgZXh0ZW5kU2VsZWN0aW9uQmFj a3dhcmRCeUNoYXJhY3RlckNvbW1hbmQoKTsKKyAgICBleHRlbmRTZWxlY3Rpb25CYWNrd2FyZEJ5 Q2hhcmFjdGVyQ29tbWFuZCgpOworfQorPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxwPlRo aXMgdGVzdHMgdGhhdCB3aGVuIGEgc2VsZWN0aW9uIHRoYXQgc3RhcnRzIGF0IFtyZXBsYWNlZCBl bGVtZW50LCAxXSBpcyBwYWludGVkLCB0aGUgcmVwbGFjZWQgZWxlbWVudCBkb2Vzbid0IGFwcGVh ciBzZWxlY3RlZC4gIFRoaXMgdGVzdCB1c2VzIGFuIGltYWdlIGZvciB0aGUgcmVwbGFjZWQgZWxl bWVudC48L3A+Cis8ZGl2IGlkPSJ0ZXN0IiBjb250ZW50ZWRpdGFibGU+CithYmM8aW1nIHNyYz0i Li4vYWJlLmpwZyI+ZGVmCis8L2Rpdj4KKzxzY3JpcHQ+cnVuRWRpdGluZ1Rlc3QoKTwvc2NyaXB0 PgorPC9ib2R5PgorCis8L2h0bWw+ClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQpJbmRleDog V2ViQ29yZS9raHRtbC9yZW5kZXJpbmcvcmVuZGVyX3JlcGxhY2VkLmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViQ29yZS9raHRtbC9yZW5kZXJpbmcvcmVuZGVyX3JlcGxhY2VkLmgJKHJldmlzaW9uIDEyMTIz KQorKysgV2ViQ29yZS9raHRtbC9yZW5kZXJpbmcvcmVuZGVyX3JlcGxhY2VkLmgJKHdvcmtpbmcg Y29weSkKQEAgLTYzLDcgKzYzLDcgQEAKICAgICB2aXJ0dWFsIFNlbGVjdGlvblN0YXRlIHNlbGVj dGlvblN0YXRlKCkgY29uc3QgeyByZXR1cm4gbV9zZWxlY3Rpb25TdGF0ZTsgfQogICAgIHZpcnR1 YWwgdm9pZCBzZXRTZWxlY3Rpb25TdGF0ZShTZWxlY3Rpb25TdGF0ZSBzKTsKICAgICB2aXJ0dWFs IEludFJlY3Qgc2VsZWN0aW9uUmVjdCgpOwotICAgIAorICAgIGJvb2wgaXNTZWxlY3RlZCgpOwog ICAgIHZpcnR1YWwgUUNvbG9yIHNlbGVjdGlvbkNvbG9yKFFQYWludGVyICpwKSBjb25zdDsKIAog cHJvdGVjdGVkOgpJbmRleDogV2ViQ29yZS9raHRtbC9yZW5kZXJpbmcvcmVuZGVyX2ltYWdlLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2todG1sL3JlbmRlcmluZy9yZW5kZXJfaW1hZ2UuY3Bw CShyZXZpc2lvbiAxMjEyMykKKysrIFdlYkNvcmUva2h0bWwvcmVuZGVyaW5nL3JlbmRlcl9pbWFn ZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIwOCw3ICsyMDgsNyBAQAogICAgICAgICByZXR1cm47 CiAgICAgICAgIAogICAgIGJvb2wgaXNQcmludGluZyA9IChpLnAtPmRldmljZSgpLT5kZXZUeXBl KCkgPT0gUUludGVybmFsOjpQcmludGVyKTsKLSAgICBib29sIGRyYXdTZWxlY3Rpb25UaW50ID0g KHNlbGVjdGlvblN0YXRlKCkgIT0gU2VsZWN0aW9uTm9uZSkgJiYgIWlzUHJpbnRpbmc7CisgICAg Ym9vbCBkcmF3U2VsZWN0aW9uVGludCA9IGlzU2VsZWN0ZWQoKSAmJiAhaXNQcmludGluZzsKICAg ICBpZiAoaS5waGFzZSA9PSBQYWludEFjdGlvblNlbGVjdGlvbikgewogICAgICAgICBpZiAoc2Vs ZWN0aW9uU3RhdGUoKSA9PSBTZWxlY3Rpb25Ob25lKSB7CiAgICAgICAgICAgICByZXR1cm47Cklu ZGV4OiBXZWJDb3JlL2todG1sL3JlbmRlcmluZy9yZW5kZXJfcmVwbGFjZWQuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYkNvcmUva2h0bWwvcmVuZGVyaW5nL3JlbmRlcl9yZXBsYWNlZC5jcHAJKHJldmlz aW9uIDEyMTIzKQorKysgV2ViQ29yZS9raHRtbC9yZW5kZXJpbmcvcmVuZGVyX3JlcGxhY2VkLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMjAzLDcgKzIwMywyOSBAQAogICAgIGNvbnRhaW5pbmdCbG9j aygpLT5zZXRTZWxlY3Rpb25TdGF0ZShzKTsKIH0KIAorYm9vbCBSZW5kZXJSZXBsYWNlZDo6aXNT ZWxlY3RlZCgpCit7CisgICAgU2VsZWN0aW9uU3RhdGUgcyA9IHNlbGVjdGlvblN0YXRlKCk7Cisg ICAgaWYgKHMgPT0gU2VsZWN0aW9uTm9uZSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIGlm IChzID09IFNlbGVjdGlvbkluc2lkZSkKKyAgICAgICAgcmV0dXJuIHRydWU7CiAKKyAgICBpbnQg c2VsZWN0aW9uU3RhcnQsIHNlbGVjdGlvbkVuZDsKKyAgICBSZW5kZXJPYmplY3Q6OnNlbGVjdGlv blN0YXJ0RW5kKHNlbGVjdGlvblN0YXJ0LCBzZWxlY3Rpb25FbmQpOworICAgIGlmIChzID09IFNl bGVjdGlvblN0YXJ0KQorICAgICAgICByZXR1cm4gc2VsZWN0aW9uU3RhcnQgPT0gMDsKKyAgICAg ICAgCisgICAgaW50IGVuZCA9IGVsZW1lbnQoKS0+aGFzQ2hpbGROb2RlcygpID8gZWxlbWVudCgp LT5jaGlsZE5vZGVDb3VudCgpIDogMTsKKyAgICBpZiAocyA9PSBTZWxlY3Rpb25FbmQpCisgICAg ICAgIHJldHVybiBzZWxlY3Rpb25FbmQgPT0gZW5kOworICAgIGlmIChzID09IFNlbGVjdGlvbkJv dGgpCisgICAgICAgIHJldHVybiBzZWxlY3Rpb25TdGFydCA9PSAwICYmIHNlbGVjdGlvbkVuZCA9 PSBlbmQ7CisgICAgICAgIAorICAgIGFzc2VydCgwKTsKKyAgICByZXR1cm4gZmFsc2U7Cit9CisK IFFDb2xvciBSZW5kZXJSZXBsYWNlZDo6c2VsZWN0aW9uQ29sb3IoUVBhaW50ZXIgKnApIGNvbnN0 CiB7CiAgICAgUUNvbG9yIGNvbG9yID0gUmVuZGVyQm94OjpzZWxlY3Rpb25Db2xvcihwKTsKQEAg LTM4Nyw3ICs0MDksNyBAQAogICAgIAogICAgIC8vIFBhaW50IGEgcGFydGlhbGx5IHRyYW5zcGFy ZW50IHdhc2ggb3ZlciBzZWxlY3RlZCB3aWRnZXRzLgogICAgIGJvb2wgaXNQcmludGluZyA9IChp LnAtPmRldmljZSgpLT5kZXZUeXBlKCkgPT0gUUludGVybmFsOjpQcmludGVyKTsKLSAgICBpZiAo bV9zZWxlY3Rpb25TdGF0ZSAhPSBTZWxlY3Rpb25Ob25lICYmICFpc1ByaW50aW5nKSB7CisgICAg aWYgKGlzU2VsZWN0ZWQoKSAmJiAhaXNQcmludGluZykgewogICAgICAgICBRQnJ1c2ggYnJ1c2go c2VsZWN0aW9uQ29sb3IoaS5wKSk7CiAgICAgICAgIEludFJlY3Qgc2VsUmVjdChzZWxlY3Rpb25S ZWN0KCkpOwogICAgICAgICBpLnAtPmZpbGxSZWN0KHNlbFJlY3QueCgpLCBzZWxSZWN0LnkoKSwg c2VsUmVjdC53aWR0aCgpLCBzZWxSZWN0LmhlaWdodCgpLCBicnVzaCk7Cg==