51266 2010-12-17 11:24:27 -0800 WebKit2: Implement a title attribute per frame 2010-12-17 11:36:02 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 sam webkit-unassigned oldest_to_newest 323889 0 sam 2010-12-17 11:24:27 -0800 WebKit2: Implement a title attribute per frame. WebKit1 has a per-frame title attribute. On the Mac this is exposed as [WebDataSource pageTitle]. 323893 1 76897 sam 2010-12-17 11:28:21 -0800 Created attachment 76897 Patch 323896 2 76897 darin 2010-12-17 11:32:04 -0800 Comment on attachment 76897 Patch A little irritating that frame titles matter. 323901 3 sam 2010-12-17 11:35:25 -0800 (In reply to comment #2) > (From update of attachment 76897 [details]) > A little irritating that frame titles matter. Indeed. I blame John Sullivan. 323903 4 sam 2010-12-17 11:36:02 -0800 Landed in r74282. 76897 2010-12-17 11:28:21 -0800 2010-12-17 11:32:04 -0800 Patch titlePerFrame.diff text/plain 7227 sam SW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hhbmdlTG9n CShyZXZpc2lvbiA3NDI4MCkKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMzMgQEAKKzIwMTAtMTItMTcgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWJLaXQy OiBJbXBsZW1lbnQgYSB0aXRsZSBhdHRyaWJ1dGUgcGVyIGZyYW1lCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MTI2NgorCisgICAgICAgIENhY2hlIHRo ZSB0aXRsZSBvZiBlYWNoIGZyYW1lIG9uIHRoZSBXZWJGcmFtZVByb3h5LiBSZW1vdmVzCisgICAg ICAgIHRoZSBXZWJQYWdlUHJveHkncyBjYWNoZSBvZiB0aGUgbWFpbiBmcmFtZSB0aXRsZSB0byBq dXN0CisgICAgICAgIGFjY2VzcyB0aGUgbWFpbiBmcmFtZS4KKworICAgICAgICBXZSBjbGVhciB0 aGUgY2FjaGVkIHRpdGxlIG9uIG5ldyBjb21taXR0ZWQgbG9hZHMgYW5kIG9uIGZhaWx1cmVzCisg ICAgICAgIHRvIGxvYWQuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0MvV0tGcmFtZS5jcHA6 CisgICAgICAgIChXS0ZyYW1lQ29weVRpdGxlKToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0Mv V0tGcmFtZS5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJGcmFtZVByb3h5LmNwcDoKKyAgICAg ICAgKFdlYktpdDo6V2ViRnJhbWVQcm94eTo6ZGlkQ29tbWl0TG9hZCk6CisgICAgICAgIChXZWJL aXQ6OldlYkZyYW1lUHJveHk6OmRpZEZhaWxMb2FkKToKKyAgICAgICAgKFdlYktpdDo6V2ViRnJh bWVQcm94eTo6ZGlkQ2hhbmdlVGl0bGUpOgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJGcmFtZVBy b3h5Lmg6CisgICAgICAgIChXZWJLaXQ6OldlYkZyYW1lUHJveHk6OnRpdGxlKToKKyAgICAgICAg KiBVSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVBy b3h5OjpjbG9zZSk6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6cGFnZVRpdGxlKToK KyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVByb3h5OjpkaWRSZWNlaXZlVGl0bGVGb3JGcmFtZSk6 CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6cHJvY2Vzc0RpZENyYXNoKToKKyAgICAg ICAgKiBVSVByb2Nlc3MvV2ViUGFnZVByb3h5Lmg6CisKIDIwMTAtMTItMTYgIERhcmluIEFkbGVy ICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hY2llaiBTdGFjaG93 aWFrLgpJbmRleDogV2ViS2l0Mi9VSVByb2Nlc3MvV2ViRnJhbWVQcm94eS5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViS2l0Mi9VSVByb2Nlc3MvV2ViRnJhbWVQcm94eS5jcHAJKHJldmlzaW9uIDc0Mjc3 KQorKysgV2ViS2l0Mi9VSVByb2Nlc3MvV2ViRnJhbWVQcm94eS5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTEyNywxMCArMTI3LDEwIEBAIHZvaWQgV2ViRnJhbWVQcm94eTo6ZGlkRmFpbFByb3Zpc2lv bmFsTG8KIAogdm9pZCBXZWJGcmFtZVByb3h5OjpkaWRDb21taXRMb2FkKCkKIHsKLSAgICAvLyBG SVhNRTogQWRkIGFzc2VydGlvbnMuCiAgICAgbV9sb2FkU3RhdGUgPSBMb2FkU3RhdGVDb21taXR0 ZWQ7CiAgICAgbV91cmwgPSBtX3Byb3Zpc2lvbmFsVVJMOwogICAgIG1fcHJvdmlzaW9uYWxVUkwg PSBTdHJpbmcoKTsKKyAgICBtX3RpdGxlID0gU3RyaW5nKCk7CiB9CiAKIHZvaWQgV2ViRnJhbWVQ cm94eTo6ZGlkRmluaXNoTG9hZCgpCkBAIC0xNDIsNiArMTQyLDcgQEAgdm9pZCBXZWJGcmFtZVBy b3h5OjpkaWRGaW5pc2hMb2FkKCkKIHZvaWQgV2ViRnJhbWVQcm94eTo6ZGlkRmFpbExvYWQoKQog ewogICAgIG1fbG9hZFN0YXRlID0gTG9hZFN0YXRlRmluaXNoZWQ7CisgICAgbV90aXRsZSA9IFN0 cmluZygpOwogfQogCiB2b2lkIFdlYkZyYW1lUHJveHk6OmRpZFNhbWVEb2N1bWVudE5hdmlnYXRp b24oY29uc3QgU3RyaW5nJiB1cmwpCkBAIC0xNDksOCArMTUwLDkgQEAgdm9pZCBXZWJGcmFtZVBy b3h5OjpkaWRTYW1lRG9jdW1lbnROYXZpZwogICAgIG1fdXJsID0gdXJsOwogfQogCi12b2lkIFdl YkZyYW1lUHJveHk6OmRpZFJlY2VpdmVUaXRsZShjb25zdCBTdHJpbmcmKQordm9pZCBXZWJGcmFt ZVByb3h5OjpkaWRDaGFuZ2VUaXRsZShjb25zdCBTdHJpbmcmIHRpdGxlKQogeworICAgIG1fdGl0 bGUgPSB0aXRsZTsKIH0KIAogdm9pZCBXZWJGcmFtZVByb3h5OjpyZWNlaXZlZFBvbGljeURlY2lz aW9uKFdlYkNvcmU6OlBvbGljeUFjdGlvbiBhY3Rpb24sIHVpbnQ2NF90IGxpc3RlbmVySUQpCklu ZGV4OiBXZWJLaXQyL1VJUHJvY2Vzcy9XZWJGcmFtZVByb3h5LmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi S2l0Mi9VSVByb2Nlc3MvV2ViRnJhbWVQcm94eS5oCShyZXZpc2lvbiA3NDI3NykKKysrIFdlYktp dDIvVUlQcm9jZXNzL1dlYkZyYW1lUHJveHkuaAkod29ya2luZyBjb3B5KQpAQCAtODQsNiArODQs OCBAQCBwdWJsaWM6CiAgICAgdm9pZCBzZXRNSU1FVHlwZShjb25zdCBTdHJpbmcmIG1pbWVUeXBl KSB7IG1fTUlNRVR5cGUgPSBtaW1lVHlwZTsgfQogICAgIGNvbnN0IFN0cmluZyYgbWltZVR5cGUo KSBjb25zdCB7IHJldHVybiBtX01JTUVUeXBlOyB9CiAKKyAgICBjb25zdCBTdHJpbmcmIHRpdGxl KCkgY29uc3QgeyByZXR1cm4gbV90aXRsZTsgfQorCiAgICAgdm9pZCBzZXRDZXJ0aWZpY2F0ZUlu Zm8oUGFzc1JlZlB0cjxXZWJDZXJ0aWZpY2F0ZUluZm8+KTsKICAgICBXZWJDZXJ0aWZpY2F0ZUlu Zm8qIGNlcnRpZmljYXRlSW5mbygpIGNvbnN0IHsgcmV0dXJuIG1fY2VydGlmaWNhdGVJbmZvLmdl dCgpOyB9CiAKQEAgLTEwMCw3ICsxMDIsNyBAQCBwdWJsaWM6CiAgICAgdm9pZCBkaWRGaW5pc2hM b2FkKCk7CiAgICAgdm9pZCBkaWRGYWlsTG9hZCgpOwogICAgIHZvaWQgZGlkU2FtZURvY3VtZW50 TmF2aWdhdGlvbihjb25zdCBTdHJpbmcmKTsgLy8gZWcuIGFuY2hvciBuYXZpZ2F0aW9uLCBzZXNz aW9uIHN0YXRlIGNoYW5nZS4KLSAgICB2b2lkIGRpZFJlY2VpdmVUaXRsZShjb25zdCBTdHJpbmcm KTsKKyAgICB2b2lkIGRpZENoYW5nZVRpdGxlKGNvbnN0IFN0cmluZyYpOwogCiAgICAgdm9pZCBy ZWNlaXZlZFBvbGljeURlY2lzaW9uKFdlYkNvcmU6OlBvbGljeUFjdGlvbiwgdWludDY0X3QgbGlz dGVuZXJJRCk7CiAgICAgV2ViRnJhbWVQb2xpY3lMaXN0ZW5lclByb3h5KiBzZXRVcFBvbGljeUxp c3RlbmVyUHJveHkodWludDY0X3QgbGlzdGVuZXJJRCk7CkBAIC0xMTcsNiArMTE5LDcgQEAgcHJp dmF0ZToKICAgICBTdHJpbmcgbV9wcm92aXNpb25hbFVSTDsKICAgICBTdHJpbmcgbV91bnJlYWNo YWJsZVVSTDsKICAgICBTdHJpbmcgbV9NSU1FVHlwZTsKKyAgICBTdHJpbmcgbV90aXRsZTsKICAg ICBib29sIG1faXNGcmFtZVNldDsKICAgICBSZWZQdHI8V2ViQ2VydGlmaWNhdGVJbmZvPiBtX2Nl cnRpZmljYXRlSW5mbzsKICAgICBSZWZQdHI8V2ViRnJhbWVMaXN0ZW5lclByb3h5PiBtX2FjdGl2 ZUxpc3RlbmVyOwpJbmRleDogV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCShyZXZpc2lvbiA3 NDI3NykKKysrIFdlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTIzOCw3ICsyMzgsNiBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6Y2xvc2UoKQogICAgICAg ICBtX29wZW5QYW5lbFJlc3VsdExpc3RlbmVyID0gMDsKICAgICB9CiAKLSAgICBtX3BhZ2VUaXRs ZSA9IFN0cmluZygpOwogICAgIG1fdG9vbFRpcCA9IFN0cmluZygpOwogCiAgICAgaW52YWxpZGF0 ZUNhbGxiYWNrTWFwKG1fY29udGVudHNBc1N0cmluZ0NhbGxiYWNrcyk7CkBAIC02MjMsNiArNjIy LDE1IEBAIHZvaWQgV2ViUGFnZVByb3h5OjpyZWNlaXZlZFBvbGljeURlY2lzaW8KICAgICBwcm9j ZXNzKCktPnNlbmQoTWVzc2FnZXM6OldlYlBhZ2U6OkRpZFJlY2VpdmVQb2xpY3lEZWNpc2lvbihm cmFtZS0+ZnJhbWVJRCgpLCBsaXN0ZW5lcklELCBhY3Rpb24sIGRvd25sb2FkSUQpLCBtX3BhZ2VJ RCk7CiB9CiAKKworU3RyaW5nIFdlYlBhZ2VQcm94eTo6cGFnZVRpdGxlKCkgY29uc3QKK3sKKyAg ICBpZiAoIW1fbWFpbkZyYW1lKQorICAgICAgICByZXR1cm4gU3RyaW5nKCk7CisKKyAgICByZXR1 cm4gbV9tYWluRnJhbWUtPnRpdGxlKCk7Cit9CisKIHZvaWQgV2ViUGFnZVByb3h5OjpzZXRVc2Vy QWdlbnQoY29uc3QgU3RyaW5nJiB1c2VyQWdlbnQpCiB7CiAgICAgaWYgKG1fdXNlckFnZW50ID09 IHVzZXJBZ2VudCkKQEAgLTEwMTQsMTMgKzEwMjIsOCBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6ZGlk UmVjZWl2ZVRpdGxlRm9yRnJhCiAgICAgICAgIHJldHVybjsKIAogICAgIFdlYkZyYW1lUHJveHkq IGZyYW1lID0gcHJvY2VzcygpLT53ZWJGcmFtZShmcmFtZUlEKTsKLQotICAgIGZyYW1lLT5kaWRS ZWNlaXZlVGl0bGUodGl0bGUpOwotCi0gICAgLy8gQ2FjaGUgdGhlIHRpdGxlIGZvciB0aGUgbWFp biBmcmFtZSBpbiB0aGUgcGFnZS4KLSAgICBpZiAoZnJhbWUgPT0gbV9tYWluRnJhbWUpCi0gICAg ICAgIG1fcGFnZVRpdGxlID0gdGl0bGU7Ci0KKyAgICBmcmFtZS0+ZGlkQ2hhbmdlVGl0bGUodGl0 bGUpOworICAgIAogICAgIG1fbG9hZGVyQ2xpZW50LmRpZFJlY2VpdmVUaXRsZUZvckZyYW1lKHRo aXMsIHRpdGxlLCBmcmFtZSwgdXNlckRhdGEuZ2V0KCkpOwogfQogCkBAIC0xNzE0LDcgKzE3MTcs NiBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6cHJvY2Vzc0RpZENyYXNoKCkKICAgICAgICAgbV9vcGVu UGFuZWxSZXN1bHRMaXN0ZW5lciA9IDA7CiAgICAgfQogCi0gICAgbV9wYWdlVGl0bGUgPSBTdHJp bmcoKTsKICAgICBtX3Rvb2xUaXAgPSBTdHJpbmcoKTsKIAogICAgIGludmFsaWRhdGVDYWxsYmFj a01hcChtX2NvbnRlbnRzQXNTdHJpbmdDYWxsYmFja3MpOwpJbmRleDogV2ViS2l0Mi9VSVByb2Nl c3MvV2ViUGFnZVByb3h5LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFn ZVByb3h5LmgJKHJldmlzaW9uIDc0Mjc3KQorKysgV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVBy b3h5LmgJKHdvcmtpbmcgY29weSkKQEAgLTIwMSw3ICsyMDEsNyBAQCBwdWJsaWM6CiAgICAgdm9p ZCBoYW5kbGVUb3VjaEV2ZW50KGNvbnN0IFdlYlRvdWNoRXZlbnQmKTsKICNlbmRpZgogCi0gICAg Y29uc3QgU3RyaW5nJiBwYWdlVGl0bGUoKSBjb25zdCB7IHJldHVybiBtX3BhZ2VUaXRsZTsgfQor ICAgIFN0cmluZyBwYWdlVGl0bGUoKSBjb25zdDsKICAgICBjb25zdCBTdHJpbmcmIHRvb2xUaXAo KSBjb25zdCB7IHJldHVybiBtX3Rvb2xUaXA7IH0KIAogICAgIHZvaWQgc2V0VXNlckFnZW50KGNv bnN0IFN0cmluZyYpOwpAQCAtNDM1LDcgKzQzNSw2IEBAIHByaXZhdGU6CiAgICAgUmVmUHRyPFdl YlBhZ2VHcm91cD4gbV9wYWdlR3JvdXA7CiAgICAgUmVmUHRyPFdlYkZyYW1lUHJveHk+IG1fbWFp bkZyYW1lOwogICAgIFJlZlB0cjxXZWJGcmFtZVByb3h5PiBtX2ZvY3VzZWRGcmFtZTsKLSAgICBT dHJpbmcgbV9wYWdlVGl0bGU7CiAKICAgICBTdHJpbmcgbV91c2VyQWdlbnQ7CiAgICAgU3RyaW5n IG1fYXBwbGljYXRpb25OYW1lRm9yVXNlckFnZW50OwpJbmRleDogV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL0MvV0tGcmFtZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0Mv V0tGcmFtZS5jcHAJKHJldmlzaW9uIDc0Mjc3KQorKysgV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0Mv V0tGcmFtZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTc2LDYgKzc2LDExIEBAIFdLU3RyaW5nUmVm IFdLRnJhbWVDb3B5TUlNRVR5cGUoV0tGcmFtZVIKICAgICByZXR1cm4gdG9Db3BpZWRBUEkodG9J bXBsKGZyYW1lUmVmKS0+bWltZVR5cGUoKSk7CiB9CiAKK1dLU3RyaW5nUmVmIFdLRnJhbWVDb3B5 VGl0bGUoV0tGcmFtZVJlZiBmcmFtZVJlZikKK3sKKyAgICByZXR1cm4gdG9Db3BpZWRBUEkodG9J bXBsKGZyYW1lUmVmKS0+dGl0bGUoKSk7Cit9CisKIFdLUGFnZVJlZiBXS0ZyYW1lR2V0UGFnZShX S0ZyYW1lUmVmIGZyYW1lUmVmKQogewogICAgIHJldHVybiB0b0FQSSh0b0ltcGwoZnJhbWVSZWYp LT5wYWdlKCkpOwpJbmRleDogV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tGcmFtZS5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLRnJhbWUuaAkocmV2aXNpb24gNzQy NzcpCisrKyBXZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS0ZyYW1lLmgJKHdvcmtpbmcgY29weSkK QEAgLTQ5LDEwICs0OSwxMCBAQCBXS19FWFBPUlQgYm9vbCBXS0ZyYW1lSXNNYWluRnJhbWUoV0tG cmFtCiBXS19FWFBPUlQgV0tGcmFtZUxvYWRTdGF0ZSBXS0ZyYW1lR2V0RnJhbWVMb2FkU3RhdGUo V0tGcmFtZVJlZiBmcmFtZSk7CiBXS19FWFBPUlQgV0tVUkxSZWYgV0tGcmFtZUNvcHlQcm92aXNp b25hbFVSTChXS0ZyYW1lUmVmIGZyYW1lKTsKIFdLX0VYUE9SVCBXS1VSTFJlZiBXS0ZyYW1lQ29w eVVSTChXS0ZyYW1lUmVmIGZyYW1lKTsKLQogV0tfRVhQT1JUIFdLVVJMUmVmIFdLRnJhbWVDb3B5 VW5yZWFjaGFibGVVUkwoV0tGcmFtZVJlZiBmcmFtZSk7CiAKIFdLX0VYUE9SVCBXS1N0cmluZ1Jl ZiBXS0ZyYW1lQ29weU1JTUVUeXBlKFdLRnJhbWVSZWYgZnJhbWUpOworV0tfRVhQT1JUIFdLU3Ry aW5nUmVmIFdLRnJhbWVDb3B5VGl0bGUoV0tGcmFtZVJlZiBmcmFtZSk7CiAKIFdLX0VYUE9SVCBX S1BhZ2VSZWYgV0tGcmFtZUdldFBhZ2UoV0tGcmFtZVJlZiBmcmFtZSk7CiAK