51233 2010-12-16 22:50:43 -0800 [Qt] Default image interpolation should reset the render hint 2010-12-17 08:43:21 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 ariya.hidayat ariya.hidayat hausmann kling webkit-ews oldest_to_newest 323608 0 ariya.hidayat 2010-12-16 22:50:43 -0800 Setting image interpolation quality to 'default' sets the SmoothPixmapTransform render hint. This breaks the low-quality painting logic in GraphicsContext::drawImage. The reason is because the logic involves the steps: save current image interpolation quality, set the quality to low, draw the image, revert back the quality to the original. Thus, default must serve as a way to reset the render hint (to the original), otherwise the SmoothPixmapTransform render hint will be set forever. 323617 1 76849 ariya.hidayat 2010-12-16 23:36:37 -0800 Created attachment 76849 [Qt] Default image interpolation should reset the render hint 323620 2 webkit-ews 2010-12-16 23:47:35 -0800 Attachment 76849 did not build on qt: Build output: http://queues.webkit.org/results/7255006 323622 3 76851 ariya.hidayat 2010-12-17 00:00:51 -0800 Created attachment 76851 [Qt] Default image interpolation should reset the render hint 323683 4 76851 kling 2010-12-17 02:53:01 -0800 Comment on attachment 76851 [Qt] Default image interpolation should reset the render hint Thanks for fixing this! r=me 323800 5 76851 ariya.hidayat 2010-12-17 08:43:14 -0800 Comment on attachment 76851 [Qt] Default image interpolation should reset the render hint Clearing flags on attachment: 76851 Committed r74272: <http://trac.webkit.org/changeset/74272> 323801 6 ariya.hidayat 2010-12-17 08:43:21 -0800 All reviewed patches have been landed. Closing bug. 76849 2010-12-16 23:36:37 -0800 2010-12-17 00:00:47 -0800 [Qt] Default image interpolation should reset the render hint bug-51233-20101216233636.patch text/plain 2829 ariya.hidayat ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MTc0NGVhNTJiYTdlMmVmMmJiYjAzYzQzMGFiM2UzYjY3ZGQwNGI5Mi4uYmU5MDI0NjU4MDBhOTg4 NmY4NGEzOTVjMmRhZjZkMWFkYTc4MTMwMCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0xMi0xNiAgQXJp eWEgSGlkYXlhdCAgPGFyaXlhQHNlbmNoYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBEZWZhdWx0IGltYWdlIGludGVycG9sYXRpb24g c2hvdWxkIHJlc2V0IHRoZSByZW5kZXIgaGludAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTEyMzMKKworICAgICAgICBTYXZlIGluaXRpYWwgU21vb3Ro UGl4bWFwVHJhbnNmb3JtIHJlbmRlciBoaW50IHNvIHRoYXQgaXQgY2FuIGJlIHVzZWQKKyAgICAg ICAgd2l0aCBkZWZhdWx0IGltYWdlIGludGVycG9sYXRpb24gcXVhbGl0eSB0byByZXNldCBiYWNr IHRoZSByZW5kZXIgaGludHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFw aGljc0NvbnRleHRRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHRQbGF0 Zm9ybVByaXZhdGU6OkdyYXBoaWNzQ29udGV4dFBsYXRmb3JtUHJpdmF0ZSk6CisgICAgICAgIChX ZWJDb3JlOjpHcmFwaGljc0NvbnRleHQ6OnNldEltYWdlSW50ZXJwb2xhdGlvblF1YWxpdHkpOgor CiAyMDEwLTEyLTE2ICBLb2FuLVNpbiBUYW4gIDxrb2Fuc2luLnRhbkBnbWFpbC5jb20+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgS2VudCBUYW11cmEuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4dFF0LmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0UXQuY3BwCmluZGV4IDkyZGQzZTQ0YmUyYTZkNWNh MjRkYTk5OWM1MmQ0OTQwZWVmNjcxN2MuLjJlZjNhNzQ2ZGE3YzZmYjJkNGQ1ZmU2NGRjOTAzZDM5 ZGEyYWFiMzcgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhp Y3NDb250ZXh0UXQuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhp Y3NDb250ZXh0UXQuY3BwCkBAIC0xOTgsNiArMTk4LDcgQEAgcHVibGljOgogICAgIFFCcnVzaCBz b2xpZENvbG9yOwogCiAgICAgSW50ZXJwb2xhdGlvblF1YWxpdHkgaW1hZ2VJbnRlcnBvbGF0aW9u UXVhbGl0eTsKKyAgICBib29sIGluaXRpYWxTbW9vdGhQaXhtYXBUcmFuc2Zvcm1IaW50OwogCiAg ICAgQ29udGV4dFNoYWRvdyBzaGFkb3c7CiAgICAgUVN0YWNrPENvbnRleHRTaGFkb3c+IHNoYWRv d1N0YWNrOwpAQCAtMjI5LDYgKzIzMCw3IEBAIEdyYXBoaWNzQ29udGV4dFBsYXRmb3JtUHJpdmF0 ZTo6R3JhcGhpY3NDb250ZXh0UGxhdGZvcm1Qcml2YXRlKFFQYWludGVyKiBwLCBjb25zCiAgICAg LCBzb2xpZENvbG9yKGluaXRpYWxTb2xpZENvbG9yKQogICAgICwgaW1hZ2VJbnRlcnBvbGF0aW9u UXVhbGl0eShJbnRlcnBvbGF0aW9uRGVmYXVsdCkKICAgICAsIHBhaW50ZXIocCkKKyAgICAsIGlu aXRpYWxTbW9vdGhQaXhtYXBUcmFuc2Zvcm1IaW50KGZhbHNlKQogICAgICwgcGxhdGZvcm1Db250 ZXh0SXNPd25lZChmYWxzZSkKIHsKICAgICBpZiAoIXBhaW50ZXIpCkBAIC0yMzcsNiArMjM5LDkg QEAgR3JhcGhpY3NDb250ZXh0UGxhdGZvcm1Qcml2YXRlOjpHcmFwaGljc0NvbnRleHRQbGF0Zm9y bVByaXZhdGUoUVBhaW50ZXIqIHAsIGNvbnMKICAgICAvLyBVc2UgdGhlIGRlZmF1bHQgdGhlIFFQ YWludGVyIHdhcyBjb25zdHJ1Y3RlZCB3aXRoLgogICAgIGFudGlBbGlhc2luZ0ZvclJlY3RzQW5k TGluZXMgPSBwYWludGVyLT50ZXN0UmVuZGVySGludChRUGFpbnRlcjo6QW50aWFsaWFzaW5nKTsK IAorICAgIC8vIFVzZWQgZm9yIGRlZmF1bHQgaW1hZ2UgaW50ZXJwb2xhdGlvbiBxdWFsaXR5Lgor ICAgIGluaXRpYWxTbW9vdGhQaXhtYXBUcmFuc2Zvcm1IaW50ID0gcGFpbnRlci0+dGVzdFJlbmRl ckhpbnQoUVBhaW50ZXI6OlNtb290aFBpeG1hcFRyYW5zZm9ybSk7CisKICAgICBwYWludGVyLT5z ZXRSZW5kZXJIaW50KFFQYWludGVyOjpBbnRpYWxpYXNpbmcsIHRydWUpOwogfQogCkBAIC0xMzkx LDEzICsxMzk2LDE2IEBAIHZvaWQgR3JhcGhpY3NDb250ZXh0OjpzZXRJbWFnZUludGVycG9sYXRp b25RdWFsaXR5KEludGVycG9sYXRpb25RdWFsaXR5IHF1YWxpdHkpCiAgICAgICAgIG1fZGF0YS0+ cCgpLT5zZXRSZW5kZXJIaW50KFFQYWludGVyOjpTbW9vdGhQaXhtYXBUcmFuc2Zvcm0sIGZhbHNl KTsKICAgICAgICAgYnJlYWs7CiAKLSAgICBjYXNlIEludGVycG9sYXRpb25EZWZhdWx0OgogICAg IGNhc2UgSW50ZXJwb2xhdGlvbk1lZGl1bToKICAgICBjYXNlIEludGVycG9sYXRpb25IaWdoOgot ICAgIGRlZmF1bHQ6CiAgICAgICAgIC8vIHVzZSB0aGUgZmlsdGVyCiAgICAgICAgIG1fZGF0YS0+ cCgpLT5zZXRSZW5kZXJIaW50KFFQYWludGVyOjpTbW9vdGhQaXhtYXBUcmFuc2Zvcm0sIHRydWUp OwogICAgICAgICBicmVhazsKKworICAgIGNhc2UgSW50ZXJwb2xhdGlvbkRlZmF1bHQ6CisgICAg ZGVmYXVsdDoKKyAgICAgICAgbV9kYXRhLT5wKCktPnNldFJlbmRlckhpbnQoUVBhaW50ZXI6OlNt b290aFBpeG1hcFRyYW5zZm9ybSwgbV9kYXRhLT5pbml0aWFsU21vb3RoUGl4bWFwVHJhbnNmb3Jt SGludCk7CisgICAgICAgIGJyZWFrOwogICAgIH07CiB9CiAK 76851 2010-12-17 00:00:51 -0800 2010-12-17 08:43:14 -0800 [Qt] Default image interpolation should reset the render hint bug-51233-20101217000050.patch text/plain 2831 ariya.hidayat ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MTc0NGVhNTJiYTdlMmVmMmJiYjAzYzQzMGFiM2UzYjY3ZGQwNGI5Mi4uYmU5MDI0NjU4MDBhOTg4 NmY4NGEzOTVjMmRhZjZkMWFkYTc4MTMwMCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0xMi0xNiAgQXJp eWEgSGlkYXlhdCAgPGFyaXlhQHNlbmNoYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBEZWZhdWx0IGltYWdlIGludGVycG9sYXRpb24g c2hvdWxkIHJlc2V0IHRoZSByZW5kZXIgaGludAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTEyMzMKKworICAgICAgICBTYXZlIGluaXRpYWwgU21vb3Ro UGl4bWFwVHJhbnNmb3JtIHJlbmRlciBoaW50IHNvIHRoYXQgaXQgY2FuIGJlIHVzZWQKKyAgICAg ICAgd2l0aCBkZWZhdWx0IGltYWdlIGludGVycG9sYXRpb24gcXVhbGl0eSB0byByZXNldCBiYWNr IHRoZSByZW5kZXIgaGludHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFw aGljc0NvbnRleHRRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHRQbGF0 Zm9ybVByaXZhdGU6OkdyYXBoaWNzQ29udGV4dFBsYXRmb3JtUHJpdmF0ZSk6CisgICAgICAgIChX ZWJDb3JlOjpHcmFwaGljc0NvbnRleHQ6OnNldEltYWdlSW50ZXJwb2xhdGlvblF1YWxpdHkpOgor CiAyMDEwLTEyLTE2ICBLb2FuLVNpbiBUYW4gIDxrb2Fuc2luLnRhbkBnbWFpbC5jb20+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgS2VudCBUYW11cmEuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4dFF0LmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0UXQuY3BwCmluZGV4IDkyZGQzZTQ0YmUyYTZkNWNh MjRkYTk5OWM1MmQ0OTQwZWVmNjcxN2MuLmNjYTViZmM2Njc1MTdmY2VjN2E2ZWMyNGZmYzkwYWUw NTk3ZGI3MzEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhp Y3NDb250ZXh0UXQuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhp Y3NDb250ZXh0UXQuY3BwCkBAIC0xOTgsNiArMTk4LDcgQEAgcHVibGljOgogICAgIFFCcnVzaCBz b2xpZENvbG9yOwogCiAgICAgSW50ZXJwb2xhdGlvblF1YWxpdHkgaW1hZ2VJbnRlcnBvbGF0aW9u UXVhbGl0eTsKKyAgICBib29sIGluaXRpYWxTbW9vdGhQaXhtYXBUcmFuc2Zvcm1IaW50OwogCiAg ICAgQ29udGV4dFNoYWRvdyBzaGFkb3c7CiAgICAgUVN0YWNrPENvbnRleHRTaGFkb3c+IHNoYWRv d1N0YWNrOwpAQCAtMjI4LDYgKzIyOSw3IEBAIEdyYXBoaWNzQ29udGV4dFBsYXRmb3JtUHJpdmF0 ZTo6R3JhcGhpY3NDb250ZXh0UGxhdGZvcm1Qcml2YXRlKFFQYWludGVyKiBwLCBjb25zCiAgICAg LCBsYXllckNvdW50KDApCiAgICAgLCBzb2xpZENvbG9yKGluaXRpYWxTb2xpZENvbG9yKQogICAg ICwgaW1hZ2VJbnRlcnBvbGF0aW9uUXVhbGl0eShJbnRlcnBvbGF0aW9uRGVmYXVsdCkKKyAgICAs IGluaXRpYWxTbW9vdGhQaXhtYXBUcmFuc2Zvcm1IaW50KGZhbHNlKQogICAgICwgcGFpbnRlcihw KQogICAgICwgcGxhdGZvcm1Db250ZXh0SXNPd25lZChmYWxzZSkKIHsKQEAgLTIzNyw2ICsyMzks OSBAQCBHcmFwaGljc0NvbnRleHRQbGF0Zm9ybVByaXZhdGU6OkdyYXBoaWNzQ29udGV4dFBsYXRm b3JtUHJpdmF0ZShRUGFpbnRlciogcCwgY29ucwogICAgIC8vIFVzZSB0aGUgZGVmYXVsdCB0aGUg UVBhaW50ZXIgd2FzIGNvbnN0cnVjdGVkIHdpdGguCiAgICAgYW50aUFsaWFzaW5nRm9yUmVjdHNB bmRMaW5lcyA9IHBhaW50ZXItPnRlc3RSZW5kZXJIaW50KFFQYWludGVyOjpBbnRpYWxpYXNpbmcp OwogCisgICAgLy8gVXNlZCBmb3IgZGVmYXVsdCBpbWFnZSBpbnRlcnBvbGF0aW9uIHF1YWxpdHku CisgICAgaW5pdGlhbFNtb290aFBpeG1hcFRyYW5zZm9ybUhpbnQgPSBwYWludGVyLT50ZXN0UmVu ZGVySGludChRUGFpbnRlcjo6U21vb3RoUGl4bWFwVHJhbnNmb3JtKTsKKwogICAgIHBhaW50ZXIt PnNldFJlbmRlckhpbnQoUVBhaW50ZXI6OkFudGlhbGlhc2luZywgdHJ1ZSk7CiB9CiAKQEAgLTEz OTEsMTMgKzEzOTYsMTYgQEAgdm9pZCBHcmFwaGljc0NvbnRleHQ6OnNldEltYWdlSW50ZXJwb2xh dGlvblF1YWxpdHkoSW50ZXJwb2xhdGlvblF1YWxpdHkgcXVhbGl0eSkKICAgICAgICAgbV9kYXRh LT5wKCktPnNldFJlbmRlckhpbnQoUVBhaW50ZXI6OlNtb290aFBpeG1hcFRyYW5zZm9ybSwgZmFs c2UpOwogICAgICAgICBicmVhazsKIAotICAgIGNhc2UgSW50ZXJwb2xhdGlvbkRlZmF1bHQ6CiAg ICAgY2FzZSBJbnRlcnBvbGF0aW9uTWVkaXVtOgogICAgIGNhc2UgSW50ZXJwb2xhdGlvbkhpZ2g6 Ci0gICAgZGVmYXVsdDoKICAgICAgICAgLy8gdXNlIHRoZSBmaWx0ZXIKICAgICAgICAgbV9kYXRh LT5wKCktPnNldFJlbmRlckhpbnQoUVBhaW50ZXI6OlNtb290aFBpeG1hcFRyYW5zZm9ybSwgdHJ1 ZSk7CiAgICAgICAgIGJyZWFrOworCisgICAgY2FzZSBJbnRlcnBvbGF0aW9uRGVmYXVsdDoKKyAg ICBkZWZhdWx0OgorICAgICAgICBtX2RhdGEtPnAoKS0+c2V0UmVuZGVySGludChRUGFpbnRlcjo6 U21vb3RoUGl4bWFwVHJhbnNmb3JtLCBtX2RhdGEtPmluaXRpYWxTbW9vdGhQaXhtYXBUcmFuc2Zv cm1IaW50KTsKKyAgICAgICAgYnJlYWs7CiAgICAgfTsKIH0KIAo=