<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>51215</bug_id>
          
          <creation_ts>2010-12-16 14:54:21 -0800</creation_ts>
          <short_desc>[Qt] Only include ScrollAnimatorWin.h and compile ScrollAnimatorWin.cpp on Windows if ENABLE_SMOOTH_SCROLLING=1</short_desc>
          <delta_ts>2010-12-16 15:17:55 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Qt</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Daniel Bates">dbates</reporter>
          <assigned_to name="Daniel Bates">dbates</assigned_to>
          <cc>abecsi</cc>
    
    <cc>kenneth</cc>
    
    <cc>ossy</cc>
    
    <cc>tonikitoo</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>323437</commentid>
    <comment_count>0</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2010-12-16 14:54:21 -0800</bug_when>
    <thetext>We should only include the header ScrollAnimatorWin.h and compile ScrollAnimatorWin.cpp when building under Windows/Windows CE with SMOOTH_SCROLLING enabled.

This makes the conditional inclusion of these files consistent with how we conditionally include files for other optional features, such as SVG, DATABASE, and DOM_STORAGE.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>323441</commentid>
    <comment_count>1</comment_count>
      <attachid>76815</attachid>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2010-12-16 15:04:47 -0800</bug_when>
    <thetext>Created attachment 76815
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>323448</commentid>
    <comment_count>2</comment_count>
      <attachid>76815</attachid>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2010-12-16 15:10:00 -0800</bug_when>
    <thetext>Comment on attachment 76815
Patch

r=me

r-&apos;ed by mistake.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>323455</commentid>
    <comment_count>3</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2010-12-16 15:17:55 -0800</bug_when>
    <thetext>Committed r74217: &lt;http://trac.webkit.org/changeset/74217&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>76815</attachid>
            <date>2010-12-16 15:04:47 -0800</date>
            <delta_ts>2010-12-16 15:09:59 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>Bug51215.patch</filename>
            <type>text/plain</type>
            <size>1633</size>
            <attacher name="Daniel Bates">dbates</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n
CShyZXZpc2lvbiA3NDIxNSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMTggQEAKKzIwMTAtMTItMTYgIERhbmllbCBCYXRlcyAgPGRiYXRlc0ByaW0uY29t
PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0g
T25seSBpbmNsdWRlIFNjcm9sbEFuaW1hdG9yV2luLmggYW5kIGNvbXBpbGUgU2Nyb2xsQW5pbWF0
b3JXaW4uY3BwCisgICAgICAgIG9uIFdpbmRvd3MgaWYgRU5BQkxFX1NNT09USF9TQ1JPTExJTkc9
MQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTEyMTUK
KworICAgICAgICBDb25kaXRpb25hbGx5IGluY2x1ZGUgdGhlIGZpbGVzIFNjcm9sbEFuaW1hdG9y
V2luLmggYW5kIFNjcm9sbEFuaW1hdG9yV2luLmNwcCB3aGVuIGJ1aWxkaW5nCisgICAgICAgIHRo
ZSBRdCBXaW5kb3dzIHdpdGggc21vb3RoIHNjcm9sbGluZyBlbmFibGVkLgorCisgICAgICAgIE5v
IGNoYW5nZSBpbiBmdW5jdGlvbmFsaXR5IHNpbmNlIHRoZXNlIGZpbGVzIGFyZSBndWFyZGVkIGJ5
IEVOQUJMRShTTU9PVEhfU0NST0xMSU5HKS4KKworICAgICAgICAqIFdlYkNvcmUucHJvOgorCiAy
MDEwLTEyLTE2ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJl
dmlld2VkIGJ5IERhcmluIEFkbGVyLgpJbmRleDogV2ViQ29yZS9XZWJDb3JlLnBybwo9PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09Ci0tLSBXZWJDb3JlL1dlYkNvcmUucHJvCShyZXZpc2lvbiA3NDIxNSkKKysrIFdlYkNvcmUv
V2ViQ29yZS5wcm8JKHdvcmtpbmcgY29weSkKQEAgLTI3NzcsMTMgKzI3NzcsMTggQEAgbWFlbW81
IHsKICAgICBTT1VSQ0VTICs9IC4uL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9RdE1hZW1vV2Vi
UG9wdXAuY3BwCiB9CiAKLQorY29udGFpbnMoREVGSU5FUywgRU5BQkxFX1NNT09USF9TQ1JPTExJ
Tkc9MSkgewogICAgIHdpbjMyLSp8d2luY2UqIHsKICAgICAgICAgSEVBREVSUyArPSBwbGF0Zm9y
bS9TY3JvbGxBbmltYXRvcldpbi5oCi0gICAgICAgIFNPVVJDRVMgKz0gcGxhdGZvcm0vU2Nyb2xs
QW5pbWF0b3JXaW4uY3BwIFwKLSAgICAgICAgICAgICAgICAgICBwbGF0Zm9ybS93aW4vU3lzdGVt
VGltZVdpbi5jcHAgXAotICAgICAgICAgICAgICAgICAgIHBsYXRmb3JtL2dyYXBoaWNzL3dpbi9U
cmFuc2Zvcm1hdGlvbk1hdHJpeFdpbi5jcHAKKyAgICAgICAgU09VUkNFUyArPSBwbGF0Zm9ybS9T
Y3JvbGxBbmltYXRvcldpbi5jcHAKICAgICB9Cit9CisKK3dpbjMyLSp8d2luY2UqIHsKKyAgICBT
T1VSQ0VTICs9IFwKKyAgICAgICAgcGxhdGZvcm0vd2luL1N5c3RlbVRpbWVXaW4uY3BwIFwKKyAg
ICAgICAgcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL1RyYW5zZm9ybWF0aW9uTWF0cml4V2luLmNwcAor
fQogCiAgICAgbWFjIHsKICAgICAgICAgU09VUkNFUyArPSBcCg==
</data>
<flag name="review"
          id="67820"
          type_id="1"
          status="+"
          setter="tonikitoo"
    />
          </attachment>
      

    </bug>

</bugzilla>