51205 2010-12-16 12:00:31 -0800 Don't try to call plug-in member functions if the plug-in hasn't been initialized 2010-12-16 15:39:58 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 andersca andersca abarth eric webkit.review.bot oldest_to_newest 323329 0 andersca 2010-12-16 12:00:31 -0800 Don't try to call plug-in member functions if the plug-in hasn't been initialized 323331 1 andersca 2010-12-16 12:00:48 -0800 <rdar://problem/8730204> 323334 2 76797 andersca 2010-12-16 12:03:27 -0800 Created attachment 76797 Patch 323338 3 76797 oliver 2010-12-16 12:05:54 -0800 Comment on attachment 76797 Patch r=me 323340 4 andersca 2010-12-16 12:08:12 -0800 Committed r74205: <http://trac.webkit.org/changeset/74205> 323482 5 webkit.review.bot 2010-12-16 15:39:58 -0800 http://trac.webkit.org/changeset/74205 might have broken Leopard Intel Debug (Tests) 76797 2010-12-16 12:03:27 -0800 2010-12-16 12:05:53 -0800 Patch bug-51205-20101216120326.patch text/plain 4309 andersca ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg MDNmZDBkMjdlYjFmMzY4NTllN2M0OGQ0OWQwYjQyMjJhZjgwNmRkMS4uODk4MTBkY2U0ZmM0MGU3 MjZhMjY3MWQ5MjFjZjk1MDE5M2Q5MDBmYyAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyNyBAQAogMjAxMC0xMi0xNiAgQW5k ZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERvbid0IHRyeSB0byBjYWxsIHBsdWctaW4gbWVt YmVyIGZ1bmN0aW9ucyBpZiB0aGUgcGx1Zy1pbiBoYXNuJ3QgYmVlbiBpbml0aWFsaXplZAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTEyMDUKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzg3MzAyMDQ+CisKKyAgICAgICAgTWFrZSBzdXJlIHRoYXQgYWxs IFBsdWdpblZpZXcgZnVuY3Rpb25zIHRoYXQgY2FuIGJlIGNhbGxlZCB3aGlsZSBhIHBsdWctaW4g aGFzIG5vdCBiZWVuCisgICAgICAgIGluaXRpYWxpemVkIChpZiB0aGUgcGx1Zy1pbiBwYWdlIGlz IGluIGEgYmFja2dyb3VuZCB0YWIgZm9yIGV4YW1wbGUpIGhhdmUgYW4gYWRkaXRpb25hbAorICAg ICAgICBjaGVjayBmb3IgbV9pc0luaXRpYWxpemVkLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9Q bHVnaW5zL1BsdWdpblZpZXcuY3BwOgorICAgICAgICAoV2ViS2l0OjpQbHVnaW5WaWV3OjpzZXRX aW5kb3dJc0ZvY3VzZWQpOgorICAgICAgICAoV2ViS2l0OjpQbHVnaW5WaWV3Ojp3aW5kb3dBbmRW aWV3RnJhbWVzQ2hhbmdlZCk6CisgICAgICAgIChXZWJLaXQ6OlBsdWdpblZpZXc6OnBsYXRmb3Jt TGF5ZXIpOgorICAgICAgICAoV2ViS2l0OjpQbHVnaW5WaWV3OjpzY3JpcHRPYmplY3QpOgorICAg ICAgICAoV2ViS2l0OjpQbHVnaW5WaWV3Ojpwcml2YXRlQnJvd3NpbmdTdGF0ZUNoYW5nZWQpOgor ICAgICAgICAoV2ViS2l0OjpQbHVnaW5WaWV3OjpoYW5kbGVFdmVudCk6CisgICAgICAgIChXZWJL aXQ6OlBsdWdpblZpZXc6OnZpZXdHZW9tZXRyeURpZENoYW5nZSk6CisgICAgICAgIChXZWJLaXQ6 OlBsdWdpblZpZXc6OnNldEZvY3VzKToKKworMjAxMC0xMi0xNiAgQW5kZXJzIENhcmxzc29uICA8 YW5kZXJzY2FAYXBwbGUuY29tPgorCiAgICAgICAgIFJldmlld2VkIGJ5IEpvaG4gU3VsbGl2YW4u CiAKICAgICAgICAgQWRkIGEgYnVuY2ggb2YgbV9pc1N0YXJ0ZWQgYXNzZXJ0aW9ucyB0byBwbHVn LWluIGNvZGUuCmRpZmYgLS1naXQgYS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9QbHVnaW5W aWV3LmNwcCBiL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BsdWdpblZpZXcuY3BwCmluZGV4 IGEyZTRmODkwYTJjOWJhMTQ4NjA1MmZkYWQzN2U4MWFmOTFjYmYyOTkuLjg4ZDMxNWI4MGJhNmZh YmQ4YmRhNGE2NGU3ZDRmNTNmYzc5OTIwOWIgMTAwNjQ0Ci0tLSBhL1dlYktpdDIvV2ViUHJvY2Vz cy9QbHVnaW5zL1BsdWdpblZpZXcuY3BwCisrKyBiL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5z L1BsdWdpblZpZXcuY3BwCkBAIC0zNzgsNyArMzc4LDcgQEAgdm9pZCBQbHVnaW5WaWV3OjpzZXRX aW5kb3dJc1Zpc2libGUoYm9vbCB3aW5kb3dJc1Zpc2libGUpCiAKIHZvaWQgUGx1Z2luVmlldzo6 c2V0V2luZG93SXNGb2N1c2VkKGJvb2wgd2luZG93SXNGb2N1c2VkKQogewotICAgIGlmICghbV9w bHVnaW4pCisgICAgaWYgKCFtX2lzSW5pdGlhbGl6ZWQgfHwgIW1fcGx1Z2luKQogICAgICAgICBy ZXR1cm47CiAKICAgICBtX3BsdWdpbi0+d2luZG93Rm9jdXNDaGFuZ2VkKHdpbmRvd0lzRm9jdXNl ZCk7ICAgIApAQCAtMzg2LDcgKzM4Niw3IEBAIHZvaWQgUGx1Z2luVmlldzo6c2V0V2luZG93SXNG b2N1c2VkKGJvb2wgd2luZG93SXNGb2N1c2VkKQogCiB2b2lkIFBsdWdpblZpZXc6OndpbmRvd0Fu ZFZpZXdGcmFtZXNDaGFuZ2VkKGNvbnN0IEludFJlY3QmIHdpbmRvd0ZyYW1lSW5TY3JlZW5Db29y ZGluYXRlcywgY29uc3QgSW50UmVjdCYgdmlld0ZyYW1lSW5XaW5kb3dDb29yZGluYXRlcykKIHsK LSAgICBpZiAoIW1fcGx1Z2luKQorICAgIGlmICghbV9pc0luaXRpYWxpemVkIHx8ICFtX3BsdWdp bikKICAgICAgICAgcmV0dXJuOwogCiAgICAgbV9wbHVnaW4tPndpbmRvd0FuZFZpZXdGcmFtZXND aGFuZ2VkKHdpbmRvd0ZyYW1lSW5TY3JlZW5Db29yZGluYXRlcywgdmlld0ZyYW1lSW5XaW5kb3dD b29yZGluYXRlcyk7CkBAIC00NjEsOCArNDYxLDggQEAgdm9pZCBQbHVnaW5WaWV3Ojppbml0aWFs aXplUGx1Z2luKCkKICNpZiBQTEFURk9STShNQUMpCiBQbGF0Zm9ybUxheWVyKiBQbHVnaW5WaWV3 OjpwbGF0Zm9ybUxheWVyKCkgY29uc3QKIHsKLSAgICAvLyBUaGUgcGx1Zy1pbiBjYW4gYmUgbnVs bCBoZXJlIGlmIGl0IGZhaWxlZCB0byBpbml0aWFsaXplIG9yIGhhc24ndCB5ZXQgYmVlbiBpbml0 aWFsaXplZC4KLSAgICBpZiAoIW1fcGx1Z2luKQorICAgIC8vIFRoZSBwbHVnLWluIGNhbiBiZSBu dWxsIGhlcmUgaWYgaXQgZmFpbGVkIHRvIGluaXRpYWxpemUuCisgICAgaWYgKCFtX2lzSW5pdGlh bGl6ZWQgfHwgIW1fcGx1Z2luKQogICAgICAgICByZXR1cm4gMDsKICAgICAgICAgCiAgICAgcmV0 dXJuIG1fcGx1Z2luLT5wbHVnaW5MYXllcigpOwpAQCAtNDcyLDkgKzQ3Miw5IEBAIFBsYXRmb3Jt TGF5ZXIqIFBsdWdpblZpZXc6OnBsYXRmb3JtTGF5ZXIoKSBjb25zdAogSlNPYmplY3QqIFBsdWdp blZpZXc6OnNjcmlwdE9iamVjdChKU0dsb2JhbE9iamVjdCogZ2xvYmFsT2JqZWN0KQogewogICAg IC8vIFRoZSBwbHVnLWluIGNhbiBiZSBudWxsIGhlcmUgaWYgaXQgZmFpbGVkIHRvIGluaXRpYWxp emUuCi0gICAgaWYgKCFtX3BsdWdpbikKKyAgICBpZiAoIW1faXNJbml0aWFsaXplZCB8fCAhbV9w bHVnaW4pCiAgICAgICAgIHJldHVybiAwOwotICAgIAorCiAgICAgTlBPYmplY3QqIHNjcmlwdGFi bGVOUE9iamVjdCA9IG1fcGx1Z2luLT5wbHVnaW5TY3JpcHRhYmxlTlBPYmplY3QoKTsKICAgICBp ZiAoIXNjcmlwdGFibGVOUE9iamVjdCkKICAgICAgICAgcmV0dXJuIDA7CkBAIC00ODgsNyArNDg4 LDcgQEAgSlNPYmplY3QqIFBsdWdpblZpZXc6OnNjcmlwdE9iamVjdChKU0dsb2JhbE9iamVjdCog Z2xvYmFsT2JqZWN0KQogdm9pZCBQbHVnaW5WaWV3Ojpwcml2YXRlQnJvd3NpbmdTdGF0ZUNoYW5n ZWQoYm9vbCBwcml2YXRlQnJvd3NpbmdFbmFibGVkKQogewogICAgIC8vIFRoZSBwbHVnLWluIGNh biBiZSBudWxsIGhlcmUgaWYgaXQgZmFpbGVkIHRvIGluaXRpYWxpemUuCi0gICAgaWYgKCFtX3Bs dWdpbikKKyAgICBpZiAoIW1faXNJbml0aWFsaXplZCB8fCAhbV9wbHVnaW4pCiAgICAgICAgIHJl dHVybjsKIAogICAgIG1fcGx1Z2luLT5wcml2YXRlQnJvd3NpbmdTdGF0ZUNoYW5nZWQocHJpdmF0 ZUJyb3dzaW5nRW5hYmxlZCk7CkBAIC01MzcsNyArNTM3LDcgQEAgdm9pZCBQbHVnaW5WaWV3Ojpz ZXRQYXJlbnQoU2Nyb2xsVmlldyogc2Nyb2xsVmlldykKIAogdm9pZCBQbHVnaW5WaWV3OjpoYW5k bGVFdmVudChFdmVudCogZXZlbnQpCiB7Ci0gICAgaWYgKCFtX3BsdWdpbikKKyAgICBpZiAoIW1f aXNJbml0aWFsaXplZCB8fCAhbV9wbHVnaW4pCiAgICAgICAgIHJldHVybjsKIAogICAgIGNvbnN0 IFdlYkV2ZW50KiBjdXJyZW50RXZlbnQgPSBXZWJQYWdlOjpjdXJyZW50RXZlbnQoKTsKQEAgLTU3 NSw3ICs1NzUsNyBAQCB2b2lkIFBsdWdpblZpZXc6OmhhbmRsZUV2ZW50KEV2ZW50KiBldmVudCkK ICAgICAKIHZvaWQgUGx1Z2luVmlldzo6dmlld0dlb21ldHJ5RGlkQ2hhbmdlKCkKIHsKLSAgICBp ZiAoIXBhcmVudCgpIHx8ICFtX3BsdWdpbiB8fCAhbV9pc0luaXRpYWxpemVkKQorICAgIGlmICgh bV9pc0luaXRpYWxpemVkIHx8ICFtX3BsdWdpbiB8fCAhcGFyZW50KCkpCiAgICAgICAgIHJldHVy bjsKIAogICAgIC8vIEdldCB0aGUgZnJhbWUgcmVjdCBpbiB3aW5kb3cgY29vcmRpbmF0ZXMuCkBA IC03OTcsNyArNzk3LDEwIEBAIHZvaWQgUGx1Z2luVmlldzo6aW52YWxpZGF0ZVJlY3QoY29uc3Qg SW50UmVjdCYgZGlydHlSZWN0KQogdm9pZCBQbHVnaW5WaWV3OjpzZXRGb2N1cyhib29sIGhhc0Zv Y3VzKQogewogICAgIFdpZGdldDo6c2V0Rm9jdXMoaGFzRm9jdXMpOwotICAgIAorCisgICAgaWYg KCFtX2lzSW5pdGlhbGl6ZWQgfHwgIW1fcGx1Z2luKQorICAgICAgICByZXR1cm47CisKICAgICBt X3BsdWdpbi0+c2V0Rm9jdXMoaGFzRm9jdXMpOwogfQogCg==