51203 2010-12-16 11:58:08 -0800 WebKit2: Cannot copy two successive selections using cmd-c 2010-12-16 15:40:03 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Mac (Intel) OS X 10.6 RESOLVED FIXED InRadar P1 Blocker --- 1 enrica enrica abarth eric webkit.review.bot oldest_to_newest 323325 0 76795 enrica 2010-12-16 11:58:08 -0800 Created attachment 76795 Test case * SUMMARY In WebKit2, I cannot copy two successive selections using cmd-c. I can make a selection and copy it using cmd-c, but then when I make a new selection, the copy item is not enabled in the edit menu and cmd-c does nothing. If I make yet another selection, copying works again. This does not occur when I copy via the edit menu. * STEPS TO REPRODUCE 1. Open the attached test case in Safari while in WK2 mode. 2. Open TextEdit 3. Using the mouse, select the text 'line one'. 4. Copy the selection by pressing cmd-c. 5. Paste the selection into TextEdit using cmd-v. 6. Return to Safari and select the text 'line two'. 7. Open the edit menu and observe that the copy command is disabled. 8. Paste into TextEdit using cmd-v. Observe that 'line one' is still in the clipboard rather than 'line two'. 9. Return to Safari and clear the selection by left clicking once. 10. Re-select 'line two' and press cmd-c. 11. Paste the selection into TextEdit using cmd-v. Observe that 'line two' is now correctly pasted. 323330 1 76796 enrica 2010-12-16 12:00:34 -0800 Created attachment 76796 Patch 323345 2 76796 mjs 2010-12-16 12:17:01 -0800 Comment on attachment 76796 Patch r=me 323346 3 enrica 2010-12-16 12:19:09 -0800 Committed revision 74206. 323483 4 webkit.review.bot 2010-12-16 15:40:03 -0800 http://trac.webkit.org/changeset/74206 might have broken Leopard Intel Debug (Tests) 76795 2010-12-16 11:58:08 -0800 2010-12-16 11:58:08 -0800 Test case selection.html text/html 31 enrica PHA+bGluZSBvbmU8L3A+CjxwPmxpbmUgdHdvPC9wPg== 76796 2010-12-16 12:00:34 -0800 2010-12-16 12:17:01 -0800 Patch bug8680309.txt text/plain 5494 enrica SW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hhbmdlTG9n CShyZXZpc2lvbiA3NDIwMikKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMzQgQEAKKzIwMTAtMTItMTYgIEVucmljYSBDYXN1Y2NpICA8ZW5yaWNhQGFwcGxl LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBX ZWJLaXQyOiBDYW5ub3QgY29weSB0d28gc3VjY2Vzc2l2ZSBzZWxlY3Rpb25zIHVzaW5nIGNtZC1j CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84NjgwMzA5PiAKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUxMjAzCisgICAgICAgIAorICAgICAgICBUaGUg cHJldmlvdXMgaW1wbGVtZW50YXRpb24gYXNzdW1lZCBhIGNhbGwgc2VxdWVuY2UgZnJvbSBBcHBL aXQgdGhhdAorICAgICAgICB3YXMgbm90IGFsd2F5cyBoYXBwZW5pbmcuCisgICAgICAgIFdoZW4g dGhlIHVzZXIgY2xpY2tzIG9uIHRoZSBwdWxsZG93biBtZW51LCBBcHBLaXQgc2VuZHMgdmFsaWRh dGVVc2VySW50ZXJmYWNlSXRlbQorICAgICAgICBjYWxscyBmb3IgZWFjaCBlbGVtZW50IHRoYXQg bmVlZHMgdmFsaWRhdGlvbiBhbmQgd2UgdXNlZCB0byBjb3VudCB0aGUgbnVtYmVyIG9mCisgICAg ICAgIHZhbGlkYXRpb24gcmVxdWVzdHMgYmVpbmcgc2VudCB0byB0aGUgd2ViIHByb2Nlc3MuCisg ICAgICAgIEFsbCB0aGVzZSBjYWxscyBhcmUgbWFkZSBiZWZvcmUgd2UgaGF2ZSB0aGUgY2hhbmNl IHRvIGdldCBvbmUgcmVwbHkgZnJvbSB0aGUgV2ViUHJvY2Vzcy4KKyAgICAgICAgV2UgYWxzbyBk ZWxheWVkIHRoZSBtZW51IHVwZGF0ZSB1bnRpbCB3ZSBoYWQgcmVjZWl2ZWQgYWxsIHRoZSByZXBs aWVzIHRvIHRoZSB2YWxpZGF0aW9uIHJlcXVlc3RzLgorICAgICAgICBBdCB0aGF0IHBvaW50IHdl IGNhbGxlZCB1cGRhdGUgb24gdGhlIG1lbnUgdG8gdHJpZ2dlciB0aGUgdmFsaWRhdGlvbiBvbmUg bW9yZSB0aW1lIHdpdGgKKyAgICAgICAgdGhlIGRhdGEgcmV0cml2ZWQgZnJvbSB0aGUgV2ViUHJv Y2Vzcy4KKyAgICAgICAgV2hlbiB0aGUgdXNlciBzaW1wbHkgcHJlc3NlcyBjbWQtYywgb25seSBv bmUgY2FsbCB0byB2YWlkYXRlVXNlckludGVyZmFjZUl0ZW0gaXMgbWFkZQorICAgICAgICBhbmQg dGhlIG1lbnUgdXBkYXRlIHRyaWdnZXJlZCB0aGUgdmFsaWRhdGlvbiBvZiBhbGwgdGhlIG1lbnUg ZW50cmllcyBjYXVzaW5nIHRoZSBpbnRlcm5hbAorICAgICAgICBzdGF0ZSB0byBiZSBvdXQgb2Yg c3luYy4KKyAgICAgICAgVGhlIG5ldyBpbXBsZW1lbnRhdGlvbiBpcyB2ZXJ5IHNpbXBsZTogZm9y IGVhY2ggdmFsaWRhdGlvbiByZXF1ZXN0IGZyb20gQXBwS2l0IHdlIHNlbmQKKyAgICAgICAgYSBy ZXF1ZXN0IHRvIHRoZSBXZWJQcm9jZXNzIGFuZCB3ZSBjYWNoZSBhIHJlZmVyZW5jZSB0byB0aGUg bWVudSBpdGVtIGJlaW5nIHZhbGlkYXRlZC4KKyAgICAgICAgV2hlbiB0aGUgV2ViUHJvY2VzcyBy ZXBsaWVzLCB3ZSByZXRyaWV2ZSB0aGUgbWVudSBpdGVtIGZyb20gb3VyIGNhY2hlIGFuZCB1cGRh dGUgaXRzIHN0YXRlLgorICAgICAgICAKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL21hYy9XS1Zp ZXcubW06CisgICAgICAgICgtW1dLVmlldyBpbml0V2l0aEZyYW1lOmNvbnRleHRSZWY6cGFnZUdy b3VwUmVmOl0pOiBSZW1vdmVkIGluaXRpYWxpemF0aW9uIG9mIGRlbGV0ZWQgbWVtZWJlcnMuCisg ICAgICAgICgtW1dLVmlldyB2YWxpZGF0ZVVzZXJJbnRlcmZhY2VJdGVtOl0pOiBSZXF1ZXN0IHZh bGlkYXRpb24gdG8gdGhlIFdlYlByb2Nlc3MgYW5kIHJldHVybiBZRVMgdG8gCisgICAgICAgIGFs bG93IEFwcEtpdCB0byBkbyB0aGUga2V5QmluZGluZyBwcm9jZXNzaW5nLgorICAgICAgICAoLVtX S1ZpZXcgX3NldFVzZXJJbnRlcmZhY2VJdGVtU3RhdGU6ZW5hYmxlZDpzdGF0ZTpdKTogQ2FsbGVk IHdoZW4gdGhlIFdlYlByb2Nlc3MgcmVwbGllcyB0byB0aGUKKyAgICAgICAgdmFsaWRhdGlvbiBy ZXF1ZXN0IHRvIGNoZWNrL3VuY2hlY2sgYW5kIGVuYWJsZS9kaXNhYmxlIHRoZSBtZW51IGl0ZW0u CisKIDIwMTAtMTItMTYgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAog ICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IFdlYktpdDIvVUlQcm9jZXNz L0FQSS9tYWMvV0tWaWV3Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvVUlQcm9jZXNzL0FQSS9t YWMvV0tWaWV3Lm1tCShyZXZpc2lvbiA3NDIwMikKKysrIFdlYktpdDIvVUlQcm9jZXNzL0FQSS9t YWMvV0tWaWV3Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC02NywxMyArNjcsNiBAQCBleHRlcm4gIkMi IHsKIHVzaW5nIG5hbWVzcGFjZSBXZWJLaXQ7CiB1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKIAot c3RydWN0IEVkaXRDb21tYW5kU3RhdGUgewotICAgIEVkaXRDb21tYW5kU3RhdGUoKSA6IG1faXNF bmFibGVkKGZhbHNlKSwgbV9zdGF0ZSgwKSB7fTsKLSAgICBFZGl0Q29tbWFuZFN0YXRlKGJvb2wg aXNFbmFibGVkLCBpbnQgc3RhdGUpIDogbV9pc0VuYWJsZWQoaXNFbmFibGVkKSwgbV9zdGF0ZShz dGF0ZSkgeyB9Ci0gICAgYm9vbCBtX2lzRW5hYmxlZDsKLSAgICBpbnQgbV9zdGF0ZTsKLX07Ci0K IEBpbnRlcmZhY2UgTlNXaW5kb3cgKERldGFpbHMpCiAtIChOU1JlY3QpX2dyb3dCb3hSZWN0Owog LSAoQk9PTClfdXBkYXRlR3Jvd0JveEZvcldpbmRvd0ZyYW1lQ2hhbmdlOwpAQCAtOTMsMTEgKzg2 LDcgQEAgQGludGVyZmFjZSBXS1ZpZXdEYXRhIDogTlNPYmplY3QgewogICAgIE5TVmlldyAqX2xh eWVySG9zdGluZ1ZpZXc7CiAjZW5kaWYKICAgICAvLyBGb3IgTWVudXMuCi0gICAgaW50IF9tZW51 RW50cmllc0NvdW50OwotICAgIFZlY3RvcjxSZXRhaW5QdHI8TlNNZW51PiA+IF9tZW51TGlzdDsK LSAgICBib29sIF9pc1BlcmZvcm1pbmdVcGRhdGU7Ci0gICAgCi0gICAgSGFzaE1hcDxTdHJpbmcs IEVkaXRDb21tYW5kU3RhdGU+IF9tZW51TWFwOworICAgIEhhc2hNYXA8U3RyaW5nLCBSZXRhaW5Q dHI8TlNNZW51SXRlbT4gPiBfbWVudUl0ZW1zTWFwOwogCiAgICAgT3duUHRyPFBERlZpZXdDb250 cm9sbGVyPiBfcGRmVmlld0NvbnRyb2xsZXI7CiAKQEAgLTE2Nyw5ICsxNTYsNiBAQCAtIChpZClp bml0V2l0aEZyYW1lOihOU1JlY3QpZnJhbWUgY29udGV4CiAgICAgX2RhdGEtPl9wYWdlLT5pbml0 aWFsaXplV2ViUGFnZShJbnRTaXplKGZyYW1lLnNpemUpKTsKICAgICBfZGF0YS0+X3BhZ2UtPnNl dElzSW5XaW5kb3coW3NlbGYgd2luZG93XSk7CiAKLSAgICBfZGF0YS0+X21lbnVFbnRyaWVzQ291 bnQgPSAwOwotICAgIF9kYXRhLT5faXNQZXJmb3JtaW5nVXBkYXRlID0gZmFsc2U7Ci0KICAgICBf ZGF0YS0+X2lzU2VsZWN0aW9uTm9uZSA9IFlFUzsKICAgICBfZGF0YS0+X2lzU2VsZWN0aW9uRWRp dGFibGUgPSBOTzsKICAgICBfZGF0YS0+X2lzU2VsZWN0aW9uSW5QYXNzd29yZEZpZWxkID0gTk87 CkBAIC0zMzAsMTkgKzMxNiw5IEBAIC0gKEJPT0wpdmFsaWRhdGVVc2VySW50ZXJmYWNlSXRlbToo aWQgPE4KICAgICBpZiAoIVttZW51SXRlbSBpc0tpbmRPZkNsYXNzOltOU01lbnVJdGVtIGNsYXNz XV0pCiAgICAgICAgIHJldHVybiBOTzsgLy8gRklYTUU6IFdlIG5lZWQgdG8gYmUgYWJsZSB0byBo YW5kbGUgb3RoZXIgdXNlciBpbnRlcmZhY2UgZWxlbWVudHMuCiAgICAgCi0gICAgUmV0YWluUHRy PE5TTWVudT4gbWVudSA9IFttZW51SXRlbSBtZW51XTsKLSAgICBpZiAoIV9kYXRhLT5faXNQZXJm b3JtaW5nVXBkYXRlKSB7Ci0gICAgICAgIGlmIChfZGF0YS0+X21lbnVMaXN0LmZpbmQobWVudSkg PT0gbm90Rm91bmQpCi0gICAgICAgICAgICBfZGF0YS0+X21lbnVMaXN0LmFwcGVuZChtZW51KTsK LSAgICAgICAgX2RhdGEtPl9tZW51TWFwLmFkZChjb21tYW5kTmFtZSwgRWRpdENvbW1hbmRTdGF0 ZShmYWxzZSwgMCkpOwotICAgICAgICBfZGF0YS0+X21lbnVFbnRyaWVzQ291bnQrKzsKKyAgICBp ZiAoX2RhdGEtPl9tZW51SXRlbXNNYXAuZmluZChjb21tYW5kTmFtZSkgPT0gX2RhdGEtPl9tZW51 SXRlbXNNYXAuZW5kKCkpIHsKKyAgICAgICAgX2RhdGEtPl9tZW51SXRlbXNNYXAuYWRkKGNvbW1h bmROYW1lLCBtZW51SXRlbSk7CiAgICAgICAgIF9kYXRhLT5fcGFnZS0+dmFsaWRhdGVNZW51SXRl bShjb21tYW5kTmFtZSk7Ci0gICAgfSBlbHNlIHsKLSAgICAgICAgRWRpdENvbW1hbmRTdGF0ZSBp bmZvID0gX2RhdGEtPl9tZW51TWFwLnRha2UoY29tbWFuZE5hbWUpOwotICAgICAgICBbbWVudUl0 ZW0gc2V0U3RhdGU6aW5mby5tX3N0YXRlXTsKLSAgICAgICAgaWYgKF9kYXRhLT5fbWVudU1hcC5p c0VtcHR5KCkpCi0gICAgICAgICAgICBfZGF0YS0+X2lzUGVyZm9ybWluZ1VwZGF0ZSA9IGZhbHNl OwotICAgICAgICByZXR1cm4gaW5mby5tX2lzRW5hYmxlZDsKICAgICB9CiAKICAgICByZXR1cm4g WUVTOwpAQCAtOTE4LDE5ICs4OTQsOSBAQCAtICh2b2lkKV9zZXRDdXJzb3I6KE5TQ3Vyc29yICop Y3Vyc29yCiAKIC0gKHZvaWQpX3NldFVzZXJJbnRlcmZhY2VJdGVtU3RhdGU6KE5TU3RyaW5nICop Y29tbWFuZE5hbWUgZW5hYmxlZDooQk9PTClpc0VuYWJsZWQgc3RhdGU6KGludCluZXdTdGF0ZQog ewotICAgIEFTU0VSVChfZGF0YS0+X21lbnVFbnRyaWVzQ291bnQpOwotICAgIF9kYXRhLT5fbWVu dU1hcC5zZXQoY29tbWFuZE5hbWUsIEVkaXRDb21tYW5kU3RhdGUoaXNFbmFibGVkLCBuZXdTdGF0 ZSkpOwotICAgIGlmICgtLV9kYXRhLT5fbWVudUVudHJpZXNDb3VudCkKLSAgICAgICAgcmV0dXJu OwotICAgIAotICAgIC8vIEFsbCB0aGUgbWVudSBlbnRyaWVzIGhhdmUgYmVlbiB2YWxpZGF0ZWQu Ci0gICAgLy8gQ2FsbGluZyB1cGRhdGUgd2lsbCB0cmlnZ2VyIHRoZSB2YWxpZGF0aW9uCi0gICAg Ly8gdG8gYmUgcGVyZm9ybWVkIHdpdGggdGhlIGFjcXVpcmVkIGRhdGEuCi0gICAgX2RhdGEtPl9p c1BlcmZvcm1pbmdVcGRhdGUgPSB0cnVlOwotICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgX2Rh dGEtPl9tZW51TGlzdC5zaXplKCk7IGkrKykKLSAgICAgICAgW19kYXRhLT5fbWVudUxpc3RbaV0u Z2V0KCkgdXBkYXRlXTsKLSAgICAKLSAgICBfZGF0YS0+X21lbnVMaXN0LmNsZWFyKCk7CisgICAg TlNNZW51SXRlbSAqbWVudUl0ZW0gPSBfZGF0YS0+X21lbnVJdGVtc01hcC50YWtlKGNvbW1hbmRO YW1lKS5nZXQoKTsKKyAgICBbbWVudUl0ZW0gc2V0U3RhdGU6bmV3U3RhdGVdOworICAgIFttZW51 SXRlbSBzZXRFbmFibGVkOmlzRW5hYmxlZF07CiB9CiAKIC0gKE5TUmVjdClfY29udmVydFRvRGV2 aWNlU3BhY2U6KE5TUmVjdClyZWN0Cg==