51189 2010-12-16 07:56:01 -0800 Web Inspector: Console always scroll to the bottom on new events 2010-12-16 15:39:07 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 yurys yurys abarth apavlov bweinstein eric jerem.selier joepeck keishi loislo mathias pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 323177 0 yurys 2010-12-16 07:56:01 -0800 Console should not scroll to the bottom while scrolled up. 323179 1 76769 yurys 2010-12-16 08:01:02 -0800 Created attachment 76769 Patch 323188 2 76769 pfeldman 2010-12-16 08:29:25 -0800 Comment on attachment 76769 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=76769&action=review > WebCore/inspector/front-end/ConsoleView.js:215 > + _isScrolledToLastMessage: function() Can we define this on Element.prototype instead and reuse in DataGrid? 323194 3 76772 yurys 2010-12-16 08:39:56 -0800 Created attachment 76772 Patch 323195 4 yurys 2010-12-16 08:40:42 -0800 Done. (In reply to comment #2) > (From update of attachment 76769 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=76769&action=review > > > WebCore/inspector/front-end/ConsoleView.js:215 > > + _isScrolledToLastMessage: function() > > Can we define this on Element.prototype instead and reuse in DataGrid? 323200 5 76772 yurys 2010-12-16 08:57:16 -0800 Comment on attachment 76772 Patch Clearing flags on attachment: 76772 Committed r74193: <http://trac.webkit.org/changeset/74193> 323201 6 yurys 2010-12-16 08:57:26 -0800 All reviewed patches have been landed. Closing bug. 323473 7 webkit.review.bot 2010-12-16 15:39:07 -0800 http://trac.webkit.org/changeset/74193 might have broken Leopard Intel Debug (Tests) 76769 2010-12-16 08:01:02 -0800 2010-12-16 08:39:56 -0800 Patch bug-51189-20101216190059.patch text/plain 2488 yurys ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OTlmYzM5NWRkMGRlZjE4YzliNTA4NzQ5MDkwODBiMzNhYzQ3ODBmYS4uYjg4YmMzM2ZjMGRjOGVh ZDlkM2UxYjRmZTU4ZWVjNjI4MzIwMzgyNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0xMi0xNiAgWXVy eSBTZW1pa2hhdHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBDb25zb2xlIGFsd2F5 cyBzY3JvbGwgdG8gdGhlIGJvdHRvbSBvbiBuZXcgZXZlbnRzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MTE4OQorCisgICAgICAgIFdoZW4gbmV3IG1l c3NhZ2VzIGFyZSBhZGRlZCB0byB0aGUgY29uc29sZSBpdCB3aWxsIGF1dG8gc2Nyb2xsCisgICAg ICAgIG9ubHkgaWYgaXQgd2FzIGFscmVhZHkgc2Nyb2xsZWQgZG93biB0byB0aGUgbGFzdCByZWNv cmQuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0NvbnNvbGVWaWV3LmpzOgorICAg ICAgICAoV2ViSW5zcGVjdG9yLkNvbnNvbGVWaWV3LnByb3RvdHlwZS5fc2NoZWR1bGVTY3JvbGxJ bnRvVmlldy5zY3JvbGxJbnRvVmlldyk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuQ29uc29sZVZp ZXcucHJvdG90eXBlLl9zY2hlZHVsZVNjcm9sbEludG9WaWV3KToKKyAgICAgICAgKFdlYkluc3Bl Y3Rvci5Db25zb2xlVmlldy5wcm90b3R5cGUuX2lzU2Nyb2xsZWRUb0xhc3RNZXNzYWdlKToKKyAg ICAgICAgKFdlYkluc3BlY3Rvci5Db25zb2xlVmlldy5wcm90b3R5cGUuYWRkTWVzc2FnZSk6CisK IDIwMTAtMTItMTYgIEhhbnMgV2VubmJvcmcgIDxoYW5zQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBSZXZpZXdlZCBieSBKZXJlbXkgT3Jsb3cuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvQ29uc29sZVZpZXcuanMgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv Q29uc29sZVZpZXcuanMKaW5kZXggYTU4MmJmYjMwNjkwMWU1MGViZmNjMTY2ZGRkMzFkMzNjNGI3 OTc1NC4uOTE3Y2EwZjA3ZmM3MjYzOTZmOGY4OWFmYzQ2ZDQxYjM4MjM2Y2JjYiAxMDA2NDQKLS0t IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NvbnNvbGVWaWV3LmpzCisrKyBiL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Db25zb2xlVmlldy5qcwpAQCAtMjA2LDE0ICsyMDYsMjEg QEAgV2ViSW5zcGVjdG9yLkNvbnNvbGVWaWV3LnByb3RvdHlwZSA9IHsKIAogICAgICAgICBmdW5j dGlvbiBzY3JvbGxJbnRvVmlldygpCiAgICAgICAgIHsKLSAgICAgICAgICAgIHRoaXMucHJvbXB0 RWxlbWVudC5zY3JvbGxJbnRvVmlldyhmYWxzZSk7CisgICAgICAgICAgICB0aGlzLnByb21wdEVs ZW1lbnQuc2Nyb2xsSW50b1ZpZXcodHJ1ZSk7CiAgICAgICAgICAgICBkZWxldGUgdGhpcy5fc2Ny b2xsSW50b1ZpZXdUaW1lcjsKICAgICAgICAgfQogICAgICAgICB0aGlzLl9zY3JvbGxJbnRvVmll d1RpbWVyID0gc2V0VGltZW91dChzY3JvbGxJbnRvVmlldy5iaW5kKHRoaXMpLCAyMCk7CiAgICAg fSwKIAorICAgIF9pc1Njcm9sbGVkVG9MYXN0TWVzc2FnZTogZnVuY3Rpb24oKQorICAgIHsKKyAg ICAgICAgcmV0dXJuIHRoaXMubWVzc2FnZXNFbGVtZW50LnNjcm9sbFRvcCA9PT0gdGhpcy5tZXNz YWdlc0VsZW1lbnQuc2Nyb2xsSGVpZ2h0IC0gdGhpcy5tZXNzYWdlc0VsZW1lbnQub2Zmc2V0SGVp Z2h0OworICAgIH0sCisKICAgICBhZGRNZXNzYWdlOiBmdW5jdGlvbihtc2cpCiAgICAgeworICAg ICAgICB2YXIgc2hvdWxkU2Nyb2xsVG9MYXN0TWVzc2FnZSA9IHRoaXMuX2lzU2Nyb2xsZWRUb0xh c3RNZXNzYWdlKCk7CisKICAgICAgICAgaWYgKG1zZyBpbnN0YW5jZW9mIFdlYkluc3BlY3Rvci5D b25zb2xlTWVzc2FnZSAmJiAhKG1zZyBpbnN0YW5jZW9mIFdlYkluc3BlY3Rvci5Db25zb2xlQ29t bWFuZFJlc3VsdCkpIHsKICAgICAgICAgICAgIHRoaXMuX2luY3JlbWVudEVycm9yV2FybmluZ0Nv dW50KG1zZyk7CiAgICAgICAgICAgICBXZWJJbnNwZWN0b3IucmVzb3VyY2VNYW5hZ2VyLmFkZENv bnNvbGVNZXNzYWdlKG1zZyk7CkBAIC0yNDEsNyArMjQ4LDggQEAgV2ViSW5zcGVjdG9yLkNvbnNv bGVWaWV3LnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgIHRoaXMuY3VycmVudEdyb3VwLmFkZE1l c3NhZ2UobXNnKTsKICAgICAgICAgfQogCi0gICAgICAgIHRoaXMuX3NjaGVkdWxlU2Nyb2xsSW50 b1ZpZXcoKTsKKyAgICAgICAgaWYgKHNob3VsZFNjcm9sbFRvTGFzdE1lc3NhZ2UpCisgICAgICAg ICAgICB0aGlzLl9zY2hlZHVsZVNjcm9sbEludG9WaWV3KCk7CiAgICAgfSwKIAogICAgIHVwZGF0 ZU1lc3NhZ2VSZXBlYXRDb3VudDogZnVuY3Rpb24oY291bnQpCg== 76772 2010-12-16 08:39:56 -0800 2010-12-16 08:57:16 -0800 Patch scroll.patch text/plain 3394 yurys ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZGE1MTRjZS4uZGQwMDc4MyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0xMi0xNiAgWXVyeSBTZW1pa2hh dHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBDb25zb2xlIGFsd2F5cyBzY3JvbGwg dG8gdGhlIGJvdHRvbSBvbiBuZXcgZXZlbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD01MTE4OQorCisgICAgICAgIFdoZW4gbmV3IG1lc3NhZ2VzIGFy ZSBhZGRlZCB0byB0aGUgY29uc29sZSBpdCB3aWxsIGF1dG8gc2Nyb2xsCisgICAgICAgIG9ubHkg aWYgaXQgd2FzIGFscmVhZHkgc2Nyb2xsZWQgZG93biB0byB0aGUgbGFzdCByZWNvcmQuCisKKyAg ICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0NvbnNvbGVWaWV3LmpzOgorICAgICAgICAoV2Vi SW5zcGVjdG9yLkNvbnNvbGVWaWV3LnByb3RvdHlwZS5fc2NoZWR1bGVTY3JvbGxJbnRvVmlldy5z Y3JvbGxJbnRvVmlldyk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuQ29uc29sZVZpZXcucHJvdG90 eXBlLl9zY2hlZHVsZVNjcm9sbEludG9WaWV3KToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Db25z b2xlVmlldy5wcm90b3R5cGUuX2lzU2Nyb2xsZWRUb0xhc3RNZXNzYWdlKToKKyAgICAgICAgKFdl Ykluc3BlY3Rvci5Db25zb2xlVmlldy5wcm90b3R5cGUuYWRkTWVzc2FnZSk6CisKIDIwMTAtMTIt MTYgIFBhdmVsIFBvZGl2aWxvdiAgPHBvZGl2aWxvdkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgWXVyeSBTZW1pa2hhdHNreS4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9Db25zb2xlVmlldy5qcyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVu ZC9Db25zb2xlVmlldy5qcwppbmRleCBhNTgyYmZiLi45ZTczN2JjIDEwMDY0NAotLS0gYS9XZWJD b3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ29uc29sZVZpZXcuanMKKysrIGIvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL0NvbnNvbGVWaWV3LmpzCkBAIC0yMDYsNyArMjA2LDcgQEAgV2ViSW5z cGVjdG9yLkNvbnNvbGVWaWV3LnByb3RvdHlwZSA9IHsKIAogICAgICAgICBmdW5jdGlvbiBzY3Jv bGxJbnRvVmlldygpCiAgICAgICAgIHsKLSAgICAgICAgICAgIHRoaXMucHJvbXB0RWxlbWVudC5z Y3JvbGxJbnRvVmlldyhmYWxzZSk7CisgICAgICAgICAgICB0aGlzLnByb21wdEVsZW1lbnQuc2Ny b2xsSW50b1ZpZXcodHJ1ZSk7CiAgICAgICAgICAgICBkZWxldGUgdGhpcy5fc2Nyb2xsSW50b1Zp ZXdUaW1lcjsKICAgICAgICAgfQogICAgICAgICB0aGlzLl9zY3JvbGxJbnRvVmlld1RpbWVyID0g c2V0VGltZW91dChzY3JvbGxJbnRvVmlldy5iaW5kKHRoaXMpLCAyMCk7CkBAIC0yMTQsNiArMjE0 LDggQEAgV2ViSW5zcGVjdG9yLkNvbnNvbGVWaWV3LnByb3RvdHlwZSA9IHsKIAogICAgIGFkZE1l c3NhZ2U6IGZ1bmN0aW9uKG1zZykKICAgICB7CisgICAgICAgIHZhciBzaG91bGRTY3JvbGxUb0xh c3RNZXNzYWdlID0gdGhpcy5tZXNzYWdlc0VsZW1lbnQuaXNTY3JvbGxlZFRvQm90dG9tKCk7CisK ICAgICAgICAgaWYgKG1zZyBpbnN0YW5jZW9mIFdlYkluc3BlY3Rvci5Db25zb2xlTWVzc2FnZSAm JiAhKG1zZyBpbnN0YW5jZW9mIFdlYkluc3BlY3Rvci5Db25zb2xlQ29tbWFuZFJlc3VsdCkpIHsK ICAgICAgICAgICAgIHRoaXMuX2luY3JlbWVudEVycm9yV2FybmluZ0NvdW50KG1zZyk7CiAgICAg ICAgICAgICBXZWJJbnNwZWN0b3IucmVzb3VyY2VNYW5hZ2VyLmFkZENvbnNvbGVNZXNzYWdlKG1z Zyk7CkBAIC0yNDEsNyArMjQzLDggQEAgV2ViSW5zcGVjdG9yLkNvbnNvbGVWaWV3LnByb3RvdHlw ZSA9IHsKICAgICAgICAgICAgIHRoaXMuY3VycmVudEdyb3VwLmFkZE1lc3NhZ2UobXNnKTsKICAg ICAgICAgfQogCi0gICAgICAgIHRoaXMuX3NjaGVkdWxlU2Nyb2xsSW50b1ZpZXcoKTsKKyAgICAg ICAgaWYgKHNob3VsZFNjcm9sbFRvTGFzdE1lc3NhZ2UpCisgICAgICAgICAgICB0aGlzLl9zY2hl ZHVsZVNjcm9sbEludG9WaWV3KCk7CiAgICAgfSwKIAogICAgIHVwZGF0ZU1lc3NhZ2VSZXBlYXRD b3VudDogZnVuY3Rpb24oY291bnQpCmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvRGF0YUdyaWQuanMgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRGF0YUdyaWQu anMKaW5kZXggNTI5OTVkNC4uNTgzMWQxZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL0RhdGFHcmlkLmpzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9E YXRhR3JpZC5qcwpAQCAtNDk1LDcgKzQ5NSw3IEBAIFdlYkluc3BlY3Rvci5EYXRhR3JpZC5wcm90 b3R5cGUgPSB7CiAKICAgICBpc1Njcm9sbGVkVG9MYXN0Um93OiBmdW5jdGlvbigpCiAgICAgewot ICAgICAgICByZXR1cm4gdGhpcy5fc2Nyb2xsQ29udGFpbmVyLnNjcm9sbFRvcCA9PT0gdGhpcy5f c2Nyb2xsQ29udGFpbmVyLnNjcm9sbEhlaWdodCAtIHRoaXMuX3Njcm9sbENvbnRhaW5lci5vZmZz ZXRIZWlnaHQ7CisgICAgICAgIHJldHVybiB0aGlzLl9zY3JvbGxDb250YWluZXIuaXNTY3JvbGxl ZFRvQm90dG9tKCk7CiAgICAgfSwKIAogICAgIHNjcm9sbFRvTGFzdFJvdzogZnVuY3Rpb24oKQpk aWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL3V0aWxpdGllcy5qcyBiL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC91dGlsaXRpZXMuanMKaW5kZXggZjk3OGM2Zi4uNjg4 ZTA4MCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL3V0aWxpdGllcy5q cworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvdXRpbGl0aWVzLmpzCkBAIC0yMTYs NiArMjE2LDExIEBAIEVsZW1lbnQucHJvdG90eXBlLnBydW5lRW1wdHlUZXh0Tm9kZXMgPSBmdW5j dGlvbigpCiAgICAgfQogfQogCitFbGVtZW50LnByb3RvdHlwZS5pc1Njcm9sbGVkVG9Cb3R0b20g PSBmdW5jdGlvbigpCit7CisgICAgcmV0dXJuIHRoaXMuc2Nyb2xsVG9wID09PSB0aGlzLnNjcm9s bEhlaWdodCAtIHRoaXMub2Zmc2V0SGVpZ2h0OworfQorCiBOb2RlLnByb3RvdHlwZS5lbmNsb3Np bmdOb2RlT3JTZWxmV2l0aE5vZGVOYW1lSW5BcnJheSA9IGZ1bmN0aW9uKG5hbWVBcnJheSkKIHsK ICAgICBmb3IgKHZhciBub2RlID0gdGhpczsgbm9kZSAmJiBub2RlICE9PSB0aGlzLm93bmVyRG9j dW1lbnQ7IG5vZGUgPSBub2RlLnBhcmVudE5vZGUpCg==