<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>51181</bug_id>
          
          <creation_ts>2010-12-16 05:21:05 -0800</creation_ts>
          <short_desc>[GTK] Compile warning introduced in r74129</short_desc>
          <delta_ts>2010-12-17 03:13:38 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Carlos Garcia Campos">cgarcia</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>xan.lopez</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>323118</commentid>
    <comment_count>0</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2010-12-16 05:21:05 -0800</bug_when>
    <thetext>../WebCore/platform/gtk/RenderThemeGtk.cpp:821: warning: &quot;GTK_API_VERSION_2&quot; is not defined

the problem is that it&apos;s using #if GTK_API_VERSION_2 instead of #ifdef</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>323120</commentid>
    <comment_count>1</comment_count>
      <attachid>76756</attachid>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2010-12-16 05:23:58 -0800</bug_when>
    <thetext>Created attachment 76756
Patch to fix the warning</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>323206</commentid>
    <comment_count>2</comment_count>
      <attachid>76756</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2010-12-16 09:14:33 -0800</bug_when>
    <thetext>Comment on attachment 76756
Patch to fix the warning

Thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>323207</commentid>
    <comment_count>3</comment_count>
      <attachid>76756</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-12-16 09:16:31 -0800</bug_when>
    <thetext>Comment on attachment 76756
Patch to fix the warning

Rejecting attachment 76756 from commit-queue.

Failed to run &quot;[&apos;./WebKitTools/Scripts/webkit-patch&apos;, &apos;--status-host=queues.webkit.org&apos;, &apos;--bot-id=cr-jail-3&apos;, &apos;apply-attachment&apos;, &apos;--non-interactive&apos;, 76756]&quot; exit_code: 2
Last 500 characters of output:
ailed to merge in the changes.
Patch failed at 0001 2010-12-16  Yury Semikhatsky  &lt;yurys@chromium.org&gt;

When you have resolved this problem run &quot;git rebase --continue&quot;.
If you would prefer to skip this patch, instead run &quot;git rebase --skip&quot;.
To restore the original branch and stop rebasing run &quot;git rebase --abort&quot;.

rebase refs/remotes/origin/master: command returned error: 1

Died at WebKitTools/Scripts/update-webkit line 132.

Failed to run &quot;[&apos;WebKitTools/Scripts/update-webkit&apos;]&quot; exit_code: 2

Full output: http://queues.webkit.org/results/7179076</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>323689</commentid>
    <comment_count>4</comment_count>
      <attachid>76756</attachid>
    <who name="Xan Lopez">xan.lopez</who>
    <bug_when>2010-12-17 03:13:28 -0800</bug_when>
    <thetext>Comment on attachment 76756
Patch to fix the warning

Landed manually in r74246.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>323690</commentid>
    <comment_count>5</comment_count>
    <who name="Xan Lopez">xan.lopez</who>
    <bug_when>2010-12-17 03:13:38 -0800</bug_when>
    <thetext>Closing.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>76756</attachid>
            <date>2010-12-16 05:23:58 -0800</date>
            <delta_ts>2010-12-17 03:13:28 -0800</delta_ts>
            <desc>Patch to fix the warning</desc>
            <filename>fix-compile-warning.diff</filename>
            <type>text/plain</type>
            <size>1101</size>
            <attacher name="Carlos Garcia Campos">cgarcia</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
MDZmOWJlOC4uYTIxNDdjYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi
Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0xMi0xNiAgQ2FybG9zIEdhcmNp
YSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C
T0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gQ29tcGlsZSB3YXJuaW5nIGludHJvZHVjZWQg
aW4gcjc0MTI5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p
ZD01MTE4MQorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1JlbmRlclRoZW1lR3RrLmNwcDoKKyAg
ICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lR3RrOjpndGtDb250YWluZXIpOgorCiAyMDEwLTEy
LTE2ICBZdXJ5IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVu
cmV2aWV3ZWQuIEZpeCBDaHJvbWl1bSBEZWJ1ZyBjb21waWxhdGlvbiBhZnRlciByNzQxNzcgCmRp
ZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9SZW5kZXJUaGVtZUd0ay5jcHAgYi9XZWJD
b3JlL3BsYXRmb3JtL2d0ay9SZW5kZXJUaGVtZUd0ay5jcHAKaW5kZXggZjczMmMxNi4uZDNjMzll
OSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUmVuZGVyVGhlbWVHdGsuY3BwCisr
KyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1JlbmRlclRoZW1lR3RrLmNwcApAQCAtODE4LDcgKzgx
OCw3IEBAIEd0a1dpZGdldCogUmVuZGVyVGhlbWVHdGs6Omd0a0NvbnRhaW5lcigpIGNvbnN0CiAg
ICAgICAgIHJldHVybiBtX2d0a0NvbnRhaW5lcjsKIAogICAgIG1fZ3RrV2luZG93ID0gZ3RrX3dp
bmRvd19uZXcoR1RLX1dJTkRPV19QT1BVUCk7Ci0jaWYgR1RLX0FQSV9WRVJTSU9OXzIKKyNpZmRl
ZiBHVEtfQVBJX1ZFUlNJT05fMgogICAgIGd0a193aWRnZXRfc2V0X2NvbG9ybWFwKG1fZ3RrV2lu
ZG93LCBtX3RoZW1lUGFydHMuY29sb3JtYXApOwogI2VuZGlmCiAgICAgZ3RrX3dpZGdldF9yZWFs
aXplKG1fZ3RrV2luZG93KTsK
</data>

          </attachment>
      

    </bug>

</bugzilla>