<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>51176</bug_id>
          
          <creation_ts>2010-12-16 04:28:45 -0800</creation_ts>
          <short_desc>sheriff-bot should be able to do multi-revision rollouts</short_desc>
          <delta_ts>2011-01-05 06:19:16 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>51924</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Gabor Rapcsanyi">rgabor</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abarth</cc>
    
    <cc>abecsi</cc>
    
    <cc>eric</cc>
    
    <cc>mihaip</cc>
    
    <cc>ojan</cc>
    
    <cc>ossy</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>323104</commentid>
    <comment_count>0</comment_count>
    <who name="Gabor Rapcsanyi">rgabor</who>
    <bug_when>2010-12-16 04:28:45 -0800</bug_when>
    <thetext>The sheriff-bot should be able to do multi-revision rollouts.
The webkit-patch is ready for this after https://bugs.webkit.org/show_bug.cgi?id=33336

Eg.:
  sheriffbot rollout r123 r124 r125 Some reason</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>323122</commentid>
    <comment_count>1</comment_count>
      <attachid>76757</attachid>
    <who name="Gabor Rapcsanyi">rgabor</who>
    <bug_when>2010-12-16 05:30:23 -0800</bug_when>
    <thetext>Created attachment 76757
proposed patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>326515</commentid>
    <comment_count>2</comment_count>
      <attachid>76757</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-12-24 01:48:49 -0800</bug_when>
    <thetext>Comment on attachment 76757
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=76757&amp;action=review

Needs another round. :)

&gt; WebKitTools/Scripts/webkitpy/tool/bot/irc_command.py:64
&gt; +        read_revision = True
&gt; +        rollout_reason = []
&gt; +        # the first argument must be a revision number
&gt; +        svn_revision_list = [args[0].lstrip(&quot;r&quot;)]
&gt; +        if not svn_revision_list[0].isdigit():
&gt; +            read_revision = False
&gt; +

Please split this (arg parsing, etc.) into private (_foo()) helper functions instead of just making execute longer.

&gt; WebKitTools/Scripts/webkitpy/tool/bot/sheriff.py:58
&gt; +            svn_revisions = &quot; &quot;.join([str(int(revision)) for revision in svn_revision_list])

Um, why do str(int(?

&gt; WebKitTools/Scripts/webkitpy/tool/bot/sheriff.py:76
&gt; +            svn_revisions,

Please pass them individually as numbers converted to strings, instead of as a joined string.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>328927</commentid>
    <comment_count>3</comment_count>
      <attachid>77872</attachid>
    <who name="Gabor Rapcsanyi">rgabor</who>
    <bug_when>2011-01-04 02:17:14 -0800</bug_when>
    <thetext>Created attachment 77872
proposed_patch_v2</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>328928</commentid>
    <comment_count>4</comment_count>
    <who name="Gabor Rapcsanyi">rgabor</who>
    <bug_when>2011-01-04 02:20:41 -0800</bug_when>
    <thetext>(In reply to comment #2)
&gt; (From update of attachment 76757 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=76757&amp;action=review
&gt; 
&gt; Needs another round. :)
&gt; 
&gt; &gt; WebKitTools/Scripts/webkitpy/tool/bot/irc_command.py:64
&gt; &gt; +        read_revision = True
&gt; &gt; +        rollout_reason = []
&gt; &gt; +        # the first argument must be a revision number
&gt; &gt; +        svn_revision_list = [args[0].lstrip(&quot;r&quot;)]
&gt; &gt; +        if not svn_revision_list[0].isdigit():
&gt; &gt; +            read_revision = False
&gt; &gt; +
&gt; 
&gt; Please split this (arg parsing, etc.) into private (_foo()) helper functions instead of just making execute longer.
&gt; 

corrected

&gt; &gt; WebKitTools/Scripts/webkitpy/tool/bot/sheriff.py:58
&gt; &gt; +            svn_revisions = &quot; &quot;.join([str(int(revision)) for revision in svn_revision_list])
&gt; 
&gt; Um, why do str(int(?
&gt; 

Here I just check the revisions whether they are numbers and after I convert back to string for the concatenation.

&gt; &gt; WebKitTools/Scripts/webkitpy/tool/bot/sheriff.py:76
&gt; &gt; +            svn_revisions,
&gt; 
&gt; Please pass them individually as numbers converted to strings, instead of as a joined string.

We have to pass the revisions between apostrophes or quotes to webkit-patch, and I think that&apos;s the best place to convert them to that format.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>329483</commentid>
    <comment_count>5</comment_count>
      <attachid>77872</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-01-05 01:35:02 -0800</bug_when>
    <thetext>Comment on attachment 77872
proposed_patch_v2

Looks great!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>329519</commentid>
    <comment_count>6</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2011-01-05 05:26:30 -0800</bug_when>
    <thetext>(In reply to comment #5)
&gt; (From update of attachment 77872 [details])
&gt; Looks great!

Landed in http://trac.webkit.org/changeset/75062</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>329534</commentid>
    <comment_count>7</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2011-01-05 06:19:16 -0800</bug_when>
    <thetext>(In reply to comment #6)
&gt; Landed in http://trac.webkit.org/changeset/75062

And a little fix landed in http://trac.webkit.org/changeset/75063</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>76757</attachid>
            <date>2010-12-16 05:30:23 -0800</date>
            <delta_ts>2011-01-04 02:17:14 -0800</delta_ts>
            <desc>proposed patch</desc>
            <filename>sheriff_multi_rollout.patch</filename>
            <type>text/plain</type>
            <size>8311</size>
            <attacher name="Gabor Rapcsanyi">rgabor</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D
aGFuZ2VMb2cJKHJldmlzaW9uIDc0MTgxKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr
aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMTItMTYgIEdhYm9yIFJhcGNzYW55aSAg
PHJnYWJvckBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP
T1BTISkuCisKKyAgICAgICAgc2hlcmlmZi1ib3Qgc2hvdWxkIGJlIGFibGUgdG8gZG8gbXVsdGkt
cmV2aXNpb24gcm9sbG91dHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i
dWcuY2dpP2lkPTUxMTc2CisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L2ly
Y19jb21tYW5kLnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3Qvc2hlcmlm
Zi5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L3NoZXJpZmZpcmNib3Rf
dW5pdHRlc3QucHk6CisKIDIwMTAtMTItMTUgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5i
b3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHI3NDEzNi4K
SW5kZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3QvaXJjX2NvbW1hbmQu
cHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PQotLS0gV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9p
cmNfY29tbWFuZC5weQkocmV2aXNpb24gNzQxODEpCisrKyBXZWJLaXRUb29scy9TY3JpcHRzL3dl
YmtpdHB5L3Rvb2wvYm90L2lyY19jb21tYW5kLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0zMCw5ICsz
MCwxMCBAQCBpbXBvcnQgcmFuZG9tCiBpbXBvcnQgd2Via2l0cHkuY29tbW9uLmNvbmZpZy5pcmMg
YXMgY29uZmlnX2lyYwogCiBmcm9tIHdlYmtpdHB5LmNvbW1vbi5jb25maWcgaW1wb3J0IHVybHMK
LWZyb20gd2Via2l0cHkudG9vbC5ib3QucXVldWVlbmdpbmUgaW1wb3J0IFRlcm1pbmF0ZVF1ZXVl
CiBmcm9tIHdlYmtpdHB5LmNvbW1vbi5uZXQuYnVnemlsbGEgaW1wb3J0IHBhcnNlX2J1Z19pZAog
ZnJvbSB3ZWJraXRweS5jb21tb24uc3lzdGVtLmV4ZWN1dGl2ZSBpbXBvcnQgU2NyaXB0RXJyb3IK
K2Zyb20gd2Via2l0cHkudG9vbC5ib3QucXVldWVlbmdpbmUgaW1wb3J0IFRlcm1pbmF0ZVF1ZXVl
Citmcm9tIHdlYmtpdHB5LnRvb2wuZ3JhbW1hciBpbXBvcnQgam9pbl93aXRoX3NlcGFyYXRvcnMK
IAogIyBGSVhNRTogTWVyZ2Ugd2l0aCBDb21tYW5kPwogY2xhc3MgSVJDQ29tbWFuZChvYmplY3Qp
OgpAQCAtNTQsMTYgKzU1LDMyIEBAIGNsYXNzIFJlc3RhcnQoSVJDQ29tbWFuZCk6CiAKIGNsYXNz
IFJvbGxvdXQoSVJDQ29tbWFuZCk6CiAgICAgZGVmIGV4ZWN1dGUoc2VsZiwgbmljaywgYXJncywg
dG9vbCwgc2hlcmlmZik6Ci0gICAgICAgIGlmIGxlbihhcmdzKSA8IDI6Ci0gICAgICAgICAgICB0
b29sLmlyYygpLnBvc3QoIiVzOiBVc2FnZTogU1ZOX1JFVklTSU9OIFJFQVNPTiIgJSBuaWNrKQor
ICAgICAgICByZWFkX3JldmlzaW9uID0gVHJ1ZQorICAgICAgICByb2xsb3V0X3JlYXNvbiA9IFtd
CisgICAgICAgICMgdGhlIGZpcnN0IGFyZ3VtZW50IG11c3QgYmUgYSByZXZpc2lvbiBudW1iZXIK
KyAgICAgICAgc3ZuX3JldmlzaW9uX2xpc3QgPSBbYXJnc1swXS5sc3RyaXAoInIiKV0KKyAgICAg
ICAgaWYgbm90IHN2bl9yZXZpc2lvbl9saXN0WzBdLmlzZGlnaXQoKToKKyAgICAgICAgICAgIHJl
YWRfcmV2aXNpb24gPSBGYWxzZQorCisgICAgICAgIGZvciBhcmcgaW4gYXJnc1sxOl06CisgICAg
ICAgICAgICBpZiBhcmcubHN0cmlwKCJyIikuaXNkaWdpdCgpIGFuZCByZWFkX3JldmlzaW9uOgor
ICAgICAgICAgICAgICAgIHN2bl9yZXZpc2lvbl9saXN0LmFwcGVuZChhcmcubHN0cmlwKCJyIikp
CisgICAgICAgICAgICBlbHNlOgorICAgICAgICAgICAgICAgIHJlYWRfcmV2aXNpb24gPSBGYWxz
ZQorICAgICAgICAgICAgICAgIHJvbGxvdXRfcmVhc29uLmFwcGVuZChhcmcpCisKKyAgICAgICAg
aWYgKGxlbihzdm5fcmV2aXNpb25fbGlzdCkgPT0gMCkgb3IgKGxlbihyb2xsb3V0X3JlYXNvbikg
PT0gMCk6CisgICAgICAgICAgICB0b29sLmlyYygpLnBvc3QoIiVzOiBVc2FnZTogU1ZOX1JFVklT
SU9OIFtTVk5fUkVWSVNJT05TXSBSRUFTT04iICUgbmljaykKICAgICAgICAgICAgIHJldHVybgot
ICAgICAgICBzdm5fcmV2aXNpb24gPSBhcmdzWzBdLmxzdHJpcCgiciIpCi0gICAgICAgIHJvbGxv
dXRfcmVhc29uID0gIiAiLmpvaW4oYXJnc1sxOl0pCi0gICAgICAgIHRvb2wuaXJjKCkucG9zdCgi
UHJlcGFyaW5nIHJvbGxvdXQgZm9yIHIlcy4uLiIgJSBzdm5fcmV2aXNpb24pCisKKyAgICAgICAg
cm9sbG91dF9yZWFzb24gPSAiICIuam9pbihyb2xsb3V0X3JlYXNvbikKKworICAgICAgICB0b29s
LmlyYygpLnBvc3QoIlByZXBhcmluZyByb2xsb3V0IGZvciAlcy4uLiIgJQorICAgICAgICAgICAg
ICAgICAgICAgICAgam9pbl93aXRoX3NlcGFyYXRvcnMoWyJyIiArIHN0cihyZXZpc2lvbikgZm9y
IHJldmlzaW9uIGluIHN2bl9yZXZpc2lvbl9saXN0XSkpCiAgICAgICAgIHRyeToKICAgICAgICAg
ICAgIGNvbXBsZXRlX3JlYXNvbiA9ICIlcyAoUmVxdWVzdGVkIGJ5ICVzIG9uICVzKS4iICUgKAog
ICAgICAgICAgICAgICAgIHJvbGxvdXRfcmVhc29uLCBuaWNrLCBjb25maWdfaXJjLmNoYW5uZWwp
Ci0gICAgICAgICAgICBidWdfaWQgPSBzaGVyaWZmLnBvc3Rfcm9sbG91dF9wYXRjaChzdm5fcmV2
aXNpb24sIGNvbXBsZXRlX3JlYXNvbikKKyAgICAgICAgICAgIGJ1Z19pZCA9IHNoZXJpZmYucG9z
dF9yb2xsb3V0X3BhdGNoKHN2bl9yZXZpc2lvbl9saXN0LCBjb21wbGV0ZV9yZWFzb24pCiAgICAg
ICAgICAgICBidWdfdXJsID0gdG9vbC5idWdzLmJ1Z191cmxfZm9yX2J1Z19pZChidWdfaWQpCiAg
ICAgICAgICAgICB0b29sLmlyYygpLnBvc3QoIiVzOiBDcmVhdGVkIHJvbGxvdXQ6ICVzIiAlIChu
aWNrLCBidWdfdXJsKSkKICAgICAgICAgZXhjZXB0IFNjcmlwdEVycm9yLCBlOgpJbmRleDogV2Vi
S2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9zaGVyaWZmLnB5Cj09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K
LS0tIFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3Qvc2hlcmlmZi5weQkocmV2
aXNpb24gNzQxODEpCisrKyBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L3No
ZXJpZmYucHkJKHdvcmtpbmcgY29weSkKQEAgLTUxLDE0ICs1MSwxNSBAQCBjbGFzcyBTaGVyaWZm
KG9iamVjdCk6CiAKICAgICAgICAgc2VsZi5fdG9vbC5pcmMoKS5wb3N0KGlyY19tZXNzYWdlKQog
Ci0gICAgZGVmIHBvc3Rfcm9sbG91dF9wYXRjaChzZWxmLCBzdm5fcmV2aXNpb24sIHJvbGxvdXRf
cmVhc29uKToKLSAgICAgICAgIyBFbnN1cmUgdGhhdCBzdm5fcmV2aXNpb24gaXMgYSBudW1iZXIg
KGFuZCBub3QgYW4gb3B0aW9uIHRvCisgICAgZGVmIHBvc3Rfcm9sbG91dF9wYXRjaChzZWxmLCBz
dm5fcmV2aXNpb25fbGlzdCwgcm9sbG91dF9yZWFzb24pOgorICAgICAgICAjIEVuc3VyZSB0aGF0
IHN2biByZXZpc2lvbnMgYXJlIG51bWJlcnMgKGFuZCBub3Qgb3B0aW9ucyB0bwogICAgICAgICAj
IGNyZWF0ZS1yb2xsb3V0KS4KICAgICAgICAgdHJ5OgotICAgICAgICAgICAgc3ZuX3JldmlzaW9u
ID0gaW50KHN2bl9yZXZpc2lvbikKKyAgICAgICAgICAgIHN2bl9yZXZpc2lvbnMgPSAiICIuam9p
bihbc3RyKGludChyZXZpc2lvbikpIGZvciByZXZpc2lvbiBpbiBzdm5fcmV2aXNpb25fbGlzdF0p
CiAgICAgICAgIGV4Y2VwdDoKICAgICAgICAgICAgIHJhaXNlIFNjcmlwdEVycm9yKG1lc3NhZ2U9
IkludmFsaWQgc3ZuIHJldmlzaW9uIG51bWJlciBcIiVzXCIuIgotICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgJSBzdm5fcmV2aXNpb24pCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAlICIgIi5qb2luKHN2bl9yZXZpc2lvbl9saXN0KSkKKyAgICAgICAgc3ZuX3JldmlzaW9ucyA9
ICInJXMnIiAlIHN2bl9yZXZpc2lvbnMKIAogICAgICAgICBpZiByb2xsb3V0X3JlYXNvbi5zdGFy
dHN3aXRoKCItIik6CiAgICAgICAgICAgICByYWlzZSBTY3JpcHRFcnJvcihtZXNzYWdlPSJUaGUg
cm9sbG91dCByZWFzb24gbWF5IG5vdCBiZWdpbiAiCkBAIC03Miw3ICs3Myw3IEBAIGNsYXNzIFNo
ZXJpZmYob2JqZWN0KToKICAgICAgICAgICAgICMgcGFzcyBpdCBwcm9waHlsYWN0aWNhbGx5IGJl
Y2F1c2Ugd2UgcmVqZWN0IHVucmVjb2duaXplZCBjb21tYW5kCiAgICAgICAgICAgICAjIGxpbmUg
c3dpdGNoZXMuCiAgICAgICAgICAgICAiLS1wYXJlbnQtY29tbWFuZD1zaGVyaWZmLWJvdCIsCi0g
ICAgICAgICAgICBzdm5fcmV2aXNpb24sCisgICAgICAgICAgICBzdm5fcmV2aXNpb25zLAogICAg
ICAgICAgICAgcm9sbG91dF9yZWFzb24sCiAgICAgICAgIF0pCiAgICAgICAgIHJldHVybiBwYXJz
ZV9idWdfaWQob3V0cHV0KQpJbmRleDogV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29s
L2JvdC9zaGVyaWZmaXJjYm90X3VuaXR0ZXN0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xz
L1NjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3Qvc2hlcmlmZmlyY2JvdF91bml0dGVzdC5weQkocmV2
aXNpb24gNzQxODEpCisrKyBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L3No
ZXJpZmZpcmNib3RfdW5pdHRlc3QucHkJKHdvcmtpbmcgY29weSkKQEAgLTYyLDEyICs2MiwyMCBA
QCBjbGFzcyBTaGVyaWZmSVJDQm90VGVzdCh1bml0dGVzdC5UZXN0Q2FzCiAgICAgICAgIGV4cGVj
dGVkX3N0ZGVyciA9ICJNT0NLOiBpcmMucG9zdDogUHJlcGFyaW5nIHJvbGxvdXQgZm9yIHIyMTY1
NC4uLlxuTU9DSzogaXJjLnBvc3Q6IG1vY2tfbmljazogQ3JlYXRlZCByb2xsb3V0OiBodHRwOi8v
ZXhhbXBsZS5jb20vMzY5MzZcbiIKICAgICAgICAgT3V0cHV0Q2FwdHVyZSgpLmFzc2VydF9vdXRw
dXRzKHNlbGYsIHJ1biwgYXJncz1bInJvbGxvdXQgMjE2NTQgVGhpcyBwYXRjaCBicm9rZSB0aGUg
d29ybGQiXSwgZXhwZWN0ZWRfc3RkZXJyPWV4cGVjdGVkX3N0ZGVycikKIAorICAgIGRlZiB0ZXN0
X211bHRpX3JvbGxvdXQoc2VsZik6CisgICAgICAgIGV4cGVjdGVkX3N0ZGVyciA9ICJNT0NLOiBp
cmMucG9zdDogUHJlcGFyaW5nIHJvbGxvdXQgZm9yIHIyMTY1NCwgcjIxNjU1LCBhbmQgcjIxNjU2
Li4uXG5NT0NLOiBpcmMucG9zdDogbW9ja19uaWNrOiBDcmVhdGVkIHJvbGxvdXQ6IGh0dHA6Ly9l
eGFtcGxlLmNvbS8zNjkzNlxuIgorICAgICAgICBPdXRwdXRDYXB0dXJlKCkuYXNzZXJ0X291dHB1
dHMoc2VsZiwgcnVuLCBhcmdzPVsicm9sbG91dCAyMTY1NCAyMTY1NSAyMTY1NiBUaGlzIDIxNjU0
IHBhdGNoIGJyb2tlIHRoZSB3b3JsZCJdLCBleHBlY3RlZF9zdGRlcnI9ZXhwZWN0ZWRfc3RkZXJy
KQorCiAgICAgZGVmIHRlc3Rfcm9sbG91dF93aXRoX3JfaW5fc3ZuX3JldmlzaW9uKHNlbGYpOgog
ICAgICAgICBleHBlY3RlZF9zdGRlcnIgPSAiTU9DSzogaXJjLnBvc3Q6IFByZXBhcmluZyByb2xs
b3V0IGZvciByMjE2NTQuLi5cbk1PQ0s6IGlyYy5wb3N0OiBtb2NrX25pY2s6IENyZWF0ZWQgcm9s
bG91dDogaHR0cDovL2V4YW1wbGUuY29tLzM2OTM2XG4iCiAgICAgICAgIE91dHB1dENhcHR1cmUo
KS5hc3NlcnRfb3V0cHV0cyhzZWxmLCBydW4sIGFyZ3M9WyJyb2xsb3V0IHIyMTY1NCBUaGlzIHBh
dGNoIGJyb2tlIHRoZSB3b3JsZCJdLCBleHBlY3RlZF9zdGRlcnI9ZXhwZWN0ZWRfc3RkZXJyKQog
CisgICAgZGVmIHRlc3RfbXVsdGlfcm9sbG91dF93aXRoX3JfaW5fc3ZuX3JldmlzaW9uKHNlbGYp
OgorICAgICAgICBleHBlY3RlZF9zdGRlcnIgPSAiTU9DSzogaXJjLnBvc3Q6IFByZXBhcmluZyBy
b2xsb3V0IGZvciByMjE2NTQsIHIyMTY1NSwgYW5kIHIyMTY1Ni4uLlxuTU9DSzogaXJjLnBvc3Q6
IG1vY2tfbmljazogQ3JlYXRlZCByb2xsb3V0OiBodHRwOi8vZXhhbXBsZS5jb20vMzY5MzZcbiIK
KyAgICAgICAgT3V0cHV0Q2FwdHVyZSgpLmFzc2VydF9vdXRwdXRzKHNlbGYsIHJ1biwgYXJncz1b
InJvbGxvdXQgcjIxNjU0IDIxNjU1IHIyMTY1NiBUaGlzIHIyMTY1NCBwYXRjaCBicm9rZSB0aGUg
d29ybGQiXSwgZXhwZWN0ZWRfc3RkZXJyPWV4cGVjdGVkX3N0ZGVycikKKwogICAgIGRlZiB0ZXN0
X3JvbGxvdXRfYmFuYW5hcyhzZWxmKToKLSAgICAgICAgZXhwZWN0ZWRfc3RkZXJyID0gIk1PQ0s6
IGlyYy5wb3N0OiBtb2NrX25pY2s6IFVzYWdlOiBTVk5fUkVWSVNJT04gUkVBU09OXG4iCisgICAg
ICAgIGV4cGVjdGVkX3N0ZGVyciA9ICJNT0NLOiBpcmMucG9zdDogbW9ja19uaWNrOiBVc2FnZTog
U1ZOX1JFVklTSU9OIFtTVk5fUkVWSVNJT05TXSBSRUFTT05cbiIKICAgICAgICAgT3V0cHV0Q2Fw
dHVyZSgpLmFzc2VydF9vdXRwdXRzKHNlbGYsIHJ1biwgYXJncz1bInJvbGxvdXQgYmFuYW5hcyJd
LCBleHBlY3RlZF9zdGRlcnI9ZXhwZWN0ZWRfc3RkZXJyKQogCiAgICAgZGVmIHRlc3Rfcm9sbG91
dF9pbnZhbGlkYXRlX3JldmlzaW9uKHNlbGYpOgpAQCAtOTAsNiArOTgsMjEgQEAgY2xhc3MgU2hl
cmlmZklSQ0JvdFRlc3QodW5pdHRlc3QuVGVzdENhcwogICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgIjIxNjU0IC1iYWQiXSwKICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgIGV4cGVjdGVkX3N0ZGVycj1leHBlY3RlZF9zdGRlcnIpCiAKKyAg
ICBkZWYgdGVzdF9tdWx0aV9yb2xsb3V0X2ludmFsaWRhdGVfcmVhc29uKHNlbGYpOgorICAgICAg
ICBleHBlY3RlZF9zdGRlcnIgPSAoIk1PQ0s6IGlyYy5wb3N0OiBQcmVwYXJpbmcgcm9sbG91dCBm
b3IgIgorICAgICAgICAgICAgICAgICAgICAgICAgICAgInIyMTY1NCwgcjIxNjU1LCBhbmQgcjIx
NjU2Li4uXG5NT0NLOiBpcmMucG9zdDogbW9ja19uaWNrOiBGYWlsZWQgdG8gIgorICAgICAgICAg
ICAgICAgICAgICAgICAgICAgImNyZWF0ZSByb2xsb3V0IHBhdGNoOlxuTU9DSzogaXJjLnBvc3Q6
IFRoZSByb2xsb3V0IgorICAgICAgICAgICAgICAgICAgICAgICAgICAgIiByZWFzb24gbWF5IG5v
dCBiZWdpbiB3aXRoIC0gKFwiLWJhZCAoUmVxdWVzdGVkICIKKyAgICAgICAgICAgICAgICAgICAg
ICAgICAgICJieSBtb2NrX25pY2sgb24gI3dlYmtpdCkuXCIpLlxuIikKKyAgICAgICAgT3V0cHV0
Q2FwdHVyZSgpLmFzc2VydF9vdXRwdXRzKHNlbGYsIHJ1biwKKyAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgIGFyZ3M9WyJyb2xsb3V0ICIKKyAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICIyMTY1NCAyMTY1NSByMjE2NTYgLWJhZCJdLAorICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZXhwZWN0ZWRfc3RkZXJyPWV4cGVj
dGVkX3N0ZGVycikKKwogICAgIGRlZiB0ZXN0X3JvbGxvdXRfbm9fcmVhc29uKHNlbGYpOgotICAg
ICAgICBleHBlY3RlZF9zdGRlcnIgPSAiTU9DSzogaXJjLnBvc3Q6IG1vY2tfbmljazogVXNhZ2U6
IFNWTl9SRVZJU0lPTiBSRUFTT05cbiIKKyAgICAgICAgZXhwZWN0ZWRfc3RkZXJyID0gIk1PQ0s6
IGlyYy5wb3N0OiBtb2NrX25pY2s6IFVzYWdlOiBTVk5fUkVWSVNJT04gW1NWTl9SRVZJU0lPTlNd
IFJFQVNPTlxuIgogICAgICAgICBPdXRwdXRDYXB0dXJlKCkuYXNzZXJ0X291dHB1dHMoc2VsZiwg
cnVuLCBhcmdzPVsicm9sbG91dCAyMTY1NCJdLCBleHBlY3RlZF9zdGRlcnI9ZXhwZWN0ZWRfc3Rk
ZXJyKQorCisgICAgZGVmIHRlc3RfbXVsdGlfcm9sbG91dF9ub19yZWFzb24oc2VsZik6CisgICAg
ICAgIGV4cGVjdGVkX3N0ZGVyciA9ICJNT0NLOiBpcmMucG9zdDogbW9ja19uaWNrOiBVc2FnZTog
U1ZOX1JFVklTSU9OIFtTVk5fUkVWSVNJT05TXSBSRUFTT05cbiIKKyAgICAgICAgT3V0cHV0Q2Fw
dHVyZSgpLmFzc2VydF9vdXRwdXRzKHNlbGYsIHJ1biwgYXJncz1bInJvbGxvdXQgMjE2NTQgMjE2
NTUgcjIxNjU2Il0sIGV4cGVjdGVkX3N0ZGVycj1leHBlY3RlZF9zdGRlcnIpCg==
</data>
<flag name="review"
          id="67756"
          type_id="1"
          status="-"
          setter="eric"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>77872</attachid>
            <date>2011-01-04 02:17:14 -0800</date>
            <delta_ts>2011-01-05 01:35:02 -0800</delta_ts>
            <desc>proposed_patch_v2</desc>
            <filename>sheriff03.patch</filename>
            <type>text/plain</type>
            <size>8208</size>
            <attacher name="Gabor Rapcsanyi">rgabor</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3Qvc2hlcmlmZmlyY2JvdF91bml0
dGVzdC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L3No
ZXJpZmZpcmNib3RfdW5pdHRlc3QucHkJKHJldmlzaW9uIDc0OTYxKQorKysgVG9vbHMvU2NyaXB0
cy93ZWJraXRweS90b29sL2JvdC9zaGVyaWZmaXJjYm90X3VuaXR0ZXN0LnB5CSh3b3JraW5nIGNv
cHkpCkBAIC02MiwxMiArNjIsMjAgQEAKICAgICAgICAgZXhwZWN0ZWRfc3RkZXJyID0gIk1PQ0s6
IGlyYy5wb3N0OiBQcmVwYXJpbmcgcm9sbG91dCBmb3IgcjIxNjU0Li4uXG5NT0NLOiBpcmMucG9z
dDogbW9ja19uaWNrOiBDcmVhdGVkIHJvbGxvdXQ6IGh0dHA6Ly9leGFtcGxlLmNvbS8zNjkzNlxu
IgogICAgICAgICBPdXRwdXRDYXB0dXJlKCkuYXNzZXJ0X291dHB1dHMoc2VsZiwgcnVuLCBhcmdz
PVsicm9sbG91dCAyMTY1NCBUaGlzIHBhdGNoIGJyb2tlIHRoZSB3b3JsZCJdLCBleHBlY3RlZF9z
dGRlcnI9ZXhwZWN0ZWRfc3RkZXJyKQogCisgICAgZGVmIHRlc3RfbXVsdGlfcm9sbG91dChzZWxm
KToKKyAgICAgICAgZXhwZWN0ZWRfc3RkZXJyID0gIk1PQ0s6IGlyYy5wb3N0OiBQcmVwYXJpbmcg
cm9sbG91dCBmb3IgcjIxNjU0LCByMjE2NTUsIGFuZCByMjE2NTYuLi5cbk1PQ0s6IGlyYy5wb3N0
OiBtb2NrX25pY2s6IENyZWF0ZWQgcm9sbG91dDogaHR0cDovL2V4YW1wbGUuY29tLzM2OTM2XG4i
CisgICAgICAgIE91dHB1dENhcHR1cmUoKS5hc3NlcnRfb3V0cHV0cyhzZWxmLCBydW4sIGFyZ3M9
WyJyb2xsb3V0IDIxNjU0IDIxNjU1IDIxNjU2IFRoaXMgMjE2NTQgcGF0Y2ggYnJva2UgdGhlIHdv
cmxkIl0sIGV4cGVjdGVkX3N0ZGVycj1leHBlY3RlZF9zdGRlcnIpCisKICAgICBkZWYgdGVzdF9y
b2xsb3V0X3dpdGhfcl9pbl9zdm5fcmV2aXNpb24oc2VsZik6CiAgICAgICAgIGV4cGVjdGVkX3N0
ZGVyciA9ICJNT0NLOiBpcmMucG9zdDogUHJlcGFyaW5nIHJvbGxvdXQgZm9yIHIyMTY1NC4uLlxu
TU9DSzogaXJjLnBvc3Q6IG1vY2tfbmljazogQ3JlYXRlZCByb2xsb3V0OiBodHRwOi8vZXhhbXBs
ZS5jb20vMzY5MzZcbiIKICAgICAgICAgT3V0cHV0Q2FwdHVyZSgpLmFzc2VydF9vdXRwdXRzKHNl
bGYsIHJ1biwgYXJncz1bInJvbGxvdXQgcjIxNjU0IFRoaXMgcGF0Y2ggYnJva2UgdGhlIHdvcmxk
Il0sIGV4cGVjdGVkX3N0ZGVycj1leHBlY3RlZF9zdGRlcnIpCiAKKyAgICBkZWYgdGVzdF9tdWx0
aV9yb2xsb3V0X3dpdGhfcl9pbl9zdm5fcmV2aXNpb24oc2VsZik6CisgICAgICAgIGV4cGVjdGVk
X3N0ZGVyciA9ICJNT0NLOiBpcmMucG9zdDogUHJlcGFyaW5nIHJvbGxvdXQgZm9yIHIyMTY1NCwg
cjIxNjU1LCBhbmQgcjIxNjU2Li4uXG5NT0NLOiBpcmMucG9zdDogbW9ja19uaWNrOiBDcmVhdGVk
IHJvbGxvdXQ6IGh0dHA6Ly9leGFtcGxlLmNvbS8zNjkzNlxuIgorICAgICAgICBPdXRwdXRDYXB0
dXJlKCkuYXNzZXJ0X291dHB1dHMoc2VsZiwgcnVuLCBhcmdzPVsicm9sbG91dCByMjE2NTQgMjE2
NTUgcjIxNjU2IFRoaXMgcjIxNjU0IHBhdGNoIGJyb2tlIHRoZSB3b3JsZCJdLCBleHBlY3RlZF9z
dGRlcnI9ZXhwZWN0ZWRfc3RkZXJyKQorCiAgICAgZGVmIHRlc3Rfcm9sbG91dF9iYW5hbmFzKHNl
bGYpOgotICAgICAgICBleHBlY3RlZF9zdGRlcnIgPSAiTU9DSzogaXJjLnBvc3Q6IG1vY2tfbmlj
azogVXNhZ2U6IFNWTl9SRVZJU0lPTiBSRUFTT05cbiIKKyAgICAgICAgZXhwZWN0ZWRfc3RkZXJy
ID0gIk1PQ0s6IGlyYy5wb3N0OiBtb2NrX25pY2s6IFVzYWdlOiBTVk5fUkVWSVNJT04gW1NWTl9S
RVZJU0lPTlNdIFJFQVNPTlxuIgogICAgICAgICBPdXRwdXRDYXB0dXJlKCkuYXNzZXJ0X291dHB1
dHMoc2VsZiwgcnVuLCBhcmdzPVsicm9sbG91dCBiYW5hbmFzIl0sIGV4cGVjdGVkX3N0ZGVycj1l
eHBlY3RlZF9zdGRlcnIpCiAKICAgICBkZWYgdGVzdF9yb2xsb3V0X2ludmFsaWRhdGVfcmV2aXNp
b24oc2VsZik6CkBAIC05MCw2ICs5OCwyMSBAQAogICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgIjIxNjU0IC1iYWQiXSwKICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIGV4cGVjdGVkX3N0ZGVycj1leHBlY3RlZF9zdGRlcnIpCiAKKyAgICBk
ZWYgdGVzdF9tdWx0aV9yb2xsb3V0X2ludmFsaWRhdGVfcmVhc29uKHNlbGYpOgorICAgICAgICBl
eHBlY3RlZF9zdGRlcnIgPSAoIk1PQ0s6IGlyYy5wb3N0OiBQcmVwYXJpbmcgcm9sbG91dCBmb3Ig
IgorICAgICAgICAgICAgICAgICAgICAgICAgICAgInIyMTY1NCwgcjIxNjU1LCBhbmQgcjIxNjU2
Li4uXG5NT0NLOiBpcmMucG9zdDogbW9ja19uaWNrOiBGYWlsZWQgdG8gIgorICAgICAgICAgICAg
ICAgICAgICAgICAgICAgImNyZWF0ZSByb2xsb3V0IHBhdGNoOlxuTU9DSzogaXJjLnBvc3Q6IFRo
ZSByb2xsb3V0IgorICAgICAgICAgICAgICAgICAgICAgICAgICAgIiByZWFzb24gbWF5IG5vdCBi
ZWdpbiB3aXRoIC0gKFwiLWJhZCAoUmVxdWVzdGVkICIKKyAgICAgICAgICAgICAgICAgICAgICAg
ICAgICJieSBtb2NrX25pY2sgb24gI3dlYmtpdCkuXCIpLlxuIikKKyAgICAgICAgT3V0cHV0Q2Fw
dHVyZSgpLmFzc2VydF9vdXRwdXRzKHNlbGYsIHJ1biwKKyAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIGFyZ3M9WyJyb2xsb3V0ICIKKyAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICIyMTY1NCAyMTY1NSByMjE2NTYgLWJhZCJdLAorICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZXhwZWN0ZWRfc3RkZXJyPWV4cGVjdGVk
X3N0ZGVycikKKwogICAgIGRlZiB0ZXN0X3JvbGxvdXRfbm9fcmVhc29uKHNlbGYpOgotICAgICAg
ICBleHBlY3RlZF9zdGRlcnIgPSAiTU9DSzogaXJjLnBvc3Q6IG1vY2tfbmljazogVXNhZ2U6IFNW
Tl9SRVZJU0lPTiBSRUFTT05cbiIKKyAgICAgICAgZXhwZWN0ZWRfc3RkZXJyID0gIk1PQ0s6IGly
Yy5wb3N0OiBtb2NrX25pY2s6IFVzYWdlOiBTVk5fUkVWSVNJT04gW1NWTl9SRVZJU0lPTlNdIFJF
QVNPTlxuIgogICAgICAgICBPdXRwdXRDYXB0dXJlKCkuYXNzZXJ0X291dHB1dHMoc2VsZiwgcnVu
LCBhcmdzPVsicm9sbG91dCAyMTY1NCJdLCBleHBlY3RlZF9zdGRlcnI9ZXhwZWN0ZWRfc3RkZXJy
KQorCisgICAgZGVmIHRlc3RfbXVsdGlfcm9sbG91dF9ub19yZWFzb24oc2VsZik6CisgICAgICAg
IGV4cGVjdGVkX3N0ZGVyciA9ICJNT0NLOiBpcmMucG9zdDogbW9ja19uaWNrOiBVc2FnZTogU1ZO
X1JFVklTSU9OIFtTVk5fUkVWSVNJT05TXSBSRUFTT05cbiIKKyAgICAgICAgT3V0cHV0Q2FwdHVy
ZSgpLmFzc2VydF9vdXRwdXRzKHNlbGYsIHJ1biwgYXJncz1bInJvbGxvdXQgMjE2NTQgMjE2NTUg
cjIxNjU2Il0sIGV4cGVjdGVkX3N0ZGVycj1leHBlY3RlZF9zdGRlcnIpCkluZGV4OiBUb29scy9T
Y3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L2lyY19jb21tYW5kLnB5Cj09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRv
b2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3QvaXJjX2NvbW1hbmQucHkJKHJldmlzaW9uIDc0
OTYxKQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9pcmNfY29tbWFuZC5weQko
d29ya2luZyBjb3B5KQpAQCAtMzAsOSArMzAsMTAgQEAKIGltcG9ydCB3ZWJraXRweS5jb21tb24u
Y29uZmlnLmlyYyBhcyBjb25maWdfaXJjCiAKIGZyb20gd2Via2l0cHkuY29tbW9uLmNvbmZpZyBp
bXBvcnQgdXJscwotZnJvbSB3ZWJraXRweS50b29sLmJvdC5xdWV1ZWVuZ2luZSBpbXBvcnQgVGVy
bWluYXRlUXVldWUKIGZyb20gd2Via2l0cHkuY29tbW9uLm5ldC5idWd6aWxsYSBpbXBvcnQgcGFy
c2VfYnVnX2lkCiBmcm9tIHdlYmtpdHB5LmNvbW1vbi5zeXN0ZW0uZXhlY3V0aXZlIGltcG9ydCBT
Y3JpcHRFcnJvcgorZnJvbSB3ZWJraXRweS50b29sLmJvdC5xdWV1ZWVuZ2luZSBpbXBvcnQgVGVy
bWluYXRlUXVldWUKK2Zyb20gd2Via2l0cHkudG9vbC5ncmFtbWFyIGltcG9ydCBqb2luX3dpdGhf
c2VwYXJhdG9ycwogCiAjIEZJWE1FOiBNZXJnZSB3aXRoIENvbW1hbmQ/CiBjbGFzcyBJUkNDb21t
YW5kKG9iamVjdCk6CkBAIC01MywxNyArNTQsMzggQEAKIAogCiBjbGFzcyBSb2xsb3V0KElSQ0Nv
bW1hbmQpOgorICAgIGRlZiBfcGFyc2VfYXJncyhzZWxmLCBhcmdzKToKKyAgICAgICAgcmVhZF9y
ZXZpc2lvbiA9IFRydWUKKyAgICAgICAgcm9sbG91dF9yZWFzb24gPSBbXQorICAgICAgICAjIHRo
ZSBmaXJzdCBhcmd1bWVudCBtdXN0IGJlIGEgcmV2aXNpb24gbnVtYmVyCisgICAgICAgIHN2bl9y
ZXZpc2lvbl9saXN0ID0gW2FyZ3NbMF0ubHN0cmlwKCJyIildCisgICAgICAgIGlmIG5vdCBzdm5f
cmV2aXNpb25fbGlzdFswXS5pc2RpZ2l0KCk6CisgICAgICAgICAgICByZWFkX3JldmlzaW9uID0g
RmFsc2UKKworICAgICAgICBmb3IgYXJnIGluIGFyZ3NbMTpdOgorICAgICAgICAgICAgaWYgYXJn
LmxzdHJpcCgiciIpLmlzZGlnaXQoKSBhbmQgcmVhZF9yZXZpc2lvbjoKKyAgICAgICAgICAgICAg
ICBzdm5fcmV2aXNpb25fbGlzdC5hcHBlbmQoYXJnLmxzdHJpcCgiciIpKQorICAgICAgICAgICAg
ZWxzZToKKyAgICAgICAgICAgICAgICByZWFkX3JldmlzaW9uID0gRmFsc2UKKyAgICAgICAgICAg
ICAgICByb2xsb3V0X3JlYXNvbi5hcHBlbmQoYXJnKQorCisgICAgICAgIHJldHVybiBzdm5fcmV2
aXNpb25fbGlzdCwgcm9sbG91dF9yZWFzb24KKwogICAgIGRlZiBleGVjdXRlKHNlbGYsIG5pY2ss
IGFyZ3MsIHRvb2wsIHNoZXJpZmYpOgotICAgICAgICBpZiBsZW4oYXJncykgPCAyOgotICAgICAg
ICAgICAgdG9vbC5pcmMoKS5wb3N0KCIlczogVXNhZ2U6IFNWTl9SRVZJU0lPTiBSRUFTT04iICUg
bmljaykKKyAgICAgICAgc3ZuX3JldmlzaW9uX2xpc3QsIHJvbGxvdXRfcmVhc29uID0gc2VsZi5f
cGFyc2VfYXJncyhhcmdzKQorCisgICAgICAgIGlmIChsZW4oc3ZuX3JldmlzaW9uX2xpc3QpID09
IDApIG9yIChsZW4ocm9sbG91dF9yZWFzb24pID09IDApOgorICAgICAgICAgICAgdG9vbC5pcmMo
KS5wb3N0KCIlczogVXNhZ2U6IFNWTl9SRVZJU0lPTiBbU1ZOX1JFVklTSU9OU10gUkVBU09OIiAl
IG5pY2spCiAgICAgICAgICAgICByZXR1cm4KLSAgICAgICAgc3ZuX3JldmlzaW9uID0gYXJnc1sw
XS5sc3RyaXAoInIiKQotICAgICAgICByb2xsb3V0X3JlYXNvbiA9ICIgIi5qb2luKGFyZ3NbMTpd
KQotICAgICAgICB0b29sLmlyYygpLnBvc3QoIlByZXBhcmluZyByb2xsb3V0IGZvciByJXMuLi4i
ICUgc3ZuX3JldmlzaW9uKQorCisgICAgICAgIHJvbGxvdXRfcmVhc29uID0gIiAiLmpvaW4ocm9s
bG91dF9yZWFzb24pCisKKyAgICAgICAgdG9vbC5pcmMoKS5wb3N0KCJQcmVwYXJpbmcgcm9sbG91
dCBmb3IgJXMuLi4iICUKKyAgICAgICAgICAgICAgICAgICAgICAgIGpvaW5fd2l0aF9zZXBhcmF0
b3JzKFsiciIgKyBzdHIocmV2aXNpb24pIGZvciByZXZpc2lvbiBpbiBzdm5fcmV2aXNpb25fbGlz
dF0pKQogICAgICAgICB0cnk6CiAgICAgICAgICAgICBjb21wbGV0ZV9yZWFzb24gPSAiJXMgKFJl
cXVlc3RlZCBieSAlcyBvbiAlcykuIiAlICgKICAgICAgICAgICAgICAgICByb2xsb3V0X3JlYXNv
biwgbmljaywgY29uZmlnX2lyYy5jaGFubmVsKQotICAgICAgICAgICAgYnVnX2lkID0gc2hlcmlm
Zi5wb3N0X3JvbGxvdXRfcGF0Y2goc3ZuX3JldmlzaW9uLCBjb21wbGV0ZV9yZWFzb24pCisgICAg
ICAgICAgICBidWdfaWQgPSBzaGVyaWZmLnBvc3Rfcm9sbG91dF9wYXRjaChzdm5fcmV2aXNpb25f
bGlzdCwgY29tcGxldGVfcmVhc29uKQogICAgICAgICAgICAgYnVnX3VybCA9IHRvb2wuYnVncy5i
dWdfdXJsX2Zvcl9idWdfaWQoYnVnX2lkKQogICAgICAgICAgICAgdG9vbC5pcmMoKS5wb3N0KCIl
czogQ3JlYXRlZCByb2xsb3V0OiAlcyIgJSAobmljaywgYnVnX3VybCkpCiAgICAgICAgIGV4Y2Vw
dCBTY3JpcHRFcnJvciwgZToKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3Qv
c2hlcmlmZi5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90
L3NoZXJpZmYucHkJKHJldmlzaW9uIDc0OTYxKQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS90
b29sL2JvdC9zaGVyaWZmLnB5CSh3b3JraW5nIGNvcHkpCkBAIC01MSwxNCArNTEsMTUgQEAKIAog
ICAgICAgICBzZWxmLl90b29sLmlyYygpLnBvc3QoaXJjX21lc3NhZ2UpCiAKLSAgICBkZWYgcG9z
dF9yb2xsb3V0X3BhdGNoKHNlbGYsIHN2bl9yZXZpc2lvbiwgcm9sbG91dF9yZWFzb24pOgotICAg
ICAgICAjIEVuc3VyZSB0aGF0IHN2bl9yZXZpc2lvbiBpcyBhIG51bWJlciAoYW5kIG5vdCBhbiBv
cHRpb24gdG8KKyAgICBkZWYgcG9zdF9yb2xsb3V0X3BhdGNoKHNlbGYsIHN2bl9yZXZpc2lvbl9s
aXN0LCByb2xsb3V0X3JlYXNvbik6CisgICAgICAgICMgRW5zdXJlIHRoYXQgc3ZuIHJldmlzaW9u
cyBhcmUgbnVtYmVycyAoYW5kIG5vdCBvcHRpb25zIHRvCiAgICAgICAgICMgY3JlYXRlLXJvbGxv
dXQpLgogICAgICAgICB0cnk6Ci0gICAgICAgICAgICBzdm5fcmV2aXNpb24gPSBpbnQoc3ZuX3Jl
dmlzaW9uKQorICAgICAgICAgICAgc3ZuX3JldmlzaW9ucyA9ICIgIi5qb2luKFtzdHIoaW50KHJl
dmlzaW9uKSkgZm9yIHJldmlzaW9uIGluIHN2bl9yZXZpc2lvbl9saXN0XSkKICAgICAgICAgZXhj
ZXB0OgogICAgICAgICAgICAgcmFpc2UgU2NyaXB0RXJyb3IobWVzc2FnZT0iSW52YWxpZCBzdm4g
cmV2aXNpb24gbnVtYmVyIFwiJXNcIi4iCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAl
IHN2bl9yZXZpc2lvbikKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICUgIiAiLmpvaW4o
c3ZuX3JldmlzaW9uX2xpc3QpKQorICAgICAgICBzdm5fcmV2aXNpb25zID0gIiclcyciICUgc3Zu
X3JldmlzaW9ucwogCiAgICAgICAgIGlmIHJvbGxvdXRfcmVhc29uLnN0YXJ0c3dpdGgoIi0iKToK
ICAgICAgICAgICAgIHJhaXNlIFNjcmlwdEVycm9yKG1lc3NhZ2U9IlRoZSByb2xsb3V0IHJlYXNv
biBtYXkgbm90IGJlZ2luICIKQEAgLTcyLDcgKzczLDcgQEAKICAgICAgICAgICAgICMgcGFzcyBp
dCBwcm9waHlsYWN0aWNhbGx5IGJlY2F1c2Ugd2UgcmVqZWN0IHVucmVjb2duaXplZCBjb21tYW5k
CiAgICAgICAgICAgICAjIGxpbmUgc3dpdGNoZXMuCiAgICAgICAgICAgICAiLS1wYXJlbnQtY29t
bWFuZD1zaGVyaWZmLWJvdCIsCi0gICAgICAgICAgICBzdm5fcmV2aXNpb24sCisgICAgICAgICAg
ICBzdm5fcmV2aXNpb25zLAogICAgICAgICAgICAgcm9sbG91dF9yZWFzb24sCiAgICAgICAgIF0p
CiAgICAgICAgIHJldHVybiBwYXJzZV9idWdfaWQob3V0cHV0KQpJbmRleDogVG9vbHMvQ2hhbmdl
TG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0NoYW5nZUxvZwkocmV2aXNpb24gNzQ5NjEpCisrKyBU
b29scy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAxMS0wMS0w
NCAgR2Fib3IgUmFwY3NhbnlpICA8cmdhYm9yQGluZi51LXN6ZWdlZC5odT4KKworICAgICAgICBS
ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBzaGVyaWZmLWJvdCBzaG91bGQg
YmUgYWJsZSB0byBkbyBtdWx0aS1yZXZpc2lvbiByb2xsb3V0cworICAgICAgICBodHRwczovL2J1
Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTExNzYKKworICAgICAgICAqIFNjcmlwdHMv
d2Via2l0cHkvdG9vbC9ib3QvaXJjX2NvbW1hbmQucHk6CisgICAgICAgICogU2NyaXB0cy93ZWJr
aXRweS90b29sL2JvdC9zaGVyaWZmLnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9v
bC9ib3Qvc2hlcmlmZmlyY2JvdF91bml0dGVzdC5weToKKwogMjAxMS0wMS0wMyAgWWkgU2hlbiAg
PHlpLjQuc2hlbkBub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4K
</data>
<flag name="review"
          id="69091"
          type_id="1"
          status="+"
          setter="abarth"
    />
          </attachment>
      

    </bug>

</bugzilla>