51173 2010-12-16 02:51:52 -0800 [GTK] Buttons rendering was broken in r74129 2010-12-17 18:37:52 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 cgarcia webkit-unassigned commit-queue oldest_to_newest 323088 0 cgarcia 2010-12-16 02:51:52 -0800 - // FIXME: The depressed value should probably apply for other theme parts too. - // It must be used for range thumbs, because otherwise when the thumb is pressed, - // the rendering is incorrect. - if (type == MOZ_GTK_SCALE_THUMB_HORIZONTAL || type == MOZ_GTK_SCALE_THUMB_VERTICAL) - widgetState.depressed = isPressed(renderObject); - else - widgetState.depressed = false; - We still need to set the depressed state for other widget types 323089 1 76747 cgarcia 2010-12-16 02:53:59 -0800 Created attachment 76747 Patch to fix the problem 323209 2 76747 mrobinson 2010-12-16 09:20:22 -0800 Comment on attachment 76747 Patch to fix the problem Thanks! 323251 3 76747 commit-queue 2010-12-16 10:23:53 -0800 Comment on attachment 76747 Patch to fix the problem Rejecting attachment 76747 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'apply-attachment', '--non-interactive', 76747]" exit_code: 2 Last 500 characters of output: ailed to merge in the changes. Patch failed at 0001 2010-12-16 Yury Semikhatsky <yurys@chromium.org> When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at WebKitTools/Scripts/update-webkit line 132. Failed to run "['WebKitTools/Scripts/update-webkit']" exit_code: 2 Full output: http://queues.webkit.org/results/7101076 323294 4 commit-queue 2010-12-16 11:04:13 -0800 The commit-queue encountered the following flaky tests while processing attachment 76747: fast/dom/onerror-img.html bug 51019 animations/suspend-resume-animation.html bug 48161 (author: cmarrin@apple.com) The commit-queue is continuing to process your patch. 324071 5 76747 commit-queue 2010-12-17 18:37:47 -0800 Comment on attachment 76747 Patch to fix the problem Clearing flags on attachment: 76747 Committed r74311: <http://trac.webkit.org/changeset/74311> 324072 6 commit-queue 2010-12-17 18:37:52 -0800 All reviewed patches have been landed. Closing bug. 76747 2010-12-16 02:53:59 -0800 2010-12-17 18:37:47 -0800 Patch to fix the problem fix-buttons.diff text/plain 1250 cgarcia ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YWI5ZGYyZS4uMjQxZDY1ZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0xMi0xNiAgQ2FybG9zIEdhcmNp YSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gQnV0dG9ucyByZW5kZXJpbmcgd2FzIGJyb2tl biBpbiByNzQxMjkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTUxMTczCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvUmVuZGVyVGhlbWVHdGsuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVHdGs6OnBhaW50UmVuZGVyT2JqZWN0KToKKwog MjAxMC0xMi0xNSAgQnJpYW4gV2VpbnN0ZWluICA8YndlaW5zdGVpbkBhcHBsZS5jb20+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgSm9uIEhvbmV5Y3V0dC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxh dGZvcm0vZ3RrL1JlbmRlclRoZW1lR3RrLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1JlbmRl clRoZW1lR3RrLmNwcAppbmRleCBmNzMyYzE2Li41YWVlOTViIDEwMDY0NAotLS0gYS9XZWJDb3Jl L3BsYXRmb3JtL2d0ay9SZW5kZXJUaGVtZUd0ay5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9n dGsvUmVuZGVyVGhlbWVHdGsuY3BwCkBAIC0yOTgsNiArMjk4LDcgQEAgYm9vbCBSZW5kZXJUaGVt ZUd0azo6cGFpbnRSZW5kZXJPYmplY3QoR3RrVGhlbWVXaWRnZXRUeXBlIHR5cGUsIFJlbmRlck9i amVjdCogcmUKICAgICB3aWRnZXRTdGF0ZS5kaXNhYmxlZCA9ICFpc0VuYWJsZWQocmVuZGVyT2Jq ZWN0KSB8fCBpc1JlYWRPbmx5Q29udHJvbChyZW5kZXJPYmplY3QpOwogICAgIHdpZGdldFN0YXRl LmlzRGVmYXVsdCA9IGZhbHNlOwogICAgIHdpZGdldFN0YXRlLmNhbkRlZmF1bHQgPSBmYWxzZTsK KyAgICB3aWRnZXRTdGF0ZS5kZXByZXNzZWQgPSBmYWxzZTsKIAogICAgIFdpZGdldFJlbmRlcmlu Z0NvbnRleHQgd2lkZ2V0Q29udGV4dChjb250ZXh0LCByZWN0KTsKICAgICByZXR1cm4gIXdpZGdl dENvbnRleHQucGFpbnRNb3ppbGxhV2lkZ2V0KHR5cGUsICZ3aWRnZXRTdGF0ZSwgZmxhZ3MsIGd0 a1RleHREaXJlY3Rpb24ocmVuZGVyT2JqZWN0LT5zdHlsZSgpLT5kaXJlY3Rpb24oKSkpOwo=