51171 2010-12-16 01:56:09 -0800 [GTK] Wrong check in ResourceHandleSoup in error cases 2010-12-17 04:46:52 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 1 svillar svillar oldest_to_newest 323078 0 svillar 2010-12-16 01:56:09 -0800 Wrong check in ResourceHandleSoup in error cases 323080 1 76744 svillar 2010-12-16 02:04:55 -0800 Created attachment 76744 Patch 323081 2 svillar 2010-12-16 02:08:38 -0800 BTW the crash was previously see here https://bugs.webkit.org/show_bug.cgi?id=51104#c2. This patch does not fix the test (as it needs authentication challenge support in WebKitGtk+) but it fixes the crash. 323167 3 76744 mrobinson 2010-12-16 07:34:17 -0800 Comment on attachment 76744 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=76744&action=review > WebCore/platform/network/soup/ResourceHandleSoup.cpp:-512 > // WebCore might have cancelled the job in the while > - if (!d->m_cancelled && soupMsg->response_body->data) Better leave a comment here before landing this which explains the issue. 323715 4 svillar 2010-12-17 04:46:52 -0800 Committed r74251: <http://trac.webkit.org/changeset/74251> 76744 2010-12-16 02:04:55 -0800 2010-12-16 07:34:16 -0800 Patch bug-51171-20101216110453.patch text/plain 1725 svillar ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MjQ3MTQ3NTc1NmIyMjJhNDEyZmVjZjY0YTg0NmZjNzE1OTcxZDQ5Zi4uNDM5OTZkZWY3MzQ2OTc4 MjA4NTgzMjY5MDExMzBiYjY5MTQ0YTRmMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0xMi0xNiAgU2Vy Z2lvIFZpbGxhciBTZW5pbiAgPHN2aWxsYXJAaWdhbGlhLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXcm9uZyBjaGVjayBpbiBSZXNvdXJjZUhh bmRsZVNvdXAgaW4gZXJyb3IgY2FzZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTUxMTcxCisKKyAgICAgICAgQ2FsbGluZyBkaWRSZWNlaXZlRGF0YSB3 aXRoIG5vIGRhdGEgY2F1c2VzIGEgY3Jhc2ggaW4gZGVidWcKKyAgICAgICAgYnVpbGRzLiBDaGVj a2luZyBmb3Igc291cE1zZy0+cmVzcG9uc2VfYm9keS0+ZGF0YSBpcyBub3QgY29ycmVjdCBhcyBs aWJzb3VwCisgICAgICAgIGFsd2F5cyBjcmVhdGVzIGEgYnVmZmVyIGZvciB0aGF0LiBJbnN0ZWFk IHdlIHNob3VsZCBjaGVjayBmb3IKKyAgICAgICAgc291cE1zZy0+cmVzcG9uc2VfYm9keS0+bGVu Z3RoCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVTb3Vw LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnNlbmRSZXF1ZXN0Q2FsbGJhY2spOgorCiAyMDEwLTEy LTE0ICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBBbGV4ZXkgUHJvc2t1cnlha292LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9u ZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vbmV0 d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHAKaW5kZXggMDllMWViZTQ4NDMyMWJhYjYw Y2NkZDRhODgwMzhiNTBmNjU1YmZhNi4uYjk5NTk2M2Q4ZTVkM2MxODdlMGIzZThmYTYzNmJjYmE4 M2E2NmJjMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3Vy Y2VIYW5kbGVTb3VwLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNv dXJjZUhhbmRsZVNvdXAuY3BwCkBAIC01MDksNyArNTA5LDcgQEAgc3RhdGljIHZvaWQgc2VuZFJl cXVlc3RDYWxsYmFjayhHT2JqZWN0KiBzb3VyY2UsIEdBc3luY1Jlc3VsdCogcmVzLCBncG9pbnRl ciB1c2UKICAgICAgICAgICAgIGNsaWVudC0+ZGlkUmVjZWl2ZVJlc3BvbnNlKGhhbmRsZS5nZXQo KSwgZC0+bV9yZXNwb25zZSk7CiAKICAgICAgICAgICAgIC8vIFdlYkNvcmUgbWlnaHQgaGF2ZSBj YW5jZWxsZWQgdGhlIGpvYiBpbiB0aGUgd2hpbGUKLSAgICAgICAgICAgIGlmICghZC0+bV9jYW5j ZWxsZWQgJiYgc291cE1zZy0+cmVzcG9uc2VfYm9keS0+ZGF0YSkKKyAgICAgICAgICAgIGlmICgh ZC0+bV9jYW5jZWxsZWQgJiYgc291cE1zZy0+cmVzcG9uc2VfYm9keS0+bGVuZ3RoKQogICAgICAg ICAgICAgICAgIGNsaWVudC0+ZGlkUmVjZWl2ZURhdGEoaGFuZGxlLmdldCgpLCBzb3VwTXNnLT5y ZXNwb25zZV9ib2R5LT5kYXRhLCBzb3VwTXNnLT5yZXNwb25zZV9ib2R5LT5sZW5ndGgsIHRydWUp OwogICAgICAgICB9CiAK