<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>51166</bug_id>
          
          <creation_ts>2010-12-15 22:55:24 -0800</creation_ts>
          <short_desc>ExecutableAllocator::cacheFlush should call sys_cache_control</short_desc>
          <delta_ts>2010-12-16 13:36:56 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Pratik Solanki">psolanki</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>barraclough</cc>
    
    <cc>commit-queue</cc>
    
    <cc>ddkilzer</cc>
    
    <cc>ggaren</cc>
    
    <cc>psolanki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>323057</commentid>
    <comment_count>0</comment_count>
    <who name="Pratik Solanki">psolanki</who>
    <bug_when>2010-12-15 22:55:24 -0800</bug_when>
    <thetext>cacheFlush() currently calls sys_icache_invalidate() and sys_dcache_flush. Instead we should just call sys_cache_control(kCacheFunctionPrepareForExecution,..).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>323058</commentid>
    <comment_count>1</comment_count>
    <who name="Pratik Solanki">psolanki</who>
    <bug_when>2010-12-15 22:55:57 -0800</bug_when>
    <thetext>&lt;rdar://problem/8737284&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>323059</commentid>
    <comment_count>2</comment_count>
      <attachid>76737</attachid>
    <who name="Pratik Solanki">psolanki</who>
    <bug_when>2010-12-15 23:06:39 -0800</bug_when>
    <thetext>Created attachment 76737
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>323244</commentid>
    <comment_count>3</comment_count>
      <attachid>76737</attachid>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2010-12-16 10:13:32 -0800</bug_when>
    <thetext>Comment on attachment 76737
Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>323246</commentid>
    <comment_count>4</comment_count>
      <attachid>76737</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-12-16 10:15:08 -0800</bug_when>
    <thetext>Comment on attachment 76737
Patch

Rejecting attachment 76737 from commit-queue.

Failed to run &quot;[&apos;./WebKitTools/Scripts/webkit-patch&apos;, &apos;--status-host=queues.webkit.org&apos;, &apos;--bot-id=cr-jail-3&apos;, &apos;apply-attachment&apos;, &apos;--non-interactive&apos;, 76737]&quot; exit_code: 2
Last 500 characters of output:
ailed to merge in the changes.
Patch failed at 0001 2010-12-16  Yury Semikhatsky  &lt;yurys@chromium.org&gt;

When you have resolved this problem run &quot;git rebase --continue&quot;.
If you would prefer to skip this patch, instead run &quot;git rebase --skip&quot;.
To restore the original branch and stop rebasing run &quot;git rebase --abort&quot;.

rebase refs/remotes/origin/master: command returned error: 1

Died at WebKitTools/Scripts/update-webkit line 132.

Failed to run &quot;[&apos;WebKitTools/Scripts/update-webkit&apos;]&quot; exit_code: 2

Full output: http://queues.webkit.org/results/7094077</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>323351</commentid>
    <comment_count>5</comment_count>
      <attachid>76737</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-12-16 12:28:22 -0800</bug_when>
    <thetext>Comment on attachment 76737
Patch

Rejecting attachment 76737 from commit-queue.

Failed to run &quot;[&apos;./WebKitTools/Scripts/webkit-patch&apos;, &apos;--status-host=queues.webkit.org&apos;, &apos;--bot-id=cr-jail-3&apos;, &apos;apply-attachment&apos;, &apos;--non-interactive&apos;, 76737]&quot; exit_code: 2
Last 500 characters of output:
ailed to merge in the changes.
Patch failed at 0001 2010-12-16  Yury Semikhatsky  &lt;yurys@chromium.org&gt;

When you have resolved this problem run &quot;git rebase --continue&quot;.
If you would prefer to skip this patch, instead run &quot;git rebase --skip&quot;.
To restore the original branch and stop rebasing run &quot;git rebase --abort&quot;.

rebase refs/remotes/origin/master: command returned error: 1

Died at WebKitTools/Scripts/update-webkit line 132.

Failed to run &quot;[&apos;WebKitTools/Scripts/update-webkit&apos;]&quot; exit_code: 2

Full output: http://queues.webkit.org/results/7135083</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>323385</commentid>
    <comment_count>6</comment_count>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2010-12-16 13:36:56 -0800</bug_when>
    <thetext>Committed revision 74210.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>76737</attachid>
            <date>2010-12-15 23:06:39 -0800</date>
            <delta_ts>2010-12-16 12:28:22 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-51166-20101215230638.patch</filename>
            <type>text/plain</type>
            <size>1411</size>
            <attacher name="Pratik Solanki">psolanki</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No
YW5nZUxvZwppbmRleCBlNWQ2NGY0N2I1NDY3YTUyZTJlNmVkODY3NDc1OGY2MmIwMDA3YzgxLi5m
NmNkYzdjZThlOTkwN2E4NTNjYTY3ZmFjY2EwNWU5ZTViMzZiODAzIDEwMDY0NAotLS0gYS9KYXZh
U2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0x
LDMgKzEsMTQgQEAKKzIwMTAtMTItMTUgIFByYXRpayBTb2xhbmtpICA8cHNvbGFua2lAYXBwbGUu
Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0
dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MTE2NgorICAgICAgICBFeGVj
dXRhYmxlQWxsb2NhdG9yOjpjYWNoZUZsdXNoIHNob3VsZCBjYWxsIHN5c19jYWNoZV9jb250cm9s
CisKKyAgICAgICAgKiBqaXQvRXhlY3V0YWJsZUFsbG9jYXRvci5oOgorICAgICAgICAoSlNDOjpF
eGVjdXRhYmxlQWxsb2NhdG9yOjpjYWNoZUZsdXNoKTogVXNlIHRoZSBtb3JlIGNvcnJlY3QgYW5k
IGZvcndhcmQgbG9va2luZyBBUEkgLQorICAgICAgICBzeXNfY2FjaGVfY29udHJvbChrQ2FjaGVG
dW5jdGlvblByZXBhcmVGb3JFeGVjdXRpb24sLi4uKS4KKwogMjAxMC0xMi0xNSAgS2VubmV0aCBS
dXNzZWxsICA8a2JyQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgSmFtZXMgUm9i
aW5zb24uCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS9qaXQvRXhlY3V0YWJsZUFsbG9jYXRv
ci5oIGIvSmF2YVNjcmlwdENvcmUvaml0L0V4ZWN1dGFibGVBbGxvY2F0b3IuaAppbmRleCBiZTIw
YzczMDJiMWY4MWJiNjEwZDY4YWUxZDQzMTkwMWMwMTRmZTBkLi5iNmRlYmU0NDYyZmYzY2M5MDEy
MGYxM2QzMjlkYjg2ZWRkOTRjNmY4IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS9qaXQvRXhl
Y3V0YWJsZUFsbG9jYXRvci5oCisrKyBiL0phdmFTY3JpcHRDb3JlL2ppdC9FeGVjdXRhYmxlQWxs
b2NhdG9yLmgKQEAgLTI1NSw4ICsyNTUsNyBAQCBwdWJsaWM6CiAjZWxpZiBDUFUoQVJNX1RIVU1C
MikgJiYgT1MoSU9TKQogICAgIHN0YXRpYyB2b2lkIGNhY2hlRmx1c2godm9pZCogY29kZSwgc2l6
ZV90IHNpemUpCiAgICAgewotICAgICAgICBzeXNfZGNhY2hlX2ZsdXNoKGNvZGUsIHNpemUpOwot
ICAgICAgICBzeXNfaWNhY2hlX2ludmFsaWRhdGUoY29kZSwgc2l6ZSk7CisgICAgICAgIHN5c19j
YWNoZV9jb250cm9sKGtDYWNoZUZ1bmN0aW9uUHJlcGFyZUZvckV4ZWN1dGlvbiwgY29kZSwgc2l6
ZSk7CiAgICAgfQogI2VsaWYgQ1BVKEFSTV9USFVNQjIpICYmIE9TKExJTlVYKQogICAgIHN0YXRp
YyB2b2lkIGNhY2hlRmx1c2godm9pZCogY29kZSwgc2l6ZV90IHNpemUpCg==
</data>
<flag name="review"
          id="67735"
          type_id="1"
          status="+"
          setter="ggaren"
    />
    <flag name="commit-queue"
          id="67736"
          type_id="3"
          status="-"
          setter="commit-queue"
    />
          </attachment>
      

    </bug>

</bugzilla>