51150 2010-12-15 16:46:08 -0800 WebView's _scaleWebView SPI doesn't work on pages with compositing layers 2010-12-15 18:18:28 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 bdakin bdakin bdakin simon.fraser oldest_to_newest 322935 0 bdakin 2010-12-15 16:46:08 -0800 If you apply a scale factor to a page with compositing layers via the _scaleWebView SPI, the composited layers will scale, and the other layers will not. Also, the painting is clipped at the boundaries of the size of the un-scaled WebView. This does not happen on pages without compositing layers. <rdar://problem/8604713> 322968 1 76714 bdakin 2010-12-15 17:23:35 -0800 Created attachment 76714 Patch Simon was worried that docWidth and docHeight might be incorrect at times -- especially if they could ever be negative. I feel confident that they are correct here because of Hyatt's description in the ChangeLog for r73885: "RenderView now uses docLeft/Top/Height/Width functions, which are just overflow queries that account for writing modes. These methods are now the preferred way to query for the physical dimensions of a document." Also, all of the layout tests pass, and I did some testing on LTR and RTL web sites with compositing layers. 322982 2 simon.fraser 2010-12-15 17:45:45 -0800 (In reply to comment #1) > Created an attachment (id=76714) [details] > Patch > > Simon was worried that docWidth and docHeight might be incorrect at times -- especially if they could ever be negative. To clarify, it's top/left I'm worried about. I think the graphics layer origin might have to be adjusted in some situations (like RTL, or vertical text). 322993 3 bdakin 2010-12-15 18:15:18 -0800 Thanks Darin! And thanks for clarifying, Simon. Simon and I looked at this more closely, and he was correct that there are still some problems on RTL pages with compositing layers that start with a horizontal scrollbar and content anchored to the right side of the page. I have a test case for that and will file a follow-up bug. In the meantime, I committed this patch with revision 74168. 322995 4 bdakin 2010-12-15 18:18:28 -0800 Filed https://bugs.webkit.org/show_bug.cgi?id=51158 as a follow-up for the RTL issue mentioned above. 76714 2010-12-15 17:23:35 -0800 2010-12-15 17:38:50 -0800 Patch for-review.txt text/plain 2558 bdakin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3NDE2MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjMgQEAKKzIwMTAtMTItMTUgIEJldGggRGFraW4gIDxiZGFraW5AYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBm b3IgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUxMTUwIFdlYlZpZXcn cyAKKyAgICAgICAgX3NjYWxlV2ViVmlldyBTUEkgZG9lc24ndCB3b3JrIG9uIHBhZ2VzIHdpdGgg Y29tcG9zaXRpbmcgbGF5ZXJzCisgICAgICAgIC1hbmQgY29ycmVzcG9uZGluZy0KKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzg2MDQ3MTM+CisKKyAgICAgICAgcGFpbnRpbmdHb2VzVG9XaW5kb3co KSBzaG91bGQgcmV0dXJuIGZhbHNlIGlmIHRoZSBvd25pbmcgbGF5ZXIgaGFzIAorICAgICAgICBh IHRyYW5zZm9ybS4KKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5nLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyQmFja2luZzo6cGFpbnRpbmdHb2VzVG9XaW5k b3cpOgorCisgICAgICAgIFVzZSBkb2NXaWR0aCgpIGFuZCBkb2NIZWlnaHQoKSBpbnN0ZWFkIG9m IHJpZ2h0TGF5b3V0T3ZlcmZsb3coKSBhbmQgCisgICAgICAgIGJvdHRvbUxheW91dE92ZXJmbG93 KCkgc2luY2UgZG9jV2lkdGgvSGVpZ2h0IGFyZSBub3cgdGhlIHByZWZlcnJlZCAKKyAgICAgICAg d2F5IHRvIHF1ZXJ5IHBoeXNpY2FsIGRpbWVuc2lvbnMgb2YgdGhlIGRvY3VtZW50LgorICAgICAg ICAqIHJlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6UmVuZGVyTGF5ZXJDb21wb3NpdG9yOjp1cGRhdGVSb290TGF5ZXJQb3NpdGlvbik6CisKIDIw MTAtMTItMTUgIFlvbmcgTGkgIDx5b2xpQHJpbS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg RGFyaW4gQWRsZXIuCkluZGV4OiBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5j cHAJKHJldmlzaW9uIDc0MTI1KQorKysgV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNr aW5nLmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTExLDcgKzkxMSw3IEBAIEZsb2F0UG9pbnQgUmVu ZGVyTGF5ZXJCYWNraW5nOjpjb250ZW50c1QKIGJvb2wgUmVuZGVyTGF5ZXJCYWNraW5nOjpwYWlu dGluZ0dvZXNUb1dpbmRvdygpIGNvbnN0CiB7CiAgICAgaWYgKG1fb3duaW5nTGF5ZXItPmlzUm9v dExheWVyKCkpCi0gICAgICAgIHJldHVybiBjb21wb3NpdG9yKCktPnJvb3RMYXllckF0dGFjaG1l bnQoKSAhPSBSZW5kZXJMYXllckNvbXBvc2l0b3I6OlJvb3RMYXllckF0dGFjaGVkVmlhRW5jbG9z aW5nSWZyYW1lOworICAgICAgICByZXR1cm4gIW1fb3duaW5nTGF5ZXItPmhhc1RyYW5zZm9ybSgp ICYmIChjb21wb3NpdG9yKCktPnJvb3RMYXllckF0dGFjaG1lbnQoKSAhPSBSZW5kZXJMYXllckNv bXBvc2l0b3I6OlJvb3RMYXllckF0dGFjaGVkVmlhRW5jbG9zaW5nSWZyYW1lKTsKICAgICAKICAg ICByZXR1cm4gZmFsc2U7CiB9CkluZGV4OiBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNv bXBvc2l0b3IuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVy Q29tcG9zaXRvci5jcHAJKHJldmlzaW9uIDc0MTI1KQorKysgV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyTGF5ZXJDb21wb3NpdG9yLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTA2MCw3ICsxMDYwLDcg QEAgdm9pZCBSZW5kZXJMYXllckNvbXBvc2l0b3I6OnVwZGF0ZVJvb3RMYQogICAgIC8vIEV2ZW50 dWFsbHkgd2Ugd2lsbCBuZWVkIHRvIGFjY291bnQgZm9yIHNjcm9sbGluZyBoZXJlLgogICAgIC8v IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODUxOAogICAgIGlmICht X3Jvb3RQbGF0Zm9ybUxheWVyKQotICAgICAgICBtX3Jvb3RQbGF0Zm9ybUxheWVyLT5zZXRTaXpl KEZsb2F0U2l6ZShtX3JlbmRlclZpZXctPnJpZ2h0TGF5b3V0T3ZlcmZsb3coKSwgbV9yZW5kZXJW aWV3LT5ib3R0b21MYXlvdXRPdmVyZmxvdygpKSk7CisgICAgICAgIG1fcm9vdFBsYXRmb3JtTGF5 ZXItPnNldFNpemUoRmxvYXRTaXplKG1fcmVuZGVyVmlldy0+ZG9jV2lkdGgoKSwgbV9yZW5kZXJW aWV3LT5kb2NIZWlnaHQoKSkpOwogfQogCiB2b2lkIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6ZGlk U3RhcnRBY2NlbGVyYXRlZEFuaW1hdGlvbihDU1NQcm9wZXJ0eUlEIHByb3BlcnR5KQo=