51145 2010-12-15 15:29:03 -0800 Web Inspector: REGRESSION: console shows nothing when Inspector is localized 2010-12-15 15:42:27 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 322869 0 timothy 2010-12-15 15:29:03 -0800 The console shows nothing when the Inspector is localized ebcause we use UI strings as CSS classes. This is a regression. 322875 1 76698 timothy 2010-12-15 15:32:43 -0800 Created attachment 76698 Proposed Change 322886 2 76698 joepeck 2010-12-15 15:37:59 -0800 Comment on attachment 76698 Proposed Change r=me. Looks good. It would be nice if this converged with the Resources filters, but this is good. 322891 3 timothy 2010-12-15 15:42:18 -0800 <rdar://problem/8277827> 322892 4 timothy 2010-12-15 15:42:27 -0800 Fixed in r74153. 76698 2010-12-15 15:32:43 -0800 2010-12-15 15:37:58 -0800 Proposed Change 0001-Fix-a-regression-where-the-Web-Inspector-console-wou.patch text/plain 4180 timothy RnJvbSAxZTQ0NDVhYzE2MjQ1YzU3MDdmMDEwMTNkYTNlNjViNGUxYWZhNWI4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUaW1vdGh5IEhhdGNoZXIgPHRpbW90aHlAYXBwbGUuY29tPgpE YXRlOiBXZWQsIDE1IERlYyAyMDEwIDE1OjMyOjEyIC0wODAwClN1YmplY3Q6IFtQQVRDSF0gRml4 IGEgcmVncmVzc2lvbiB3aGVyZSB0aGUgV2ViIEluc3BlY3RvciBjb25zb2xlIHdvdWxkIGJlIGVt cHR5CiBpZiB0aGUgSW5zcGVjdG9yIGlzIGxvY2FsaXplZC4KCmh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD01MTE0NQoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgoq IGluc3BlY3Rvci9mcm9udC1lbmQvQ29uc29sZVZpZXcuanM6CihXZWJJbnNwZWN0b3IuQ29uc29s ZVZpZXcuY3JlYXRlRmlsdGVyRWxlbWVudCk6IEFkZCBhIGxhYmVsIGFyZ3VtZW50IHNvIHRoZSBV SSBzdHJpbmcKaXMgc2VwYXJhdGUgZnJvbSB0aGUgY2xhc3NuYW1lLiBDb2RlIGNsZWFuIHVwLgoo V2ViSW5zcGVjdG9yLkNvbnNvbGVWaWV3LnByb3RvdHlwZS5maWx0ZXIpOiBSZW1vdmUgdG9Mb3dl ckNhc2UgYW5kIHVzZSBzdHJpbmcgY29tcGFyZS4KKFdlYkluc3BlY3Rvci5Db25zb2xlVmlldyk6 IFBhc3Mgc2VwYXJhdGUgY2xhc3NuYW1lcyBhbmQgbGFiZWxzIHRvIGNyZWF0ZUZpbHRlckVsZW1l bnQuCi0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAx NSArKysrKysrKysrKysrKysKIFdlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Db25zb2xlVmll dy5qcyB8ICAgMjEgKysrKysrKysrKy0tLS0tLS0tLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDI1IGlu c2VydGlvbnMoKyksIDExIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdl TG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjY0NTIwMy4uMDE3Y2EwNiAxMDA2NDQKLS0t IGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx OCBAQAorMjAxMC0xMi0xNSAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5jb20+CisK KyAgICAgICAgRml4IGEgcmVncmVzc2lvbiB3aGVyZSB0aGUgV2ViIEluc3BlY3RvciBjb25zb2xl IHdvdWxkIGJlIGVtcHR5CisgICAgICAgIGlmIHRoZSBJbnNwZWN0b3IgaXMgbG9jYWxpemVkLgor CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MTE0NQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVj dG9yL2Zyb250LWVuZC9Db25zb2xlVmlldy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Db25z b2xlVmlldy5jcmVhdGVGaWx0ZXJFbGVtZW50KTogQWRkIGEgbGFiZWwgYXJndW1lbnQgc28gdGhl IFVJIHN0cmluZworICAgICAgICBpcyBzZXBhcmF0ZSBmcm9tIHRoZSBjbGFzc25hbWUuIENvZGUg Y2xlYW4gdXAuCisgICAgICAgIChXZWJJbnNwZWN0b3IuQ29uc29sZVZpZXcucHJvdG90eXBlLmZp bHRlcik6IFJlbW92ZSB0b0xvd2VyQ2FzZSBhbmQgdXNlIHN0cmluZyBjb21wYXJlLgorICAgICAg ICAoV2ViSW5zcGVjdG9yLkNvbnNvbGVWaWV3KTogUGFzcyBzZXBhcmF0ZSBjbGFzc25hbWVzIGFu ZCBsYWJlbHMgdG8gY3JlYXRlRmlsdGVyRWxlbWVudC4KKwogMjAxMC0xMi0xNSAgU2FtIFdlaW5p ZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFuZGVycyBDYXJsc3Nv bi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Db25zb2xlVmlldy5q cyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Db25zb2xlVmlldy5qcwppbmRleCBmMGRm MDEwLi5hNTgyYmZiIDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ29u c29sZVZpZXcuanMKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NvbnNvbGVWaWV3 LmpzCkBAIC02OCwyNCArNjgsMjMgQEAgV2ViSW5zcGVjdG9yLkNvbnNvbGVWaWV3ID0gZnVuY3Rp b24oZHJhd2VyKQogICAgIH0KIAogICAgIHZhciB1cGRhdGVGaWx0ZXJIYW5kbGVyID0gdGhpcy5f dXBkYXRlRmlsdGVyLmJpbmQodGhpcyk7Ci0gICAgZnVuY3Rpb24gY3JlYXRlRmlsdGVyRWxlbWVu dChjYXRlZ29yeSkgeworICAgIGZ1bmN0aW9uIGNyZWF0ZUZpbHRlckVsZW1lbnQoY2F0ZWdvcnks IGxhYmVsKSB7CiAgICAgICAgIHZhciBjYXRlZ29yeUVsZW1lbnQgPSBkb2N1bWVudC5jcmVhdGVF bGVtZW50KCJsaSIpOwogICAgICAgICBjYXRlZ29yeUVsZW1lbnQuY2F0ZWdvcnkgPSBjYXRlZ29y eTsKLSAgICAgICAgY2F0ZWdvcnlFbGVtZW50LmFkZFN0eWxlQ2xhc3MoY2F0ZWdvcnlFbGVtZW50 LmNhdGVnb3J5KTsKKyAgICAgICAgY2F0ZWdvcnlFbGVtZW50LmNsYXNzTmFtZSA9IGNhdGVnb3J5 OwogICAgICAgICBjYXRlZ29yeUVsZW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigiY2xpY2siLCB1cGRh dGVGaWx0ZXJIYW5kbGVyLCBmYWxzZSk7Ci0KLSAgICAgICAgdmFyIGxhYmVsID0gY2F0ZWdvcnku dG9TdHJpbmcoKTsKLSAgICAgICAgY2F0ZWdvcnlFbGVtZW50LmFwcGVuZENoaWxkKGRvY3VtZW50 LmNyZWF0ZVRleHROb2RlKGxhYmVsKSk7CisgICAgICAgIGNhdGVnb3J5RWxlbWVudC50ZXh0Q29u dGVudCA9IGxhYmVsOwogCiAgICAgICAgIHRoaXMuZmlsdGVyQmFyRWxlbWVudC5hcHBlbmRDaGls ZChjYXRlZ29yeUVsZW1lbnQpOworCiAgICAgICAgIHJldHVybiBjYXRlZ29yeUVsZW1lbnQ7CiAg ICAgfQogCi0gICAgdGhpcy5hbGxFbGVtZW50ID0gY3JlYXRlRmlsdGVyRWxlbWVudC5jYWxsKHRo aXMsIFdlYkluc3BlY3Rvci5VSVN0cmluZygiQWxsIikpOworICAgIHRoaXMuYWxsRWxlbWVudCA9 IGNyZWF0ZUZpbHRlckVsZW1lbnQuY2FsbCh0aGlzLCAiYWxsIiwgV2ViSW5zcGVjdG9yLlVJU3Ry aW5nKCJBbGwiKSk7CiAgICAgY3JlYXRlRGl2aWRlckVsZW1lbnQuY2FsbCh0aGlzKTsKLSAgICB0 aGlzLmVycm9yRWxlbWVudCA9IGNyZWF0ZUZpbHRlckVsZW1lbnQuY2FsbCh0aGlzLCBXZWJJbnNw ZWN0b3IuVUlTdHJpbmcoIkVycm9ycyIpKTsKLSAgICB0aGlzLndhcm5pbmdFbGVtZW50ID0gY3Jl YXRlRmlsdGVyRWxlbWVudC5jYWxsKHRoaXMsIFdlYkluc3BlY3Rvci5VSVN0cmluZygiV2Fybmlu Z3MiKSk7Ci0gICAgdGhpcy5sb2dFbGVtZW50ID0gY3JlYXRlRmlsdGVyRWxlbWVudC5jYWxsKHRo aXMsIFdlYkluc3BlY3Rvci5VSVN0cmluZygiTG9ncyIpKTsKKyAgICB0aGlzLmVycm9yRWxlbWVu dCA9IGNyZWF0ZUZpbHRlckVsZW1lbnQuY2FsbCh0aGlzLCAiZXJyb3JzIiwgV2ViSW5zcGVjdG9y LlVJU3RyaW5nKCJFcnJvcnMiKSk7CisgICAgdGhpcy53YXJuaW5nRWxlbWVudCA9IGNyZWF0ZUZp bHRlckVsZW1lbnQuY2FsbCh0aGlzLCAid2FybmluZ3MiLCBXZWJJbnNwZWN0b3IuVUlTdHJpbmco Ildhcm5pbmdzIikpOworICAgIHRoaXMubG9nRWxlbWVudCA9IGNyZWF0ZUZpbHRlckVsZW1lbnQu Y2FsbCh0aGlzLCAibG9ncyIsIFdlYkluc3BlY3Rvci5VSVN0cmluZygiTG9ncyIpKTsKIAogICAg IHRoaXMuZmlsdGVyKHRoaXMuYWxsRWxlbWVudCwgZmFsc2UpOwogICAgIHRoaXMuX3JlZ2lzdGVy U2hvcnRjdXRzKCk7CkBAIC0xMjgsOSArMTI3LDkgQEAgV2ViSW5zcGVjdG9yLkNvbnNvbGVWaWV3 LnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgIHRoaXMubWVzc2FnZXNFbGVtZW50LnJlbW92ZVN0 eWxlQ2xhc3MoImZpbHRlci1sb2dzIik7CiAgICAgICAgIH0KIAotICAgICAgICB2YXIgdGFyZ2V0 RmlsdGVyQ2xhc3MgPSAiZmlsdGVyLSIgKyB0YXJnZXQuY2F0ZWdvcnkudG9Mb3dlckNhc2UoKTsK KyAgICAgICAgdmFyIHRhcmdldEZpbHRlckNsYXNzID0gImZpbHRlci0iICsgdGFyZ2V0LmNhdGVn b3J5OwogCi0gICAgICAgIGlmICh0YXJnZXQuY2F0ZWdvcnkgPT0gIkFsbCIpIHsKKyAgICAgICAg aWYgKHRhcmdldC5jYXRlZ29yeSA9PT0gImFsbCIpIHsKICAgICAgICAgICAgIGlmICh0YXJnZXQu aGFzU3R5bGVDbGFzcygic2VsZWN0ZWQiKSkgewogICAgICAgICAgICAgICAgIC8vIFdlIGNhbid0 IHVuc2VsZWN0IGFsbCwgc28gd2UgYnJlYWsgZWFybHkgaGVyZQogICAgICAgICAgICAgICAgIHJl dHVybjsKLS0gCjEuNy4wLjIKCg==