51144 2010-12-15 15:25:05 -0800 Clang -Wcast-align gives an error in WebBasePluginPackage.mm 2010-12-21 10:51:32 -0800 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 zwarich zwarich abarth eric webkit.review.bot zimmermann oldest_to_newest 322863 0 zwarich 2010-12-15 15:25:05 -0800 Clang -Wcast-align gives an error in WebBasePluginPackage.mm. This is the only error, so we might as well fix it. 322978 1 76716 zwarich 2010-12-15 17:34:56 -0800 Created attachment 76716 Proposed patch 323036 2 zwarich 2010-12-15 20:35:27 -0800 Fixed in r74172. 323463 3 webkit.review.bot 2010-12-16 15:37:59 -0800 http://trac.webkit.org/changeset/74172 might have broken Leopard Intel Debug (Tests) 324970 4 zimmermann 2010-12-21 05:53:04 -0800 Since this patch is in, I can't use DRT on Leopard anymore: Exception Codes: KERN_INVALID_ADDRESS at 0x00000000bbadbeef Crashed Thread: 0 Thread 0 Crashed: 0 com.apple.WebKit 0x00d50a34 WTF::VectorBufferBase<unsigned int>::allocateBuffer(unsigned long) + 38 (Vector.h:286) 1 com.apple.WebKit 0x00d50a9b WTF::VectorBuffer<unsigned int, 128ul>::VectorBuffer(unsigned long) + 67 2 com.apple.WebKit 0x00d50acd WTF::Vector<unsigned int, 128ul>::Vector(unsigned long) + 47 3 com.apple.WebKit 0x00d4ecc5 -[WebBasePluginPackage isNativeLibraryData:] + 69 (WebBasePluginPackage.mm:356) 4 com.apple.WebKit 0x00df1e18 -[WebPluginPackage initWithPath:] + 550 (WebPluginPackage.mm:67) 5 com.apple.WebKit 0x00d4e9b0 +[WebBasePluginPackage pluginWithPath:] + 72 (WebBasePluginPackage.mm:79) 6 com.apple.WebKit 0x00defcf4 -[WebPluginDatabase(Internal) _scanForNewPlugins] + 442 (WebPluginDatabase.mm:488) 7 com.apple.WebKit 0x00df0980 -[WebPluginDatabase refresh] + 192 (WebPluginDatabase.mm:272) 8 com.apple.WebKit 0x00df1121 +[WebPluginDatabase sharedDatabase] + 189 (WebPluginDatabase.mm:72) 9 DumpRenderTree 0x00012f28 __ZL32addTestPluginsToPluginSearchPathPKc + 146 10 DumpRenderTree 0x0001651f dumpRenderTree(int, char const**) + 43 11 DumpRenderTree 0x00016874 main + 94 (DumpRenderTree.mm:711) 12 DumpRenderTree 0x00002b6a start + 54 324971 5 zimmermann 2010-12-21 05:53:21 -0800 (In reply to comment #4) > Since this patch is in, I can't use DRT on Leopard anymore: To clarify, it crashes on every test. 324973 6 76716 zimmermann 2010-12-21 06:09:18 -0800 Comment on attachment 76716 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=76716&action=review > WebKit/mac/Plugins/WebBasePluginPackage.mm:355 > + NSUInteger sizeInBytes = [data length]; > + Vector<uint32_t, 128> rawData((sizeInBytes - 1) / 4 + 1); This silently assumes sizeInBytes > 0. The crash I see happens with sizeInBytes=0. So using sizeInBytes > 0 ? ((sizeInBytes - 1) / 4 + 1) : 0, should fix the problem. 325072 7 zwarich 2010-12-21 10:51:32 -0800 (In reply to comment #6) > (From update of attachment 76716 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=76716&action=review > > > WebKit/mac/Plugins/WebBasePluginPackage.mm:355 > > + NSUInteger sizeInBytes = [data length]; > > + Vector<uint32_t, 128> rawData((sizeInBytes - 1) / 4 + 1); > > This silently assumes sizeInBytes > 0. The crash I see happens with sizeInBytes=0. > So using sizeInBytes > 0 ? ((sizeInBytes - 1) / 4 + 1) : 0, should fix the problem. r=me on that, I was going to land this fix myself 76716 2010-12-15 17:34:56 -0800 2010-12-21 06:09:18 -0800 Proposed patch align.patch text/plain 4581 zwarich SW5kZXg6IFdlYktpdC9tYWMvUGx1Z2lucy9XZWJCYXNlUGx1Z2luUGFja2FnZS5tbQo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJLaXQvbWFjL1BsdWdpbnMvV2ViQmFzZVBsdWdpblBhY2thZ2UubW0JKHJldmlz aW9uIDc0MTM2KQorKysgV2ViS2l0L21hYy9QbHVnaW5zL1dlYkJhc2VQbHVnaW5QYWNrYWdlLm1t CSh3b3JraW5nIGNvcHkpCkBAIC0zNDMsMzEgKzM0MywzMiBAQAogICAgICAgICBlcXVhbElnbm9y aW5nQ2FzZShwbHVnaW5JbmZvLmZpbGUsIEphdmFDRk1QbHVnaW5GaWxlbmFtZSk7CiB9CiAKLXN0 YXRpYyBpbmxpbmUgdm9pZCBzd2FwSW50c0luSGVhZGVyKHVpbnQ4X3QqIGJ5dGVzLCB1bnNpZ25l ZCBsZW5ndGgpCitzdGF0aWMgaW5saW5lIHZvaWQgc3dhcEludHNJbkhlYWRlcih1aW50MzJfdCog cmF3RGF0YSwgc2l6ZV90IGxlbmd0aCkKIHsKLSAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwg bGVuZ3RoOyBpICs9IDQpIAotICAgICAgICAqKHVpbnQzMl90KikoYnl0ZXMgKyBpKSA9IE9TU3dh cEludDMyKCoodWludDMyX3QgKikoYnl0ZXMgKyBpKSk7CisgICAgZm9yIChzaXplX3QgaSA9IDA7 IGkgPCBsZW5ndGg7ICsraSkgCisgICAgICAgIHJhd0RhdGFbaV0gPSBPU1N3YXBJbnQzMihyYXdE YXRhW2ldKTsKIH0KIAogLSAoQk9PTClpc05hdGl2ZUxpYnJhcnlEYXRhOihOU0RhdGEgKilkYXRh CiB7Ci0gICAgVmVjdG9yPHVpbnQ4X3QsIDUxMj4gYnl0ZXMoW2RhdGEgbGVuZ3RoXSk7Ci0gICAg bWVtY3B5KGJ5dGVzLmRhdGEoKSwgW2RhdGEgYnl0ZXNdLCBieXRlcy5zaXplKCkpOworICAgIE5T VUludGVnZXIgc2l6ZUluQnl0ZXMgPSBbZGF0YSBsZW5ndGhdOworICAgIFZlY3Rvcjx1aW50MzJf dCwgMTI4PiByYXdEYXRhKChzaXplSW5CeXRlcyAtIDEpIC8gNCArIDEpOworICAgIG1lbWNweShy YXdEYXRhLmRhdGEoKSwgW2RhdGEgYnl0ZXNdLCBzaXplSW5CeXRlcyk7CiAgICAgCiAgICAgdW5z aWduZWQgbnVtQXJjaHMgPSAwOwogICAgIHN0cnVjdCBmYXRfYXJjaCBzaW5nbGVBcmNoID0geyAw LCAwLCAwLCAwLCAwIH07CiAgICAgc3RydWN0IGZhdF9hcmNoKiBhcmNocyA9IDA7CiAgICAgICAg Ci0gICAgaWYgKGJ5dGVzLnNpemUoKSA+PSBzaXplb2Yoc3RydWN0IG1hY2hfaGVhZGVyXzY0KSkg ewotICAgICAgICB1aW50MzJfdCBtYWdpYyA9ICpyZWludGVycHJldF9jYXN0PHVpbnQzMl90Kj4o Ynl0ZXMuZGF0YSgpKTsKKyAgICBpZiAoc2l6ZUluQnl0ZXMgPj0gc2l6ZW9mKHN0cnVjdCBtYWNo X2hlYWRlcl82NCkpIHsKKyAgICAgICAgdWludDMyX3QgbWFnaWMgPSAqcmF3RGF0YS5kYXRhKCk7 CiAgICAgICAgIAogICAgICAgICBpZiAobWFnaWMgPT0gTUhfTUFHSUMgfHwgbWFnaWMgPT0gTUhf Q0lHQU0pIHsKICAgICAgICAgICAgIC8vIFdlIGhhdmUgYSAzMi1iaXQgdGhpbiBiaW5hcnkKLSAg ICAgICAgICAgIHN0cnVjdCBtYWNoX2hlYWRlciogaGVhZGVyID0gKHN0cnVjdCBtYWNoX2hlYWRl ciopYnl0ZXMuZGF0YSgpOworICAgICAgICAgICAgc3RydWN0IG1hY2hfaGVhZGVyKiBoZWFkZXIg PSAoc3RydWN0IG1hY2hfaGVhZGVyKilyYXdEYXRhLmRhdGEoKTsKIAogICAgICAgICAgICAgLy8g Q2hlY2sgaWYgd2UgbmVlZCB0byBzd2FwIHRoZSBieXRlcwogICAgICAgICAgICAgaWYgKG1hZ2lj ID09IE1IX0NJR0FNKQotICAgICAgICAgICAgICAgIHN3YXBJbnRzSW5IZWFkZXIoYnl0ZXMuZGF0 YSgpLCBieXRlcy5zaXplKCkpOworICAgICAgICAgICAgICAgIHN3YXBJbnRzSW5IZWFkZXIocmF3 RGF0YS5kYXRhKCksIHJhd0RhdGEuc2l6ZSgpKTsKICAgICAKICAgICAgICAgICAgIHNpbmdsZUFy Y2guY3B1dHlwZSA9IGhlYWRlci0+Y3B1dHlwZTsKICAgICAgICAgICAgIHNpbmdsZUFyY2guY3B1 c3VidHlwZSA9IGhlYWRlci0+Y3B1c3VidHlwZTsKQEAgLTM3NiwxMSArMzc3LDExIEBACiAgICAg ICAgICAgICBudW1BcmNocyA9IDE7CiAgICAgICAgIH0gZWxzZSBpZiAobWFnaWMgPT0gTUhfTUFH SUNfNjQgfHwgbWFnaWMgPT0gTUhfQ0lHQU1fNjQpIHsKICAgICAgICAgICAgIC8vIFdlIGhhdmUg YSA2NC1iaXQgdGhpbiBiaW5hcnkKLSAgICAgICAgICAgIHN0cnVjdCBtYWNoX2hlYWRlcl82NCog aGVhZGVyID0gKHN0cnVjdCBtYWNoX2hlYWRlcl82NCopYnl0ZXMuZGF0YSgpOworICAgICAgICAg ICAgc3RydWN0IG1hY2hfaGVhZGVyXzY0KiBoZWFkZXIgPSAoc3RydWN0IG1hY2hfaGVhZGVyXzY0 KilyYXdEYXRhLmRhdGEoKTsKIAogICAgICAgICAgICAgLy8gQ2hlY2sgaWYgd2UgbmVlZCB0byBz d2FwIHRoZSBieXRlcwogICAgICAgICAgICAgaWYgKG1hZ2ljID09IE1IX0NJR0FNXzY0KQotICAg ICAgICAgICAgICAgIHN3YXBJbnRzSW5IZWFkZXIoYnl0ZXMuZGF0YSgpLCBieXRlcy5zaXplKCkp OworICAgICAgICAgICAgICAgIHN3YXBJbnRzSW5IZWFkZXIocmF3RGF0YS5kYXRhKCksIHJhd0Rh dGEuc2l6ZSgpKTsKICAgICAgICAgICAgIAogICAgICAgICAgICAgc2luZ2xlQXJjaC5jcHV0eXBl ID0gaGVhZGVyLT5jcHV0eXBlOwogICAgICAgICAgICAgc2luZ2xlQXJjaC5jcHVzdWJ0eXBlID0g aGVhZGVyLT5jcHVzdWJ0eXBlOwpAQCAtMzkyLDEyICszOTMsMTIgQEAKIAogICAgICAgICAgICAg Ly8gQ2hlY2sgaWYgd2UgbmVlZCB0byBzd2FwIHRoZSBieXRlcwogICAgICAgICAgICAgaWYgKG1h Z2ljID09IEZBVF9DSUdBTSkKLSAgICAgICAgICAgICAgICBzd2FwSW50c0luSGVhZGVyKGJ5dGVz LmRhdGEoKSwgYnl0ZXMuc2l6ZSgpKTsKKyAgICAgICAgICAgICAgICBzd2FwSW50c0luSGVhZGVy KHJhd0RhdGEuZGF0YSgpLCByYXdEYXRhLnNpemUoKSk7CiAgICAgICAgICAgICAKLSAgICAgICAg ICAgIGFyY2hzID0gKHN0cnVjdCBmYXRfYXJjaCopKGJ5dGVzLmRhdGEoKSArIHNpemVvZihzdHJ1 Y3QgZmF0X2hlYWRlcikpOyAgICAgICAgICAgIAotICAgICAgICAgICAgbnVtQXJjaHMgPSAoKHN0 cnVjdCBmYXRfaGVhZGVyICopYnl0ZXMuZGF0YSgpKS0+bmZhdF9hcmNoOworICAgICAgICAgICAg YXJjaHMgPSAoc3RydWN0IGZhdF9hcmNoKikocmF3RGF0YS5kYXRhKCkgKyBzaXplb2Yoc3RydWN0 IGZhdF9oZWFkZXIpKTsgICAgICAgICAgICAKKyAgICAgICAgICAgIG51bUFyY2hzID0gKChzdHJ1 Y3QgZmF0X2hlYWRlciAqKXJhd0RhdGEuZGF0YSgpKS0+bmZhdF9hcmNoOwogICAgICAgICAgICAg Ci0gICAgICAgICAgICB1bnNpZ25lZCBtYXhBcmNocyA9IChieXRlcy5zaXplKCkgLSBzaXplb2Yo c3RydWN0IGZhdF9oZWFkZXIpKSAvIHNpemVvZihzdHJ1Y3QgZmF0X2FyY2gpOworICAgICAgICAg ICAgdW5zaWduZWQgbWF4QXJjaHMgPSAoc2l6ZUluQnl0ZXMgLSBzaXplb2Yoc3RydWN0IGZhdF9o ZWFkZXIpKSAvIHNpemVvZihzdHJ1Y3QgZmF0X2FyY2gpOwogICAgICAgICAgICAgaWYgKG51bUFy Y2hzID4gbWF4QXJjaHMpCiAgICAgICAgICAgICAgICAgbnVtQXJjaHMgPSBtYXhBcmNoczsKICAg ICAgICAgfSAgICAgICAgICAgIApJbmRleDogV2ViS2l0L21hYy9DaGFuZ2VMb2cKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDc0MTM2KQorKysgV2ViS2l0L21h Yy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwyMCBAQAorMjAxMC0xMi0xNSAg Q2FtZXJvbiBad2FyaWNoICA8endhcmljaEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2xhbmcgLVdjYXN0LWFsaWduIGdpdmVzIGFu IGVycm9yIGluIFdlYkJhc2VQbHVnaW5QYWNrYWdlLm1tCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MTE0NAorCisgICAgICAgIEZpeCBhbiBhbGlnbm1l bnQgaXNzdWUuIE9TU3dhcEludDMyIHRha2VzIGRhdGEgdGhhdCBpcyAzMi1iaXQgYWxpZ25lZCBv biBBUk0sIGJ1dAorICAgICAgICB3ZSB3ZXJlIGNhbGxpbmcgaXQgb24gYSBieXRlIGFycmF5IDMy IGJpdHMgYXQgYSB0aW1lLiBXaGlsZSB0aGlzIGlzIG9rYXkgaW4gcHJhY3RpY2UsCisgICAgICAg IHNpbmNlIFRDTWFsbG9jIHdvbid0IGdpdmUgdXMgYSBub24tMzItYml0IGFsaWduZWQgYmxvY2sg YXJyYXkgb2YgYnl0ZXMgYW5kIFZlY3RvcidzCisgICAgICAgIGlubGluZSBzdG9yYWdlIGlzIGF0 IHRoZSBiZWdpbm5pbmcgb2YgdGhlIFZlY3RvciwgaXQgaXMgc3RpbGwgYmV0dGVyIHRvIGZpeCB0 aGlzCisgICAgICAgIGFuZCBzaWxlbmNlIHRoZSB3YXJuaW5nLgorCisgICAgICAgICogUGx1Z2lu cy9XZWJCYXNlUGx1Z2luUGFja2FnZS5tbToKKyAgICAgICAgKHN3YXBJbnRzSW5IZWFkZXIpOgor ICAgICAgICAoLVtXZWJCYXNlUGx1Z2luUGFja2FnZSBpc05hdGl2ZUxpYnJhcnlEYXRhOl0pOgor CiAyMDEwLTEyLTE0ICBNYXJrIFJvd2UgIDxtcm93ZUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgU2FtIFdlaW5pZy4K