51141 2010-12-15 15:16:31 -0800 [JSC] Const correctness in ASTBuilder and SyntaxChecker 2010-12-16 15:39:02 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ariya.hidayat ariya.hidayat abarth eric webkit.review.bot oldest_to_newest 322844 0 ariya.hidayat 2010-12-15 15:16:31 -0800 [JSC] Const correctness in ASTBuilder and SyntaxChecker 322856 1 76695 ariya.hidayat 2010-12-15 15:22:44 -0800 Created attachment 76695 2010-12-15 Ariya Hidayat <ariya@sencha.com> 322868 2 76695 ariya.hidayat 2010-12-15 15:28:44 -0800 Comment on attachment 76695 2010-12-15 Ariya Hidayat <ariya@sencha.com> I forget the ChangeLog. 322887 3 76699 ariya.hidayat 2010-12-15 15:39:21 -0800 Created attachment 76699 Patch 323093 4 76699 kling 2010-12-16 03:18:37 -0800 Comment on attachment 76699 Patch r=me 323190 5 76699 ariya.hidayat 2010-12-16 08:32:23 -0800 Comment on attachment 76699 Patch Clearing flags on attachment: 76699 Committed r74192: <http://trac.webkit.org/changeset/74192> 323191 6 ariya.hidayat 2010-12-16 08:32:28 -0800 All reviewed patches have been landed. Closing bug. 323472 7 webkit.review.bot 2010-12-16 15:39:02 -0800 http://trac.webkit.org/changeset/74192 might have broken Leopard Intel Debug (Tests) 76695 2010-12-15 15:22:44 -0800 2010-12-15 15:28:43 -0800 2010-12-15 Ariya Hidayat <ariya@sencha.com> bug-51141-20101215152242.patch text/plain 1961 ariya.hidayat ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL3BhcnNlci9BU1RCdWlsZGVyLmggYi9KYXZhU2Ny aXB0Q29yZS9wYXJzZXIvQVNUQnVpbGRlci5oCmluZGV4IDlhNjgxNDQ2OTViODkyOWU1ZjFmYzJm YzI3ZTU1NzZlNjNkZDFjNDguLjA0Y2YyNzI4NjJhNWIxNjUyMzk0NjkyNzgyODY4N2VkNTU2ZDMy NTAgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL3BhcnNlci9BU1RCdWlsZGVyLmgKKysrIGIv SmF2YVNjcmlwdENvcmUvcGFyc2VyL0FTVEJ1aWxkZXIuaApAQCAtNTc2LDEwICs1NzYsMTAgQEAg cHVibGljOgogICAgICAgICByZXR1cm4gcmVzdWx0OwogICAgIH0KICAgICAKLSAgICBjb25zdCBJ ZGVudGlmaWVyJiBnZXROYW1lKFByb3BlcnR5IHByb3BlcnR5KSB7IHJldHVybiBwcm9wZXJ0eS0+ bmFtZSgpOyB9Ci0gICAgUHJvcGVydHlOb2RlOjpUeXBlIGdldFR5cGUoUHJvcGVydHkgcHJvcGVy dHkpIHsgcmV0dXJuIHByb3BlcnR5LT50eXBlKCk7IH0KKyAgICBjb25zdCBJZGVudGlmaWVyJiBn ZXROYW1lKFByb3BlcnR5IHByb3BlcnR5KSBjb25zdCB7IHJldHVybiBwcm9wZXJ0eS0+bmFtZSgp OyB9CisgICAgUHJvcGVydHlOb2RlOjpUeXBlIGdldFR5cGUoUHJvcGVydHkgcHJvcGVydHkpIGNv bnN0IHsgcmV0dXJuIHByb3BlcnR5LT50eXBlKCk7IH0KIAotICAgIGJvb2wgaXNSZXNvbHZlKEV4 cHJlc3Npb25Ob2RlKiBleHByKSB7IHJldHVybiBleHByLT5pc1Jlc29sdmVOb2RlKCk7IH0KKyAg ICBib29sIGlzUmVzb2x2ZShFeHByZXNzaW9uTm9kZSogZXhwcikgY29uc3QgeyByZXR1cm4gZXhw ci0+aXNSZXNvbHZlTm9kZSgpOyB9CiAKIHByaXZhdGU6CiAgICAgc3RydWN0IFNjb3BlIHsKZGlm ZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL3BhcnNlci9TeW50YXhDaGVja2VyLmggYi9KYXZhU2Ny aXB0Q29yZS9wYXJzZXIvU3ludGF4Q2hlY2tlci5oCmluZGV4IGY5MDkzYTc0NDdhOTQzMzFiNGU4 ZTEwNjNkNWM4NmRhOTJkNDc5YWQuLmIwMGU3MTBlMzUyMDY4ZDZjMzljYmQyODFlYWM2N2QwMDAz MWIzZDQgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL3BhcnNlci9TeW50YXhDaGVja2VyLmgK KysrIGIvSmF2YVNjcmlwdENvcmUvcGFyc2VyL1N5bnRheENoZWNrZXIuaApAQCAtMjAzLDkgKzIw Myw5IEBAIHB1YmxpYzoKICAgICAKICAgICB2b2lkIGFzc2lnbm1lbnRTdGFja0FwcGVuZChpbnQs IGludCwgaW50LCBpbnQsIGludCwgT3BlcmF0b3IpIHsgfQogICAgIGludCBjcmVhdGVBc3NpZ25t ZW50KGludCwgaW50LCBpbnQsIGludCwgaW50KSB7IEFTU0VSVF9OT1RfUkVBQ0hFRCgpOyByZXR1 cm4gMTsgfQotICAgIGNvbnN0IElkZW50aWZpZXImIGdldE5hbWUoY29uc3QgUHJvcGVydHkmIHBy b3BlcnR5KSB7IEFTU0VSVChwcm9wZXJ0eS5uYW1lKTsgcmV0dXJuICpwcm9wZXJ0eS5uYW1lOyB9 Ci0gICAgUHJvcGVydHlOb2RlOjpUeXBlIGdldFR5cGUoY29uc3QgUHJvcGVydHkmIHByb3BlcnR5 KSB7IHJldHVybiBwcm9wZXJ0eS50eXBlOyB9Ci0gICAgYm9vbCBpc1Jlc29sdmUoRXhwcmVzc2lv blR5cGUgZXhwcikgeyByZXR1cm4gZXhwciA9PSBSZXNvbHZlRXhwciB8fCBleHByID09IFJlc29s dmVFdmFsRXhwcjsgfQorICAgIGNvbnN0IElkZW50aWZpZXImIGdldE5hbWUoY29uc3QgUHJvcGVy dHkmIHByb3BlcnR5KSBjb25zdCB7IEFTU0VSVChwcm9wZXJ0eS5uYW1lKTsgcmV0dXJuICpwcm9w ZXJ0eS5uYW1lOyB9CisgICAgUHJvcGVydHlOb2RlOjpUeXBlIGdldFR5cGUoY29uc3QgUHJvcGVy dHkmIHByb3BlcnR5KSBjb25zdCB7IHJldHVybiBwcm9wZXJ0eS50eXBlOyB9CisgICAgYm9vbCBp c1Jlc29sdmUoRXhwcmVzc2lvblR5cGUgZXhwcikgY29uc3QgeyByZXR1cm4gZXhwciA9PSBSZXNv bHZlRXhwciB8fCBleHByID09IFJlc29sdmVFdmFsRXhwcjsgfQogICAgIAogcHJpdmF0ZToKICAg ICBpbnQgbV90b3BCaW5hcnlFeHByOwo= 76699 2010-12-15 15:39:21 -0800 2010-12-16 08:32:23 -0800 Patch bug-51141-20101215153920.patch text/plain 2719 ariya.hidayat ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCBkNGJmNTM4MjFhOWNhYjc4MTQ3MjllNmNiNWU0MmE0YTUwODM3M2Y5Li42 YzFlNTJkNWVkMjY2ZGM3MjU2YWU3NDgxYTY0Y2Q1OWEzNDhhOTYzIDEwMDY0NAotLS0gYS9KYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTcgQEAKKzIwMTAtMTItMTUgIEFyaXlhIEhpZGF5YXQgIDxhcml5YUBzZW5jaGEuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtKU0Nd IENvbnN0IGNvcnJlY3RuZXNzIGluIEFTVEJ1aWxkZXIgYW5kIFN5bnRheENoZWNrZXIKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUxMTQxCisKKyAgICAg ICAgKiBwYXJzZXIvQVNUQnVpbGRlci5oOgorICAgICAgICAoSlNDOjpBU1RCdWlsZGVyOjpnZXRO YW1lKToKKyAgICAgICAgKEpTQzo6QVNUQnVpbGRlcjo6Z2V0VHlwZSk6CisgICAgICAgIChKU0M6 OkFTVEJ1aWxkZXI6OmlzUmVzb2x2ZSk6CisgICAgICAgICogcGFyc2VyL1N5bnRheENoZWNrZXIu aDoKKyAgICAgICAgKEpTQzo6U3ludGF4Q2hlY2tlcjo6b3BlcmF0b3JTdGFja1BvcCk6CisKIDIw MTAtMTItMTQgIE1hcmsgUm93ZSAgPG1yb3dlQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBTYW0gV2VpbmlnLgpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvcGFyc2VyL0FTVEJ1 aWxkZXIuaCBiL0phdmFTY3JpcHRDb3JlL3BhcnNlci9BU1RCdWlsZGVyLmgKaW5kZXggOWE2ODE0 NDY5NWI4OTI5ZTVmMWZjMmZjMjdlNTU3NmU2M2RkMWM0OC4uMDRjZjI3Mjg2MmE1YjE2NTIzOTQ2 OTI3ODI4Njg3ZWQ1NTZkMzI1MCAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvcGFyc2VyL0FT VEJ1aWxkZXIuaAorKysgYi9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvQVNUQnVpbGRlci5oCkBAIC01 NzYsMTAgKzU3NiwxMCBAQCBwdWJsaWM6CiAgICAgICAgIHJldHVybiByZXN1bHQ7CiAgICAgfQog ICAgIAotICAgIGNvbnN0IElkZW50aWZpZXImIGdldE5hbWUoUHJvcGVydHkgcHJvcGVydHkpIHsg cmV0dXJuIHByb3BlcnR5LT5uYW1lKCk7IH0KLSAgICBQcm9wZXJ0eU5vZGU6OlR5cGUgZ2V0VHlw ZShQcm9wZXJ0eSBwcm9wZXJ0eSkgeyByZXR1cm4gcHJvcGVydHktPnR5cGUoKTsgfQorICAgIGNv bnN0IElkZW50aWZpZXImIGdldE5hbWUoUHJvcGVydHkgcHJvcGVydHkpIGNvbnN0IHsgcmV0dXJu IHByb3BlcnR5LT5uYW1lKCk7IH0KKyAgICBQcm9wZXJ0eU5vZGU6OlR5cGUgZ2V0VHlwZShQcm9w ZXJ0eSBwcm9wZXJ0eSkgY29uc3QgeyByZXR1cm4gcHJvcGVydHktPnR5cGUoKTsgfQogCi0gICAg Ym9vbCBpc1Jlc29sdmUoRXhwcmVzc2lvbk5vZGUqIGV4cHIpIHsgcmV0dXJuIGV4cHItPmlzUmVz b2x2ZU5vZGUoKTsgfQorICAgIGJvb2wgaXNSZXNvbHZlKEV4cHJlc3Npb25Ob2RlKiBleHByKSBj b25zdCB7IHJldHVybiBleHByLT5pc1Jlc29sdmVOb2RlKCk7IH0KIAogcHJpdmF0ZToKICAgICBz dHJ1Y3QgU2NvcGUgewpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvcGFyc2VyL1N5bnRheENo ZWNrZXIuaCBiL0phdmFTY3JpcHRDb3JlL3BhcnNlci9TeW50YXhDaGVja2VyLmgKaW5kZXggZjkw OTNhNzQ0N2E5NDMzMWI0ZThlMTA2M2Q1Yzg2ZGE5MmQ0NzlhZC4uYjAwZTcxMGUzNTIwNjhkNmMz OWNiZDI4MWVhYzY3ZDAwMDMxYjNkNCAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvcGFyc2Vy L1N5bnRheENoZWNrZXIuaAorKysgYi9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvU3ludGF4Q2hlY2tl ci5oCkBAIC0yMDMsOSArMjAzLDkgQEAgcHVibGljOgogICAgIAogICAgIHZvaWQgYXNzaWdubWVu dFN0YWNrQXBwZW5kKGludCwgaW50LCBpbnQsIGludCwgaW50LCBPcGVyYXRvcikgeyB9CiAgICAg aW50IGNyZWF0ZUFzc2lnbm1lbnQoaW50LCBpbnQsIGludCwgaW50LCBpbnQpIHsgQVNTRVJUX05P VF9SRUFDSEVEKCk7IHJldHVybiAxOyB9Ci0gICAgY29uc3QgSWRlbnRpZmllciYgZ2V0TmFtZShj b25zdCBQcm9wZXJ0eSYgcHJvcGVydHkpIHsgQVNTRVJUKHByb3BlcnR5Lm5hbWUpOyByZXR1cm4g KnByb3BlcnR5Lm5hbWU7IH0KLSAgICBQcm9wZXJ0eU5vZGU6OlR5cGUgZ2V0VHlwZShjb25zdCBQ cm9wZXJ0eSYgcHJvcGVydHkpIHsgcmV0dXJuIHByb3BlcnR5LnR5cGU7IH0KLSAgICBib29sIGlz UmVzb2x2ZShFeHByZXNzaW9uVHlwZSBleHByKSB7IHJldHVybiBleHByID09IFJlc29sdmVFeHBy IHx8IGV4cHIgPT0gUmVzb2x2ZUV2YWxFeHByOyB9CisgICAgY29uc3QgSWRlbnRpZmllciYgZ2V0 TmFtZShjb25zdCBQcm9wZXJ0eSYgcHJvcGVydHkpIGNvbnN0IHsgQVNTRVJUKHByb3BlcnR5Lm5h bWUpOyByZXR1cm4gKnByb3BlcnR5Lm5hbWU7IH0KKyAgICBQcm9wZXJ0eU5vZGU6OlR5cGUgZ2V0 VHlwZShjb25zdCBQcm9wZXJ0eSYgcHJvcGVydHkpIGNvbnN0IHsgcmV0dXJuIHByb3BlcnR5LnR5 cGU7IH0KKyAgICBib29sIGlzUmVzb2x2ZShFeHByZXNzaW9uVHlwZSBleHByKSBjb25zdCB7IHJl dHVybiBleHByID09IFJlc29sdmVFeHByIHx8IGV4cHIgPT0gUmVzb2x2ZUV2YWxFeHByOyB9CiAg ICAgCiBwcml2YXRlOgogICAgIGludCBtX3RvcEJpbmFyeUV4cHI7Cg==