51140 2010-12-15 15:15:38 -0800 FormatBlock doesn't preserve typing style but it should 2010-12-23 18:14:48 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 rniwa rniwa commit-queue darin enrica ojan oldest_to_newest 322842 0 rniwa 2010-12-15 15:15:38 -0800 InsertListCommand and IndentOutdentCommand both preserve typing style but FormatBlockCommand doesn't. This is a bug. 322913 1 76706 rniwa 2010-12-15 16:06:37 -0800 Created attachment 76706 fixes the bug 322915 2 rniwa 2010-12-15 16:08:46 -0800 (In reply to comment #1) > Created an attachment (id=76706) [details] > fixes the bug It seems like there are some edge cases in which typing style isn't preserved. But we should address each of such edge case in a separate bug since InsertListCommand and IndentOutdentCommand seem to have similar issues. 326410 3 76706 commit-queue 2010-12-23 18:14:42 -0800 Comment on attachment 76706 fixes the bug Clearing flags on attachment: 76706 Committed r74601: <http://trac.webkit.org/changeset/74601> 326411 4 commit-queue 2010-12-23 18:14:48 -0800 All reviewed patches have been landed. Closing bug. 76706 2010-12-15 16:06:37 -0800 2010-12-23 18:14:42 -0800 fixes the bug bug-51140-20101215160636.patch text/plain 3565 rniwa ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA4NWJhYzdlYmUxMGZmMzJhODZkY2U0OTgzYjZmZDIxNjkyNWIzNzNhLi5iYTNjZTE0 ODY4ODdkNDEzYTNmM2Q1OWJmZDc4NWNkM2U4MTA2MWMwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTAtMTItMTUgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRm9ybWF0QmxvY2sgZG9lc24n dCBwcmVzZXJ2ZSB0eXBpbmcgc3R5bGUgYnV0IGl0IHNob3VsZAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTExNDAKKworICAgICAgICBBZGRlZCBhIHRl c3QgdG8gdHlwZSB0ZXh0IGFmdGVyIGJvbGRpbmcgdGhlIHR5cGluZyBzdHlsZSBhbmQgZXhlY3V0 aW5nIGEgRm9ybWF0QmxvY2sgY29tbWFuZC4KKyAgICAgICAgQmVjYXVzZSBGb3JtYXRCbG9jayBj b21tYW5kIHByZXNlcnZlcyB0eXBpbmcgc3R5bGUsIHRoZSB0eXBlZCB0ZXh0IHNob3VsZCBiZSBp biBib2xkLgorCisgICAgICAgICogZWRpdGluZy9leGVjQ29tbWFuZC9mb3JtYXQtYmxvY2stdHlw aW5nLXN0eWxlLmh0bWw6IEFkZGVkLgorCiAyMDEwLTEyLTE1ICBKaWFuIExpICA8amlhbmxpQGNo cm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLiBNYXJrIGEgZmFpbGVkIHRlc3QgaW4g Y2hyb21pdW0gdGVzdCBleHBlY3RhdGlvbnMuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9lZGl0 aW5nL2V4ZWNDb21tYW5kL2Zvcm1hdC1ibG9jay10eXBpbmctc3R5bGUtZXhwZWN0ZWQudHh0IGIv TGF5b3V0VGVzdHMvZWRpdGluZy9leGVjQ29tbWFuZC9mb3JtYXQtYmxvY2stdHlwaW5nLXN0eWxl LWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5hYjViZDg2ZTJkODdlODA2NTA1ZWYxZmMxY2U2MjZk NDczNGExMDUxCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9leGVjQ29t bWFuZC9mb3JtYXQtYmxvY2stdHlwaW5nLXN0eWxlLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDYg QEAKK1RoaXMgdGVzdHMgZW5zdXJlcyBGb3JtYXRCbG9jayBwcmVzZXJ2ZXMgdGhlIHR5cGluZyBz dHlsZS4KKworIndvcmxkIiBzaG91bGQgYmUgYm9sZGVkOgorfCAiaGVsbG8iCit8IDxiPgorfCAg ICIgd29ybGQ8I3NlbGVjdGlvbi1jYXJldD4iCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9lZGl0 aW5nL2V4ZWNDb21tYW5kL2Zvcm1hdC1ibG9jay10eXBpbmctc3R5bGUuaHRtbCBiL0xheW91dFRl c3RzL2VkaXRpbmcvZXhlY0NvbW1hbmQvZm9ybWF0LWJsb2NrLXR5cGluZy1zdHlsZS5odG1sCm5l dyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAuLjRhYTJjOTEzZTA3N2RkNzhkYzgwZWU3NjMwNzk4YmMyM2UzMGEyMWEKLS0tIC9k ZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL2Zvcm1hdC1ibG9j ay10eXBpbmctc3R5bGUuaHRtbApAQCAtMCwwICsxLDIxIEBACis8IURPQ1RZUEUgaHRtbD4KKzxo dG1sPgorPGJvZHk+Cis8ZGl2IGlkPSJ0ZXN0IiBjb250ZW50ZWRpdGFibGU+aGVsbG88L2Rpdj4K KzxzY3JpcHQgc3JjPSIuLi8uLi9yZXNvdXJjZXMvZHVtcC1hcy1tYXJrdXAuanMiPjwvc2NyaXB0 PgorPHNjcmlwdD4KKworTWFya3VwLmRlc2NyaXB0aW9uKCJUaGlzIHRlc3RzIGVuc3VyZXMgRm9y bWF0QmxvY2sgcHJlc2VydmVzIHRoZSB0eXBpbmcgc3R5bGUuIik7CisKK3ZhciB0ZXN0ID0gZG9j dW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3Rlc3QnKTsKK3dpbmRvdy5nZXRTZWxlY3Rpb24oKS5zZXRQ b3NpdGlvbih0ZXN0LCA1KTsKKworZG9jdW1lbnQuZXhlY0NvbW1hbmQoJ0JvbGQnLCBmYWxzZSwg bnVsbCk7Citkb2N1bWVudC5leGVjQ29tbWFuZCgnRm9ybWF0QmxvY2snLCBmYWxzZSwgJycpOwor ZG9jdW1lbnQuZXhlY0NvbW1hbmQoJ0luc2VydFRleHQnLCBmYWxzZSwgJyB3b3JsZCcpOworCitN YXJrdXAuZHVtcCh0ZXN0LCAnIndvcmxkIiBzaG91bGQgYmUgYm9sZGVkJyk7CisKKzwvc2NyaXB0 PgorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJD b3JlL0NoYW5nZUxvZwppbmRleCBlMTZjMmM1Njk3NDQwM2U2YzhiNzhlNzQ1OTViNjViOGZlMDlk MWFiLi5hM2I2YzVmOTVjNzRiN2UwN2M3YjRlMTIxMjA3MWNjOGE2OGFkZDdlIDEwMDY0NAotLS0g YS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEwLTEyLTE1ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZvcm1hdEJsb2NrIGRv ZXNuJ3QgcHJlc2VydmUgdHlwaW5nIHN0eWxlIGJ1dCBpdCBzaG91bGQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUxMTQwCisKKyAgICAgICAgRml4ZWQg dGhlIGJ1ZyBieSBtYWtpbmcgcHJlc2VydmVUeXBpbmdTdHlsZSByZXR1cm4gdHJ1ZS4KKworICAg ICAgICBUZXN0OiBlZGl0aW5nL2V4ZWNDb21tYW5kL2Zvcm1hdC1ibG9jay10eXBpbmctc3R5bGUu aHRtbAorCisgICAgICAgICogZWRpdGluZy9Gb3JtYXRCbG9ja0NvbW1hbmQuaDoKKyAgICAgICAg KFdlYkNvcmU6OkZvcm1hdEJsb2NrQ29tbWFuZDo6cHJlc2VydmVzVHlwaW5nU3R5bGUpOgorCiAy MDEwLTEyLTE1ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBHdXN0YXZvIE5vcm9uaGEgU2lsdmEuCmRpZmYgLS1naXQgYS9XZWJD b3JlL2VkaXRpbmcvRm9ybWF0QmxvY2tDb21tYW5kLmggYi9XZWJDb3JlL2VkaXRpbmcvRm9ybWF0 QmxvY2tDb21tYW5kLmgKaW5kZXggMzUyZmEyMzAxMWU3ODdlYzgxNmEyMWVjODA5ODNkOTA5MmIx MmNiNC4uNGJlMjM1ZjE3M2I4ZjIzYzA0OWRiZTA3NWRkNTYxNWEwYTU1OThkNCAxMDA2NDQKLS0t IGEvV2ViQ29yZS9lZGl0aW5nL0Zvcm1hdEJsb2NrQ29tbWFuZC5oCisrKyBiL1dlYkNvcmUvZWRp dGluZy9Gb3JtYXRCbG9ja0NvbW1hbmQuaApAQCAtMzcsNiArMzcsOCBAQCBwdWJsaWM6CiAgICAg ewogICAgICAgICByZXR1cm4gYWRvcHRSZWYobmV3IEZvcm1hdEJsb2NrQ29tbWFuZChkb2N1bWVu dCwgdGFnTmFtZSkpOwogICAgIH0KKyAgICAKKyAgICB2aXJ0dWFsIGJvb2wgcHJlc2VydmVzVHlw aW5nU3R5bGUoKSBjb25zdCB7IHJldHVybiB0cnVlOyB9CiAKICAgICBzdGF0aWMgRWxlbWVudCog ZWxlbWVudEZvckZvcm1hdEJsb2NrQ29tbWFuZChSYW5nZSopOwogICAgIGJvb2wgZGlkQXBwbHko KSBjb25zdCB7IHJldHVybiBtX2RpZEFwcGx5OyB9Cg==