51137 2010-12-15 14:56:34 -0800 IOSurface bounds checks on bytesPerRow and allocSize are incorrect 2010-12-15 15:28:31 -0800 1 1 1 Unclassified WebKit Canvas 528+ (Nightly build) Mac (Intel) OS X 10.6 RESOLVED FIXED P2 Normal --- 1 mdelaney7 mdelaney7 mdelaney7 simon.fraser oldest_to_newest 322826 0 mdelaney7 2010-12-15 14:56:34 -0800 Since the IOSurfaceAlignProperty functions may align bytesPerRow and allocSize for reasons other than not allowing the values to be too large, bounds checking off of their returned values is not correct. This patch will remove those incorrect bounds checks. 322829 1 76690 mdelaney7 2010-12-15 15:05:21 -0800 Created attachment 76690 Patch 322843 2 76690 eric 2010-12-15 15:15:41 -0800 Comment on attachment 76690 Patch Which tests? On which platform? 322853 3 76690 simon.fraser 2010-12-15 15:20:18 -0800 Comment on attachment 76690 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=76690&action=review > WebCore/ChangeLog:8 > + No new tests added - many current canvas layout tests fail because of this incorrect bounds check. You should clarify that tests will only fail for those using this new functionality. 322866 4 mdelaney7 2010-12-15 15:28:20 -0800 Yea, exactly. Only on my local build using this new functionality (IOSurfaces) are any of the usual tests failing. This patch will fix those - not any tests failing on the bots. This is now reflected in the changelog. 322867 5 mdelaney7 2010-12-15 15:28:31 -0800 Committed r74148: <http://trac.webkit.org/changeset/74148> 76690 2010-12-15 15:05:21 -0800 2010-12-15 15:20:18 -0800 Patch bug-51137-20101215150517.patch text/plain 1478 mdelaney7 SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3NDE0NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMTItMTUgIE1hdHRoZXcgRGVsYW5leSAgPG1kZWxhbmV5QGFw cGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBJT1N1cmZhY2UgYm91bmRzIGNoZWNrcyBvbiBieXRlc1BlclJvdyBhbmQgYWxsb2NTaXplIGFy ZSBpbmNvcnJlY3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTUxMTM3CisKKyAgICAgICAgTm8gbmV3IHRlc3RzIGFkZGVkIC0gbWFueSBjdXJyZW50IGNh bnZhcyBsYXlvdXQgdGVzdHMgZmFpbCBiZWNhdXNlIG9mIHRoaXMgaW5jb3JyZWN0IGJvdW5kcyBj aGVjay4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NnL0ltYWdlQnVmZmVyQ0cuY3Bw OgorCiAyMDEwLTEyLTE1ICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgQW5kZXJzIENhcmxzc29uLgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9jZy9JbWFnZUJ1ZmZlckNHLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2NnL0ltYWdlQnVmZmVyQ0cuY3BwCShyZXZpc2lvbiA3NDEyOCkKKysrIFdlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cvSW1hZ2VCdWZmZXJDRy5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTYzLDExICs2MywxMSBAQCBzdGF0aWMgUmV0YWluUHRyPElPU3VyZmFjZVJlZj4gY3JlYXRl SU9TCiAgICAgaW50IGhlaWdodCA9IHNpemUuaGVpZ2h0KCk7CiAKICAgICB1bnNpZ25lZCBsb25n IGJ5dGVzUGVyUm93ID0gSU9TdXJmYWNlQWxpZ25Qcm9wZXJ0eShrSU9TdXJmYWNlQnl0ZXNQZXJS b3csIHNpemUud2lkdGgoKSAqIGJ5dGVzUGVyRWxlbWVudCk7Ci0gICAgaWYgKCFieXRlc1BlclJv dyB8fCBieXRlc1BlclJvdyAhPSAoc2l6ZS53aWR0aCgpICogYnl0ZXNQZXJFbGVtZW50KSkKKyAg ICBpZiAoIWJ5dGVzUGVyUm93KQogICAgICAgICByZXR1cm4gMDsKIAogICAgIHVuc2lnbmVkIGxv bmcgYWxsb2NTaXplID0gSU9TdXJmYWNlQWxpZ25Qcm9wZXJ0eShrSU9TdXJmYWNlQWxsb2NTaXpl LCBzaXplLmhlaWdodCgpICogYnl0ZXNQZXJSb3cpOwotICAgIGlmICghYWxsb2NTaXplIHx8IGFs bG9jU2l6ZSAhPSAoc2l6ZS5oZWlnaHQoKSAqIGJ5dGVzUGVyUm93KSkKKyAgICBpZiAoIWFsbG9j U2l6ZSkKICAgICAgICAgcmV0dXJuIDA7CiAKICAgICBjb25zdCB2b2lkICprZXlzWzZdOwo=