51133 2010-12-15 14:04:38 -0800 Provide an interface to force using fullscreen mediaplayer 2011-01-04 07:08:23 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED P2 Enhancement --- 1 max.hong.shen max.hong.shen abarth ademar commit-queue eric.carlson eric hausmann hui_huang jer.noble kenneth kling manyoso tonikitoo webkit.review.bot oldest_to_newest 322804 0 max.hong.shen 2010-12-15 14:04:38 -0800 Based on the worked done by Tor Arne Vestbo (tor.arne.vestbo@nokia.com), we try to add a function shouldForceFullScreenVideoPlayback in ChromeClient to force webkit to launch full screen media player for playing the html5 video. The idea is that a browser vendor can specify this behavior through the platform plugin. This patch is only the WebCore-part of forcing fullscreen player. 322808 1 76686 max.hong.shen 2010-12-15 14:14:34 -0800 Created attachment 76686 first try 322927 2 tonikitoo 2010-12-15 16:43:29 -0800 > 10 idea is that a browser vendor can specify this behavior through the > 11 platform plugin. Do all platforms have a platform plugin-like thing available? 323039 3 jer.noble 2010-12-15 20:51:21 -0800 Why are the changes to MediaPlayer necessary? Why not call the chrome() client methods from HTMLMediaElement? 323140 4 76764 max.hong.shen 2010-12-16 06:12:33 -0800 Created attachment 76764 minor changes 323148 5 max.hong.shen 2010-12-16 06:34:46 -0800 (In reply to comment #2) > > 10 idea is that a browser vendor can specify this behavior through the > > 11 platform plugin. > > Do all platforms have a platform plugin-like thing available? Good question! I am not sure about the answer but just like qtwebkit did for the HitTestResult padding -- first, it hacks webcore, then qtwebkit extends its platform plugin to define the paddings. So, I think it makes sense to add a new interface in webcore::chromeclient to hack the webkit, then for Qt, we can extend the platform plugin to force fullscreen; and for other platforms, they also can force fullscreen by changing the implementation of their own chrome client. 323149 6 max.hong.shen 2010-12-16 06:36:04 -0800 (In reply to comment #3) > Why are the changes to MediaPlayer necessary? Why not call the chrome() client methods from HTMLMediaElement? Just want to make it readable and clear :) I can change the code if you guys don't like it. 323162 7 76764 eric.carlson 2010-12-16 07:18:59 -0800 Comment on attachment 76764 minor changes View in context: https://bugs.webkit.org/attachment.cgi?id=76764&action=review r- for the layering problem. > WebCore/ChangeLog:5 > + Provide an interface to force using fullscreen mediaplayer "force" isn't right if the method names changes as I suggest below. > WebCore/ChangeLog:13 > + No new tests. as the changes should not change functionality. Typo, either replace the "." with a "," or capitalize "as". > WebCore/page/ChromeClient.h:268 > +#if ENABLE(VIDEO) > + virtual bool shouldForceFullScreenVideoPlayback() { return false; } > +#endif I am not sure about this name, maybe "requiresFullscreenForVideoPlayback()"? > WebCore/platform/graphics/MediaPlayer.cpp:443 > +bool MediaPlayer::shouldForceFullscreenVideoPlayback() const > +{ > + Document* doc = document(); > + if (!doc || !doc->page()) > + return false; > + > + return doc->page()->chrome()->client()->shouldForceFullScreenVideoPlayback(); > +} > + This layering doesn't make sense. MediaPlayer is the bridge between the platform specific media engine and the rest of WebCore, so this method should only be here if the answer comes from the media engine. If the answer comes from the chrome client, HTMLMediaElement should call it directly - as it already does to enter and exit fullscreen. 323168 8 max.hong.shen 2010-12-16 07:37:22 -0800 (In reply to comment #7) > (From update of attachment 76764 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=76764&action=review > > r- for the layering problem. > > > > WebCore/ChangeLog:5 > > + Provide an interface to force using fullscreen mediaplayer > > "force" isn't right if the method names changes as I suggest below. > > > WebCore/ChangeLog:13 > > + No new tests. as the changes should not change functionality. > > Typo, either replace the "." with a "," or capitalize "as". > > > WebCore/page/ChromeClient.h:268 > > +#if ENABLE(VIDEO) > > + virtual bool shouldForceFullScreenVideoPlayback() { return false; } > > +#endif > > I am not sure about this name, maybe "requiresFullscreenForVideoPlayback()"? > > > WebCore/platform/graphics/MediaPlayer.cpp:443 > > +bool MediaPlayer::shouldForceFullscreenVideoPlayback() const > > +{ > > + Document* doc = document(); > > + if (!doc || !doc->page()) > > + return false; > > + > > + return doc->page()->chrome()->client()->shouldForceFullScreenVideoPlayback(); > > +} > > + > > This layering doesn't make sense. MediaPlayer is the bridge between the platform specific media engine and the rest of WebCore, so this method should only be here if the answer comes from the media engine. If the answer comes from the chrome client, HTMLMediaElement should call it directly - as it already does to enter and exit fullscreen. Thanks for reviewing, Eric. I know the interface name is really confusing :( This interface means once it returns true, all the html 5 video should be played in fullscreen mode only (no inline playing mode allowed). So, how about we change it to fullScreenVideoPlaybackOnly? Does it make sense? 323181 9 76770 max.hong.shen 2010-12-16 08:17:46 -0800 Created attachment 76770 updated with eric's suggestion 323192 10 76770 tonikitoo 2010-12-16 08:36:19 -0800 Comment on attachment 76770 updated with eric's suggestion View in context: https://bugs.webkit.org/attachment.cgi?id=76770&action=review > WebCore/ChangeLog:13 > + No new tests, as the changes should not change functionality. It this reads better: "New new tests needed since there is not functionality change." > WebCore/html/HTMLMediaElement.cpp:2112 > + if (document() && document()->page() && document()->page()->chrome()->client()->requiresFullscreenForVideoPlayback() && !m_isFullscreen) I think the right way to do it is adding a method to Chrome, and Chrome calls ChromeClient. Look at Chrome.cpp methods. 323277 11 76785 max.hong.shen 2010-12-16 10:50:38 -0800 Created attachment 76785 add a new function to chrome, and make it calls chromeclient::requiresFullscreenForVideoPlayback 323302 12 76785 jer.noble 2010-12-16 11:23:02 -0800 Comment on attachment 76785 add a new function to chrome, and make it calls chromeclient::requiresFullscreenForVideoPlayback View in context: https://bugs.webkit.org/attachment.cgi?id=76785&action=review Overall, the new patch is better than the first one, but moving enterFullscreenForNode() and exitFullscreenFroNode() from ChromeClient into Chrome is not strictly needed here. If you believe they should be exposed through Chrome, that deserves a separate patch. > WebCore/html/HTMLMediaElement.cpp:2417 > - document()->page()->chrome()->client()->enterFullscreenForNode(this); > + document()->page()->chrome()->enterFullscreenForNode(this); These changes don't seem necessary for your patch. > WebCore/html/HTMLMediaElement.cpp:-2427 > - document()->page()->chrome()->client()->exitFullscreenForNode(this); Ditto. > WebCore/page/Chrome.cpp:532 > +void Chrome::enterFullscreenForNode(Node* node) > +{ > + m_client->enterFullscreenForNode(node); > +} > + > +void Chrome::exitFullscreenForNode(Node* node) > +{ > + m_client->exitFullscreenForNode(node); > +} Ditto. > WebCore/page/Chrome.h:153 > + void enterFullscreenForNode(Node*); > + void exitFullscreenForNode(Node*); Ditto. 323310 13 tonikitoo 2010-12-16 11:32:43 -0800 (In reply to comment #12) > (From update of attachment 76785 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=76785&action=review > > Overall, the new patch is better than the first one, but moving enterFullscreenForNode() and exitFullscreenFroNode() from ChromeClient into Chrome is not strictly needed here. If you believe they should be exposed through Chrome, that deserves a separate patch. If you think they are not needed, sorry Yi, since I suggested them. Could you please say why not though? 323312 14 max.hong.shen 2010-12-16 11:37:28 -0800 (In reply to comment #13) > (In reply to comment #12) > > (From update of attachment 76785 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=76785&action=review > > > > Overall, the new patch is better than the first one, but moving enterFullscreenForNode() and exitFullscreenFroNode() from ChromeClient into Chrome is not strictly needed here. If you believe they should be exposed through Chrome, that deserves a separate patch. > > If you think they are not needed, sorry Yi, since I suggested them. > > Could you please say why not though? That's all right, Antonio. I am always with you :) I think what Jer suggested is that we should make a separated patch for moving enterFullscreenForNode() and exitFullscreenFroNode() from ChromeClient into Chrome. 323359 15 76802 max.hong.shen 2010-12-16 12:43:04 -0800 Created attachment 76802 updated with Jer's suggestion 323378 16 jer.noble 2010-12-16 13:24:33 -0800 (In reply to comment #15) > Created an attachment (id=76802) [details] > updated with Jer's suggestion Much better, thanks. :) 323380 17 76802 tonikitoo 2010-12-16 13:27:23 -0800 Comment on attachment 76802 updated with Jer's suggestion looks good to me too. Eric? 323386 18 76802 eric.carlson 2010-12-16 13:37:12 -0800 Comment on attachment 76802 updated with Jer's suggestion View in context: https://bugs.webkit.org/attachment.cgi?id=76802&action=review r+, but clearing the cq flag because I would like the ChangeLog comment to be accurate. Thanks for the change! > WebCore/ChangeLog:13 > + No new tests needed since there is no functionality change. This is not true, there is definitely new functionality and it will be possible to create new tests once a platform implements requiresFullscreenForVideoPlayback. Probably better to say something like "No new tests because no client implements requiresFullscreenForVideoPlayback yet". 323398 19 76812 max.hong.shen 2010-12-16 13:50:16 -0800 Created attachment 76812 fix changelog 323403 20 76812 commit-queue 2010-12-16 13:59:18 -0800 Comment on attachment 76812 fix changelog Rejecting attachment 76812 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'apply-attachment', '--non-interactive', 76812]" exit_code: 2 Last 500 characters of output: ailed to merge in the changes. Patch failed at 0001 2010-12-16 Yury Semikhatsky <yurys@chromium.org> When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at WebKitTools/Scripts/update-webkit line 132. Failed to run "['WebKitTools/Scripts/update-webkit']" exit_code: 2 Full output: http://queues.webkit.org/results/7180068 323428 21 76812 eric 2010-12-16 14:22:23 -0800 Comment on attachment 76812 fix changelog Bot's git repo got corrupted. 323576 22 76812 commit-queue 2010-12-16 19:29:05 -0800 Comment on attachment 76812 fix changelog Clearing flags on attachment: 76812 Committed r74228: <http://trac.webkit.org/changeset/74228> 323577 23 commit-queue 2010-12-16 19:29:12 -0800 All reviewed patches have been landed. Closing bug. 328760 24 77842 max.hong.shen 2011-01-03 13:40:35 -0800 Created attachment 77842 a small fix for video to enter the fullscreen mode 328762 25 kenneth 2011-01-03 13:43:07 -0800 I think you need to reopen. Simon Hausmann, can you have a look at the patch? 328764 26 max.hong.shen 2011-01-03 13:44:31 -0800 According to the interface name, only video should be displayed in fullscreen when requiresFullscreenForVideoPlayback is specified. 328765 27 77843 max.hong.shen 2011-01-03 13:45:13 -0800 Created attachment 77843 fix typo 328955 28 77843 hausmann 2011-01-04 04:48:02 -0800 Comment on attachment 77843 fix typo That surely corrects the logic and brings it in line with the name requiresFullscreenFor_Video_Playback(), but I have the distinct feeling that in the future we're going to remove the _Video_ part from the function ;-) 328960 29 77843 commit-queue 2011-01-04 05:17:59 -0800 Comment on attachment 77843 fix typo Clearing flags on attachment: 77843 Committed r74965: <http://trac.webkit.org/changeset/74965> 328961 30 commit-queue 2011-01-04 05:18:07 -0800 All reviewed patches have been landed. Closing bug. 328972 31 webkit.review.bot 2011-01-04 06:08:09 -0800 http://trac.webkit.org/changeset/74965 might have broken GTK Linux 32-bit Release The following tests are not passing: media/audio-delete-while-slider-thumb-clicked.html 328982 32 ademar 2011-01-04 07:08:13 -0800 Revision r74228 cherry-picked into qtwebkit-2.2 with commit 6f4a70e <http://gitorious.org/webkit/qtwebkit/commit/6f4a70e> Revision r74965 cherry-picked into qtwebkit-2.2 with commit 26e1be3 <http://gitorious.org/webkit/qtwebkit/commit/26e1be3> 76686 2010-12-15 14:14:34 -0800 2010-12-16 06:12:33 -0800 first try 51133.patch text/plain 5330 max.hong.shen SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3NDEzMykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjggQEAKKzIwMTAtMTItMTUgIFlpIFNoZW4gIDx5aS40LnNoZW5Abm9raWEuY29t PiwgVG9yIEFybmUgVmVzdGJvIDx0b3IuYXJuZS52ZXN0Ym9Abm9raWEuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFByb3ZpZGUgYW4gaW50ZXJm YWNlIHRvIGZvcmNlIHVzaW5nIGZ1bGxzY3JlZW4gbWVkaWFwbGF5ZXIKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUxMTMzCisKKyAgICAgICAgQWRkIENo cm9tZUNsaWVudDo6c2hvdWxkRm9yY2VGdWxsU2NyZWVuVmlkZW9QbGF5YmFjayB0byBmb3JjZSB3 ZWJraXQKKyAgICAgICAgdG8gbGF1bmNoIGZ1bGxzY3JlZW4gdmlkZW8gcGxheWVyIGZvciBwbGF5 aW5nIHRoZSBodG1sNSB2aWRlby4gVGhlIAorICAgICAgICBpZGVhIGlzIHRoYXQgYSBicm93c2Vy IHZlbmRvciBjYW4gc3BlY2lmeSB0aGlzIGJlaGF2aW9yIHRocm91Z2ggdGhlCisgICAgICAgIHBs YXRmb3JtIHBsdWdpbi4KKworICAgICAgICBObyBuZXcgdGVzdHMuIGFzIHRoZSBjaGFuZ2VzIHNo b3VsZCBub3QgY2hhbmdlIGZ1bmN0aW9uYWxpdHkuCisKKyAgICAgICAgKiBodG1sL0hUTUxNZWRp YUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6dXBkYXRl UGxheVN0YXRlKToKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OmV4aXRGdWxs c2NyZWVuKToKKyAgICAgICAgKiBwYWdlL0Nocm9tZUNsaWVudC5oOgorICAgICAgICAoV2ViQ29y ZTo6Q2hyb21lQ2xpZW50OjpzaG91bGRGb3JjZUZ1bGxTY3JlZW5WaWRlb1BsYXliYWNrKToKKyAg ICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9NZWRpYVBsYXllci5jcHA6CisgICAgICAgIChXZWJD b3JlOjpNZWRpYVBsYXllcjo6c2hvdWxkRm9yY2VGdWxsc2NyZWVuVmlkZW9QbGF5YmFjayk6Cisg ICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllcjo6ZG9jdW1lbnQpOgorICAgICAgICAoV2ViQ29y ZTo6TWVkaWFQbGF5ZXI6OmluTWVkaWFEb2N1bWVudCk6CisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3MvTWVkaWFQbGF5ZXIuaDoKKwogMjAxMC0xMi0xNSAgTWFydGluIFJvYmluc29uICA8bXJv Ymluc29uQGlnYWxpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgR3VzdGF2byBOb3Jvbmhh IFNpbHZhLgpJbmRleDogV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAkocmV2aXNpb24gNzQxMzMp CisrKyBXZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTIxMDksNiArMjEwOSw5IEBAIHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6dXBkYXRlUGxheVN0YXRl KCkKICAgICAgICAgaW52YWxpZGF0ZUNhY2hlZFRpbWUoKTsKIAogICAgICAgICBpZiAocGxheWVy UGF1c2VkKSB7CisgICAgICAgICAgICBpZiAobV9wbGF5ZXItPnNob3VsZEZvcmNlRnVsbHNjcmVl blZpZGVvUGxheWJhY2soKSAmJiAhbV9pc0Z1bGxzY3JlZW4pCisgICAgICAgICAgICAgICAgZW50 ZXJGdWxsc2NyZWVuKCk7CisKICAgICAgICAgICAgIC8vIFNldCByYXRlIGJlZm9yZSBjYWxsaW5n IHBsYXkgaW4gY2FzZSB0aGUgcmF0ZSB3YXMgc2V0IGJlZm9yZSB0aGUgbWVkaWEgZW5naW5lIHdh cyBzZXR1cC4KICAgICAgICAgICAgIC8vIFRoZSBtZWRpYSBlbmdpbmUgc2hvdWxkIGp1c3Qgc3Rh c2ggdGhlIHJhdGUgc2luY2UgaXQgaXNuJ3QgYWxyZWFkeSBwbGF5aW5nLgogICAgICAgICAgICAg bV9wbGF5ZXItPnNldFJhdGUobV9wbGF5YmFja1JhdGUpOwpAQCAtMjQyNCw2ICsyNDI3LDggQEAg dm9pZCBIVE1MTWVkaWFFbGVtZW50OjpleGl0RnVsbHNjcmVlbigpCiAgICAgQVNTRVJUKG1faXNG dWxsc2NyZWVuKTsKICAgICBtX2lzRnVsbHNjcmVlbiA9IGZhbHNlOwogICAgIGlmIChkb2N1bWVu dCgpICYmIGRvY3VtZW50KCktPnBhZ2UoKSkgeworICAgICAgICBpZiAobV9wbGF5ZXItPnNob3Vs ZEZvcmNlRnVsbHNjcmVlblZpZGVvUGxheWJhY2soKSkKKyAgICAgICAgICAgIHBhdXNlSW50ZXJu YWwoKTsKICAgICAgICAgZG9jdW1lbnQoKS0+cGFnZSgpLT5jaHJvbWUoKS0+Y2xpZW50KCktPmV4 aXRGdWxsc2NyZWVuRm9yTm9kZSh0aGlzKTsKICAgICAgICAgc2NoZWR1bGVFdmVudChldmVudE5h bWVzKCkud2Via2l0ZW5kZnVsbHNjcmVlbkV2ZW50KTsKICAgICB9CkluZGV4OiBXZWJDb3JlL3Bh Z2UvQ2hyb21lQ2xpZW50LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wYWdlL0Nocm9tZUNsaWVu dC5oCShyZXZpc2lvbiA3NDEzMykKKysrIFdlYkNvcmUvcGFnZS9DaHJvbWVDbGllbnQuaAkod29y a2luZyBjb3B5KQpAQCAtMjYyLDYgKzI2MiwxMCBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAg ICAgIHZpcnR1YWwgdm9pZCBlbnRlckZ1bGxTY3JlZW5Gb3JFbGVtZW50KEVsZW1lbnQqKSB7IH0K ICAgICAgICAgdmlydHVhbCB2b2lkIGV4aXRGdWxsU2NyZWVuRm9yRWxlbWVudChFbGVtZW50Kikg eyB9CiAjZW5kaWYKKworI2lmIEVOQUJMRShWSURFTykgCisgICAgICAgIHZpcnR1YWwgYm9vbCBz aG91bGRGb3JjZUZ1bGxTY3JlZW5WaWRlb1BsYXliYWNrKCkgeyByZXR1cm4gZmFsc2U7IH0gCisj ZW5kaWYKICAgICAgICAgCiAjaWYgRU5BQkxFKFRJTEVEX0JBQ0tJTkdfU1RPUkUpCiAgICAgICAg IHZpcnR1YWwgSW50UmVjdCB2aXNpYmxlUmVjdEZvclRpbGVkQmFja2luZ1N0b3JlKCkgY29uc3Qg eyByZXR1cm4gSW50UmVjdCgpOyB9CkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL01l ZGlhUGxheWVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL01l ZGlhUGxheWVyLmNwcAkocmV2aXNpb24gNzQxMzMpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL01lZGlhUGxheWVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjgsNiArMjgsOCBAQAogI2lm IEVOQUJMRShWSURFTykKICNpbmNsdWRlICJNZWRpYVBsYXllci5oIgogCisjaW5jbHVkZSAiQ2hy b21lLmgiIAorI2luY2x1ZGUgIkNocm9tZUNsaWVudC5oIgogI2luY2x1ZGUgIkNvbnRlbnRUeXBl LmgiCiAjaW5jbHVkZSAiRG9jdW1lbnQuaCIKICNpbmNsdWRlICJGcmFtZS5oIgpAQCAtNDMwLDYg KzQzMiwxOCBAQCBib29sIE1lZGlhUGxheWVyOjpzdXBwb3J0c0Z1bGxzY3JlZW4oKSBjCiAgICAg cmV0dXJuIG1fcHJpdmF0ZS0+c3VwcG9ydHNGdWxsc2NyZWVuKCk7CiB9CiAKK2Jvb2wgTWVkaWFQ bGF5ZXI6OnNob3VsZEZvcmNlRnVsbHNjcmVlblZpZGVvUGxheWJhY2soKSBjb25zdCAKK3sgCisg ICAgRG9jdW1lbnQqIGRvYyA9IGRvY3VtZW50KCk7IAorICAgIGlmICghZG9jIHx8ICFkb2MtPnBh Z2UoKSkgCisgICAgICAgIHJldHVybiBmYWxzZTsgCisKKyAgICBpZiAoZG9jLT5wYWdlKCktPmNo cm9tZSgpLT5jbGllbnQoKS0+c2hvdWxkRm9yY2VGdWxsU2NyZWVuVmlkZW9QbGF5YmFjaygpKSAK KyAgICAgICAgcmV0dXJuIHRydWU7IAorCisgICAgcmV0dXJuIGZhbHNlOyAKK30KKwogYm9vbCBN ZWRpYVBsYXllcjo6c3VwcG9ydHNTYXZlKCkgY29uc3QKIHsKICAgICByZXR1cm4gbV9wcml2YXRl LT5zdXBwb3J0c1NhdmUoKTsKQEAgLTQ1MCwxMiArNDY0LDE2IEBAIGJvb2wgTWVkaWFQbGF5ZXI6 Omhhc0F1ZGlvKCkgY29uc3QKICAgICByZXR1cm4gbV9wcml2YXRlLT5oYXNBdWRpbygpOwogfQog Ci1ib29sIE1lZGlhUGxheWVyOjppbk1lZGlhRG9jdW1lbnQoKQorRG9jdW1lbnQqIE1lZGlhUGxh eWVyOjpkb2N1bWVudCgpIGNvbnN0CiB7CiAgICAgRnJhbWUqIGZyYW1lID0gbV9mcmFtZVZpZXcg PyBtX2ZyYW1lVmlldy0+ZnJhbWUoKSA6IDA7Ci0gICAgRG9jdW1lbnQqIGRvY3VtZW50ID0gZnJh bWUgPyBmcmFtZS0+ZG9jdW1lbnQoKSA6IDA7Ci0gICAgCi0gICAgcmV0dXJuIGRvY3VtZW50ICYm IGRvY3VtZW50LT5pc01lZGlhRG9jdW1lbnQoKTsKKyAgICByZXR1cm4gZnJhbWUgPyBmcmFtZS0+ ZG9jdW1lbnQoKSA6IDA7Cit9CisKK2Jvb2wgTWVkaWFQbGF5ZXI6OmluTWVkaWFEb2N1bWVudCgp IAoreyAKKyAgICBEb2N1bWVudCogZG9jID0gZG9jdW1lbnQoKTsgCisgICAgcmV0dXJuIGRvYyAm JiBkb2MtPmlzTWVkaWFEb2N1bWVudCgpOyAKIH0KIAogUGxhdGZvcm1NZWRpYSBNZWRpYVBsYXll cjo6cGxhdGZvcm1NZWRpYSgpIGNvbnN0CkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L01lZGlhUGxheWVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9N ZWRpYVBsYXllci5oCShyZXZpc2lvbiA3NDEzMykKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvTWVkaWFQbGF5ZXIuaAkod29ya2luZyBjb3B5KQpAQCAtMTY1LDYgKzE2NSw3IEBAIHB1Ymxp YzoKICAgICBzdGF0aWMgYm9vbCBpc0F2YWlsYWJsZSgpOwogCiAgICAgYm9vbCBzdXBwb3J0c0Z1 bGxzY3JlZW4oKSBjb25zdDsKKyAgICBib29sIHNob3VsZEZvcmNlRnVsbHNjcmVlblZpZGVvUGxh eWJhY2soKSBjb25zdDsKICAgICBib29sIHN1cHBvcnRzU2F2ZSgpIGNvbnN0OwogICAgIFBsYXRm b3JtTWVkaWEgcGxhdGZvcm1NZWRpYSgpIGNvbnN0OwogI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01Q T1NJVElORykKQEAgLTI4OCw2ICsyODksOCBAQCBwcml2YXRlOgogCiAgICAgc3RhdGljIHZvaWQg aW5pdGlhbGl6ZU1lZGlhRW5naW5lcygpOwogCisgICAgRG9jdW1lbnQqIGRvY3VtZW50KCkgY29u c3Q7CisKICAgICBNZWRpYVBsYXllckNsaWVudCogbV9tZWRpYVBsYXllckNsaWVudDsKICAgICBU aW1lcjxNZWRpYVBsYXllcj4gbV9yZWxvYWRUaW1lcjsKICAgICBPd25QdHI8TWVkaWFQbGF5ZXJQ cml2YXRlSW50ZXJmYWNlKj4gbV9wcml2YXRlOwo= 76764 2010-12-16 06:12:33 -0800 2010-12-16 08:17:46 -0800 minor changes 51133.patch text/plain 5347 max.hong.shen SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3NDE4NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjggQEAKKzIwMTAtMTItMTYgIFlpIFNoZW4gIDx5aS40LnNoZW5Abm9raWEuY29t PiwgVG9yIEFybmUgVmVzdGJvIDx0b3IuYXJuZS52ZXN0Ym9Abm9raWEuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFByb3ZpZGUgYW4gaW50ZXJm YWNlIHRvIGZvcmNlIHVzaW5nIGZ1bGxzY3JlZW4gbWVkaWFwbGF5ZXIKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUxMTMzCisKKyAgICAgICAgQWRkIENo cm9tZUNsaWVudDo6c2hvdWxkRm9yY2VGdWxsU2NyZWVuVmlkZW9QbGF5YmFjayB0byBmb3JjZSB3 ZWJraXQKKyAgICAgICAgdG8gbGF1bmNoIGZ1bGxzY3JlZW4gdmlkZW8gcGxheWVyIGZvciBwbGF5 aW5nIHRoZSBodG1sNSB2aWRlby4gVGhlIAorICAgICAgICBpZGVhIGlzIHRoYXQgYSBicm93c2Vy IHZlbmRvciBjYW4gc3BlY2lmeSB0aGlzIGJlaGF2aW9yIHRocm91Z2ggdGhlCisgICAgICAgIHBs YXRmb3JtIHBsdWdpbiBvciBzb21ldGhpbmcgZWxzZSBieSB1c2luZyB0aGlzIGludGVyZmFjZS4K KworICAgICAgICBObyBuZXcgdGVzdHMuIGFzIHRoZSBjaGFuZ2VzIHNob3VsZCBub3QgY2hhbmdl IGZ1bmN0aW9uYWxpdHkuCisKKyAgICAgICAgKiBodG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6dXBkYXRlUGxheVN0YXRlKToKKyAg ICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OmV4aXRGdWxsc2NyZWVuKToKKyAgICAg ICAgKiBwYWdlL0Nocm9tZUNsaWVudC5oOgorICAgICAgICAoV2ViQ29yZTo6Q2hyb21lQ2xpZW50 OjpzaG91bGRGb3JjZUZ1bGxTY3JlZW5WaWRlb1BsYXliYWNrKToKKyAgICAgICAgKiBwbGF0Zm9y bS9ncmFwaGljcy9NZWRpYVBsYXllci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXll cjo6c2hvdWxkRm9yY2VGdWxsc2NyZWVuVmlkZW9QbGF5YmFjayk6CisgICAgICAgIChXZWJDb3Jl OjpNZWRpYVBsYXllcjo6ZG9jdW1lbnQpOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXI6 OmluTWVkaWFEb2N1bWVudCk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvTWVkaWFQbGF5 ZXIuaDoKKwogMjAxMC0xMi0xNiAgWXVyeSBTZW1pa2hhdHNreSAgPHl1cnlzQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBVbnJldmlld2VkLiBGaXggQ2hyb21pdW0gTWFjIERlYnVnIENsYW5nIGNv bXBpbGF0aW9uLgpJbmRleDogV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAkocmV2aXNpb24gNzQx MzMpCisrKyBXZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTIxMDksNiArMjEwOSw5IEBAIHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6dXBkYXRlUGxheVN0 YXRlKCkKICAgICAgICAgaW52YWxpZGF0ZUNhY2hlZFRpbWUoKTsKIAogICAgICAgICBpZiAocGxh eWVyUGF1c2VkKSB7CisgICAgICAgICAgICBpZiAobV9wbGF5ZXItPnNob3VsZEZvcmNlRnVsbHNj cmVlblZpZGVvUGxheWJhY2soKSAmJiAhbV9pc0Z1bGxzY3JlZW4pCisgICAgICAgICAgICAgICAg ZW50ZXJGdWxsc2NyZWVuKCk7CisKICAgICAgICAgICAgIC8vIFNldCByYXRlIGJlZm9yZSBjYWxs aW5nIHBsYXkgaW4gY2FzZSB0aGUgcmF0ZSB3YXMgc2V0IGJlZm9yZSB0aGUgbWVkaWEgZW5naW5l IHdhcyBzZXR1cC4KICAgICAgICAgICAgIC8vIFRoZSBtZWRpYSBlbmdpbmUgc2hvdWxkIGp1c3Qg c3Rhc2ggdGhlIHJhdGUgc2luY2UgaXQgaXNuJ3QgYWxyZWFkeSBwbGF5aW5nLgogICAgICAgICAg ICAgbV9wbGF5ZXItPnNldFJhdGUobV9wbGF5YmFja1JhdGUpOwpAQCAtMjQyNCw2ICsyNDI3LDgg QEAgdm9pZCBIVE1MTWVkaWFFbGVtZW50OjpleGl0RnVsbHNjcmVlbigpCiAgICAgQVNTRVJUKG1f aXNGdWxsc2NyZWVuKTsKICAgICBtX2lzRnVsbHNjcmVlbiA9IGZhbHNlOwogICAgIGlmIChkb2N1 bWVudCgpICYmIGRvY3VtZW50KCktPnBhZ2UoKSkgeworICAgICAgICBpZiAobV9wbGF5ZXItPnNo b3VsZEZvcmNlRnVsbHNjcmVlblZpZGVvUGxheWJhY2soKSkKKyAgICAgICAgICAgIHBhdXNlSW50 ZXJuYWwoKTsKICAgICAgICAgZG9jdW1lbnQoKS0+cGFnZSgpLT5jaHJvbWUoKS0+Y2xpZW50KCkt PmV4aXRGdWxsc2NyZWVuRm9yTm9kZSh0aGlzKTsKICAgICAgICAgc2NoZWR1bGVFdmVudChldmVu dE5hbWVzKCkud2Via2l0ZW5kZnVsbHNjcmVlbkV2ZW50KTsKICAgICB9CkluZGV4OiBXZWJDb3Jl L3BhZ2UvQ2hyb21lQ2xpZW50LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wYWdlL0Nocm9tZUNs aWVudC5oCShyZXZpc2lvbiA3NDEzMykKKysrIFdlYkNvcmUvcGFnZS9DaHJvbWVDbGllbnQuaAko d29ya2luZyBjb3B5KQpAQCAtMjYyLDYgKzI2MiwxMCBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAg ICAgICAgIHZpcnR1YWwgdm9pZCBlbnRlckZ1bGxTY3JlZW5Gb3JFbGVtZW50KEVsZW1lbnQqKSB7 IH0KICAgICAgICAgdmlydHVhbCB2b2lkIGV4aXRGdWxsU2NyZWVuRm9yRWxlbWVudChFbGVtZW50 KikgeyB9CiAjZW5kaWYKKworI2lmIEVOQUJMRShWSURFTykgCisgICAgICAgIHZpcnR1YWwgYm9v bCBzaG91bGRGb3JjZUZ1bGxTY3JlZW5WaWRlb1BsYXliYWNrKCkgeyByZXR1cm4gZmFsc2U7IH0g CisjZW5kaWYKICAgICAgICAgCiAjaWYgRU5BQkxFKFRJTEVEX0JBQ0tJTkdfU1RPUkUpCiAgICAg ICAgIHZpcnR1YWwgSW50UmVjdCB2aXNpYmxlUmVjdEZvclRpbGVkQmFja2luZ1N0b3JlKCkgY29u c3QgeyByZXR1cm4gSW50UmVjdCgpOyB9CkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L01lZGlhUGxheWVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L01lZGlhUGxheWVyLmNwcAkocmV2aXNpb24gNzQxMzMpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL01lZGlhUGxheWVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjgsNiArMjgsOCBAQAog I2lmIEVOQUJMRShWSURFTykKICNpbmNsdWRlICJNZWRpYVBsYXllci5oIgogCisjaW5jbHVkZSAi Q2hyb21lLmgiIAorI2luY2x1ZGUgIkNocm9tZUNsaWVudC5oIgogI2luY2x1ZGUgIkNvbnRlbnRU eXBlLmgiCiAjaW5jbHVkZSAiRG9jdW1lbnQuaCIKICNpbmNsdWRlICJGcmFtZS5oIgpAQCAtNDMw LDYgKzQzMiwxNSBAQCBib29sIE1lZGlhUGxheWVyOjpzdXBwb3J0c0Z1bGxzY3JlZW4oKSBjCiAg ICAgcmV0dXJuIG1fcHJpdmF0ZS0+c3VwcG9ydHNGdWxsc2NyZWVuKCk7CiB9CiAKK2Jvb2wgTWVk aWFQbGF5ZXI6OnNob3VsZEZvcmNlRnVsbHNjcmVlblZpZGVvUGxheWJhY2soKSBjb25zdCAKK3sg CisgICAgRG9jdW1lbnQqIGRvYyA9IGRvY3VtZW50KCk7IAorICAgIGlmICghZG9jIHx8ICFkb2Mt PnBhZ2UoKSkgCisgICAgICAgIHJldHVybiBmYWxzZTsgCisKKyAgICByZXR1cm4gZG9jLT5wYWdl KCktPmNocm9tZSgpLT5jbGllbnQoKS0+c2hvdWxkRm9yY2VGdWxsU2NyZWVuVmlkZW9QbGF5YmFj aygpOworfQorCiBib29sIE1lZGlhUGxheWVyOjpzdXBwb3J0c1NhdmUoKSBjb25zdAogewogICAg IHJldHVybiBtX3ByaXZhdGUtPnN1cHBvcnRzU2F2ZSgpOwpAQCAtNDUwLDEyICs0NjEsMTYgQEAg Ym9vbCBNZWRpYVBsYXllcjo6aGFzQXVkaW8oKSBjb25zdAogICAgIHJldHVybiBtX3ByaXZhdGUt Pmhhc0F1ZGlvKCk7CiB9CiAKLWJvb2wgTWVkaWFQbGF5ZXI6OmluTWVkaWFEb2N1bWVudCgpCitE b2N1bWVudCogTWVkaWFQbGF5ZXI6OmRvY3VtZW50KCkgY29uc3QKIHsKICAgICBGcmFtZSogZnJh bWUgPSBtX2ZyYW1lVmlldyA/IG1fZnJhbWVWaWV3LT5mcmFtZSgpIDogMDsKLSAgICBEb2N1bWVu dCogZG9jdW1lbnQgPSBmcmFtZSA/IGZyYW1lLT5kb2N1bWVudCgpIDogMDsKLSAgICAKLSAgICBy ZXR1cm4gZG9jdW1lbnQgJiYgZG9jdW1lbnQtPmlzTWVkaWFEb2N1bWVudCgpOworICAgIHJldHVy biBmcmFtZSA/IGZyYW1lLT5kb2N1bWVudCgpIDogMDsKK30KKworYm9vbCBNZWRpYVBsYXllcjo6 aW5NZWRpYURvY3VtZW50KCkgCit7IAorICAgIERvY3VtZW50KiBkb2MgPSBkb2N1bWVudCgpOyAK KyAgICByZXR1cm4gZG9jICYmIGRvYy0+aXNNZWRpYURvY3VtZW50KCk7IAogfQogCiBQbGF0Zm9y bU1lZGlhIE1lZGlhUGxheWVyOjpwbGF0Zm9ybU1lZGlhKCkgY29uc3QKSW5kZXg6IFdlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvTWVkaWFQbGF5ZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL01lZGlhUGxheWVyLmgJKHJldmlzaW9uIDc0MTMzKQorKysgV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9NZWRpYVBsYXllci5oCSh3b3JraW5nIGNvcHkpCkBAIC0xNjUs NiArMTY1LDcgQEAgcHVibGljOgogICAgIHN0YXRpYyBib29sIGlzQXZhaWxhYmxlKCk7CiAKICAg ICBib29sIHN1cHBvcnRzRnVsbHNjcmVlbigpIGNvbnN0OworICAgIGJvb2wgc2hvdWxkRm9yY2VG dWxsc2NyZWVuVmlkZW9QbGF5YmFjaygpIGNvbnN0OwogICAgIGJvb2wgc3VwcG9ydHNTYXZlKCkg Y29uc3Q7CiAgICAgUGxhdGZvcm1NZWRpYSBwbGF0Zm9ybU1lZGlhKCkgY29uc3Q7CiAjaWYgVVNF KEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQpAQCAtMjg4LDYgKzI4OSw4IEBAIHByaXZhdGU6CiAK ICAgICBzdGF0aWMgdm9pZCBpbml0aWFsaXplTWVkaWFFbmdpbmVzKCk7CiAKKyAgICBEb2N1bWVu dCogZG9jdW1lbnQoKSBjb25zdDsKKwogICAgIE1lZGlhUGxheWVyQ2xpZW50KiBtX21lZGlhUGxh eWVyQ2xpZW50OwogICAgIFRpbWVyPE1lZGlhUGxheWVyPiBtX3JlbG9hZFRpbWVyOwogICAgIE93 blB0cjxNZWRpYVBsYXllclByaXZhdGVJbnRlcmZhY2UqPiBtX3ByaXZhdGU7Cg== 76770 2010-12-16 08:17:46 -0800 2010-12-16 10:50:38 -0800 updated with eric's suggestion 51133.patch text/plain 3077 max.hong.shen SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3NDE5MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjMgQEAKKzIwMTAtMTItMTYgIFlpIFNoZW4gIDx5aS40LnNoZW5Abm9raWEuY29t PiAsIFRvciBBcm5lIFZlc3RibyA8dG9yLmFybmUudmVzdGJvQG5va2lhLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQcm92aWRlIGFuIGludGVy ZmFjZSB0byByZXF1aXJlIHVzaW5nIGZ1bGxzY3JlZW4gbWVkaWFwbGF5ZXIKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUxMTMzCisKKyAgICAgICAgQWRk IENocm9tZUNsaWVudDo6cmVxdWlyZXNGdWxsc2NyZWVuRm9yVmlkZW9QbGF5YmFjayB0byByZXF1 aXJlIHdlYmtpdAorICAgICAgICB0byBsYXVuY2ggZnVsbHNjcmVlbiB2aWRlbyBwbGF5ZXIgZm9y IHBsYXlpbmcgdGhlIGh0bWw1IHZpZGVvLiBUaGUgCisgICAgICAgIGlkZWEgaXMgdGhhdCBhIGJy b3dzZXIgdmVuZG9yIGNhbiBzcGVjaWZ5IHRoaXMgYmVoYXZpb3IgdGhyb3VnaCB0aGUKKyAgICAg ICAgcGxhdGZvcm0gcGx1Z2luIG9yIHNvbWV0aGluZyBlbHNlIGJ5IHVzaW5nIHRoaXMgaW50ZXJm YWNlLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgYXMgdGhlIGNoYW5nZXMgc2hvdWxkIG5vdCBj aGFuZ2UgZnVuY3Rpb25hbGl0eS4KKworICAgICAgICAqIGh0bWwvSFRNTE1lZGlhRWxlbWVudC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MTWVkaWFFbGVtZW50Ojp1cGRhdGVQbGF5U3RhdGUp OgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6ZXhpdEZ1bGxzY3JlZW4pOgor ICAgICAgICAqIHBhZ2UvQ2hyb21lQ2xpZW50Lmg6CisgICAgICAgIChXZWJDb3JlOjpDaHJvbWVD bGllbnQ6OnJlcXVpcmVzRnVsbHNjcmVlbkZvclZpZGVvUGxheWJhY2spOgorCiAyMDEwLTEyLTE2 ICBQYXZlbCBQb2Rpdmlsb3YgIDxwb2Rpdmlsb3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IFl1cnkgU2VtaWtoYXRza3kuCkluZGV4OiBXZWJDb3JlL2h0bWwvSFRNTE1lZGlh RWxlbWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQu Y3BwCShyZXZpc2lvbiA3NDEzMykKKysrIFdlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNw cAkod29ya2luZyBjb3B5KQpAQCAtMjEwOSw2ICsyMTA5LDkgQEAgdm9pZCBIVE1MTWVkaWFFbGVt ZW50Ojp1cGRhdGVQbGF5U3RhdGUoKQogICAgICAgICBpbnZhbGlkYXRlQ2FjaGVkVGltZSgpOwog CiAgICAgICAgIGlmIChwbGF5ZXJQYXVzZWQpIHsKKyAgICAgICAgICAgIGlmIChkb2N1bWVudCgp ICYmIGRvY3VtZW50KCktPnBhZ2UoKSAmJiBkb2N1bWVudCgpLT5wYWdlKCktPmNocm9tZSgpLT5j bGllbnQoKS0+cmVxdWlyZXNGdWxsc2NyZWVuRm9yVmlkZW9QbGF5YmFjaygpICYmICFtX2lzRnVs bHNjcmVlbikKKyAgICAgICAgICAgICAgICBlbnRlckZ1bGxzY3JlZW4oKTsKKwogICAgICAgICAg ICAgLy8gU2V0IHJhdGUgYmVmb3JlIGNhbGxpbmcgcGxheSBpbiBjYXNlIHRoZSByYXRlIHdhcyBz ZXQgYmVmb3JlIHRoZSBtZWRpYSBlbmdpbmUgd2FzIHNldHVwLgogICAgICAgICAgICAgLy8gVGhl IG1lZGlhIGVuZ2luZSBzaG91bGQganVzdCBzdGFzaCB0aGUgcmF0ZSBzaW5jZSBpdCBpc24ndCBh bHJlYWR5IHBsYXlpbmcuCiAgICAgICAgICAgICBtX3BsYXllci0+c2V0UmF0ZShtX3BsYXliYWNr UmF0ZSk7CkBAIC0yNDI0LDcgKzI0MjcsMTAgQEAgdm9pZCBIVE1MTWVkaWFFbGVtZW50OjpleGl0 RnVsbHNjcmVlbigpCiAgICAgQVNTRVJUKG1faXNGdWxsc2NyZWVuKTsKICAgICBtX2lzRnVsbHNj cmVlbiA9IGZhbHNlOwogICAgIGlmIChkb2N1bWVudCgpICYmIGRvY3VtZW50KCktPnBhZ2UoKSkg ewotICAgICAgICBkb2N1bWVudCgpLT5wYWdlKCktPmNocm9tZSgpLT5jbGllbnQoKS0+ZXhpdEZ1 bGxzY3JlZW5Gb3JOb2RlKHRoaXMpOworICAgICAgICBDaHJvbWVDbGllbnQqIGNsaWVudCA9IGRv Y3VtZW50KCktPnBhZ2UoKS0+Y2hyb21lKCktPmNsaWVudCgpOworICAgICAgICBpZiAoY2xpZW50 LT5yZXF1aXJlc0Z1bGxzY3JlZW5Gb3JWaWRlb1BsYXliYWNrKCkpCisgICAgICAgICAgICBwYXVz ZUludGVybmFsKCk7CisgICAgICAgIGNsaWVudC0+ZXhpdEZ1bGxzY3JlZW5Gb3JOb2RlKHRoaXMp OwogICAgICAgICBzY2hlZHVsZUV2ZW50KGV2ZW50TmFtZXMoKS53ZWJraXRlbmRmdWxsc2NyZWVu RXZlbnQpOwogICAgIH0KIH0KSW5kZXg6IFdlYkNvcmUvcGFnZS9DaHJvbWVDbGllbnQuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvQ2hyb21lQ2xpZW50LmgJKHJldmlzaW9uIDc0MTMzKQor KysgV2ViQ29yZS9wYWdlL0Nocm9tZUNsaWVudC5oCSh3b3JraW5nIGNvcHkpCkBAIC0yNjIsNiAr MjYyLDEwIEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgdmlydHVhbCB2b2lkIGVudGVy RnVsbFNjcmVlbkZvckVsZW1lbnQoRWxlbWVudCopIHsgfQogICAgICAgICB2aXJ0dWFsIHZvaWQg ZXhpdEZ1bGxTY3JlZW5Gb3JFbGVtZW50KEVsZW1lbnQqKSB7IH0KICNlbmRpZgorCisjaWYgRU5B QkxFKFZJREVPKQorICAgICAgICB2aXJ0dWFsIGJvb2wgcmVxdWlyZXNGdWxsc2NyZWVuRm9yVmlk ZW9QbGF5YmFjaygpIHsgcmV0dXJuIGZhbHNlOyB9IAorI2VuZGlmCiAgICAgICAgIAogI2lmIEVO QUJMRShUSUxFRF9CQUNLSU5HX1NUT1JFKQogICAgICAgICB2aXJ0dWFsIEludFJlY3QgdmlzaWJs ZVJlY3RGb3JUaWxlZEJhY2tpbmdTdG9yZSgpIGNvbnN0IHsgcmV0dXJuIEludFJlY3QoKTsgfQo= 76785 2010-12-16 10:50:38 -0800 2010-12-16 12:43:04 -0800 add a new function to chrome, and make it calls chromeclient::requiresFullscreenForVideoPlayback 51133.patch text/plain 5003 max.hong.shen SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3NDE5OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjkgQEAKKzIwMTAtMTItMTYgIFlpIFNoZW4gIDx5aS40LnNoZW5Abm9raWEuY29t PiAsIFRvciBBcm5lIFZlc3RibyA8dG9yLmFybmUudmVzdGJvQG5va2lhLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQcm92aWRlIGFuIGludGVy ZmFjZSB0byByZXF1aXJlIHVzaW5nIGZ1bGxzY3JlZW4gbWVkaWFwbGF5ZXIKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUxMTMzCisKKyAgICAgICAgQWRk IENocm9tZUNsaWVudDo6cmVxdWlyZXNGdWxsc2NyZWVuRm9yVmlkZW9QbGF5YmFjayB0byByZXF1 aXJlIHdlYmtpdAorICAgICAgICB0byBsYXVuY2ggZnVsbHNjcmVlbiB2aWRlbyBwbGF5ZXIgZm9y IHBsYXlpbmcgdGhlIGh0bWw1IHZpZGVvLiBUaGUgCisgICAgICAgIGlkZWEgaXMgdGhhdCBhIGJy b3dzZXIgdmVuZG9yIGNhbiBzcGVjaWZ5IHRoaXMgYmVoYXZpb3IgdGhyb3VnaCB0aGUKKyAgICAg ICAgcGxhdGZvcm0gcGx1Z2luIG9yIHNvbWV0aGluZyBlbHNlIGJ5IHVzaW5nIHRoaXMgaW50ZXJm YWNlLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBuZWVkZWQgc2luY2UgdGhlcmUgaXMgbm8gZnVu Y3Rpb25hbGl0eSBjaGFuZ2UuCisKKyAgICAgICAgKiBodG1sL0hUTUxNZWRpYUVsZW1lbnQuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6dXBkYXRlUGxheVN0YXRlKToK KyAgICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OmVudGVyRnVsbHNjcmVlbik6Cisg ICAgICAgIChXZWJDb3JlOjpIVE1MTWVkaWFFbGVtZW50OjpleGl0RnVsbHNjcmVlbik6CisgICAg ICAgICogcGFnZS9DaHJvbWUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q2hyb21lOjplbnRlckZ1 bGxzY3JlZW5Gb3JOb2RlKToKKyAgICAgICAgKFdlYkNvcmU6OkNocm9tZTo6ZXhpdEZ1bGxzY3Jl ZW5Gb3JOb2RlKToKKyAgICAgICAgKFdlYkNvcmU6OkNocm9tZTo6cmVxdWlyZXNGdWxsc2NyZWVu Rm9yVmlkZW9QbGF5YmFjayk6CisgICAgICAgICogcGFnZS9DaHJvbWUuaDoKKyAgICAgICAgKiBw YWdlL0Nocm9tZUNsaWVudC5oOgorICAgICAgICAoV2ViQ29yZTo6Q2hyb21lQ2xpZW50OjpyZXF1 aXJlc0Z1bGxzY3JlZW5Gb3JWaWRlb1BsYXliYWNrKToKKwogMjAxMC0xMi0xNiAgUGF2ZWwgRmVs ZG1hbiAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBZdXJ5 IFNlbWlraGF0c2t5LgpJbmRleDogV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAkocmV2aXNpb24g NzQxMzMpCisrKyBXZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTMwLDcgKzMwLDYgQEAKIAogI2luY2x1ZGUgIkF0dHJpYnV0ZS5oIgogI2luY2x1ZGUg IkNocm9tZS5oIgotI2luY2x1ZGUgIkNocm9tZUNsaWVudC5oIgogI2luY2x1ZGUgIkNsaWVudFJl Y3QuaCIKICNpbmNsdWRlICJDbGllbnRSZWN0TGlzdC5oIgogI2luY2x1ZGUgIkNvbnRlbnRUeXBl LmgiCkBAIC0yMTA5LDYgKzIxMDgsOSBAQCB2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6OnVwZGF0ZVBs YXlTdGF0ZSgpCiAgICAgICAgIGludmFsaWRhdGVDYWNoZWRUaW1lKCk7CiAKICAgICAgICAgaWYg KHBsYXllclBhdXNlZCkgeworICAgICAgICAgICAgaWYgKGRvY3VtZW50KCkgJiYgZG9jdW1lbnQo KS0+cGFnZSgpICYmIGRvY3VtZW50KCktPnBhZ2UoKS0+Y2hyb21lKCktPnJlcXVpcmVzRnVsbHNj cmVlbkZvclZpZGVvUGxheWJhY2soKSAmJiAhbV9pc0Z1bGxzY3JlZW4pCisgICAgICAgICAgICAg ICAgZW50ZXJGdWxsc2NyZWVuKCk7CisKICAgICAgICAgICAgIC8vIFNldCByYXRlIGJlZm9yZSBj YWxsaW5nIHBsYXkgaW4gY2FzZSB0aGUgcmF0ZSB3YXMgc2V0IGJlZm9yZSB0aGUgbWVkaWEgZW5n aW5lIHdhcyBzZXR1cC4KICAgICAgICAgICAgIC8vIFRoZSBtZWRpYSBlbmdpbmUgc2hvdWxkIGp1 c3Qgc3Rhc2ggdGhlIHJhdGUgc2luY2UgaXQgaXNuJ3QgYWxyZWFkeSBwbGF5aW5nLgogICAgICAg ICAgICAgbV9wbGF5ZXItPnNldFJhdGUobV9wbGF5YmFja1JhdGUpOwpAQCAtMjQxMiw3ICsyNDE0 LDcgQEAgdm9pZCBIVE1MTWVkaWFFbGVtZW50OjplbnRlckZ1bGxzY3JlZW4oKQogICAgIEFTU0VS VCghbV9pc0Z1bGxzY3JlZW4pOwogICAgIG1faXNGdWxsc2NyZWVuID0gdHJ1ZTsKICAgICBpZiAo ZG9jdW1lbnQoKSAmJiBkb2N1bWVudCgpLT5wYWdlKCkpIHsKLSAgICAgICAgZG9jdW1lbnQoKS0+ cGFnZSgpLT5jaHJvbWUoKS0+Y2xpZW50KCktPmVudGVyRnVsbHNjcmVlbkZvck5vZGUodGhpcyk7 CisgICAgICAgIGRvY3VtZW50KCktPnBhZ2UoKS0+Y2hyb21lKCktPmVudGVyRnVsbHNjcmVlbkZv ck5vZGUodGhpcyk7CiAgICAgICAgIHNjaGVkdWxlRXZlbnQoZXZlbnROYW1lcygpLndlYmtpdGJl Z2luZnVsbHNjcmVlbkV2ZW50KTsKICAgICB9CiB9CkBAIC0yNDI0LDcgKzI0MjYsMTAgQEAgdm9p ZCBIVE1MTWVkaWFFbGVtZW50OjpleGl0RnVsbHNjcmVlbigpCiAgICAgQVNTRVJUKG1faXNGdWxs c2NyZWVuKTsKICAgICBtX2lzRnVsbHNjcmVlbiA9IGZhbHNlOwogICAgIGlmIChkb2N1bWVudCgp ICYmIGRvY3VtZW50KCktPnBhZ2UoKSkgewotICAgICAgICBkb2N1bWVudCgpLT5wYWdlKCktPmNo cm9tZSgpLT5jbGllbnQoKS0+ZXhpdEZ1bGxzY3JlZW5Gb3JOb2RlKHRoaXMpOworICAgICAgICBD aHJvbWUqIGNocm9tZSA9IGRvY3VtZW50KCktPnBhZ2UoKS0+Y2hyb21lKCk7CisgICAgICAgIGlm IChjaHJvbWUtPnJlcXVpcmVzRnVsbHNjcmVlbkZvclZpZGVvUGxheWJhY2soKSkKKyAgICAgICAg ICAgIHBhdXNlSW50ZXJuYWwoKTsKKyAgICAgICAgY2hyb21lLT5leGl0RnVsbHNjcmVlbkZvck5v ZGUodGhpcyk7CiAgICAgICAgIHNjaGVkdWxlRXZlbnQoZXZlbnROYW1lcygpLndlYmtpdGVuZGZ1 bGxzY3JlZW5FdmVudCk7CiAgICAgfQogfQpJbmRleDogV2ViQ29yZS9wYWdlL0Nocm9tZS5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViQ29yZS9wYWdlL0Nocm9tZS5jcHAJKHJldmlzaW9uIDc0MTMzKQor KysgV2ViQ29yZS9wYWdlL0Nocm9tZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTUyMSw0ICs1MjEs MTkgQEAgdm9pZCBDaHJvbWU6OnNob3dDb250ZXh0TWVudSgpCiB9CiAjZW5kaWYKIAordm9pZCBD aHJvbWU6OmVudGVyRnVsbHNjcmVlbkZvck5vZGUoTm9kZSogbm9kZSkKK3sKKyAgICBtX2NsaWVu dC0+ZW50ZXJGdWxsc2NyZWVuRm9yTm9kZShub2RlKTsKK30KKwordm9pZCBDaHJvbWU6OmV4aXRG dWxsc2NyZWVuRm9yTm9kZShOb2RlKiBub2RlKQoreworICAgIG1fY2xpZW50LT5leGl0RnVsbHNj cmVlbkZvck5vZGUobm9kZSk7Cit9CisKK2Jvb2wgQ2hyb21lOjpyZXF1aXJlc0Z1bGxzY3JlZW5G b3JWaWRlb1BsYXliYWNrKCkKK3sKKyAgICByZXR1cm4gbV9jbGllbnQtPnJlcXVpcmVzRnVsbHNj cmVlbkZvclZpZGVvUGxheWJhY2soKTsKK30KKwogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpJbmRl eDogV2ViQ29yZS9wYWdlL0Nocm9tZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGFnZS9DaHJv bWUuaAkocmV2aXNpb24gNzQxMzMpCisrKyBXZWJDb3JlL3BhZ2UvQ2hyb21lLmgJKHdvcmtpbmcg Y29weSkKQEAgLTE0OSw2ICsxNDksMTAgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiAgICAgICAg IHZvaWQgZGlzcGF0Y2hWaWV3cG9ydERhdGFEaWRDaGFuZ2UoY29uc3QgVmlld3BvcnRBcmd1bWVu dHMmKSBjb25zdDsKIAorICAgICAgICB2b2lkIGVudGVyRnVsbHNjcmVlbkZvck5vZGUoTm9kZSop OworICAgICAgICB2b2lkIGV4aXRGdWxsc2NyZWVuRm9yTm9kZShOb2RlKik7CisgICAgICAgIGJv b2wgcmVxdWlyZXNGdWxsc2NyZWVuRm9yVmlkZW9QbGF5YmFjaygpOworCiAjaWYgUExBVEZPUk0o TUFDKQogICAgICAgICB2b2lkIGZvY3VzTlNWaWV3KE5TVmlldyopOwogI2VuZGlmCkluZGV4OiBX ZWJDb3JlL3BhZ2UvQ2hyb21lQ2xpZW50LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wYWdlL0No cm9tZUNsaWVudC5oCShyZXZpc2lvbiA3NDEzMykKKysrIFdlYkNvcmUvcGFnZS9DaHJvbWVDbGll bnQuaAkod29ya2luZyBjb3B5KQpAQCAtMjU2LDYgKzI1Niw3IEBAIG5hbWVzcGFjZSBXZWJDb3Jl IHsKICAgICAgICAgdmlydHVhbCBib29sIHN1cHBvcnRzRnVsbHNjcmVlbkZvck5vZGUoY29uc3Qg Tm9kZSopIHsgcmV0dXJuIGZhbHNlOyB9CiAgICAgICAgIHZpcnR1YWwgdm9pZCBlbnRlckZ1bGxz Y3JlZW5Gb3JOb2RlKE5vZGUqKSB7IH0KICAgICAgICAgdmlydHVhbCB2b2lkIGV4aXRGdWxsc2Ny ZWVuRm9yTm9kZShOb2RlKikgeyB9CisgICAgICAgIHZpcnR1YWwgYm9vbCByZXF1aXJlc0Z1bGxz Y3JlZW5Gb3JWaWRlb1BsYXliYWNrKCkgeyByZXR1cm4gZmFsc2U7IH0gCiAKICNpZiBFTkFCTEUo RlVMTFNDUkVFTl9BUEkpCiAgICAgICAgIHZpcnR1YWwgYm9vbCBzdXBwb3J0c0Z1bGxTY3JlZW5G b3JFbGVtZW50KGNvbnN0IEVsZW1lbnQqKSB7IHJldHVybiBmYWxzZTsgfQo= 76802 2010-12-16 12:43:04 -0800 2010-12-16 13:50:16 -0800 updated with Jer's suggestion 51133.patch text/plain 3895 max.hong.shen SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3NDIwNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjYgQEAKKzIwMTAtMTItMTYgIFlpIFNoZW4gIDx5aS40LnNoZW5Abm9raWEuY29t PiwgVG9yIEFybmUgVmVzdGJvIDx0b3IuYXJuZS52ZXN0Ym9Abm9raWEuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFByb3ZpZGUgYW4gaW50ZXJm YWNlIHRvIHJlcXVpcmUgdXNpbmcgZnVsbHNjcmVlbiBtZWRpYXBsYXllcgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTExMzMKKworICAgICAgICBBZGQg Q2hyb21lQ2xpZW50OjpyZXF1aXJlc0Z1bGxzY3JlZW5Gb3JWaWRlb1BsYXliYWNrIHRvIHJlcXVp cmUgd2Via2l0CisgICAgICAgIHRvIGxhdW5jaCBmdWxsc2NyZWVuIHZpZGVvIHBsYXllciBmb3Ig cGxheWluZyB0aGUgaHRtbDUgdmlkZW8uIFRoZSAKKyAgICAgICAgaWRlYSBpcyB0aGF0IGEgYnJv d3NlciB2ZW5kb3IgY2FuIHNwZWNpZnkgdGhpcyBiZWhhdmlvciB0aHJvdWdoIHRoZQorICAgICAg ICBwbGF0Zm9ybSBwbHVnaW4gb3Igc29tZXRoaW5nIGVsc2UgYnkgdXNpbmcgdGhpcyBpbnRlcmZh Y2UuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIG5lZWRlZCBzaW5jZSB0aGVyZSBpcyBubyBmdW5j dGlvbmFsaXR5IGNoYW5nZS4KKworICAgICAgICAqIGh0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpIVE1MTWVkaWFFbGVtZW50Ojp1cGRhdGVQbGF5U3RhdGUpOgor ICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6ZXhpdEZ1bGxzY3JlZW4pOgorICAg ICAgICAqIHBhZ2UvQ2hyb21lLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNocm9tZTo6cmVxdWly ZXNGdWxsc2NyZWVuRm9yVmlkZW9QbGF5YmFjayk6CisgICAgICAgICogcGFnZS9DaHJvbWUuaDoK KyAgICAgICAgKiBwYWdlL0Nocm9tZUNsaWVudC5oOgorICAgICAgICAoV2ViQ29yZTo6Q2hyb21l Q2xpZW50OjpyZXF1aXJlc0Z1bGxzY3JlZW5Gb3JWaWRlb1BsYXliYWNrKToKKwogMjAxMC0xMi0x NiAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBEYXJpbiBBZGxlci4KSW5kZXg6IFdlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAJKHJldmlzaW9u IDc0MjAxKQorKysgV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0yMTA5LDYgKzIxMDksOSBAQCB2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6OnVwZGF0ZVBs YXlTdGF0ZSgpCiAgICAgICAgIGludmFsaWRhdGVDYWNoZWRUaW1lKCk7CiAKICAgICAgICAgaWYg KHBsYXllclBhdXNlZCkgeworICAgICAgICAgICAgaWYgKGRvY3VtZW50KCkgJiYgZG9jdW1lbnQo KS0+cGFnZSgpICYmIGRvY3VtZW50KCktPnBhZ2UoKS0+Y2hyb21lKCktPnJlcXVpcmVzRnVsbHNj cmVlbkZvclZpZGVvUGxheWJhY2soKSAmJiAhbV9pc0Z1bGxzY3JlZW4pCisgICAgICAgICAgICAg ICAgZW50ZXJGdWxsc2NyZWVuKCk7CisKICAgICAgICAgICAgIC8vIFNldCByYXRlIGJlZm9yZSBj YWxsaW5nIHBsYXkgaW4gY2FzZSB0aGUgcmF0ZSB3YXMgc2V0IGJlZm9yZSB0aGUgbWVkaWEgZW5n aW5lIHdhcyBzZXR1cC4KICAgICAgICAgICAgIC8vIFRoZSBtZWRpYSBlbmdpbmUgc2hvdWxkIGp1 c3Qgc3Rhc2ggdGhlIHJhdGUgc2luY2UgaXQgaXNuJ3QgYWxyZWFkeSBwbGF5aW5nLgogICAgICAg ICAgICAgbV9wbGF5ZXItPnNldFJhdGUobV9wbGF5YmFja1JhdGUpOwpAQCAtMjQyNCw2ICsyNDI3 LDggQEAgdm9pZCBIVE1MTWVkaWFFbGVtZW50OjpleGl0RnVsbHNjcmVlbigpCiAgICAgQVNTRVJU KG1faXNGdWxsc2NyZWVuKTsKICAgICBtX2lzRnVsbHNjcmVlbiA9IGZhbHNlOwogICAgIGlmIChk b2N1bWVudCgpICYmIGRvY3VtZW50KCktPnBhZ2UoKSkgeworICAgICAgICBpZiAoZG9jdW1lbnQo KS0+cGFnZSgpLT5jaHJvbWUoKS0+cmVxdWlyZXNGdWxsc2NyZWVuRm9yVmlkZW9QbGF5YmFjaygp KQorICAgICAgICAgICAgcGF1c2VJbnRlcm5hbCgpOwogICAgICAgICBkb2N1bWVudCgpLT5wYWdl KCktPmNocm9tZSgpLT5jbGllbnQoKS0+ZXhpdEZ1bGxzY3JlZW5Gb3JOb2RlKHRoaXMpOwogICAg ICAgICBzY2hlZHVsZUV2ZW50KGV2ZW50TmFtZXMoKS53ZWJraXRlbmRmdWxsc2NyZWVuRXZlbnQp OwogICAgIH0KSW5kZXg6IFdlYkNvcmUvcGFnZS9DaHJvbWUuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YkNvcmUvcGFnZS9DaHJvbWUuY3BwCShyZXZpc2lvbiA3NDIwMSkKKysrIFdlYkNvcmUvcGFnZS9D aHJvbWUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01MjEsNCArNTIxLDkgQEAgdm9pZCBDaHJvbWU6 OnNob3dDb250ZXh0TWVudSgpCiB9CiAjZW5kaWYKIAorYm9vbCBDaHJvbWU6OnJlcXVpcmVzRnVs bHNjcmVlbkZvclZpZGVvUGxheWJhY2soKQoreworICAgIHJldHVybiBtX2NsaWVudC0+cmVxdWly ZXNGdWxsc2NyZWVuRm9yVmlkZW9QbGF5YmFjaygpOworfQorCiB9IC8vIG5hbWVzcGFjZSBXZWJD b3JlCkluZGV4OiBXZWJDb3JlL3BhZ2UvQ2hyb21lLmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9w YWdlL0Nocm9tZS5oCShyZXZpc2lvbiA3NDIwMSkKKysrIFdlYkNvcmUvcGFnZS9DaHJvbWUuaAko d29ya2luZyBjb3B5KQpAQCAtMTQ5LDYgKzE0OSw4IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAog ICAgICAgICB2b2lkIGRpc3BhdGNoVmlld3BvcnREYXRhRGlkQ2hhbmdlKGNvbnN0IFZpZXdwb3J0 QXJndW1lbnRzJikgY29uc3Q7CiAKKyAgICAgICAgYm9vbCByZXF1aXJlc0Z1bGxzY3JlZW5Gb3JW aWRlb1BsYXliYWNrKCk7CisKICNpZiBQTEFURk9STShNQUMpCiAgICAgICAgIHZvaWQgZm9jdXNO U1ZpZXcoTlNWaWV3Kik7CiAjZW5kaWYKSW5kZXg6IFdlYkNvcmUvcGFnZS9DaHJvbWVDbGllbnQu aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvQ2hyb21lQ2xpZW50LmgJKHJldmlzaW9uIDc0 MjAxKQorKysgV2ViQ29yZS9wYWdlL0Nocm9tZUNsaWVudC5oCSh3b3JraW5nIGNvcHkpCkBAIC0y NTYsNiArMjU2LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICB2aXJ0dWFsIGJvb2wg c3VwcG9ydHNGdWxsc2NyZWVuRm9yTm9kZShjb25zdCBOb2RlKikgeyByZXR1cm4gZmFsc2U7IH0K ICAgICAgICAgdmlydHVhbCB2b2lkIGVudGVyRnVsbHNjcmVlbkZvck5vZGUoTm9kZSopIHsgfQog ICAgICAgICB2aXJ0dWFsIHZvaWQgZXhpdEZ1bGxzY3JlZW5Gb3JOb2RlKE5vZGUqKSB7IH0KKyAg ICAgICAgdmlydHVhbCBib29sIHJlcXVpcmVzRnVsbHNjcmVlbkZvclZpZGVvUGxheWJhY2soKSB7 IHJldHVybiBmYWxzZTsgfSAKIAogI2lmIEVOQUJMRShGVUxMU0NSRUVOX0FQSSkKICAgICAgICAg dmlydHVhbCBib29sIHN1cHBvcnRzRnVsbFNjcmVlbkZvckVsZW1lbnQoY29uc3QgRWxlbWVudCop IHsgcmV0dXJuIGZhbHNlOyB9Cg== 76812 2010-12-16 13:50:16 -0800 2010-12-16 19:29:04 -0800 fix changelog 51133.patch text/plain 0 max.hong.shen 77842 2011-01-03 13:40:35 -0800 2011-01-03 13:45:13 -0800 a small fix for video to enter the fullscreen mode 51133-v1.patch text/plain 1568 max.hong.shen SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3NDkyOSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMTEtMDEtMDMgIFlpIFNoZW4gIDx5aS40LnNoZW5Abm9raWEuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFByb3Zp ZGUgYW4gaW50ZXJmYWNlIHRvIHJlcXVpcmUgdXNpbmcgZnVsbHNjcmVlbiBtZWRpYXBsYXllcgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTExMzMKKwor ICAgICAgICBPbmx5IHZpZGVvIHNob3VsZCBiZSBkaXNwbGF5ZWQgaW4gZnVsbHNjcmVlbiB3aGVu IAorICAgICAgICByZXF1aXJlc0Z1bGxzY3JlZW5Gb3JWaWRlb1BsYXliYWNrIGlzIHNwZWNmaWVk LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBiZWNhdXNlIG5vIGNsaWVudCBpbXBsZW1lbnRzIHJl cXVpcmVzRnVsbHNjcmVlbkZvclZpZGVvUGxheWJhY2sgeWV0LgorCisgICAgICAgICogaHRtbC9I VE1MTWVkaWFFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6 OnVwZGF0ZVBsYXlTdGF0ZSk6CisKIDIwMTEtMDEtMDMgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25A YXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpJbmRleDogV2Vi Q29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvaHRt bC9IVE1MTWVkaWFFbGVtZW50LmNwcAkocmV2aXNpb24gNzQ5MjMpCisrKyBXZWJDb3JlL2h0bWwv SFRNTE1lZGlhRWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIxMDksNyArMjEwOSw3IEBA IHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6dXBkYXRlUGxheVN0YXRlKCkKICAgICAgICAgaW52YWxp ZGF0ZUNhY2hlZFRpbWUoKTsKIAogICAgICAgICBpZiAocGxheWVyUGF1c2VkKSB7Ci0gICAgICAg ICAgICBpZiAoZG9jdW1lbnQoKSAmJiBkb2N1bWVudCgpLT5wYWdlKCkgJiYgZG9jdW1lbnQoKS0+ cGFnZSgpLT5jaHJvbWUoKS0+cmVxdWlyZXNGdWxsc2NyZWVuRm9yVmlkZW9QbGF5YmFjaygpICYm ICFtX2lzRnVsbHNjcmVlbikKKyAgICAgICAgICAgIGlmICghbV9pc0Z1bGxzY3JlZW4gJiYgaXNW aWRlbygpICYmIGRvY3VtZW50KCkgJiYgZG9jdW1lbnQoKS0+cGFnZSgpICYmIGRvY3VtZW50KCkt PnBhZ2UoKS0+Y2hyb21lKCktPnJlcXVpcmVzRnVsbHNjcmVlbkZvclZpZGVvUGxheWJhY2soKSkK ICAgICAgICAgICAgICAgICBlbnRlckZ1bGxzY3JlZW4oKTsKIAogICAgICAgICAgICAgLy8gU2V0 IHJhdGUgYmVmb3JlIGNhbGxpbmcgcGxheSBpbiBjYXNlIHRoZSByYXRlIHdhcyBzZXQgYmVmb3Jl IHRoZSBtZWRpYSBlbmdpbmUgd2FzIHNldHVwLgo= 77843 2011-01-03 13:45:13 -0800 2011-01-04 05:17:58 -0800 fix typo 51133-v1.patch text/plain 1569 max.hong.shen SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3NDkyOSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMTEtMDEtMDMgIFlpIFNoZW4gIDx5aS40LnNoZW5Abm9raWEuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFByb3Zp ZGUgYW4gaW50ZXJmYWNlIHRvIHJlcXVpcmUgdXNpbmcgZnVsbHNjcmVlbiBtZWRpYXBsYXllcgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTExMzMKKwor ICAgICAgICBPbmx5IHZpZGVvIHNob3VsZCBiZSBkaXNwbGF5ZWQgaW4gZnVsbHNjcmVlbiB3aGVu IAorICAgICAgICByZXF1aXJlc0Z1bGxzY3JlZW5Gb3JWaWRlb1BsYXliYWNrIGlzIHNwZWNpZmll ZC4KKworICAgICAgICBObyBuZXcgdGVzdHMgYmVjYXVzZSBubyBjbGllbnQgaW1wbGVtZW50cyBy ZXF1aXJlc0Z1bGxzY3JlZW5Gb3JWaWRlb1BsYXliYWNrIHlldC4KKworICAgICAgICAqIGh0bWwv SFRNTE1lZGlhRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MTWVkaWFFbGVtZW50 Ojp1cGRhdGVQbGF5U3RhdGUpOgorCiAyMDExLTAxLTAzICBCcmFkeSBFaWRzb24gIDxiZWlkc29u QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IFdl YkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2h0 bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAJKHJldmlzaW9uIDc0OTIzKQorKysgV2ViQ29yZS9odG1s L0hUTUxNZWRpYUVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMTA5LDcgKzIxMDksNyBA QCB2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6OnVwZGF0ZVBsYXlTdGF0ZSgpCiAgICAgICAgIGludmFs aWRhdGVDYWNoZWRUaW1lKCk7CiAKICAgICAgICAgaWYgKHBsYXllclBhdXNlZCkgewotICAgICAg ICAgICAgaWYgKGRvY3VtZW50KCkgJiYgZG9jdW1lbnQoKS0+cGFnZSgpICYmIGRvY3VtZW50KCkt PnBhZ2UoKS0+Y2hyb21lKCktPnJlcXVpcmVzRnVsbHNjcmVlbkZvclZpZGVvUGxheWJhY2soKSAm JiAhbV9pc0Z1bGxzY3JlZW4pCisgICAgICAgICAgICBpZiAoIW1faXNGdWxsc2NyZWVuICYmIGlz VmlkZW8oKSAmJiBkb2N1bWVudCgpICYmIGRvY3VtZW50KCktPnBhZ2UoKSAmJiBkb2N1bWVudCgp LT5wYWdlKCktPmNocm9tZSgpLT5yZXF1aXJlc0Z1bGxzY3JlZW5Gb3JWaWRlb1BsYXliYWNrKCkp CiAgICAgICAgICAgICAgICAgZW50ZXJGdWxsc2NyZWVuKCk7CiAKICAgICAgICAgICAgIC8vIFNl dCByYXRlIGJlZm9yZSBjYWxsaW5nIHBsYXkgaW4gY2FzZSB0aGUgcmF0ZSB3YXMgc2V0IGJlZm9y ZSB0aGUgbWVkaWEgZW5naW5lIHdhcyBzZXR1cC4K