51127 2010-12-15 12:17:40 -0800 Web Inspector: timeline records should only operate WebCore time. 2010-12-16 15:39:32 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman abarth apavlov bweinstein commit-queue eric jaimeyap joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 322744 0 pfeldman 2010-12-15 12:17:40 -0800 Network timing and such should belong to the data / aux properties. Primary timing info in timeline should be taken by means of currentTime in WebCore. 322747 1 76679 pfeldman 2010-12-15 12:22:30 -0800 Created attachment 76679 [PATCH] Proposed change 322778 2 76679 yurys 2010-12-15 13:19:30 -0800 Comment on attachment 76679 [PATCH] Proposed change > // Sometimes network stack can provide for us exact finish loading time. In the other case we will use currentTime. The comment should be removed too. But at the first place what's wrong with using the time provided by the network stack? 322799 3 jaimeyap 2010-12-15 13:53:54 -0800 (In reply to comment #2) > (From update of attachment 76679 [details]) > > // Sometimes network stack can provide for us exact finish loading time. In the other case we will use currentTime. > The comment should be removed too. But at the first place what's wrong with using the time provided by the network stack? You can (and actually do in practice) end up with the time reported in the finish being well before the time reported by the response received event. In general, the timeline agent has a contract that it records times in WebCore on the UI thread. It has strict ordering guarantees, and the timestamps should follow this. Also, the network stack and resource loader will be out of process in chrome, so the webcore callbacks get invoked after some Async IPC action. So the common case will be this time wont make sense when combined with the responsetime taken in webcore on the UI thread. Basically negative time deltas (end - responseReceived) is incorrect for the timeline agent. 323213 4 76679 commit-queue 2010-12-16 09:25:16 -0800 Comment on attachment 76679 [PATCH] Proposed change Rejecting attachment 76679 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'apply-attachment', '--non-interactive', 76679]" exit_code: 2 Last 500 characters of output: ailed to merge in the changes. Patch failed at 0001 2010-12-16 Yury Semikhatsky <yurys@chromium.org> When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at WebKitTools/Scripts/update-webkit line 132. Failed to run "['WebKitTools/Scripts/update-webkit']" exit_code: 2 Full output: http://queues.webkit.org/results/7131071 323236 5 76679 pfeldman 2010-12-16 10:01:40 -0800 Comment on attachment 76679 [PATCH] Proposed change Clearing flags on attachment: 76679 Committed r74198: <http://trac.webkit.org/changeset/74198> 323237 6 pfeldman 2010-12-16 10:01:51 -0800 All reviewed patches have been landed. Closing bug. 323476 7 webkit.review.bot 2010-12-16 15:39:26 -0800 http://trac.webkit.org/changeset/74198 might have broken Leopard Intel Debug (Tests) 323477 8 webkit.review.bot 2010-12-16 15:39:32 -0800 http://trac.webkit.org/changeset/74199 might have broken Leopard Intel Debug (Tests) 76679 2010-12-15 12:22:30 -0800 2010-12-16 10:01:40 -0800 [PATCH] Proposed change resource_timing text/plain 3424 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NTY0NzU2YS4uYmYyY2M5MCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0xMi0xNSAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiB0aW1lbGluZSByZWNvcmRzIHNob3Vs ZCBvbmx5IG9wZXJhdGUgV2ViQ29yZSB0aW1lLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTExMjcKKworICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0 b3JUaW1lbGluZUFnZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvclRpbWVsaW5l QWdlbnQ6OmRpZEZpbmlzaExvYWRpbmdSZXNvdXJjZSk6CisgICAgICAgICogaW5zcGVjdG9yL1Rp bWVsaW5lUmVjb3JkRmFjdG9yeS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpUaW1lbGluZVJlY29y ZEZhY3Rvcnk6OmNyZWF0ZVJlc291cmNlRmluaXNoRGF0YSk6CisgICAgICAgICogaW5zcGVjdG9y L1RpbWVsaW5lUmVjb3JkRmFjdG9yeS5oOgorCiAyMDEwLTEyLTE0ICBDaGFybGllIFJlaXMgIDxj cmVpc0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCmRp ZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JUaW1lbGluZUFnZW50LmNwcCBi L1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclRpbWVsaW5lQWdlbnQuY3BwCmluZGV4IDY0NWI2 OTIuLjc0NzM5ZTEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclRpbWVs aW5lQWdlbnQuY3BwCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclRpbWVsaW5lQWdl bnQuY3BwCkBAIC0yNDQsOCArMjQ0LDggQEAgdm9pZCBJbnNwZWN0b3JUaW1lbGluZUFnZW50Ojpk aWRGaW5pc2hMb2FkaW5nUmVzb3VyY2UodW5zaWduZWQgbG9uZyBpZGVudGlmaWVyLAogewogICAg IHB1c2hHQ0V2ZW50UmVjb3JkcygpOwogICAgIC8vIFNvbWV0aW1lcyBuZXR3b3JrIHN0YWNrIGNh biBwcm92aWRlIGZvciB1cyBleGFjdCBmaW5pc2ggbG9hZGluZyB0aW1lLiBJbiB0aGUgb3RoZXIg Y2FzZSB3ZSB3aWxsIHVzZSBjdXJyZW50VGltZS4KLSAgICBSZWZQdHI8SW5zcGVjdG9yT2JqZWN0 PiByZWNvcmQgPSBUaW1lbGluZVJlY29yZEZhY3Rvcnk6OmNyZWF0ZUdlbmVyaWNSZWNvcmQoZmlu aXNoVGltZSA/IGZpbmlzaFRpbWUgKiAxMDAwIDogV1RGOjpjdXJyZW50VGltZU1TKCkpOwotICAg IHJlY29yZC0+c2V0T2JqZWN0KCJkYXRhIiwgVGltZWxpbmVSZWNvcmRGYWN0b3J5OjpjcmVhdGVS ZXNvdXJjZUZpbmlzaERhdGEoaWRlbnRpZmllciwgZGlkRmFpbCkpOworICAgIFJlZlB0cjxJbnNw ZWN0b3JPYmplY3Q+IHJlY29yZCA9IFRpbWVsaW5lUmVjb3JkRmFjdG9yeTo6Y3JlYXRlR2VuZXJp Y1JlY29yZChXVEY6OmN1cnJlbnRUaW1lTVMoKSk7CisgICAgcmVjb3JkLT5zZXRPYmplY3QoImRh dGEiLCBUaW1lbGluZVJlY29yZEZhY3Rvcnk6OmNyZWF0ZVJlc291cmNlRmluaXNoRGF0YShpZGVu dGlmaWVyLCBkaWRGYWlsLCBmaW5pc2hUaW1lICogMTAwMCkpOwogICAgIHJlY29yZC0+c2V0TnVt YmVyKCJ0eXBlIiwgUmVzb3VyY2VGaW5pc2hUaW1lbGluZVJlY29yZFR5cGUpOwogICAgIHNldEhl YXBTaXplU3RhdGlzdGljKHJlY29yZC5nZXQoKSk7CiAgICAgbV9mcm9udGVuZC0+YWRkUmVjb3Jk VG9UaW1lbGluZShyZWNvcmQucmVsZWFzZSgpKTsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVj dG9yL1RpbWVsaW5lUmVjb3JkRmFjdG9yeS5jcHAgYi9XZWJDb3JlL2luc3BlY3Rvci9UaW1lbGlu ZVJlY29yZEZhY3RvcnkuY3BwCmluZGV4IDM0MTc2NzQuLjdmMzM5Y2QgMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvaW5zcGVjdG9yL1RpbWVsaW5lUmVjb3JkRmFjdG9yeS5jcHAKKysrIGIvV2ViQ29yZS9p bnNwZWN0b3IvVGltZWxpbmVSZWNvcmRGYWN0b3J5LmNwcApAQCAtMTQ5LDExICsxNDksMTMgQEAg UGFzc1JlZlB0cjxJbnNwZWN0b3JPYmplY3Q+IFRpbWVsaW5lUmVjb3JkRmFjdG9yeTo6Y3JlYXRl UmVzb3VyY2VSZWNlaXZlUmVzcG9uc2UKICAgICByZXR1cm4gZGF0YS5yZWxlYXNlKCk7CiB9CiAK LVBhc3NSZWZQdHI8SW5zcGVjdG9yT2JqZWN0PiBUaW1lbGluZVJlY29yZEZhY3Rvcnk6OmNyZWF0 ZVJlc291cmNlRmluaXNoRGF0YSh1bnNpZ25lZCBsb25nIGlkZW50aWZpZXIsIGJvb2wgZGlkRmFp bCkKK1Bhc3NSZWZQdHI8SW5zcGVjdG9yT2JqZWN0PiBUaW1lbGluZVJlY29yZEZhY3Rvcnk6OmNy ZWF0ZVJlc291cmNlRmluaXNoRGF0YSh1bnNpZ25lZCBsb25nIGlkZW50aWZpZXIsIGJvb2wgZGlk RmFpbCwgZG91YmxlIGZpbmlzaFRpbWUpCiB7CiAgICAgUmVmUHRyPEluc3BlY3Rvck9iamVjdD4g ZGF0YSA9IEluc3BlY3Rvck9iamVjdDo6Y3JlYXRlKCk7CiAgICAgZGF0YS0+c2V0TnVtYmVyKCJp ZGVudGlmaWVyIiwgaWRlbnRpZmllcik7CiAgICAgZGF0YS0+c2V0Qm9vbGVhbigiZGlkRmFpbCIs IGRpZEZhaWwpOworICAgIGlmIChmaW5pc2hUaW1lKQorICAgICAgICBkYXRhLT5zZXROdW1iZXIo Im5ldHdvcmtUaW1lIiwgZmluaXNoVGltZSk7CiAgICAgcmV0dXJuIGRhdGEucmVsZWFzZSgpOwog fQogCmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9UaW1lbGluZVJlY29yZEZhY3Rvcnku aCBiL1dlYkNvcmUvaW5zcGVjdG9yL1RpbWVsaW5lUmVjb3JkRmFjdG9yeS5oCmluZGV4IDUyZGRh MjUuLjVkNGNiNzcgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL1RpbWVsaW5lUmVjb3Jk RmFjdG9yeS5oCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL1RpbWVsaW5lUmVjb3JkRmFjdG9yeS5o CkBAIC03Myw3ICs3Myw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogICAgICAgICBzdGF0aWMg UGFzc1JlZlB0cjxJbnNwZWN0b3JPYmplY3Q+IGNyZWF0ZVJlY2VpdmVSZXNvdXJjZURhdGEodW5z aWduZWQgbG9uZyBpZGVudGlmaWVyKTsKIAotICAgICAgICBzdGF0aWMgUGFzc1JlZlB0cjxJbnNw ZWN0b3JPYmplY3Q+IGNyZWF0ZVJlc291cmNlRmluaXNoRGF0YSh1bnNpZ25lZCBsb25nIGlkZW50 aWZpZXIsIGJvb2wgZGlkRmFpbCk7CisgICAgICAgIHN0YXRpYyBQYXNzUmVmUHRyPEluc3BlY3Rv ck9iamVjdD4gY3JlYXRlUmVzb3VyY2VGaW5pc2hEYXRhKHVuc2lnbmVkIGxvbmcgaWRlbnRpZmll ciwgYm9vbCBkaWRGYWlsLCBkb3VibGUgZmluaXNoVGltZSk7CiAKICAgICAgICAgc3RhdGljIFBh c3NSZWZQdHI8SW5zcGVjdG9yT2JqZWN0PiBjcmVhdGVQYWludERhdGEoY29uc3QgSW50UmVjdCYp OwogCg==