51126 2010-12-15 12:06:26 -0800 Semi-reproducible crash in ChunkedUpdateDrawingArea::paintIntoUpdateChunk closing a particular yahoo page 2010-12-15 12:15:53 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 andersca andersca mjs oldest_to_newest 322735 0 andersca 2010-12-15 12:06:26 -0800 Semi-reproducible crash in ChunkedUpdateDrawingArea::paintIntoUpdateChunk closing a particular yahoo page 322736 1 andersca 2010-12-15 12:06:47 -0800 <rdar://problem/8771219> 322737 2 76678 andersca 2010-12-15 12:07:39 -0800 Created attachment 76678 Patch 322739 3 76678 mjs 2010-12-15 12:10:17 -0800 Comment on attachment 76678 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=76678&action=review > WebKit2/WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:97 > + // The drawing area changed, return early. This comment seems redundant with the code. > WebKit2/WebProcess/WebPage/LayerBackedDrawingArea.cpp:98 > + // The drawing area changed, return early. This comment seems redundant with the code. > WebKit2/WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm:172 > + // The drawing area changed, return early. This comment seems redundant with the code. 322740 4 mjs 2010-12-15 12:10:32 -0800 (r=me with those suggestions) 322742 5 andersca 2010-12-15 12:15:53 -0800 Committed r74134: <http://trac.webkit.org/changeset/74134> 76678 2010-12-15 12:07:39 -0800 2010-12-15 12:10:17 -0800 Patch bug-51126-20101215120738.patch text/plain 3719 andersca ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg MmFiYzEyNjM3MGNjYjFlODc0ZjM3ZTRmMzZjM2E3NjYwYmJhMDFiZC4uZDVjMjM1NjgxYTRlYWQ1 Y2U0NTlmYzQxNGQ0MzU4ZTNlZTgwMDg5NSAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMC0xMi0xNSAgQW5k ZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNlbWktcmVwcm9kdWNpYmxlIGNyYXNoIGluIENo dW5rZWRVcGRhdGVEcmF3aW5nQXJlYTo6cGFpbnRJbnRvVXBkYXRlQ2h1bmsgY2xvc2luZyBhIHBh cnRpY3VsYXIgeWFob28gcGFnZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NTExMjYKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzg3NzEyMTk+CisKKyAg ICAgICAgTGF5aW5nIG91dCB0aGUgd2ViIHBhZ2UgY2FuIGNhdXNlIHRoZSBkcmF3aW5nIGFyZWEg dG8gY2hhbmdlIHNvIHdlIG5lZWQgdG8gcHJvdGVjdCBhZ2FpbnN0IHRoaXMuCisKKyAgICAgICAg KiBXZWJQcm9jZXNzL1dlYlBhZ2UvQ2h1bmtlZFVwZGF0ZURyYXdpbmdBcmVhLmNwcDoKKyAgICAg ICAgKFdlYktpdDo6Q2h1bmtlZFVwZGF0ZURyYXdpbmdBcmVhOjpkaXNwbGF5KToKKyAgICAgICAg KiBXZWJQcm9jZXNzL1dlYlBhZ2UvTGF5ZXJCYWNrZWREcmF3aW5nQXJlYS5jcHA6CisgICAgICAg IChXZWJLaXQ6OkxheWVyQmFja2VkRHJhd2luZ0FyZWE6OmRpc3BsYXkpOgorICAgICAgICAqIFdl YlByb2Nlc3MvV2ViUGFnZS9tYWMvTGF5ZXJCYWNrZWREcmF3aW5nQXJlYU1hYy5tbToKKyAgICAg ICAgKFdlYktpdDo6TGF5ZXJCYWNrZWREcmF3aW5nQXJlYTo6dXBkYXRlTGF5b3V0UnVuTG9vcE9i c2VydmVyRmlyZWQpOgorCiAyMDEwLTEyLTE1ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcu Ym90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByNzQxMTcu CmRpZmYgLS1naXQgYS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9DaHVua2VkVXBkYXRlRHJh d2luZ0FyZWEuY3BwIGIvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvQ2h1bmtlZFVwZGF0ZURy YXdpbmdBcmVhLmNwcAppbmRleCBmNDZlZjJlOWFhOTNlNmViNzMyNjY5NGFlYjkxZGE1NGYwZmI5 N2NhLi44MTc4OTQyZjQ5YzUwNDJmZDY4NGMzMGZmZDYzYjM5Y2JiNzJlYWNkIDEwMDY0NAotLS0g YS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9DaHVua2VkVXBkYXRlRHJhd2luZ0FyZWEuY3Bw CisrKyBiL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0NodW5rZWRVcGRhdGVEcmF3aW5nQXJl YS5jcHAKQEAgLTg3LDkgKzg3LDE3IEBAIHZvaWQgQ2h1bmtlZFVwZGF0ZURyYXdpbmdBcmVhOjpk aXNwbGF5KCkKICAgICBpZiAobV9kaXJ0eVJlY3QuaXNFbXB0eSgpKQogICAgICAgICByZXR1cm47 CiAKKyAgICAvLyBMYXlpbmcgb3V0IHRoZSBwYWdlIGNhbiBjYXVzZSB0aGUgZHJhd2luZyBhcmVh IHRvIGNoYW5nZSBzbyB3ZSBrZWVwIGFuIGV4dHJhIHJlZmVyZW5jZS4KKyAgICBSZWZQdHI8Q2h1 bmtlZFVwZGF0ZURyYXdpbmdBcmVhPiBwcm90ZWN0KHRoaXMpOworCiAgICAgLy8gTGF5b3V0IGlm IG5lY2Vzc2FyeS4KICAgICBtX3dlYlBhZ2UtPmxheW91dElmTmVlZGVkKCk7CiAgCisgICAgaWYg KG1fd2ViUGFnZS0+ZHJhd2luZ0FyZWEoKSAhPSB0aGlzKSB7CisgICAgICAgIC8vIFRoZSBkcmF3 aW5nIGFyZWEgY2hhbmdlZCwgcmV0dXJuIGVhcmx5LgorICAgICAgICByZXR1cm47CisgICAgfQor ICAgIAogICAgIEludFJlY3QgZGlydHlSZWN0ID0gbV9kaXJ0eVJlY3Q7CiAgICAgbV9kaXJ0eVJl Y3QgPSBJbnRSZWN0KCk7CiAKZGlmZiAtLWdpdCBhL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdl L0xheWVyQmFja2VkRHJhd2luZ0FyZWEuY3BwIGIvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2Uv TGF5ZXJCYWNrZWREcmF3aW5nQXJlYS5jcHAKaW5kZXggMzc0NWVmNzdmOTBiYmJkY2VkMmM0N2Rm ZWJhNWZkZDQxNWJkZGUxNy4uMWY0NGM0MzZiYjJiZjY5YWVjZWVmODgzMmY2MGNlZTZmNDM4MWNi NyAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvTGF5ZXJCYWNrZWREcmF3 aW5nQXJlYS5jcHAKKysrIGIvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvTGF5ZXJCYWNrZWRE cmF3aW5nQXJlYS5jcHAKQEAgLTg4LDggKzg4LDE2IEBAIHZvaWQgTGF5ZXJCYWNrZWREcmF3aW5n QXJlYTo6c2V0TmVlZHNEaXNwbGF5KGNvbnN0IEludFJlY3QmIHJlY3QpCiAKIHZvaWQgTGF5ZXJC YWNrZWREcmF3aW5nQXJlYTo6ZGlzcGxheSgpCiB7CisgICAgLy8gTGF5aW5nIG91dCB0aGUgcGFn ZSBjYW4gY2F1c2UgdGhlIGRyYXdpbmcgYXJlYSB0byBjaGFuZ2Ugc28gd2Uga2VlcCBhbiBleHRy YSByZWZlcmVuY2UuCisgICAgUmVmUHRyPExheWVyQmFja2VkRHJhd2luZ0FyZWE+IHByb3RlY3Qo dGhpcyk7CisKICAgICAvLyBMYXlvdXQgaWYgbmVjZXNzYXJ5LgogICAgIG1fd2ViUGFnZS0+bGF5 b3V0SWZOZWVkZWQoKTsKKworICAgIGlmIChtX3dlYlBhZ2UtPmRyYXdpbmdBcmVhKCkgIT0gdGhp cykgeworICAgICAgICAvLyBUaGUgZHJhd2luZyBhcmVhIGNoYW5nZWQsIHJldHVybiBlYXJseS4K KyAgICAgICAgcmV0dXJuOworICAgIH0gICAgCiB9CiAKIHZvaWQgTGF5ZXJCYWNrZWREcmF3aW5n QXJlYTo6c2NoZWR1bGVEaXNwbGF5KCkKZGlmZiAtLWdpdCBhL1dlYktpdDIvV2ViUHJvY2Vzcy9X ZWJQYWdlL21hYy9MYXllckJhY2tlZERyYXdpbmdBcmVhTWFjLm1tIGIvV2ViS2l0Mi9XZWJQcm9j ZXNzL1dlYlBhZ2UvbWFjL0xheWVyQmFja2VkRHJhd2luZ0FyZWFNYWMubW0KaW5kZXggMjZiMmJk OWE0NDhjZmMxMmFiYzRmNGJmMTJjY2Q5NzllYjM3ZGEwZC4uODdkYzU0MmY3MjQ2MzRkOGQ3NDgz MjhhNDk4N2U3YzVlZTBiNjRkNSAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBh Z2UvbWFjL0xheWVyQmFja2VkRHJhd2luZ0FyZWFNYWMubW0KKysrIGIvV2ViS2l0Mi9XZWJQcm9j ZXNzL1dlYlBhZ2UvbWFjL0xheWVyQmFja2VkRHJhd2luZ0FyZWFNYWMubW0KQEAgLTE2Myw3ICsx NjMsMTUgQEAgdm9pZCBMYXllckJhY2tlZERyYXdpbmdBcmVhOjp1cGRhdGVMYXlvdXRSdW5Mb29w T2JzZXJ2ZXJDYWxsYmFjayhDRlJ1bkxvb3BPYnNlcnYKIAogdm9pZCBMYXllckJhY2tlZERyYXdp bmdBcmVhOjp1cGRhdGVMYXlvdXRSdW5Mb29wT2JzZXJ2ZXJGaXJlZCgpCiB7CisgICAgLy8gTGF5 aW5nIG91dCB0aGUgcGFnZSBjYW4gY2F1c2UgdGhlIGRyYXdpbmcgYXJlYSB0byBjaGFuZ2Ugc28g d2Uga2VlcCBhbiBleHRyYSByZWZlcmVuY2UuCisgICAgUmVmUHRyPExheWVyQmFja2VkRHJhd2lu Z0FyZWE+IHByb3RlY3QodGhpcyk7CisKICAgICBtX3dlYlBhZ2UtPmxheW91dElmTmVlZGVkKCk7 CisKKyAgICBpZiAobV93ZWJQYWdlLT5kcmF3aW5nQXJlYSgpICE9IHRoaXMpIHsKKyAgICAgICAg Ly8gVGhlIGRyYXdpbmcgYXJlYSBjaGFuZ2VkLCByZXR1cm4gZWFybHkuCisgICAgICAgIHJldHVy bjsKKyAgICB9CiAgICAgCiAgICAgaWYgKG1fYXR0YWNoZWQpCiAgICAgICAgIHN5bmNDb21wb3Np dGluZ0xheWVycygpOwo=