51119 2010-12-15 10:32:59 -0800 REGRESSION: Element with rotation does not respond to mouse events after r73385 2011-01-12 15:51:26 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 mihaip hyatt abarth alin0steglinski arv bdakin eric jamesr simon.fraser webkit.review.bot oldest_to_newest 322676 0 mihaip 2010-12-15 10:32:59 -0800 Test case: http://persistent.info/webkit/test-cases/crbug-67004.html The third div (which has -webkit-transform: rotate(180deg)) does not turn green when hovered over. This happened between r73372 and r73408, r73385 is the most likely cause. Reported on the Chromium side as http://crbug.com/67004 322691 1 76667 simon.fraser 2010-12-15 10:50:08 -0800 Created attachment 76667 Testcase 322694 2 simon.fraser 2010-12-15 10:50:36 -0800 <rdar://problem/8772995> 322712 3 76674 hyatt 2010-12-15 11:26:49 -0800 Created attachment 76674 Patch 322713 4 mihaip 2010-12-15 11:29:39 -0800 Seems like this could have a layout test (using eventSender). 322719 5 simon.fraser 2010-12-15 11:42:08 -0800 elementFromPoint() could be used to test, without any need for events. I would like to understand the rounding issues, and why they are new. 322729 6 hyatt 2010-12-15 11:54:18 -0800 They aren't new. The old code used to use the entire layer bounds as the hit test area. This area was a rect of 0, 0, rightOverflow(), bottomOverflow(). Since that isn't right for RTL documents or for vertical writing modes that could have left and top overflow, I opted to try to tighten up the hit test area to just be the point. Tightening up to a 1x1 rect though exposed rounding issues with the mapping into localHitTestRect in hitTestLayer. The patch is basically going back to what the old code did, but also incorporating left and top overflow into the hit test area. 322746 7 76674 hyatt 2010-12-15 12:21:25 -0800 Comment on attachment 76674 Patch I'll add a test. 322776 8 simon.fraser 2010-12-15 13:18:04 -0800 I think the problem is that localHitTestRect = newTransformState->mappedQuad().enclosingBoundingBox(); maps the point outside the 1x1 hitTestRect when there's a flip. 322780 9 simon.fraser 2010-12-15 13:25:18 -0800 Specifically, say I hover over the lower right corner of a 200x200 box. The local point is 195, 195, and the hitTestRest is a 195,195 1x1 rectangle. When that rectangle is mapped through the 180deg rotation, it becomes a 5, 5 -1x-1 rectangle, which gets bounded as 4,4 1x1. So the point at 5,5 is no longer inside. 322782 10 simon.fraser 2010-12-15 13:26:49 -0800 I agree with the attached patch; mapping a point inside a 1x1 rectangle through transforms is not going to work. 327262 11 77561 arv 2010-12-28 10:45:19 -0800 Created attachment 77561 Test case with mouse event 331959 12 bdakin 2011-01-10 14:39:22 -0800 (In reply to comment #2) > <rdar://problem/8772995> See also: <rdar://problem/8783620> 331964 13 78453 hyatt 2011-01-10 14:49:02 -0800 Created attachment 78453 LayoutTests portion. 331965 14 78453 simon.fraser 2011-01-10 14:51:17 -0800 Comment on attachment 78453 LayoutTests portion. View in context: https://bugs.webkit.org/attachment.cgi?id=78453&action=review > LayoutTests/fast/transforms/transform-hit-test-flipped.html:4 > +<meta charset="utf-8" /> Whu? > LayoutTests/fast/transforms/transform-hit-test-flipped.html:5 > +<title>Untitled</title> Double whu? > LayoutTests/fast/transforms/transform-hit-test-flipped.html:23 > + var elt = document.elementFromPoint(50, 50); I'm pretty sure document.elementFromPoint() will update layout. > LayoutTests/fast/transforms/transform-hit-test-flipped.html:37 > +</html> > \ No newline at end of file Boo! 332133 15 bdakin 2011-01-10 20:17:19 -0800 I committed Hyatt's patch with: http://trac.webkit.org/changeset/75472 332146 16 webkit.review.bot 2011-01-10 21:13:37 -0800 http://trac.webkit.org/changeset/75472 might have broken GTK Linux 64-bit Debug The following tests are not passing: media/adopt-node-crash.html 333377 17 aestes 2011-01-12 15:51:26 -0800 *** Bug 51808 has been marked as a duplicate of this bug. *** 76667 2010-12-15 10:50:08 -0800 2010-12-15 10:50:08 -0800 Testcase rotation-hover.html text/html 602 simon.fraser PCFET0NUWVBFIGh0bWw+CjxodG1sPgo8aGVhZD4KCTxtZXRhIGNoYXJzZXQ9InV0Zi04IiAvPgoJ PHRpdGxlPlVudGl0bGVkPC90aXRsZT4KCTxzdHlsZT4KCSAgZGl2IHsKCSAgICB3aWR0aDogMTAw cHg7CgkgICAgaGVpZ2h0OiAxMDBweDsKCSAgICBiYWNrZ3JvdW5kOiByZWQ7CgkgICAgbWFyZ2lu OiAxMHB4OwoJICAgIHBhZGRpbmc6IDEwcHg7CgkgIH0KCSAgCgkgIGRpdjpob3ZlciB7CgkgICAg YmFja2dyb3VuZDogZ3JlZW47CgkgIH0KCgkgICNyb3RhdGVkMSB7CgkgICAgLXdlYmtpdC10cmFu c2Zvcm06IHJvdGF0ZSg0NWRlZyk7CgkgIH0KCSAgCgkgICNyb3RhdGVkMiB7CgkgICAgLXdlYmtp dC10cmFuc2Zvcm06IHJvdGF0ZSgxODBkZWcpOwoJICB9Cgk8L3N0eWxlPgo8L2hlYWQ+Cjxib2R5 PgoKSG92ZXIgb3ZlciBlYWNoIG9mIHRoZSByZWQgc3F1YXJlcywgdGhleSBzaG91bGQgdHVybiBn cmVlbi4KCjxkaXYgaWQ9InJlZ3VsYXIiPnJlZ3VsYXI8L2Rpdj4KCjxkaXYgaWQ9InJvdGF0ZWQx Ij40NSBkZWdyZWUgcm90YXRpb248L2Rpdj4KCjxkaXYgaWQ9InJvdGF0ZWQyIj4xODAgZGVncmVl IHJvdGF0aW9uPC9kaXY+Cgo8L2JvZHk+CjwvaHRtbD4= 76674 2010-12-15 11:26:49 -0800 2010-12-15 12:21:25 -0800 Patch patch.txt text/plain 1360 hyatt SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3NDEyOSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMTItMTUgIERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MTExOSwgdHJhbnNmb3JtZWQgZWxl bWVudHMgbm90IHJlc3BvbmRpbmcgcHJvcGVybHkgdG8KKyAgICAgICAgOmhvdmVyIGFmdGVyIHI3 MzM4NS4gIEp1c3QgdXNlIHRoZSBlbnRpcmUgZG9jdW1lbnQgYXJlYSBhcyB0aGUgaGl0IHRlc3Qg YXJlYSwgc2luY2UgdGhlcmUgYXBwZWFycworICAgICAgICB0byBiZSBhIHJvdW5kaW5nIGJ1Zy9p c3N1ZXMgd2l0aCByZWx5aW5nIG9uIGZsb2F0IG1hdGggd2hlbiBtYXBwaW5nIHRoZSBoaXQgdGVz dCBhcmVhIGludG8KKyAgICAgICAgdHJhbnNmb3JtZWQgY29vcmRpbmF0ZXMuCisKKyAgICAgICAg KiByZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5 ZXI6OmhpdFRlc3QpOgorCiAyMDEwLTEwLTE4ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25A aWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBHdXN0YXZvIE5vcm9uaGEgU2lsdmEu CkluZGV4OiBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCShyZXZpc2lvbiA3Mzk3MikKKysrIFdl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjY4MCw3 ICsyNjgwLDcgQEAgYm9vbCBSZW5kZXJMYXllcjo6aGl0VGVzdChjb25zdCBIaXRUZXN0Ugogewog ICAgIHJlbmRlcmVyKCktPmRvY3VtZW50KCktPnVwZGF0ZUxheW91dCgpOwogICAgIAotICAgIElu dFJlY3QgaGl0VGVzdEFyZWEgPSByZXN1bHQucmVjdEZvclBvaW50KHJlc3VsdC5wb2ludCgpKTsK KyAgICBJbnRSZWN0IGhpdFRlc3RBcmVhID0gcmVuZGVyZXIoKS0+dmlldygpLT5kb2N1bWVudFJl Y3QoKTsKICAgICBpZiAoIXJlcXVlc3QuaWdub3JlQ2xpcHBpbmcoKSkKICAgICAgICAgaGl0VGVz dEFyZWEuaW50ZXJzZWN0KGZyYW1lVmlzaWJsZVJlY3QocmVuZGVyZXIoKSkpOwogCg== 77561 2010-12-28 10:45:19 -0800 2010-12-28 10:45:19 -0800 Test case with mouse event transform-mouse-events.html text/html 396 arv PCFET0NUWVBFIGh0bWw+CjxzdHlsZT4KCmRpdiB7CiAgYmFja2dyb3VuZDogcGluazsKICBtYXJn aW46IDVweDsKICBoZWlnaHQ6IDE2cHg7CiAgcGFkZGluZzogNXB4OwogIHdpZHRoOiAxNnB4Owp9 CgojYiB7CiAgLXdlYmtpdC10cmFuc2Zvcm06IHJvdGF0ZSg5MGRlZyk7Cn0KCjwvc3R5bGU+Cjxz Y3JpcHQ+Cgpkb2N1bWVudC5vbmNsaWNrID0gZnVuY3Rpb24oZSkgewogIGFsZXJ0KCd0YWdOYW1l OiAnICsgZS50YXJnZXQudGFnTmFtZSArICdcbmlkOiAnICsgZS50YXJnZXQuaWQpOwp9OwoKPC9z Y3JpcHQ+Cgo8cD5DbGljayBvbiB0aGUgcGluayBzcXVhcmVzIGJlbG93LiBUaGUgdGFyZ2V0IHNo b3VsZCBiZSB0aGUgZGl2LgoKPGRpdiBpZD1hPmE8L2Rpdj4KPGRpdiBpZD1iPmI8L2Rpdj4K 78453 2011-01-10 14:49:02 -0800 2011-01-10 14:51:17 -0800 LayoutTests portion. patch.txt text/plain 2058 hyatt SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDc1NDM4KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDEtMTAgIERhdmlkIEh5YXR0ICA8aHlh dHRAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIE5lZWQgYSBzaG9ydCBkZXNjcmlwdGlvbiBhbmQgYnVnIFVSTCAoT09QUyEpCisKKyAg ICAgICAgKiBmYXN0L3RyYW5zZm9ybXMvdHJhbnNmb3JtLWhpdC10ZXN0LWZsaXBwZWQtZXhwZWN0 ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L3RyYW5zZm9ybXMvdHJhbnNmb3JtLWhpdC10 ZXN0LWZsaXBwZWQuaHRtbDogQWRkZWQuCisKIDIwMTEtMDEtMTAgIFRvbnkgQ2hhbmcgIDx0b255 QGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByNzUzOTgs IHI3NTQwNywKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvdHJhbnNmb3Jtcy90cmFuc2Zvcm0taGl0 LXRlc3QtZmxpcHBlZC1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFz dC90cmFuc2Zvcm1zL3RyYW5zZm9ybS1oaXQtdGVzdC1mbGlwcGVkLWV4cGVjdGVkLnR4dAkocmV2 aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvdHJhbnNmb3Jtcy90cmFuc2Zvcm0taGl0LXRl c3QtZmxpcHBlZC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEgQEAKK1BBU1MK SW5kZXg6IExheW91dFRlc3RzL2Zhc3QvdHJhbnNmb3Jtcy90cmFuc2Zvcm0taGl0LXRlc3QtZmxp cHBlZC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvdHJhbnNmb3Jtcy90cmFu c2Zvcm0taGl0LXRlc3QtZmxpcHBlZC5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMv ZmFzdC90cmFuc2Zvcm1zL3RyYW5zZm9ybS1oaXQtdGVzdC1mbGlwcGVkLmh0bWwJKHJldmlzaW9u IDApCkBAIC0wLDAgKzEsMzYgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8aGVhZD4KKzxt ZXRhIGNoYXJzZXQ9InV0Zi04IiAvPgorPHRpdGxlPlVudGl0bGVkPC90aXRsZT4KKzxzdHlsZT4K KyAgI3JvdGF0ZWQgeworICAgIHdpZHRoOiAxMDBweDsKKyAgICBoZWlnaHQ6IDEwMHB4OworICAg IGJhY2tncm91bmQ6IHJlZDsKKyAgICBtYXJnaW46IDEwcHg7CisgICAgcGFkZGluZzogMTBweDsK KyAgICAtd2Via2l0LXRyYW5zZm9ybTogcm90YXRlKDE4MGRlZyk7CisgIH0KKzwvc3R5bGU+Cis8 c2NyaXB0PgoraWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgd2luZG93LmxheW91 dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKQorCitmdW5jdGlvbiBydW5UZXN0KCkKK3sKKyAg IGRvY3VtZW50LmJvZHkub2Zmc2V0V2lkdGg7CisgICB2YXIgZWx0ID0gZG9jdW1lbnQuZWxlbWVu dEZyb21Qb2ludCg1MCwgNTApOworICAgaWYgKGVsdCA9PSBkb2N1bWVudC5nZXRFbGVtZW50QnlJ ZCgncm90YXRlZCcpKQorICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdjb25zb2xlJyku aW5uZXJIVE1MID0gJ1BBU1MnOworICAgZWxzZQorICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRC eUlkKCdjb25zb2xlJykuaW5uZXJIVE1MID0gJ0ZBSUwnOworICAgZWx0LnN0eWxlLmRpc3BsYXkg PSAnbm9uZSc7Cit9Cis8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IG9ubG9hZD0icnVuVGVzdCgp Ij4KKzxkaXYgaWQ9InJvdGF0ZWQiPjE4MCBkZWdyZWUgcm90YXRpb248L2Rpdj4KKzxkaXYgaWQ9 ImNvbnNvbGUiPjwvZGl2PgorPC9ib2R5PgorPC9odG1sPgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9m IGZpbGUK