51115 2010-12-15 09:48:17 -0800 Crash in web process after the connection had been closed 2011-02-07 17:44:54 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 kbalazs webkit-unassigned andersca kenneth kling sam oldest_to_newest 322643 0 kbalazs 2010-12-15 09:48:17 -0800 This is the story: 1. The UI process close the last page 2. The connection of the web process is invalidated 3. The work queue of the connection is still running and it detects disconnection and call connectionDidClose 4. m_client is 0 so connectionDidClose does a null dereference That means we need a null check in connectionDidClose. I don't know exactly how ports other than Qt affected by the problem but a null check does not costs too much so I think it is better to handle that in the common part of the implementation. I investigated a lot of how should that fixed correctly and I think this is the best. 322652 1 kbalazs 2010-12-15 10:02:26 -0800 Note that the crash is only visible in the debugger. 323077 2 76743 kbalazs 2010-12-16 01:55:02 -0800 Created attachment 76743 Patch 324335 3 kbalazs 2010-12-20 04:59:12 -0800 After I got an assert in connectionDidClose while working on other stuff but having this patch in my branch, I decided to fix by not calling connectionDidClose at all when the connection had been invalidated. That would rather need a Qt only change. 324337 4 76988 kbalazs 2010-12-20 05:09:15 -0800 Created attachment 76988 Patch 324340 5 76988 kenneth 2010-12-20 05:29:52 -0800 Comment on attachment 76988 Patch Looks sensible 324379 6 76988 kbalazs 2010-12-20 07:12:17 -0800 Comment on attachment 76988 Patch Clearing flags on attachment: 76988 Committed r74345: <http://trac.webkit.org/changeset/74345> 324380 7 kbalazs 2010-12-20 07:12:26 -0800 All reviewed patches have been landed. Closing bug. 324446 8 andersca 2010-12-20 10:33:49 -0800 This patch is not correct, m_client must either be an atomic variable or protected by a lock. I'm going to revert this. 324453 9 kenneth 2010-12-20 10:54:13 -0800 (In reply to comment #8) > This patch is not correct, m_client must either be an atomic variable or protected by a lock. I'm going to revert this. Please do. 324454 10 andersca 2010-12-20 10:54:35 -0800 Reverted r74345 for reason: Not the correct fix. Committed r74355: <http://trac.webkit.org/changeset/74355> 324669 11 77057 kbalazs 2010-12-20 17:27:41 -0800 Created attachment 77057 Patch 324673 12 77057 darin 2010-12-20 17:35:49 -0800 Comment on attachment 77057 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=77057&action=review I think Anders should review, but I do have one comment. > WebKit2/Platform/CoreIPC/Connection.cpp:349 > + m_client = 0; // No need to lock here since the connectino has been closed on the work thread. Typo: connectino 327758 13 77057 darin 2010-12-29 17:16:11 -0800 Comment on attachment 77057 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=77057&action=review I’d like to review, but I’d like to hear from Anders whether he thinks this is the right solution. > WebKit2/ChangeLog:8 > + Add mutual exclusion for m_client. Typically for a single pointer we could use a function like the Mac OS X OSAtomicCompareAndSwapPtrBarrier instead of a mutex. I don’t know if that’s desirable here or not. > WebKit2/Platform/CoreIPC/Connection.cpp:342 > - if (!m_client) > + if (!isValid()) Is this better? Generally speaking if code is going to be manipulating m_client directly, I am not sure that isValid is providing a helpful abstraction inside the Connection class. 328465 14 kbalazs 2011-01-02 19:05:40 -0800 (In reply to comment #13) > (From update of attachment 77057 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=77057&action=review > > I’d like to review, but I’d like to hear from Anders whether he thinks this is the right solution. > > > WebKit2/ChangeLog:8 > > + Add mutual exclusion for m_client. > > Typically for a single pointer we could use a function like the Mac OS X OSAtomicCompareAndSwapPtrBarrier instead of a mutex. I don’t know if that’s desirable here or not. I don't have a strong opinion about that. However, if we want atomic functionality then I think it should be introduced into WTF for all platforms. > > > WebKit2/Platform/CoreIPC/Connection.cpp:342 > > - if (!m_client) > > + if (!isValid()) > > Is this better? Generally speaking if code is going to be manipulating m_client directly, I am not sure that isValid is providing a helpful abstraction inside the Connection class. Yes, maybe just saying |!m_client| is more straightforward here. 330068 15 kbalazs 2011-01-06 02:05:55 -0800 I should refine my opinion about using atomic here. This is not enough in the following situation: { Client* client = ATOMIC_READ(m_client); if (!client) return; --> Right now the listener thread invalidates the connection. --> After that the client is allowed to be destructed so we can end up in --> accessing a deleted object in the following line. client->didCloseOnConnectionWorkQueue(&m_connectionQueue, this); } So the didClose... call should be in a mutually excluded block. 334263 16 78932 kbalazs 2011-01-14 05:52:51 -0800 Created attachment 78932 patch v4 Patch with the isValid/m_client change suggested by Darin. 343314 17 kbalazs 2011-02-01 10:24:36 -0800 ping 346967 18 andersca 2011-02-07 17:18:02 -0800 (In reply to comment #17) > ping Sorry for not looking at this earlier. I've decided to go with a simpler approach and get rid of the Client::connectionDidCloseOnWorkQueue. 346974 19 81556 andersca 2011-02-07 17:32:57 -0800 Created attachment 81556 Patch 346982 20 andersca 2011-02-07 17:44:54 -0800 Committed r77874: <http://trac.webkit.org/changeset/77874> 76743 2010-12-16 01:55:02 -0800 2010-12-20 05:09:09 -0800 Patch bug-51115-20101216095500.patch text/plain 1603 kbalazs ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg OGEwZWI5NTY2YWJmNDJmMGY5YjNmZjBiNTVmMmFkYmU5NmYxYzUyMi4uMzIyYmNiOTg3YzRjYTlm Y2JjOGY2ZWMxZDNkYzVlNWYyNWM3ZjIyOCAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0xMi0xNSAgQmFs YXpzIEtlbGVtZW4gIDxrYmFsYXpzQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ3Jhc2ggaW4gd2ViIHByb2Nlc3MgYWZ0ZXIgdGhl IGNvbm5lY3Rpb24gaGFkIGJlZW4gY2xvc2VkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTExMTUKKworICAgICAgICBBZnRlciB0aGUgY29ubmVjdGlv biBoYWQgYmVlbiBpbnZhbGlkYXRlZCBvbiB0aGUgbWFpbiB0aHJlYWQKKyAgICAgICAgdGhlIHdv cmsgdGhyZWFkIGNhbiBzdGlsbCBkZXRlY3QgdGhhdCB0aGUgY29ubmVjdGlvbiBoYWQgYmVlbgor ICAgICAgICBjbG9zZWQgYW5kIGNhbGwgY29ubmVjdGlvbkRpZENsb3NlLiBXZSBuZWVkIHRvIGhh bmRsZSB0aGF0IGNhc2UKKyAgICAgICAgaW4gY29ubmVjdGlvbkRpZENsb3NlLgorCisgICAgICAg ICogUGxhdGZvcm0vQ29yZUlQQy9Db25uZWN0aW9uLmNwcDoKKyAgICAgICAgKENvcmVJUEM6OkNv bm5lY3Rpb246OmNvbm5lY3Rpb25EaWRDbG9zZSk6CisgICAgICAgIE51bGwgY2hlY2sgbV9jbGll bnQgYmVmb3JlIGFjY2Vzc2luZyBpdC4KKwogMjAxMC0xMi0xNSAgRGFuIEJlcm5zdGVpbiAgPG1p dHpAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCmRpZmYgLS1n aXQgYS9XZWJLaXQyL1BsYXRmb3JtL0NvcmVJUEMvQ29ubmVjdGlvbi5jcHAgYi9XZWJLaXQyL1Bs YXRmb3JtL0NvcmVJUEMvQ29ubmVjdGlvbi5jcHAKaW5kZXggZjlhODA4YzRhYmQyNWE1MTZjMTM1 MTgxNDczYjkyZTZmZWE5ODlhOC4uZmRhODk0OTVhNTE0ZTQxMjUyZmMyNDNmYjg1YWY3YjliMDQ2 MjVmYyAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9QbGF0Zm9ybS9Db3JlSVBDL0Nvbm5lY3Rpb24uY3Bw CisrKyBiL1dlYktpdDIvUGxhdGZvcm0vQ29yZUlQQy9Db25uZWN0aW9uLmNwcApAQCAtMzI3LDYg KzMyNywxMCBAQCB2b2lkIENvbm5lY3Rpb246OmNvbm5lY3Rpb25EaWRDbG9zZSgpCiAgICAgICAg ICAgICBtX3dhaXRGb3JTeW5jUmVwbHlTZW1hcGhvcmUuc2lnbmFsKCk7CiAgICAgfQogCisgICAg Ly8gVGhlIGNvbm5lY3Rpb24gbWlnaHQgaGF2ZSBiZWVuIGV4cGxpY2l0bHkgaW52YWxpZGF0ZWQg b24gdGhlIG1haW4gdGhyZWFkLgorICAgIGlmICghaXNWYWxpZCgpKQorICAgICAgICByZXR1cm47 CisKICAgICBtX2NsaWVudC0+ZGlkQ2xvc2VPbkNvbm5lY3Rpb25Xb3JrUXVldWUoJm1fY29ubmVj dGlvblF1ZXVlLCB0aGlzKTsKIAogICAgIG1fY2xpZW50UnVuTG9vcC0+c2NoZWR1bGVXb3JrKFdv cmtJdGVtOjpjcmVhdGUodGhpcywgJkNvbm5lY3Rpb246OmRpc3BhdGNoQ29ubmVjdGlvbkRpZENs b3NlKSk7Cg== 76988 2010-12-20 05:09:15 -0800 2010-12-20 17:27:35 -0800 Patch bug-51115-20101220130913.patch text/plain 2571 kbalazs ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg ZTY0ZTNmNzgzYTNhYzY4ZDYzMmZlNGM2NjkyMzBlOTdkM2M1MTgzNi4uYjUwZmZkNTY4YWU3NGZi OGVhN2Y0MTJiM2IxY2ZkN2I2MjI3MWRmNiAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0xMi0yMCAgQmFs YXpzIEtlbGVtZW4gIDxrYmFsYXpzQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XVtXSzJdIENyYXNoIGluIHdlYiBwcm9jZXNz IGFmdGVyIHRoZSBjb25uZWN0aW9uIGhhZCBiZWVuIGNsb3NlZAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTExMTUKKworICAgICAgICBEbyBub3QgY2Fs bCBjb25uZWN0aW9uRGlkQ2xvc2Ugd2l0aCBhIGNvbm5lY3Rpb24gdGhhdCBoYXMgYmVlbiBleHBs aWNpdGx5CisgICAgICAgIGludmFsaWRhdGVkIG9uIHRoZSBsaXN0ZW5lciB0aHJlYWQuCisgICAg ICAgICogUGxhdGZvcm0vQ29yZUlQQy9Db25uZWN0aW9uLmg6CisgICAgICAgICogUGxhdGZvcm0v Q29yZUlQQy9xdC9Db25uZWN0aW9uUXQuY3BwOgorICAgICAgICAoQ29yZUlQQzo6Q29ubmVjdGlv bjo6ZGlzY29ubmVjdEhhbmRsZXIpOiBBZGRlZC4KKyAgICAgICAgKENvcmVJUEM6OkNvbm5lY3Rp b246Om9wZW4pOgorCiAyMDEwLTEyLTE5ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2FtIFdlaW5pZy4KZGlmZiAtLWdpdCBhL1dlYktpdDIv UGxhdGZvcm0vQ29yZUlQQy9Db25uZWN0aW9uLmggYi9XZWJLaXQyL1BsYXRmb3JtL0NvcmVJUEMv Q29ubmVjdGlvbi5oCmluZGV4IDRkYTIyMDA4M2Q0NDJkZDdlN2IwMWU0YTEwODExMTNmNmRmNDQ4 MGYuLmQ3YWNjZGNlODE2OGQ1MGI1MjFlOTQ5Y2JmZmQ0ZTNkMGM4NWM5OTggMTAwNjQ0Ci0tLSBh L1dlYktpdDIvUGxhdGZvcm0vQ29yZUlQQy9Db25uZWN0aW9uLmgKKysrIGIvV2ViS2l0Mi9QbGF0 Zm9ybS9Db3JlSVBDL0Nvbm5lY3Rpb24uaApAQCAtMjYxLDYgKzI2MSw3IEBAIHByaXZhdGU6CiAj ZWxpZiBQTEFURk9STShRVCkKICAgICAvLyBDYWxsZWQgb24gdGhlIGNvbm5lY3Rpb24gcXVldWUu CiAgICAgdm9pZCByZWFkeVJlYWRIYW5kbGVyKCk7CisgICAgdm9pZCBkaXNjb25uZWN0SGFuZGxl cigpOwogCiAgICAgVmVjdG9yPHVpbnQ4X3Q+IG1fcmVhZEJ1ZmZlcjsKICAgICBzaXplX3QgbV9j dXJyZW50TWVzc2FnZVNpemU7CmRpZmYgLS1naXQgYS9XZWJLaXQyL1BsYXRmb3JtL0NvcmVJUEMv cXQvQ29ubmVjdGlvblF0LmNwcCBiL1dlYktpdDIvUGxhdGZvcm0vQ29yZUlQQy9xdC9Db25uZWN0 aW9uUXQuY3BwCmluZGV4IGUzZDk2NWNmZTE0ZTY0OTdkMWY5NmUwMTkwM2FkY2NhOTUzMGI0YzUu Ljg5YzFhMTc0MDExZmUyOGNkYWRhNGYwYWU0MjM0NzZhMWExMjg3M2MgMTAwNjQ0Ci0tLSBhL1dl YktpdDIvUGxhdGZvcm0vQ29yZUlQQy9xdC9Db25uZWN0aW9uUXQuY3BwCisrKyBiL1dlYktpdDIv UGxhdGZvcm0vQ29yZUlQQy9xdC9Db25uZWN0aW9uUXQuY3BwCkBAIC04Miw2ICs4MiwxMyBAQCB2 b2lkIENvbm5lY3Rpb246OnJlYWR5UmVhZEhhbmRsZXIoKQogICAgIH0KIH0KIAordm9pZCBDb25u ZWN0aW9uOjpkaXNjb25uZWN0SGFuZGxlcigpCit7CisgICAgLy8gVGhlIGNvbm5lY3Rpb24gbWln aHQgaGF2ZSBiZWVuIGV4cGxpY2l0bHkgaW52YWxpZGF0ZWQgb24gdGhlIGxpc3RlbmVyIHRocmVh ZC4KKyAgICBpZiAoaXNWYWxpZCgpKQorICAgICAgICBjb25uZWN0aW9uRGlkQ2xvc2UoKTsKK30K KwogYm9vbCBDb25uZWN0aW9uOjpvcGVuKCkKIHsKICAgICBBU1NFUlQoIW1fc29ja2V0KTsKQEAg LTk4LDcgKzEwNSw3IEBAIGJvb2wgQ29ubmVjdGlvbjo6b3BlbigpCiAgICAgICAgIG1fc29ja2V0 LT5jb25uZWN0VG9TZXJ2ZXIobV9zZXJ2ZXJOYW1lKTsKICAgICAgICAgbV9jb25uZWN0aW9uUXVl dWUubW92ZVNvY2tldFRvV29ya1RocmVhZChtX3NvY2tldCk7CiAgICAgICAgIG1fY29ubmVjdGlv blF1ZXVlLmNvbm5lY3RTaWduYWwobV9zb2NrZXQsIFNJR05BTChyZWFkeVJlYWQoKSksIFdvcmtJ dGVtOjpjcmVhdGUodGhpcywgJkNvbm5lY3Rpb246OnJlYWR5UmVhZEhhbmRsZXIpKTsKLSAgICAg ICAgbV9jb25uZWN0aW9uUXVldWUuY29ubmVjdFNpZ25hbChtX3NvY2tldCwgU0lHTkFMKGRpc2Nv bm5lY3RlZCgpKSwgV29ya0l0ZW06OmNyZWF0ZSh0aGlzLCAmQ29ubmVjdGlvbjo6Y29ubmVjdGlv bkRpZENsb3NlKSk7CisgICAgICAgIG1fY29ubmVjdGlvblF1ZXVlLmNvbm5lY3RTaWduYWwobV9z b2NrZXQsIFNJR05BTChkaXNjb25uZWN0ZWQoKSksIFdvcmtJdGVtOjpjcmVhdGUodGhpcywgJkNv bm5lY3Rpb246OmRpc2Nvbm5lY3RIYW5kbGVyKSk7CiAgICAgICAgIG1faXNDb25uZWN0ZWQgPSBt X3NvY2tldC0+d2FpdEZvckNvbm5lY3RlZCgpOwogICAgIH0KICAgICByZXR1cm4gbV9pc0Nvbm5l Y3RlZDsK 77057 2010-12-20 17:27:41 -0800 2011-01-14 05:52:51 -0800 Patch bug-51115-20101221012739.patch text/plain 3289 kbalazs ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg ZTY0ZTNmNzgzYTNhYzY4ZDYzMmZlNGM2NjkyMzBlOTdkM2M1MTgzNi4uYjBlNDg0MjljNWZkMzMx YjM3ZGI3OTgwOGE0MDFkMDg1OGRiNjRjNyAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0xMi0yMCAgQmFs YXpzIEtlbGVtZW4gIDxrYmFsYXpzQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ3Jhc2ggaW4gd2ViIHByb2Nlc3MgYWZ0ZXIgdGhl IGNvbm5lY3Rpb24gaGFkIGJlZW4gY2xvc2VkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD01MTExNQorCisgICAgICAgIEFkZCBtdXR1YWwgZXhjbHVzaW9u IGZvciBtX2NsaWVudC4KKworICAgICAgICAqIFBsYXRmb3JtL0NvcmVJUEMvQ29ubmVjdGlvbi5j cHA6CisgICAgICAgIChDb3JlSVBDOjpDb25uZWN0aW9uOjppbnZhbGlkYXRlKTogQXF1aXJlIGxv Y2sgYmVmb3JlIG51bGxpbmcgb3V0IG1fY2xpZW50LgorICAgICAgICAoQ29yZUlQQzo6Q29ubmVj dGlvbjo6Y29ubmVjdGlvbkRpZENsb3NlKTogQXF1aXJlIGxvY2sgZm9yIG1fY2xpZW50IGFuZCBl YXJseQorICAgICAgICByZXR1cm4gaWYgaXQgaGFzIGJlZW4gbnVsbGVkIG91dC4KKyAgICAgICAg KENvcmVJUEM6OkNvbm5lY3Rpb246OmRpc3BhdGNoQ29ubmVjdGlvbkRpZENsb3NlKTogQWRqdXN0 IHRoZSBjb21tZW50cyBmb3IgdGhlIGNoYW5nZS4KKyAgICAgICAgKiBQbGF0Zm9ybS9Db3JlSVBD L0Nvbm5lY3Rpb24uaDoKKwogMjAxMC0xMi0xOSAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCmRpZmYgLS1naXQgYS9XZWJL aXQyL1BsYXRmb3JtL0NvcmVJUEMvQ29ubmVjdGlvbi5jcHAgYi9XZWJLaXQyL1BsYXRmb3JtL0Nv cmVJUEMvQ29ubmVjdGlvbi5jcHAKaW5kZXggZjFmMWI2OTZkNGUxOGEwNDJmNjI4NmVmM2M0Zjgw OWYxMGQ2NzZhNS4uY2E2NDJkNDZlNzIzNDZlOTc1ZjBlZDUxZTZlMDA5NTk5ZWFkNTMxZiAxMDA2 NDQKLS0tIGEvV2ViS2l0Mi9QbGF0Zm9ybS9Db3JlSVBDL0Nvbm5lY3Rpb24uY3BwCisrKyBiL1dl YktpdDIvUGxhdGZvcm0vQ29yZUlQQy9Db25uZWN0aW9uLmNwcApAQCAtNzMsNyArNzMsMTAgQEAg dm9pZCBDb25uZWN0aW9uOjppbnZhbGlkYXRlKCkKICAgICB9CiAgICAgCiAgICAgLy8gUmVzZXQg dGhlIGNsaWVudC4KLSAgICBtX2NsaWVudCA9IDA7CisgICAgeworICAgICAgICBNdXRleExvY2tl ciBsb2NrZXIobV9jbGllbnRMb2NrKTsKKyAgICAgICAgbV9jbGllbnQgPSAwOworICAgIH0KIAog ICAgIG1fY29ubmVjdGlvblF1ZXVlLnNjaGVkdWxlV29yayhXb3JrSXRlbTo6Y3JlYXRlKHRoaXMs ICZDb25uZWN0aW9uOjpwbGF0Zm9ybUludmFsaWRhdGUpKTsKIH0KQEAgLTMyNCwyNCArMzI3LDI2 IEBAIHZvaWQgQ29ubmVjdGlvbjo6Y29ubmVjdGlvbkRpZENsb3NlKCkKICAgICAgICAgICAgIG1f d2FpdEZvclN5bmNSZXBseVNlbWFwaG9yZS5zaWduYWwoKTsKICAgICB9CiAKLSAgICBtX2NsaWVu dC0+ZGlkQ2xvc2VPbkNvbm5lY3Rpb25Xb3JrUXVldWUoJm1fY29ubmVjdGlvblF1ZXVlLCB0aGlz KTsKKyAgICB7CisgICAgICAgIE11dGV4TG9ja2VyIGxvY2tlcihtX2NsaWVudExvY2spOworICAg ICAgICBpZiAoIWlzVmFsaWQoKSkKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgbV9jbGll bnQtPmRpZENsb3NlT25Db25uZWN0aW9uV29ya1F1ZXVlKCZtX2Nvbm5lY3Rpb25RdWV1ZSwgdGhp cyk7CisgICAgfQogCiAgICAgbV9jbGllbnRSdW5Mb29wLT5zY2hlZHVsZVdvcmsoV29ya0l0ZW06 OmNyZWF0ZSh0aGlzLCAmQ29ubmVjdGlvbjo6ZGlzcGF0Y2hDb25uZWN0aW9uRGlkQ2xvc2UpKTsK IH0KIAogdm9pZCBDb25uZWN0aW9uOjpkaXNwYXRjaENvbm5lY3Rpb25EaWRDbG9zZSgpCiB7Ci0g ICAgLy8gSWYgdGhlIGNvbm5lY3Rpb24gaGFzIGJlZW4gZXhwbGljaXRseSBpbnZhbGlkYXRlZCBi ZWZvcmUgZGlzcGF0Y2hDb25uZWN0aW9uRGlkQ2xvc2Ugd2FzIGNhbGxlZCwKLSAgICAvLyB0aGVu IHRoZSBjbGllbnQgd2lsbCBiZSBudWxsIGhlcmUuCi0gICAgaWYgKCFtX2NsaWVudCkKKyAgICBp ZiAoIWlzVmFsaWQoKSkKICAgICAgICAgcmV0dXJuOwogCi0KICAgICAvLyBCZWNhdXNlIHdlIGRl ZmluZSBhIGNvbm5lY3Rpb24gYXMgYmVpbmcgInZhbGlkIiBiYXNlZCBvbiB3aGV0ZXIgaXQgaGFz IGEgbnVsbCBjbGllbnQsIHdlIG51bGwgb3V0CiAgICAgLy8gdGhlIGNsaWVudCBiZWZvcmUgY2Fs bGluZyBkaWRDbG9zZSBoZXJlLiBPdGhlcndpc2UsIHNlbmRTeW5jIHdpbGwgdHJ5IHRvIHNlbmQg YSBtZXNzYWdlIHRvIHRoZSBjb25uZWN0aW9uIGFuZAogICAgIC8vIHdpbGwgdGhlbiB3YWl0IGlu ZGVmaW5pdGVseSBmb3IgYSByZXBseS4KICAgICBDbGllbnQqIGNsaWVudCA9IG1fY2xpZW50Owot ICAgIG1fY2xpZW50ID0gMDsKKyAgICBtX2NsaWVudCA9IDA7IC8vIE5vIG5lZWQgdG8gbG9jayBo ZXJlIHNpbmNlIHRoZSBjb25uZWN0aW5vIGhhcyBiZWVuIGNsb3NlZCBvbiB0aGUgd29yayB0aHJl YWQuCiAgICAgCiAgICAgY2xpZW50LT5kaWRDbG9zZSh0aGlzKTsKIH0KZGlmZiAtLWdpdCBhL1dl YktpdDIvUGxhdGZvcm0vQ29yZUlQQy9Db25uZWN0aW9uLmggYi9XZWJLaXQyL1BsYXRmb3JtL0Nv cmVJUEMvQ29ubmVjdGlvbi5oCmluZGV4IDRkYTIyMDA4M2Q0NDJkZDdlN2IwMWU0YTEwODExMTNm NmRmNDQ4MGYuLjg5NWIwODAzZWIxYWYzYjA1ZWI5Njk3YzQ1OTNkMTVhZDE4MWU5ZWEgMTAwNjQ0 Ci0tLSBhL1dlYktpdDIvUGxhdGZvcm0vQ29yZUlQQy9Db25uZWN0aW9uLmgKKysrIGIvV2ViS2l0 Mi9QbGF0Zm9ybS9Db3JlSVBDL0Nvbm5lY3Rpb24uaApAQCAtMTc2LDcgKzE3Niw4IEBAIHByaXZh dGU6CiAgICAgdm9pZCBkaXNwYXRjaENvbm5lY3Rpb25EaWRDbG9zZSgpOwogICAgIHZvaWQgZGlz cGF0Y2hNZXNzYWdlcygpOwogICAgIHZvaWQgZGlzcGF0Y2hTeW5jTWVzc2FnZShNZXNzYWdlSUQs IEFyZ3VtZW50RGVjb2RlciopOwotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAKKworICAg IE11dGV4IG1fY2xpZW50TG9jazsKICAgICBDbGllbnQqIG1fY2xpZW50OwogICAgIGJvb2wgbV9p c1NlcnZlcjsKICAgICB1aW50NjRfdCBtX3N5bmNSZXF1ZXN0SUQ7Cg== 78932 2011-01-14 05:52:51 -0800 2011-02-07 17:32:54 -0800 patch v4 0001-Crash-in-web-process-after-the-connection-had-been-c.patch text/plain 4013 kbalazs RnJvbSA3ZWQ3YjZkNjdmOTRkYmEzMjllYTdjMjA3Y2NmNmRiMmEyZDdmZTE4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBCYWxhenMgS2VsZW1lbiA8a2JhbGF6c0B3ZWJraXQub3JnPgpE YXRlOiBGcmksIDE0IEphbiAyMDExIDEzOjQ2OjI1ICswMDAwClN1YmplY3Q6IFtQQVRDSF0gQ3Jh c2ggaW4gd2ViIHByb2Nlc3MgYWZ0ZXIgdGhlIGNvbm5lY3Rpb24gaGFkIGJlZW4gY2xvc2VkCiBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTExMTUKClJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgoKQWRkIG11dHVhbCBleGNsdXNpb24gZm9yIG1fY2xpZW50LgoKKiBQ bGF0Zm9ybS9Db3JlSVBDL0Nvbm5lY3Rpb24uY3BwOgooQ29yZUlQQzo6Q29ubmVjdGlvbjo6aW52 YWxpZGF0ZSk6IEFxdWlyZSBsb2NrIGJlZm9yZSBudWxsaW5nIG91dCBtX2NsaWVudC4KKENvcmVJ UEM6OkNvbm5lY3Rpb246OmNvbm5lY3Rpb25EaWRDbG9zZSk6IEFxdWlyZSBsb2NrIGZvciBtX2Ns aWVudCBhbmQgZWFybHkKcmV0dXJuIGlmIGl0IGhhcyBiZWVuIG51bGxlZCBvdXQuCihDb3JlSVBD OjpDb25uZWN0aW9uOjpkaXNwYXRjaENvbm5lY3Rpb25EaWRDbG9zZSk6IEFkanVzdCB0aGUgY29t bWVudHMgZm9yIHRoZSBjaGFuZ2UuCiogUGxhdGZvcm0vQ29yZUlQQy9Db25uZWN0aW9uLmg6Ci0t LQogV2ViS2l0Mi9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgIHwgICAxNiArKysrKysr KysrKysrKysrCiBXZWJLaXQyL1BsYXRmb3JtL0NvcmVJUEMvQ29ubmVjdGlvbi5jcHAgfCAgIDE3 ICsrKysrKysrKysrLS0tLS0tCiBXZWJLaXQyL1BsYXRmb3JtL0NvcmVJUEMvQ29ubmVjdGlvbi5o ICAgfCAgICAzICsrLQogMyBmaWxlcyBjaGFuZ2VkLCAyOSBpbnNlcnRpb25zKCspLCA3IGRlbGV0 aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VM b2cKaW5kZXggYzVkOWRiMi4uMzMxYjRkOCAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0xMi0yMCAgQmFs YXpzIEtlbGVtZW4gIDxrYmFsYXpzQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ3Jhc2ggaW4gd2ViIHByb2Nlc3MgYWZ0ZXIgdGhl IGNvbm5lY3Rpb24gaGFkIGJlZW4gY2xvc2VkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD01MTExNQorCisgICAgICAgIEFkZCBtdXR1YWwgZXhjbHVzaW9u IGZvciBtX2NsaWVudC4KKworICAgICAgICAqIFBsYXRmb3JtL0NvcmVJUEMvQ29ubmVjdGlvbi5j cHA6CisgICAgICAgIChDb3JlSVBDOjpDb25uZWN0aW9uOjppbnZhbGlkYXRlKTogQXF1aXJlIGxv Y2sgYmVmb3JlIG51bGxpbmcgb3V0IG1fY2xpZW50LgorICAgICAgICAoQ29yZUlQQzo6Q29ubmVj dGlvbjo6Y29ubmVjdGlvbkRpZENsb3NlKTogQXF1aXJlIGxvY2sgZm9yIG1fY2xpZW50IGFuZCBl YXJseQorICAgICAgICByZXR1cm4gaWYgaXQgaGFzIGJlZW4gbnVsbGVkIG91dC4KKyAgICAgICAg KENvcmVJUEM6OkNvbm5lY3Rpb246OmRpc3BhdGNoQ29ubmVjdGlvbkRpZENsb3NlKTogQWRqdXN0 IHRoZSBjb21tZW50cyBmb3IgdGhlIGNoYW5nZS4KKyAgICAgICAgKiBQbGF0Zm9ybS9Db3JlSVBD L0Nvbm5lY3Rpb24uaDoKKwogMjAxMS0wMS0xMyAgQmFsYXpzIEtlbGVtZW4gIDxrYmFsYXpzQHdl YmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCmRpZmYgLS1n aXQgYS9XZWJLaXQyL1BsYXRmb3JtL0NvcmVJUEMvQ29ubmVjdGlvbi5jcHAgYi9XZWJLaXQyL1Bs YXRmb3JtL0NvcmVJUEMvQ29ubmVjdGlvbi5jcHAKaW5kZXggZGE5MmNlNC4uYzM4MjNmZiAxMDA2 NDQKLS0tIGEvV2ViS2l0Mi9QbGF0Zm9ybS9Db3JlSVBDL0Nvbm5lY3Rpb24uY3BwCisrKyBiL1dl YktpdDIvUGxhdGZvcm0vQ29yZUlQQy9Db25uZWN0aW9uLmNwcApAQCAtNzUsNyArNzUsMTAgQEAg dm9pZCBDb25uZWN0aW9uOjppbnZhbGlkYXRlKCkKICAgICB9CiAgICAgCiAgICAgLy8gUmVzZXQg dGhlIGNsaWVudC4KLSAgICBtX2NsaWVudCA9IDA7CisgICAgeworICAgICAgICBNdXRleExvY2tl ciBsb2NrZXIobV9jbGllbnRMb2NrKTsKKyAgICAgICAgbV9jbGllbnQgPSAwOworICAgIH0KIAog ICAgIG1fY29ubmVjdGlvblF1ZXVlLnNjaGVkdWxlV29yayhXb3JrSXRlbTo6Y3JlYXRlKHRoaXMs ICZDb25uZWN0aW9uOjpwbGF0Zm9ybUludmFsaWRhdGUpKTsKIH0KQEAgLTMzNCwyNCArMzM3LDI2 IEBAIHZvaWQgQ29ubmVjdGlvbjo6Y29ubmVjdGlvbkRpZENsb3NlKCkKICAgICAgICAgICAgIG1f d2FpdEZvclN5bmNSZXBseVNlbWFwaG9yZS5zaWduYWwoKTsKICAgICB9CiAKLSAgICBtX2NsaWVu dC0+ZGlkQ2xvc2VPbkNvbm5lY3Rpb25Xb3JrUXVldWUoJm1fY29ubmVjdGlvblF1ZXVlLCB0aGlz KTsKKyAgICB7CisgICAgICAgIE11dGV4TG9ja2VyIGxvY2tlcihtX2NsaWVudExvY2spOworICAg ICAgICBpZiAoIWlzVmFsaWQoKSkKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgbV9jbGll bnQtPmRpZENsb3NlT25Db25uZWN0aW9uV29ya1F1ZXVlKCZtX2Nvbm5lY3Rpb25RdWV1ZSwgdGhp cyk7CisgICAgfQogCiAgICAgbV9jbGllbnRSdW5Mb29wLT5zY2hlZHVsZVdvcmsoV29ya0l0ZW06 OmNyZWF0ZSh0aGlzLCAmQ29ubmVjdGlvbjo6ZGlzcGF0Y2hDb25uZWN0aW9uRGlkQ2xvc2UpKTsK IH0KIAogdm9pZCBDb25uZWN0aW9uOjpkaXNwYXRjaENvbm5lY3Rpb25EaWRDbG9zZSgpCiB7Ci0g ICAgLy8gSWYgdGhlIGNvbm5lY3Rpb24gaGFzIGJlZW4gZXhwbGljaXRseSBpbnZhbGlkYXRlZCBi ZWZvcmUgZGlzcGF0Y2hDb25uZWN0aW9uRGlkQ2xvc2Ugd2FzIGNhbGxlZCwKLSAgICAvLyB0aGVu IHRoZSBjbGllbnQgd2lsbCBiZSBudWxsIGhlcmUuCiAgICAgaWYgKCFtX2NsaWVudCkKICAgICAg ICAgcmV0dXJuOwogCi0KICAgICAvLyBCZWNhdXNlIHdlIGRlZmluZSBhIGNvbm5lY3Rpb24gYXMg YmVpbmcgInZhbGlkIiBiYXNlZCBvbiB3aGV0ZXIgaXQgaGFzIGEgbnVsbCBjbGllbnQsIHdlIG51 bGwgb3V0CiAgICAgLy8gdGhlIGNsaWVudCBiZWZvcmUgY2FsbGluZyBkaWRDbG9zZSBoZXJlLiBP dGhlcndpc2UsIHNlbmRTeW5jIHdpbGwgdHJ5IHRvIHNlbmQgYSBtZXNzYWdlIHRvIHRoZSBjb25u ZWN0aW9uIGFuZAogICAgIC8vIHdpbGwgdGhlbiB3YWl0IGluZGVmaW5pdGVseSBmb3IgYSByZXBs eS4KICAgICBDbGllbnQqIGNsaWVudCA9IG1fY2xpZW50OwotICAgIG1fY2xpZW50ID0gMDsKKyAg ICBtX2NsaWVudCA9IDA7IC8vIE5vIG5lZWQgdG8gbG9jayBoZXJlIHNpbmNlIHRoZSBjb25uZWN0 aW5vIGhhcyBiZWVuIGNsb3NlZCBvbiB0aGUgd29yayB0aHJlYWQuCiAgICAgCiAgICAgY2xpZW50 LT5kaWRDbG9zZSh0aGlzKTsKIH0KZGlmZiAtLWdpdCBhL1dlYktpdDIvUGxhdGZvcm0vQ29yZUlQ Qy9Db25uZWN0aW9uLmggYi9XZWJLaXQyL1BsYXRmb3JtL0NvcmVJUEMvQ29ubmVjdGlvbi5oCmlu ZGV4IGI3ZTViMGYuLmI5NGU1MDIgMTAwNjQ0Ci0tLSBhL1dlYktpdDIvUGxhdGZvcm0vQ29yZUlQ Qy9Db25uZWN0aW9uLmgKKysrIGIvV2ViS2l0Mi9QbGF0Zm9ybS9Db3JlSVBDL0Nvbm5lY3Rpb24u aApAQCAtMTg5LDcgKzE4OSw4IEBAIHByaXZhdGU6CiAgICAgdm9pZCBkaXNwYXRjaENvbm5lY3Rp b25EaWRDbG9zZSgpOwogICAgIHZvaWQgZGlzcGF0Y2hNZXNzYWdlcygpOwogICAgIHZvaWQgZGlz cGF0Y2hTeW5jTWVzc2FnZShNZXNzYWdlSUQsIEFyZ3VtZW50RGVjb2RlciopOwotICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAKKworICAgIE11dGV4IG1fY2xpZW50TG9jazsKICAgICBDbGll bnQqIG1fY2xpZW50OwogICAgIGJvb2wgbV9pc1NlcnZlcjsKICAgICB1aW50NjRfdCBtX3N5bmNS ZXF1ZXN0SUQ7Ci0tIAoxLjcuMy4yCgo= 81556 2011-02-07 17:32:57 -0800 2011-02-07 17:42:56 -0800 Patch bug-51115-20110207173256.patch text/plain 8023 andersca SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDc3ODY4KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsNDIgQEAKKzIwMTEtMDItMDcgIEFuZGVycyBD YXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBDcmFzaCBpbiB3ZWIgcHJvY2VzcyBhZnRlciB0aGUgY29u bmVjdGlvbiBoYWQgYmVlbiBjbG9zZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTUxMTE1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84OTY0MjU1Pgor CisgICAgICAgIFJlbW92ZSBkaWRDbG9zZU9uQ29ubmVjdGlvbldvcmtRdWV1ZSBmcm9tIENvbm5l Y3Rpb246OkNsaWVudCBhbmQgYWRkCisgICAgICAgIENvbm5lY3Rpb246OnNldERpZENsb3NlT25D b25uZWN0aW9uV29ya1F1ZXVlQ2FsbGJhY2sgd2hpY2ggdGFrZXMgYSBzdGF0aWMKKyAgICAgICAg ZnVuY3Rpb24sIGVsaW1pbmF0aW5nIHRoZSByYWNlIGNvbmRpdGlvbiBpbiBjb25uZWN0aW9uRGlk Q2xvc2Ugd2hlcmUgbV9jbGllbnQgY291bGQgYmUKKyAgICAgICAgbnVsbGVkIG91dCBpbiB0aGUg Y2xpZW50IHRocmVhZCByaWdodCBiZWZvcmUgd2UgdHJ5IHRvIGRlcmVmZXJlbmNlIGl0LgorCisg ICAgICAgICogUGxhdGZvcm0vQ29yZUlQQy9Db25uZWN0aW9uLmNwcDoKKyAgICAgICAgKENvcmVJ UEM6OkNvbm5lY3Rpb246OkNvbm5lY3Rpb24pOgorICAgICAgICBJbml0aWFsaXplIG1fZGlkQ2xv c2VPbkNvbm5lY3Rpb25Xb3JrUXVldWVDYWxsYmFjay4KKworICAgICAgICAoQ29yZUlQQzo6Q29u bmVjdGlvbjo6c2V0RGlkQ2xvc2VPbkNvbm5lY3Rpb25Xb3JrUXVldWVDYWxsYmFjayk6CisgICAg ICAgIFVwZGF0ZSBtX2RpZENsb3NlT25Db25uZWN0aW9uV29ya1F1ZXVlQ2FsbGJhY2suCisKKyAg ICAgICAgKENvcmVJUEM6OkNvbm5lY3Rpb246OmNvbm5lY3Rpb25EaWRDbG9zZSk6CisgICAgICAg IENhbGwgbV9kaWRDbG9zZU9uQ29ubmVjdGlvbldvcmtRdWV1ZUNhbGxiYWNrLgorCisgICAgICAg ICogUGxhdGZvcm0vV29ya1F1ZXVlLmg6CisgICAgICAgIE1ha2UgV29ya1F1ZXVlIG5vbmNvcHlh YmxlLgorCisgICAgICAgICogUGx1Z2luUHJvY2Vzcy9QbHVnaW5Qcm9jZXNzLmNwcDoKKyAgICAg ICAgKFdlYktpdDo6UGx1Z2luUHJvY2Vzczo6aW5pdGlhbGl6ZUNvbm5lY3Rpb24pOgorICAgICAg ICBDYWxsIHNldERpZENsb3NlT25Db25uZWN0aW9uV29ya1F1ZXVlQ2FsbGJhY2suCisKKyAgICAg ICAgKiBTaGFyZWQvQ2hpbGRQcm9jZXNzLmNwcDoKKyAgICAgICAgKFdlYktpdDo6Q2hpbGRQcm9j ZXNzOjpkaWRDbG9zZU9uQ29ubmVjdGlvbldvcmtRdWV1ZSk6CisgICAgICAgICogU2hhcmVkL0No aWxkUHJvY2Vzcy5oOgorICAgICAgICBkaWRDbG9zZU9uQ29ubmVjdGlvbldvcmtRdWV1ZSBpcyBu b3cgYSBzdGF0aWMgbWVtYmVyIGZ1bmN0aW9uLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQ cm9jZXNzLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzczo6aW5pdGlhbGl6ZSk6Cisg ICAgICAgIENhbGwgc2V0RGlkQ2xvc2VPbkNvbm5lY3Rpb25Xb3JrUXVldWVDYWxsYmFjay4KKwog MjAxMS0wMi0wNyAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9QbGF0Zm9y bS9Xb3JrUXVldWUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9Xb3Jr UXVldWUuaAkocmV2aXNpb24gNzc4NjEpCisrKyBTb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9Xb3Jr UXVldWUuaAkod29ya2luZyBjb3B5KQpAQCAtNTEsNiArNTEsOCBAQCB0eXBlZGVmIHN0cnVjdCBf R01haW5Mb29wIEdNYWluTG9vcDsKICNlbmRpZgogCiBjbGFzcyBXb3JrUXVldWUgeworICAgIFdU Rl9NQUtFX05PTkNPUFlBQkxFKFdvcmtRdWV1ZSk7CisKIHB1YmxpYzoKICAgICBleHBsaWNpdCBX b3JrUXVldWUoY29uc3QgY2hhciogbmFtZSk7CiAgICAgfldvcmtRdWV1ZSgpOwpJbmRleDogU291 cmNlL1dlYktpdDIvUGxhdGZvcm0vQ29yZUlQQy9Db25uZWN0aW9uLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9Db3JlSVBDL0Nvbm5lY3Rpb24uY3BwCShyZXZpc2lv biA3Nzg2MSkKKysrIFNvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0NvcmVJUEMvQ29ubmVjdGlvbi5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTQ5LDYgKzQ5LDcgQEAgQ29ubmVjdGlvbjo6Q29ubmVjdGlv bihJZGVudGlmaWVyIGlkZW50aQogICAgIDogbV9jbGllbnQoY2xpZW50KQogICAgICwgbV9pc1Nl cnZlcihpc1NlcnZlcikKICAgICAsIG1fc3luY1JlcXVlc3RJRCgwKQorICAgICwgbV9kaWRDbG9z ZU9uQ29ubmVjdGlvbldvcmtRdWV1ZUNhbGxiYWNrKDApCiAgICAgLCBtX2lzQ29ubmVjdGVkKGZh bHNlKQogICAgICwgbV9jb25uZWN0aW9uUXVldWUoImNvbS5hcHBsZS5Db3JlSVBDLlJlY2VpdmVR dWV1ZSIpCiAgICAgLCBtX2NsaWVudFJ1bkxvb3AoY2xpZW50UnVuTG9vcCkKQEAgLTY4LDYgKzY5 LDEzIEBAIENvbm5lY3Rpb246On5Db25uZWN0aW9uKCkKICAgICBtX2Nvbm5lY3Rpb25RdWV1ZS5p bnZhbGlkYXRlKCk7CiB9CiAKK3ZvaWQgQ29ubmVjdGlvbjo6c2V0RGlkQ2xvc2VPbkNvbm5lY3Rp b25Xb3JrUXVldWVDYWxsYmFjayhEaWRDbG9zZU9uQ29ubmVjdGlvbldvcmtRdWV1ZUNhbGxiYWNr IGNhbGxiYWNrKQoreworICAgIEFTU0VSVCghbV9pc0Nvbm5lY3RlZCk7CisKKyAgICBtX2RpZENs b3NlT25Db25uZWN0aW9uV29ya1F1ZXVlQ2FsbGJhY2sgPSBjYWxsYmFjazsgICAgCit9CisKIHZv aWQgQ29ubmVjdGlvbjo6aW52YWxpZGF0ZSgpCiB7CiAgICAgaWYgKCFpc1ZhbGlkKCkpIHsKQEAg LTMzNCw3ICszNDIsOCBAQCB2b2lkIENvbm5lY3Rpb246OmNvbm5lY3Rpb25EaWRDbG9zZSgpCiAg ICAgICAgICAgICBtX3dhaXRGb3JTeW5jUmVwbHlTZW1hcGhvcmUuc2lnbmFsKCk7CiAgICAgfQog Ci0gICAgbV9jbGllbnQtPmRpZENsb3NlT25Db25uZWN0aW9uV29ya1F1ZXVlKCZtX2Nvbm5lY3Rp b25RdWV1ZSwgdGhpcyk7CisgICAgaWYgKG1fZGlkQ2xvc2VPbkNvbm5lY3Rpb25Xb3JrUXVldWVD YWxsYmFjaykKKyAgICAgICAgbV9kaWRDbG9zZU9uQ29ubmVjdGlvbldvcmtRdWV1ZUNhbGxiYWNr KG1fY29ubmVjdGlvblF1ZXVlLCB0aGlzKTsKIAogICAgIG1fY2xpZW50UnVuTG9vcC0+c2NoZWR1 bGVXb3JrKFdvcmtJdGVtOjpjcmVhdGUodGhpcywgJkNvbm5lY3Rpb246OmRpc3BhdGNoQ29ubmVj dGlvbkRpZENsb3NlKSk7CiB9CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9Db3JlSVBD L0Nvbm5lY3Rpb24uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9Db3Jl SVBDL0Nvbm5lY3Rpb24uaAkocmV2aXNpb24gNzc4NjEpCisrKyBTb3VyY2UvV2ViS2l0Mi9QbGF0 Zm9ybS9Db3JlSVBDL0Nvbm5lY3Rpb24uaAkod29ya2luZyBjb3B5KQpAQCAtODUsMTAgKzg1LDYg QEAgcHVibGljOgogICAgIHB1YmxpYzoKICAgICAgICAgdmlydHVhbCB2b2lkIGRpZENsb3NlKENv bm5lY3Rpb24qKSA9IDA7CiAgICAgICAgIHZpcnR1YWwgdm9pZCBkaWRSZWNlaXZlSW52YWxpZE1l c3NhZ2UoQ29ubmVjdGlvbiosIE1lc3NhZ2VJRCkgPSAwOwotCi0gICAgICAgIC8vIENhbGxlZCBv biB0aGUgY29ubmVjdGlvbiB3b3JrIHF1ZXVlIHdoZW4gdGhlIGNvbm5lY3Rpb24gaXMgY2xvc2Vk LCBiZWZvcmUKLSAgICAgICAgLy8gZGlkQ2FsbCBpcyBjYWxsZWQgb24gdGhlIGNsaWVudCB0aHJl YWQuCi0gICAgICAgIHZpcnR1YWwgdm9pZCBkaWRDbG9zZU9uQ29ubmVjdGlvbldvcmtRdWV1ZShX b3JrUXVldWUqLCBDb25uZWN0aW9uKikgeyB9CiAgICAgfTsKIAogI2lmIFBMQVRGT1JNKE1BQykK QEAgLTExMiw2ICsxMDgsMTQgQEAgcHVibGljOgogICAgIHZvaWQgc2V0U2hvdWxkQ2xvc2VDb25u ZWN0aW9uT25Qcm9jZXNzVGVybWluYXRpb24oV2ViS2l0OjpQbGF0Zm9ybVByb2Nlc3NJZGVudGlm aWVyKTsKICNlbmRpZgogCisgICAgLy8gVGhlIHNldCBjYWxsYmFjayB3aWxsIGJlIGNhbGxlZCBv biB0aGUgY29ubmVjdGlvbiB3b3JrIHF1ZXVlIHdoZW4gdGhlIGNvbm5lY3Rpb24gaXMgY2xvc2Vk LCAKKyAgICAvLyBiZWZvcmUgZGlkQ2FsbCBpcyBjYWxsZWQgb24gdGhlIGNsaWVudCB0aHJlYWQu IE11c3QgYmUgY2FsbGVkIGJlZm9yZSB0aGUgY29ubmVjdGlvbiBpcyBvcGVuZWQuCisgICAgLy8g SW4gdGhlIGZ1dHVyZSB3ZSBtaWdodCB3YW50IGEgbW9yZSBnZW5lcmljIHdheSB0byBoYW5kbGUg c3luYyBvciBhc3luYyBtZXNzYWdlcyBkaXJlY3RseQorICAgIC8vIG9uIHRoZSB3b3JrIHF1ZXVl LCBmb3IgZXhhbXBsZSBpZiB3ZSB3YW50IHRvIGhhbmRsZSB0aGVtIG9uIHNvbWUgb3RoZXIgdGhy ZWFkIHdlIGNvdWxkIGF2b2lkCisgICAgLy8gaGFuZGxpbmcgdGhlIG1lc3NhZ2Ugb24gdGhlIGNs aWVudCB0aHJlYWQgZmlyc3QuCisgICAgdHlwZWRlZiB2b2lkICgqRGlkQ2xvc2VPbkNvbm5lY3Rp b25Xb3JrUXVldWVDYWxsYmFjaykoV29ya1F1ZXVlJiwgQ29ubmVjdGlvbiopOworICAgIHZvaWQg c2V0RGlkQ2xvc2VPbkNvbm5lY3Rpb25Xb3JrUXVldWVDYWxsYmFjayhEaWRDbG9zZU9uQ29ubmVj dGlvbldvcmtRdWV1ZUNhbGxiYWNrIGNhbGxiYWNrKTsKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIAogICAgIGJvb2wgb3BlbigpOwogICAgIHZvaWQgaW52 YWxpZGF0ZSgpOwogICAgIHZvaWQgbWFya0N1cnJlbnRseURpc3BhdGNoZWRNZXNzYWdlQXNJbnZh bGlkKCk7CkBAIC0xOTQsNiArMTk4LDggQEAgcHJpdmF0ZToKICAgICBib29sIG1faXNTZXJ2ZXI7 CiAgICAgdWludDY0X3QgbV9zeW5jUmVxdWVzdElEOwogCisgICAgRGlkQ2xvc2VPbkNvbm5lY3Rp b25Xb3JrUXVldWVDYWxsYmFjayBtX2RpZENsb3NlT25Db25uZWN0aW9uV29ya1F1ZXVlQ2FsbGJh Y2s7CisKICAgICBib29sIG1faXNDb25uZWN0ZWQ7CiAgICAgV29ya1F1ZXVlIG1fY29ubmVjdGlv blF1ZXVlOwogICAgIFJ1bkxvb3AqIG1fY2xpZW50UnVuTG9vcDsKSW5kZXg6IFNvdXJjZS9XZWJL aXQyL1BsdWdpblByb2Nlc3MvUGx1Z2luUHJvY2Vzcy5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYktpdDIvUGx1Z2luUHJvY2Vzcy9QbHVnaW5Qcm9jZXNzLmNwcAkocmV2aXNpb24gNzc4NjEp CisrKyBTb3VyY2UvV2ViS2l0Mi9QbHVnaW5Qcm9jZXNzL1BsdWdpblByb2Nlc3MuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC02MSw2ICs2MSw3IEBAIHZvaWQgUGx1Z2luUHJvY2Vzczo6aW5pdGlhbGl6 ZUNvbm5lY3Rpb24KICAgICBBU1NFUlQoIW1fY29ubmVjdGlvbik7CiAKICAgICBtX2Nvbm5lY3Rp b24gPSBDb3JlSVBDOjpDb25uZWN0aW9uOjpjcmVhdGVDbGllbnRDb25uZWN0aW9uKHNlcnZlcklk ZW50aWZpZXIsIHRoaXMsIFJ1bkxvb3A6Om1haW4oKSk7CisgICAgbV9jb25uZWN0aW9uLT5zZXRE aWRDbG9zZU9uQ29ubmVjdGlvbldvcmtRdWV1ZUNhbGxiYWNrKGRpZENsb3NlT25Db25uZWN0aW9u V29ya1F1ZXVlKTsKICAgICBtX2Nvbm5lY3Rpb24tPm9wZW4oKTsKIH0KIApJbmRleDogU291cmNl L1dlYktpdDIvU2hhcmVkL0NoaWxkUHJvY2Vzcy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YktpdDIvU2hhcmVkL0NoaWxkUHJvY2Vzcy5jcHAJKHJldmlzaW9uIDc3ODYxKQorKysgU291cmNl L1dlYktpdDIvU2hhcmVkL0NoaWxkUHJvY2Vzcy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ4LDEz ICs0OCwxMyBAQCBOT19SRVRVUk4gc3RhdGljIHZvaWQgd2F0Y2hkb2dDYWxsYmFjaygpCiAgICAg X2V4aXQoRVhJVF9GQUlMVVJFKTsKIH0KIAotdm9pZCBDaGlsZFByb2Nlc3M6OmRpZENsb3NlT25D b25uZWN0aW9uV29ya1F1ZXVlKFdvcmtRdWV1ZSogd29ya1F1ZXVlLCBDb3JlSVBDOjpDb25uZWN0 aW9uKikKK3ZvaWQgQ2hpbGRQcm9jZXNzOjpkaWRDbG9zZU9uQ29ubmVjdGlvbldvcmtRdWV1ZShX b3JrUXVldWUmIHdvcmtRdWV1ZSwgQ29yZUlQQzo6Q29ubmVjdGlvbiopCiB7CiAgICAgLy8gSWYg dGhlIGNvbm5lY3Rpb24gaGFzIGJlZW4gY2xvc2VkIGFuZCB3ZSBoYXZlbid0IHJlc3BvbmRlZCBp biB0aGUgbWFpbiB0aHJlYWQgZm9yIDEwIHNlY29uZHMKICAgICAvLyB0aGUgcHJvY2VzcyB3aWxs IGV4aXQgZm9yY2libHkuCiAgICAgc3RhdGljIGNvbnN0IGRvdWJsZSB3YXRjaGRvZ0RlbGF5ID0g MTAuMDsKICAgICAKLSAgICB3b3JrUXVldWUtPnNjaGVkdWxlV29ya0FmdGVyRGVsYXkoV29ya0l0 ZW06OmNyZWF0ZSh3YXRjaGRvZ0NhbGxiYWNrKSwgd2F0Y2hkb2dEZWxheSk7CisgICAgd29ya1F1 ZXVlLnNjaGVkdWxlV29ya0FmdGVyRGVsYXkoV29ya0l0ZW06OmNyZWF0ZSh3YXRjaGRvZ0NhbGxi YWNrKSwgd2F0Y2hkb2dEZWxheSk7CiB9CiAgICAgCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQKSW5k ZXg6IFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9DaGlsZFByb2Nlc3MuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0Mi9TaGFyZWQvQ2hpbGRQcm9jZXNzLmgJKHJldmlzaW9uIDc3ODYxKQorKysg U291cmNlL1dlYktpdDIvU2hhcmVkL0NoaWxkUHJvY2Vzcy5oCSh3b3JraW5nIGNvcHkpCkBAIC0z Niw4ICszNiw3IEBAIHByb3RlY3RlZDoKICAgICBDaGlsZFByb2Nlc3MoKTsKICAgICB+Q2hpbGRQ cm9jZXNzKCk7CiAKLXByaXZhdGU6Ci0gICAgdm9pZCBkaWRDbG9zZU9uQ29ubmVjdGlvbldvcmtR dWV1ZShXb3JrUXVldWUqLCBDb3JlSVBDOjpDb25uZWN0aW9uKik7CisgICAgc3RhdGljIHZvaWQg ZGlkQ2xvc2VPbkNvbm5lY3Rpb25Xb3JrUXVldWUoV29ya1F1ZXVlJiwgQ29yZUlQQzo6Q29ubmVj dGlvbiopOwogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViS2l0CkluZGV4OiBTb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1dlYlByb2Nlc3MuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQy L1dlYlByb2Nlc3MvV2ViUHJvY2Vzcy5jcHAJKHJldmlzaW9uIDc3ODYxKQorKysgU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTI3LDYg KzEyNyw4IEBAIHZvaWQgV2ViUHJvY2Vzczo6aW5pdGlhbGl6ZShDb3JlSVBDOjpDb24KICAgICBB U1NFUlQoIW1fY29ubmVjdGlvbik7CiAKICAgICBtX2Nvbm5lY3Rpb24gPSBDb3JlSVBDOjpDb25u ZWN0aW9uOjpjcmVhdGVDbGllbnRDb25uZWN0aW9uKHNlcnZlcklkZW50aWZpZXIsIHRoaXMsIHJ1 bkxvb3ApOworICAgIG1fY29ubmVjdGlvbi0+c2V0RGlkQ2xvc2VPbkNvbm5lY3Rpb25Xb3JrUXVl dWVDYWxsYmFjayhkaWRDbG9zZU9uQ29ubmVjdGlvbldvcmtRdWV1ZSk7CisKICAgICBtX2Nvbm5l Y3Rpb24tPm9wZW4oKTsKIAogICAgIG1fcnVuTG9vcCA9IHJ1bkxvb3A7Cg==