51114 2010-12-15 09:46:07 -0800 Web Inspector: Up/Down/PageUp/PageDown on a CSS property numeric value commit the value editor 2010-12-16 15:38:27 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 apavlov apavlov abarth apavlov bweinstein eric joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 322638 0 apavlov 2010-12-15 09:46:07 -0800 [Page]Up/Down should not commit a CSS property value altogether but instead apply it to the style and continue editing. Patch to follow 322655 1 76660 apavlov 2010-12-15 10:06:35 -0800 Created attachment 76660 [PATCH] Suggested fix 322660 2 76660 yurys 2010-12-15 10:11:55 -0800 Comment on attachment 76660 [PATCH] Suggested fix View in context: https://bugs.webkit.org/attachment.cgi?id=76660&action=review > WebCore/inspector/front-end/ElementsPanel.js:-89 > - this.sidebarPanes.styles.addEventListener("style property toggled", this._stylesPaneEdited, this); _stylesPaneEdited is now only called from _styleSheetChanged, please get rid of _stylesPaneEdited 322674 3 76665 apavlov 2010-12-15 10:32:41 -0800 Created attachment 76665 [PATCH] Fix reimplemented correctly pfeldman@ has explained the idea behind the event handling. This patch reverts the erroneous fix from r74038 and augments the stylesheet onRevert handling 322864 4 76665 eric 2010-12-15 15:25:54 -0800 Comment on attachment 76665 [PATCH] Fix reimplemented correctly How do we test this? 323108 5 76751 apavlov 2010-12-16 05:00:19 -0800 Created attachment 76751 [PATCH] Test added 323113 6 pfeldman 2010-12-16 05:12:32 -0800 (In reply to comment #4) > (From update of attachment 76665 [details]) > How do we test this? Eric, could you please not blindly r- inspector changes that are missing tests without meaningful review comments? They go away from my to review report and this slows down the development. If you are willing to help us with the testing, as you know, inspector tests became flaky at some point and something in the harness needs to be fixed. I already had similar discussion with Adam the other day. 323139 7 apavlov 2010-12-16 06:10:25 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/inspector/styles-add-blank-property-expected.txt M LayoutTests/inspector/styles-add-blank-property.html M WebCore/ChangeLog M WebCore/inspector/front-end/ElementsPanel.js Committed r74185 323466 8 webkit.review.bot 2010-12-16 15:38:27 -0800 http://trac.webkit.org/changeset/74185 might have broken Leopard Intel Debug (Tests) 76660 2010-12-15 10:06:35 -0800 2010-12-15 10:32:41 -0800 [PATCH] Suggested fix scrollcommits.patch text/plain 2994 apavlov Y29tbWl0IDdiOTM1ZjE2M2U5MmY4M2ZmZDZiZTNjMjhhNDEwMTI0ODU5ZGJlOTEKQXV0aG9yOiBB bGV4YW5kZXIgUGF2bG92IDxhcGF2bG92QGNocm9taXVtLm9yZz4KRGF0ZTogICBXZWQgRGVjIDE1 IDIwOjU5OjI5IDIwMTAgKzAzMDAKCiAgICBGaXhTY3JvbGxDb21taXR0aW5nCgpkaWZmIC0tZ2l0 IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAxZGMzNzMyLi44 MzFjMWI1IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEwLTEyLTE1ICBBbGV4YW5kZXIgUGF2bG92ICA8YXBh dmxvdkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVXAvRG93bi9QYWdlVXAvUGFnZURvd24gb24gYSBD U1MgcHJvcGVydHkgbnVtZXJpYyB2YWx1ZSBjb21taXQgdGhlIHZhbHVlIGVkaXRvcgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTExMTQKKworICAgICAg ICBFbGVtZW50c1BhbmVsIHNob3VsZCBub3QgbGlzdGVuIHRvIHRoZSBzdHlsZSBlZGl0aW5nIGV2 ZW50czogdGhleSBhcmUgb25seSB1c2VkIHRvIHVwZGF0ZSB0aGUgU3R5bGVzIHBhbmUuCisgICAg ICAgIEF0IHRoZSBzYW1lIHRpbWUsIHRoZSBTdHlsZXMgcGFuZSBkb2VzIHVwZGF0ZSBpdHNlbGYg b25jZSBDU1MgZWRpdGluZyBpcyBjb21taXR0ZWQsIHRodXMgdGhlcmUgYXJlCisgICAgICAgIHR3 byBjb25zZWN1dGl2ZSB1cGRhdGVzIHRvIHRoZSBTdHlsZXMgcGFuZS4gVGhlIGJ1ZyBtYW5pZmVz dGVkIGl0c2VsZiBhZnRlciBidWcgNTEwMzQgaGFkIGJlZW4gZml4ZWQuCisKKyAgICAgICAgKiBp bnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzUGFuZWwuanM6CisgICAgICAgIChXZWJJbnNwZWN0 b3IuRWxlbWVudHNQYW5lbCk6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9TdHlsZXNT aWRlYmFyUGFuZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5TdHlsZVByb3BlcnR5VHJlZUVs ZW1lbnQucHJvdG90eXBlLik6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU3R5bGVQcm9wZXJ0eVRy ZWVFbGVtZW50LnByb3RvdHlwZSk6CisKIDIwMTAtMTItMTUgIEVyaWMgQ2FybHNvbiAgPGVyaWMu Y2FybHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCmRp ZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRWxlbWVudHNQYW5lbC5qcyBi L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1BhbmVsLmpzCmluZGV4IGQwOTZm ZTkuLjUzZTlmMmMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVt ZW50c1BhbmVsLmpzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1Bh bmVsLmpzCkBAIC04NSw4ICs4NSw2IEBAIFdlYkluc3BlY3Rvci5FbGVtZW50c1BhbmVsID0gZnVu Y3Rpb24oKQogCiAgICAgdGhpcy5zaWRlYmFyUGFuZXMuc3R5bGVzLmV4cGFuZGVkID0gdHJ1ZTsK IAotICAgIHRoaXMuc2lkZWJhclBhbmVzLnN0eWxlcy5hZGRFdmVudExpc3RlbmVyKCJzdHlsZSBl ZGl0ZWQiLCB0aGlzLl9zdHlsZXNQYW5lRWRpdGVkLCB0aGlzKTsKLSAgICB0aGlzLnNpZGViYXJQ YW5lcy5zdHlsZXMuYWRkRXZlbnRMaXN0ZW5lcigic3R5bGUgcHJvcGVydHkgdG9nZ2xlZCIsIHRo aXMuX3N0eWxlc1BhbmVFZGl0ZWQsIHRoaXMpOwogICAgIHRoaXMuc2lkZWJhclBhbmVzLm1ldHJp Y3MuYWRkRXZlbnRMaXN0ZW5lcigibWV0cmljcyBlZGl0ZWQiLCB0aGlzLl9tZXRyaWNzUGFuZUVk aXRlZCwgdGhpcyk7CiAgICAgV2ViSW5zcGVjdG9yLmNzc01vZGVsLmFkZEV2ZW50TGlzdGVuZXIo InN0eWxlc2hlZXQgY2hhbmdlZCIsIHRoaXMuX3N0eWxlU2hlZXRDaGFuZ2VkLCB0aGlzKTsKIApk aWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1N0eWxlc1NpZGViYXJQYW5l LmpzIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1N0eWxlc1NpZGViYXJQYW5lLmpzCmlu ZGV4IGEzZDc5YzEuLjA1ZDNhNTMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250 LWVuZC9TdHlsZXNTaWRlYmFyUGFuZS5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvU3R5bGVzU2lkZWJhclBhbmUuanMKQEAgLTE4NzksMTEgKzE4NzksMTMgQEAgV2ViSW5zcGVj dG9yLlN0eWxlUHJvcGVydHlUcmVlRWxlbWVudC5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICB0 aGlzLnByb3BlcnR5ID0gbmV3U3R5bGUucHJvcGVydHlBdCh0aGlzLnByb3BlcnR5LmluZGV4KTsK ICAgICAgICAgICAgIHRoaXMuX3N0eWxlUnVsZS5zdHlsZSA9IHRoaXMuc3R5bGU7CiAKLSAgICAg ICAgICAgIGlmIChzZWN0aW9uICYmIHNlY3Rpb24ucGFuZSkKLSAgICAgICAgICAgICAgICBzZWN0 aW9uLnBhbmUuZGlzcGF0Y2hFdmVudFRvTGlzdGVuZXJzKCJzdHlsZSBlZGl0ZWQiKTsKLQotICAg ICAgICAgICAgaWYgKHVwZGF0ZUludGVyZmFjZSkKKyAgICAgICAgICAgIGlmICh1cGRhdGVJbnRl cmZhY2UpIHsKICAgICAgICAgICAgICAgICB0aGlzLnVwZGF0ZUFsbCh0cnVlKTsKKworICAgICAg ICAgICAgICAgIC8vIFRoZSBldmVudCBzaG91bGQgb25seSBiZSBkaXNwYXRjaGVkIG9uIGEgbWFq b3Igc3R5bGUgY2hhbmdlIChwcm9wZXJ0eSBlZGl0aW5nIGNvbW1pdHRlZCkuCisgICAgICAgICAg ICAgICAgaWYgKHNlY3Rpb24gJiYgc2VjdGlvbi5wYW5lKQorICAgICAgICAgICAgICAgICAgICBz ZWN0aW9uLnBhbmUuZGlzcGF0Y2hFdmVudFRvTGlzdGVuZXJzKCJzdHlsZSBlZGl0ZWQiKTsKKyAg ICAgICAgICAgIH0KICAgICAgICAgfQogCiAgICAgICAgIC8vIEFwcGVuZCBhICI7IiBpZiB0aGUg bmV3IHRleHQgZG9lcyBub3QgZW5kIGluICI7Ii4K 76665 2010-12-15 10:32:41 -0800 2010-12-16 05:00:19 -0800 [PATCH] Fix reimplemented correctly scrollcommits.patch text/plain 2041 apavlov Y29tbWl0IDZkODJlYTcwMzA3YzAwYWNiNmE3YzdiYWU0NzY2NjUyZmQ1OTcwMTYKQXV0aG9yOiBB bGV4YW5kZXIgUGF2bG92IDxhcGF2bG92QGNocm9taXVtLm9yZz4KRGF0ZTogICBXZWQgRGVjIDE1 IDIwOjU5OjI5IDIwMTAgKzAzMDAKCiAgICBGaXhTY3JvbGxDb21taXR0aW5nCgpkaWZmIC0tZ2l0 IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAxZGMzNzMyLi5k MTE4MTQxIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEwLTEyLTE1ICBBbGV4YW5kZXIgUGF2bG92ICA8YXBh dmxvdkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVXAvRG93bi9QYWdlVXAvUGFnZURvd24gb24gYSBD U1MgcHJvcGVydHkgbnVtZXJpYyB2YWx1ZSBjb21taXQgdGhlIHZhbHVlIGVkaXRvcgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTExMTQKKworICAgICAg ICBUaGUgcjc0MDM4IHJlZ3Jlc3NlZCB0aGUgYmVoYXZpb3VyLiBUaGlzIHBhdGNoIGFkZGl0aW9u YWxseSBlbnN1cmVzIHRoYXQgYm90aCBNZXRyaWNzIGFuZCBTdHlsZXMgcGFuZXMKKyAgICAgICAg YXJlIHVwZGF0ZWQgb25jZSBhIHN0eWxlc2hlZXQgaXMgcmV2ZXJ0ZWQuCisKKyAgICAgICAgKiBp bnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzUGFuZWwuanM6CisgICAgICAgIChXZWJJbnNwZWN0 b3IuRWxlbWVudHNQYW5lbC5wcm90b3R5cGUuX3N0eWxlc1BhbmVFZGl0ZWQpOgorICAgICAgICAo V2ViSW5zcGVjdG9yLkVsZW1lbnRzUGFuZWwucHJvdG90eXBlLl9tZXRyaWNzUGFuZUVkaXRlZCk6 CisgICAgICAgIChXZWJJbnNwZWN0b3IuRWxlbWVudHNQYW5lbC5wcm90b3R5cGUuX3N0eWxlU2hl ZXRDaGFuZ2VkKToKKwogMjAxMC0xMi0xNSAgRXJpYyBDYXJsc29uICA8ZXJpYy5jYXJsc29uQGFw cGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBh L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1BhbmVsLmpzIGIvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzUGFuZWwuanMKaW5kZXggZDA5NmZlOS4uOTI5OTQ3 OSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzUGFuZWwu anMKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzUGFuZWwuanMKQEAg LTQ0MywyMCArNDQzLDIzIEBAIFdlYkluc3BlY3Rvci5FbGVtZW50c1BhbmVsLnByb3RvdHlwZSA9 IHsKICAgICAgICAgICAgIHRoaXMudXBkYXRlQnJlYWRjcnVtYih0cnVlKTsKICAgICB9LAogCi0g ICAgX21ldHJpY3NQYW5lRWRpdGVkOiBmdW5jdGlvbigpCisgICAgX3N0eWxlc1BhbmVFZGl0ZWQ6 IGZ1bmN0aW9uKCkKICAgICB7CisgICAgICAgIC8vIE9uY2Ugc3R5bGVzIGFyZSBlZGl0ZWQsIHRo ZSBNZXRyaWNzIHBhbmUgc2hvdWxkIGJlIHVwZGF0ZWQuCiAgICAgICAgIHRoaXMuc2lkZWJhclBh bmVzLm1ldHJpY3MubmVlZHNVcGRhdGUgPSB0cnVlOwogICAgICAgICB0aGlzLnVwZGF0ZU1ldHJp Y3MoKTsKICAgICB9LAogCi0gICAgX3N0eWxlc1BhbmVFZGl0ZWQ6IGZ1bmN0aW9uKCkKKyAgICBf bWV0cmljc1BhbmVFZGl0ZWQ6IGZ1bmN0aW9uKCkKICAgICB7CisgICAgICAgIC8vIE9uY2UgbWV0 cmljcyBhcmUgZWRpdGVkLCB0aGUgU3R5bGVzIHBhbmUgc2hvdWxkIGJlIHVwZGF0ZWQuCiAgICAg ICAgIHRoaXMuc2lkZWJhclBhbmVzLnN0eWxlcy5uZWVkc1VwZGF0ZSA9IHRydWU7CiAgICAgICAg IHRoaXMudXBkYXRlU3R5bGVzKHRydWUpOwogICAgIH0sCiAKICAgICBfc3R5bGVTaGVldENoYW5n ZWQ6IGZ1bmN0aW9uKCkKICAgICB7CisgICAgICAgIHRoaXMuX21ldHJpY3NQYW5lRWRpdGVkKCk7 CiAgICAgICAgIHRoaXMuX3N0eWxlc1BhbmVFZGl0ZWQoKTsKICAgICB9LAogCg== 76751 2010-12-16 05:00:19 -0800 2010-12-16 05:42:55 -0800 [PATCH] Test added scrollcommits.patch text/plain 5852 apavlov Y29tbWl0IDRhN2VjYmY2Y2IyNjkxZjA5ODU0Mzc2MDE4ZmU2OTlkMjAwNTAwNzkKQXV0aG9yOiBB bGV4YW5kZXIgUGF2bG92IDxhcGF2bG92QGNocm9taXVtLm9yZz4KRGF0ZTogICBXZWQgRGVjIDE1 IDIwOjU5OjI5IDIwMTAgKzAzMDAKCiAgICBGaXhTY3JvbGxDb21taXR0aW5nCgpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDM3 YWFmZGUuLmRiMTJiYmIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0xMi0xNiAgQWxleGFu ZGVyIFBhdmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFVwL0Rvd24vUGFnZVVw L1BhZ2VEb3duIG9uIGEgQ1NTIHByb3BlcnR5IG51bWVyaWMgdmFsdWUgY29tbWl0IHRoZSB2YWx1 ZSBlZGl0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTUxMTE0CisKKyAgICAgICAgKiBpbnNwZWN0b3Ivc3R5bGVzLWFkZC1ibGFuay1wcm9wZXJ0eS1l eHBlY3RlZC50eHQ6CisgICAgICAgICogaW5zcGVjdG9yL3N0eWxlcy1hZGQtYmxhbmstcHJvcGVy dHkuaHRtbDoKKwogMjAxMC0xMi0xNiAgWm9sdGFuIEhlcmN6ZWcgIDx6aGVyY3plZ0B3ZWJraXQu b3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpcmsgU2NodWx6ZS4KZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL2luc3BlY3Rvci9zdHlsZXMtYWRkLWJsYW5rLXByb3BlcnR5LWV4cGVjdGVkLnR4 dCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9zdHlsZXMtYWRkLWJsYW5rLXByb3BlcnR5LWV4cGVj dGVkLnR4dAppbmRleCA2OGEwZWMxLi5kZWIzNWJkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9p bnNwZWN0b3Ivc3R5bGVzLWFkZC1ibGFuay1wcm9wZXJ0eS1leHBlY3RlZC50eHQKKysrIGIvTGF5 b3V0VGVzdHMvaW5zcGVjdG9yL3N0eWxlcy1hZGQtYmxhbmstcHJvcGVydHktZXhwZWN0ZWQudHh0 CkBAIC0xMyw3ICsxMyw3IEBAIGRpc3BsYXk6IGJsb2NrOwogQWZ0ZXIgYXBwZW5kOgogW2V4cGFu ZGVkXSBlbGVtZW50LnN0eWxlIHsgKCkKIGZvbnQtc2l6ZTogMTJweDsKLXRleHQtZGVjb3JhdGlv bjogbm9uZTsKK21hcmdpbi1sZWZ0OiAzcHg7CiAKID09PT09PT09IE1hdGNoZWQgQ1NTIFJ1bGVz ID09PT09PT09CiBbZXhwYW5kZWRdIGRpdiB7ICh1c2VyIGFnZW50IHN0eWxlc2hlZXQpCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3Ivc3R5bGVzLWFkZC1ibGFuay1wcm9wZXJ0eS5o dG1sIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL3N0eWxlcy1hZGQtYmxhbmstcHJvcGVydHkuaHRt bAppbmRleCBmZDM2YTk1Li5iNmI1MGU2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbnNwZWN0 b3Ivc3R5bGVzLWFkZC1ibGFuay1wcm9wZXJ0eS5odG1sCisrKyBiL0xheW91dFRlc3RzL2luc3Bl Y3Rvci9zdHlsZXMtYWRkLWJsYW5rLXByb3BlcnR5Lmh0bWwKQEAgLTI3LDYgKzI3LDEzIEBAIGZ1 bmN0aW9uIGZyb250ZW5kX3NlbGVjdEluc3BlY3RlZEVsZW1lbnQodGVzdENvbnRyb2xsZXIpCiAg ICAgZnJvbnRlbmRfc2VsZWN0RWxlbWVudEFuZFJ1bih0ZXN0Q29udHJvbGxlciwgImluc3BlY3Rl ZCIsIGZyb250ZW5kX2R1bXBJbnNwZWN0ZWRTdHlsZSk7CiB9CiAKK2Z1bmN0aW9uIGZyb250ZW5k X2NyZWF0ZUtleWJvYXJkRXZlbnQoZXZlbnROYW1lLCBrZXlJZGVudGlmaWVyKQoreworICAgIHZh ciBldnQgPSBkb2N1bWVudC5jcmVhdGVFdmVudCgiS2V5Ym9hcmRFdmVudCIpOworICAgIGV2dC5p bml0S2V5Ym9hcmRFdmVudChldmVudE5hbWUsIHRydWUgLyogY2FuIGJ1YmJsZSAqLywgdHJ1ZSAv KiBjYW4gY2FuY2VsICovLCBudWxsIC8qIHZpZXcgKi8sIGtleUlkZW50aWZpZXIsICIiKTsKKyAg ICByZXR1cm4gZXZ0OworfQorCiBmdW5jdGlvbiBmcm9udGVuZF9kdW1wSW5zcGVjdGVkU3R5bGUo dGVzdENvbnRyb2xsZXIpCiB7CiAgICAgdGVzdENvbnRyb2xsZXIucmVzdWx0cy5wdXNoKCJCZWZv cmUgYXBwZW5kOiIpOwpAQCAtMzUsMTUgKzQyLDM1IEBAIGZ1bmN0aW9uIGZyb250ZW5kX2R1bXBJ bnNwZWN0ZWRTdHlsZSh0ZXN0Q29udHJvbGxlcikKICAgICB2YXIgc2VjdGlvbiA9IFdlYkluc3Bl Y3Rvci5wYW5lbHMuZWxlbWVudHMuc2lkZWJhclBhbmVzLnN0eWxlcy5zZWN0aW9uc1swXVsxXTsK ICAgICBzZWN0aW9uLmV4cGFuZCgpOwogICAgIHZhciB0cmVlRWxlbWVudCA9IHNlY3Rpb24uYWRk TmV3QmxhbmtQcm9wZXJ0eSgpOwotICAgIHRyZWVFbGVtZW50LnN0YXJ0RWRpdGluZygpOworICAg IHZhciBlbnRlcktleURvd24gPSBmcm9udGVuZF9jcmVhdGVLZXlib2FyZEV2ZW50KCJrZXlkb3du IiwgIkVudGVyIik7CisgICAgdmFyIGluY3JlbWVudEtleURvd24gPSBmcm9udGVuZF9jcmVhdGVL ZXlib2FyZEV2ZW50KCJrZXlkb3duIiwgIlVwIik7CiAKLSAgICB2YXIgZXZ0ID0gZG9jdW1lbnQu Y3JlYXRlRXZlbnQoIktleWJvYXJkRXZlbnQiKTsKLSAgICBldnQuaW5pdEtleWJvYXJkRXZlbnQo ImtleWRvd24iLCB0cnVlIC8qIGNhbiBidWJibGUgKi8sIHRydWUgLyogY2FuIGNhbmNlbCAqLywg bnVsbCAvKiB2aWV3ICovLCAiRW50ZXIiLCAiIik7Ci0gICAgdHJlZUVsZW1lbnQubmFtZUVsZW1l bnQudGV4dENvbnRlbnQgPSAidGV4dC1kZWNvcmF0aW9uIjsKLSAgICB0cmVlRWxlbWVudC52YWx1 ZUVsZW1lbnQudGV4dENvbnRlbnQgPSAibm9uZSI7Ci0gICAgdHJlZUVsZW1lbnQubmFtZUVsZW1l bnQuZGlzcGF0Y2hFdmVudChldnQpOworICAgIGZ1bmN0aW9uIHJlbW92ZUVtcHR5KCkKKyAgICB7 CisgICAgICAgIHdpbmRvdy5nZXRTZWxlY3Rpb24oKS5hbmNob3JOb2RlLmRpc3BhdGNoRXZlbnQo ZW50ZXJLZXlEb3duKTsKKyAgICAgICAgZnJvbnRlbmRfZHVtcFJlc3VsdHModGVzdENvbnRyb2xs ZXIpOworICAgIH0KIAotICAgIHRlc3RDb250cm9sbGVyLnJ1bkFmdGVyUGVuZGluZ0Rpc3BhdGNo ZXMoZnJvbnRlbmRfZHVtcFJlc3VsdHMuYmluZCh0aGlzLCB0ZXN0Q29udHJvbGxlcikpOworICAg IGZ1bmN0aW9uIGNvbW1pdCgpCisgICAgeworICAgICAgICB0cmVlRWxlbWVudC52YWx1ZUVsZW1l bnQuZGlzcGF0Y2hFdmVudChlbnRlcktleURvd24pOworICAgICAgICB0ZXN0Q29udHJvbGxlci5y dW5BZnRlclBlbmRpbmdEaXNwYXRjaGVzKHJlbW92ZUVtcHR5LmJpbmQodGhpcykpOworICAgICAg ICBmcm9udGVuZF9kdW1wUmVzdWx0cyh0ZXN0Q29udHJvbGxlcik7CisgICAgfQorCisgICAgZnVu Y3Rpb24gaW5jcmVtZW50QWdhaW4oKQorICAgIHsKKyAgICAgICAgdHJlZUVsZW1lbnQudmFsdWVF bGVtZW50LmRpc3BhdGNoRXZlbnQoaW5jcmVtZW50S2V5RG93bik7CisgICAgICAgIHRlc3RDb250 cm9sbGVyLnJ1bkFmdGVyUGVuZGluZ0Rpc3BhdGNoZXMoY29tbWl0LmJpbmQodGhpcykpOworICAg IH0KKworICAgIHRyZWVFbGVtZW50LnN0YXJ0RWRpdGluZygpOworICAgIHRyZWVFbGVtZW50Lm5h bWVFbGVtZW50LnRleHRDb250ZW50ID0gIm1hcmdpbi1sZWZ0IjsKKyAgICB0cmVlRWxlbWVudC5u YW1lRWxlbWVudC5kaXNwYXRjaEV2ZW50KGVudGVyS2V5RG93bik7CisgICAgdHJlZUVsZW1lbnQu dmFsdWVFbGVtZW50LnRleHRDb250ZW50ID0gIjFweCI7CisgICAgdHJlZUVsZW1lbnQudmFsdWVF bGVtZW50LmZpcnN0Q2hpbGQuc2VsZWN0KCk7CisgICAgdHJlZUVsZW1lbnQudmFsdWVFbGVtZW50 LmRpc3BhdGNoRXZlbnQoaW5jcmVtZW50S2V5RG93bik7CisgICAgdGVzdENvbnRyb2xsZXIucnVu QWZ0ZXJQZW5kaW5nRGlzcGF0Y2hlcyhpbmNyZW1lbnRBZ2Fpbi5iaW5kKHRoaXMpKTsKIH0KIAog ZnVuY3Rpb24gZnJvbnRlbmRfZHVtcFJlc3VsdHModGVzdENvbnRyb2xsZXIpCmRpZmYgLS1naXQg YS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDA4MjdiZjUuLjQ0 NThjM2MgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMTItMTYgIEFsZXhhbmRlciBQYXZsb3YgIDxhcGF2 bG92QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBXZWIgSW5zcGVjdG9yOiBVcC9Eb3duL1BhZ2VVcC9QYWdlRG93biBvbiBhIENT UyBwcm9wZXJ0eSBudW1lcmljIHZhbHVlIGNvbW1pdCB0aGUgdmFsdWUgZWRpdG9yCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MTExNAorCisgICAgICAg IFRoZSByNzQwMzggcmVncmVzc2VkIHRoZSBiZWhhdmlvdXIuIFRoaXMgcGF0Y2ggYWRkaXRpb25h bGx5IGVuc3VyZXMgdGhhdCBib3RoIE1ldHJpY3MgYW5kIFN0eWxlcyBwYW5lcworICAgICAgICBh cmUgdXBkYXRlZCBvbmNlIGEgc3R5bGVzaGVldCBpcyByZXZlcnRlZC4KKworICAgICAgICAqIGlu c3BlY3Rvci9mcm9udC1lbmQvRWxlbWVudHNQYW5lbC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rv ci5FbGVtZW50c1BhbmVsLnByb3RvdHlwZS5fc3R5bGVzUGFuZUVkaXRlZCk6CisgICAgICAgIChX ZWJJbnNwZWN0b3IuRWxlbWVudHNQYW5lbC5wcm90b3R5cGUuX21ldHJpY3NQYW5lRWRpdGVkKToK KyAgICAgICAgKFdlYkluc3BlY3Rvci5FbGVtZW50c1BhbmVsLnByb3RvdHlwZS5fc3R5bGVTaGVl dENoYW5nZWQpOgorCiAyMDEwLTEyLTE2ICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9y Zz4KIAogICAgICAgICBVbnJldmlld2VkLCBidWlsZCBmaXguCmRpZmYgLS1naXQgYS9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvRWxlbWVudHNQYW5lbC5qcyBiL1dlYkNvcmUvaW5zcGVjdG9y L2Zyb250LWVuZC9FbGVtZW50c1BhbmVsLmpzCmluZGV4IGQwOTZmZTkuLjkyOTk0NzkgMTAwNjQ0 Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1BhbmVsLmpzCisrKyBi L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1BhbmVsLmpzCkBAIC00NDMsMjAg KzQ0MywyMyBAQCBXZWJJbnNwZWN0b3IuRWxlbWVudHNQYW5lbC5wcm90b3R5cGUgPSB7CiAgICAg ICAgICAgICB0aGlzLnVwZGF0ZUJyZWFkY3J1bWIodHJ1ZSk7CiAgICAgfSwKIAotICAgIF9tZXRy aWNzUGFuZUVkaXRlZDogZnVuY3Rpb24oKQorICAgIF9zdHlsZXNQYW5lRWRpdGVkOiBmdW5jdGlv bigpCiAgICAgeworICAgICAgICAvLyBPbmNlIHN0eWxlcyBhcmUgZWRpdGVkLCB0aGUgTWV0cmlj cyBwYW5lIHNob3VsZCBiZSB1cGRhdGVkLgogICAgICAgICB0aGlzLnNpZGViYXJQYW5lcy5tZXRy aWNzLm5lZWRzVXBkYXRlID0gdHJ1ZTsKICAgICAgICAgdGhpcy51cGRhdGVNZXRyaWNzKCk7CiAg ICAgfSwKIAotICAgIF9zdHlsZXNQYW5lRWRpdGVkOiBmdW5jdGlvbigpCisgICAgX21ldHJpY3NQ YW5lRWRpdGVkOiBmdW5jdGlvbigpCiAgICAgeworICAgICAgICAvLyBPbmNlIG1ldHJpY3MgYXJl IGVkaXRlZCwgdGhlIFN0eWxlcyBwYW5lIHNob3VsZCBiZSB1cGRhdGVkLgogICAgICAgICB0aGlz LnNpZGViYXJQYW5lcy5zdHlsZXMubmVlZHNVcGRhdGUgPSB0cnVlOwogICAgICAgICB0aGlzLnVw ZGF0ZVN0eWxlcyh0cnVlKTsKICAgICB9LAogCiAgICAgX3N0eWxlU2hlZXRDaGFuZ2VkOiBmdW5j dGlvbigpCiAgICAgeworICAgICAgICB0aGlzLl9tZXRyaWNzUGFuZUVkaXRlZCgpOwogICAgICAg ICB0aGlzLl9zdHlsZXNQYW5lRWRpdGVkKCk7CiAgICAgfSwKIAo=