51084 2010-12-14 18:30:31 -0800 In KeyFrameAnimation.cpp, the progress variable is uninitialized, leading to compilation failure 2011-01-14 17:20:14 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 asharif.tools webkit-unassigned asharif.tools commit-queue fishd oldest_to_newest 322426 0 asharif.tools 2010-12-14 18:30:31 -0800 In KeyFrameAnimation.cpp, the progress variable is uninitialized, leading to compilation failure on Linux when compiled with -Werror using gcc. This happens because the function fetchIntervalEndpointsForProperty may have a path that will leave progress uninitialized if it is inlined. The progress variable can simply be set to 0 when created as shown here: http://codereview.chromium.org/5832001/diff/1/third_party/WebKit/WebCore/page/animation/KeyframeAnimation.cpp 322491 1 fishd 2010-12-14 20:53:46 -0800 Would you be so kind as to post your patch to this bug report following the instructions provided at http://webkit.org/coding/contributing.html? Thanks! 327380 2 77579 asharif.tools 2010-12-28 14:23:02 -0800 Created attachment 77579 Patch to fix this problem. It includes a ChangeLog entry. Sorry about the delay. I didn't realize you had replied. This patch initializes the progress variable to 0.0. 332606 3 asharif.tools 2011-01-11 13:28:05 -0800 (In reply to comment #2) > Created an attachment (id=77579) [details] > Patch to fix this problem. It includes a ChangeLog entry. > > Sorry about the delay. I didn't realize you had replied. This patch initializes the progress variable to 0.0. Ping. Is this bug fixed? Can you update the status after applying my patch? Thanks, 333929 4 asharif.tools 2011-01-13 14:17:36 -0800 (In reply to comment #3) > (In reply to comment #2) > > Created an attachment (id=77579) [details] [details] > > Patch to fix this problem. It includes a ChangeLog entry. > > > > Sorry about the delay. I didn't realize you had replied. This patch initializes the progress variable to 0.0. > > Ping. Is this bug fixed? Can you update the status after applying my patch? > > Thanks, Please review and apply this patch. I would like for this patch to be integrated into Chromium soon. Thanks, 334452 5 78969 asharif.tools 2011-01-14 11:35:18 -0800 Created attachment 78969 This is an update to the earlier patch and fixes progress in both locations. 334766 6 78969 commit-queue 2011-01-14 17:20:08 -0800 Comment on attachment 78969 This is an update to the earlier patch and fixes progress in both locations. Clearing flags on attachment: 78969 Committed r75850: <http://trac.webkit.org/changeset/75850> 334767 7 commit-queue 2011-01-14 17:20:14 -0800 All reviewed patches have been landed. Closing bug. 77579 2010-12-28 14:23:02 -0800 2011-01-14 11:35:18 -0800 Patch to fix this problem. It includes a ChangeLog entry. initialize_progress.patch text/plain 1309 asharif.tools SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3NDcyNSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMTItMjggIEFobWFkIFNoYXJpZiAgPGFzaGFyaWZAZ29vZ2xl LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBX aGVuIGlubGluZyBpcyBwZXJmb3JtZWQsIHRoZSBwcm9ncmVzcyB2YXJpYWJsZSBpcyBkZWNsYXJl ZCBhcworICAgICAgICB1bmluaXRpYWxpemVkLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gVHJp dmlhbCBmaXguCisKKyAgICAgICAgKiBwYWdlL2FuaW1hdGlvbi9LZXlmcmFtZUFuaW1hdGlvbi5j cHA6CisgICAgICAgIChXZWJDb3JlOjpLZXlmcmFtZUFuaW1hdGlvbjo6YW5pbWF0ZSk6CisKIDIw MTAtMTItMjggIFRha2FzaGkgVG95b3NoaW1hICA8dG95b3NoaW1AZ29vZ2xlLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KSW5kZXg6IFdlYkNvcmUvcGFnZS9hbmltYXRp b24vS2V5ZnJhbWVBbmltYXRpb24uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGFnZS9hbmlt YXRpb24vS2V5ZnJhbWVBbmltYXRpb24uY3BwCShyZXZpc2lvbiA3NDcxOSkKKysrIFdlYkNvcmUv cGFnZS9hbmltYXRpb24vS2V5ZnJhbWVBbmltYXRpb24uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0x ODUsNyArMTg1LDcgQEAgdm9pZCBLZXlmcmFtZUFuaW1hdGlvbjo6YW5pbWF0ZShDb21wb3NpdAog ICAgICAgICAvLyBHZXQgdGhlIGZyb20vdG8gc3R5bGVzIGFuZCBwcm9ncmVzcyBiZXR3ZWVuCiAg ICAgICAgIGNvbnN0IFJlbmRlclN0eWxlKiBmcm9tU3R5bGUgPSAwOwogICAgICAgICBjb25zdCBS ZW5kZXJTdHlsZSogdG9TdHlsZSA9IDA7Ci0gICAgICAgIGRvdWJsZSBwcm9ncmVzczsKKyAgICAg ICAgZG91YmxlIHByb2dyZXNzID0gMC4wOwogICAgICAgICBmZXRjaEludGVydmFsRW5kcG9pbnRz Rm9yUHJvcGVydHkocHJvcGVydHksIGZyb21TdHlsZSwgdG9TdHlsZSwgcHJvZ3Jlc3MpOwogICAg IAogICAgICAgICBib29sIG5lZWRzQW5pbSA9IGJsZW5kUHJvcGVydGllcyh0aGlzLCBwcm9wZXJ0 eSwgYW5pbWF0ZWRTdHlsZS5nZXQoKSwgZnJvbVN0eWxlLCB0b1N0eWxlLCBwcm9ncmVzcyk7Cg== 78969 2011-01-14 11:35:18 -0800 2011-01-14 17:20:08 -0800 This is an update to the earlier patch and fixes progress in both locations. progress.patch text/plain 1862 asharif.tools SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDc1ODA1 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDEt MTQgIEFobWFkIFNoYXJpZiAgPGFzaGFyaWYudG9vbHNAZ21haWwuY29tPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gaW5saW5pbmcgaXMgcGVy Zm9ybWVkLCB0aGUgcHJvZ3Jlc3MgdmFyaWFibGUgaXMKKyAgICAgICAgZGVjbGFyZWQgYXMgdW5p bml0aWFsaXplZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTUxMDg0CisKKyAgICAgICAgKiBXZWJDb3JlOiBDb3BpZWQgZnJvbSBXZWJDb3JlLgorICAg ICAgICAqIFdlYkNvcmUvcGFnZS9hbmltYXRpb24vS2V5ZnJhbWVBbmltYXRpb24uY3BwOgorICAg ICAgICAoV2ViQ29yZTo6S2V5ZnJhbWVBbmltYXRpb246OmFuaW1hdGUpOgorICAgICAgICAoV2Vi Q29yZTo6S2V5ZnJhbWVBbmltYXRpb246OmdldEFuaW1hdGVkU3R5bGUpOgorCiAyMDExLTAxLTEx ICBMYXN6bG8gR29tYm9zICA8bGFzemxvLjEuZ29tYm9zQG5va2lhLmNvbT4KIAogICAgICAgICBS ZXZpZXdlZCBieSBDc2FiYSBPc3p0cm9nb27DoWMuCkluZGV4OiBXZWJDb3JlL3BhZ2UvYW5pbWF0 aW9uL0tleWZyYW1lQW5pbWF0aW9uLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvYW5p bWF0aW9uL0tleWZyYW1lQW5pbWF0aW9uLmNwcAkocmV2aXNpb24gNzQ3MTkpCisrKyBXZWJDb3Jl L3BhZ2UvYW5pbWF0aW9uL0tleWZyYW1lQW5pbWF0aW9uLmNwcAkod29ya2luZyBjb3B5KQpAQCAt MTg1LDcgKzE4NSw3IEBAIHZvaWQgS2V5ZnJhbWVBbmltYXRpb246OmFuaW1hdGUoQ29tcG9zaXQK ICAgICAgICAgLy8gR2V0IHRoZSBmcm9tL3RvIHN0eWxlcyBhbmQgcHJvZ3Jlc3MgYmV0d2Vlbgog ICAgICAgICBjb25zdCBSZW5kZXJTdHlsZSogZnJvbVN0eWxlID0gMDsKICAgICAgICAgY29uc3Qg UmVuZGVyU3R5bGUqIHRvU3R5bGUgPSAwOwotICAgICAgICBkb3VibGUgcHJvZ3Jlc3M7CisgICAg ICAgIGRvdWJsZSBwcm9ncmVzcyA9IDAuMDsKICAgICAgICAgZmV0Y2hJbnRlcnZhbEVuZHBvaW50 c0ZvclByb3BlcnR5KHByb3BlcnR5LCBmcm9tU3R5bGUsIHRvU3R5bGUsIHByb2dyZXNzKTsKICAg ICAKICAgICAgICAgYm9vbCBuZWVkc0FuaW0gPSBibGVuZFByb3BlcnRpZXModGhpcywgcHJvcGVy dHksIGFuaW1hdGVkU3R5bGUuZ2V0KCksIGZyb21TdHlsZSwgdG9TdHlsZSwgcHJvZ3Jlc3MpOwpA QCAtMjIyLDcgKzIyMiw3IEBAIHZvaWQgS2V5ZnJhbWVBbmltYXRpb246OmdldEFuaW1hdGVkU3R5 bGUKICAgICAgICAgLy8gR2V0IHRoZSBmcm9tL3RvIHN0eWxlcyBhbmQgcHJvZ3Jlc3MgYmV0d2Vl bgogICAgICAgICBjb25zdCBSZW5kZXJTdHlsZSogZnJvbVN0eWxlID0gMDsKICAgICAgICAgY29u c3QgUmVuZGVyU3R5bGUqIHRvU3R5bGUgPSAwOwotICAgICAgICBkb3VibGUgcHJvZ3Jlc3M7Cisg ICAgICAgIGRvdWJsZSBwcm9ncmVzcyA9IDAuMDsKICAgICAgICAgZmV0Y2hJbnRlcnZhbEVuZHBv aW50c0ZvclByb3BlcnR5KHByb3BlcnR5LCBmcm9tU3R5bGUsIHRvU3R5bGUsIHByb2dyZXNzKTsK IAogICAgICAgICBibGVuZFByb3BlcnRpZXModGhpcywgcHJvcGVydHksIGFuaW1hdGVkU3R5bGUu Z2V0KCksIGZyb21TdHlsZSwgdG9TdHlsZSwgcHJvZ3Jlc3MpOwo=