51070 2010-12-14 16:03:13 -0800 Percentage Z values in 3d transform functions and transform-origin should cause the property to be invalid 2010-12-15 15:51:11 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser cmarrin dino simon.fraser webkit.review.bot oldest_to_newest 322320 0 simon.fraser 2010-12-14 16:03:13 -0800 I just changed the spec to say that % values in the z-component of translate3d(), translateZ() and transform-origin should make the property invalid. We should implement this. 322501 1 simon.fraser 2010-12-14 22:04:25 -0800 This already works for -webkit-transform-origin. 322506 2 76631 simon.fraser 2010-12-14 22:42:03 -0800 Created attachment 76631 Patch 322507 3 webkit.review.bot 2010-12-14 22:43:29 -0800 Attachment 76631 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/transforms/2d/resources/transform-test-utils.js', u'LayoutTests/transforms/3d/general/3dtransform-values-expected.txt', u'LayoutTests/transforms/3d/general/3dtransform-values.html', u'WebCore/ChangeLog', u'WebCore/css/CSSParser.cpp']" exit_code: 1 WebCore/css/CSSParser.cpp:5006: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style. 322732 4 76631 cmarrin 2010-12-15 12:02:11 -0800 Comment on attachment 76631 Patch r+ with the comment change to get rid of transform-origin wording. You should also fix the style issue, unless it's just noise from the style bot 322896 5 simon.fraser 2010-12-15 15:51:11 -0800 http://trac.webkit.org/changeset/74156 76631 2010-12-14 22:42:03 -0800 2010-12-15 12:02:10 -0800 Patch bug-51070-20101214224202.patch text/plain 9187 simon.fraser ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBjZjk5YjVkMGE1MzQxMWE1YjVjOWZlN2VkZTM3YmIwMDMzZmUzNzAzLi40ZDE4MDI0 MDRhYTJiMTdmMWUyZTg3NmYxYWE0ZTlkMzgzNmVlMjcyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAK KzIwMTAtMTItMTQgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUGVyY2VudGFnZSBa IHZhbHVlcyBpbiAzZCB0cmFuc2Zvcm0gZnVuY3Rpb25zIGFuZCB0cmFuc2Zvcm0tb3JpZ2luIHNo b3VsZCBjYXVzZSB0aGUgcHJvcGVydHkgdG8gYmUgaW52YWxpZAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTEwNzAKKyAgICAgICAgCisgICAgICAgIFRl c3RjYXNlIGZvciB2YXJpb3VzIDNkIHRyYW5zZm9ybSB2YWx1ZXMuCisKKyAgICAgICAgKiB0cmFu c2Zvcm1zLzJkL3Jlc291cmNlcy90cmFuc2Zvcm0tdGVzdC11dGlscy5qczoKKyAgICAgICAgKGNv bXBhcmVNYXRyaWNlcyk6IFVzZSBlYXJseSByZXR1cm4sIGVuaGFuY2UgdG8gZGVhbCB3aXRoIG1h dHJpeDNkKCksCisgICAgICAgIGFuZCBhdm9pZCBldmFsdWF0aW5nIHRoZSByZWd1bGFyIGV4cHJl c3Npb25zIHR3aWNlLgorICAgICAgICAqIHRyYW5zZm9ybXMvM2QvZ2VuZXJhbC8zZHRyYW5zZm9y bS12YWx1ZXMtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiB0cmFuc2Zvcm1zLzNkL2dl bmVyYWwvM2R0cmFuc2Zvcm0tdmFsdWVzLmh0bWw6IEFkZGVkLgorCiAyMDEwLTEyLTA4ICBSeW9z dWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQ7IFlldCBh bm90aGVyIENocm9taXVtIHJlYmFzZWxpbmVzIGZvciByNzM1NDguCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy90cmFuc2Zvcm1zLzJkL3Jlc291cmNlcy90cmFuc2Zvcm0tdGVzdC11dGlscy5qcyBi L0xheW91dFRlc3RzL3RyYW5zZm9ybXMvMmQvcmVzb3VyY2VzL3RyYW5zZm9ybS10ZXN0LXV0aWxz LmpzCmluZGV4IDZhMWYxYjdmOTZiNDY3YTU2MjU4MzJhNWZkNGI1MmVkMjk1ZDVhOWEuLmJlMjRi MzZmYjU5NzI2MjI3YzFiOGMxN2ViNDU4YjUzMGViMGNjYTggMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL3RyYW5zZm9ybXMvMmQvcmVzb3VyY2VzL3RyYW5zZm9ybS10ZXN0LXV0aWxzLmpzCisrKyBi L0xheW91dFRlc3RzL3RyYW5zZm9ybXMvMmQvcmVzb3VyY2VzL3RyYW5zZm9ybS10ZXN0LXV0aWxz LmpzCkBAIC0xMSwyNiArMTEsMjcgQEAgZnVuY3Rpb24gY29tcGFyZU1hdHJpY2VzKGEsIGIpCiB7 CiAgIGlmIChhID09ICJub25lIiAmJiBiID09ICJub25lIikKICAgICByZXR1cm4gdHJ1ZTsKLSAg ZWxzZSB7Ci0gICAgdmFyIG1hdHJpeFJlZ2V4ID0gL21hdHJpeFwoKC4rKVwpLzsKIAotICAgIGlm ICghbWF0cml4UmVnZXguZXhlYyhhKSB8fCAhbWF0cml4UmVnZXguZXhlYyhiKSkKLSAgICAgIHJl dHVybiBmYWxzZTsKLSAgCi0gICAgdmFyIGFWYWx1ZXMgPSBtYXRyaXhSZWdleC5leGVjKGEpWzFd OwotICAgIHZhciBiVmFsdWVzID0gbWF0cml4UmVnZXguZXhlYyhiKVsxXTsKLSAgCi0gICAgdmFy IGFDb21wcyA9IGFWYWx1ZXMuc3BsaXQoJywnKTsKLSAgICB2YXIgYkNvbXBzID0gYlZhbHVlcy5z cGxpdCgnLCcpOworICB2YXIgbWF0cml4UmVnZXggPSAvbWF0cml4KD86M2QpP1woKC4rKVwpLzsK IAotICAgIGlmIChhQ29tcHMubGVuZ3RoICE9IGJDb21wcy5sZW5ndGgpCi0gICAgICByZXR1cm4g ZmFsc2U7CisgIHZhciByZXN1bHRBID0gbWF0cml4UmVnZXguZXhlYyhhKTsKKyAgdmFyIHJlc3Vs dEIgPSBtYXRyaXhSZWdleC5leGVjKGIpOworICBpZiAoIXJlc3VsdEEgfHwgIXJlc3VsdEIpCisg ICAgcmV0dXJuIGZhbHNlOwogCi0gICAgZm9yICh2YXIgaSA9IDA7IGkgPCBhQ29tcHMubGVuZ3Ro OyArK2kpCi0gICAgewotICAgICAgaWYgKCFmbG9hdGluZ1BvaW50RXF1YWwoYUNvbXBzW2ldLCBi Q29tcHNbaV0pKQotICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgfQorICB2YXIgYVZhbHVlcyA9 IHJlc3VsdEFbMV07CisgIHZhciBiVmFsdWVzID0gcmVzdWx0QlsxXTsKKworICB2YXIgYUNvbXBz ID0gYVZhbHVlcy5zcGxpdCgnLCcpOworICB2YXIgYkNvbXBzID0gYlZhbHVlcy5zcGxpdCgnLCcp OworCisgIGlmIChhQ29tcHMubGVuZ3RoICE9IGJDb21wcy5sZW5ndGgpCisgICAgcmV0dXJuIGZh bHNlOworCisgIGZvciAodmFyIGkgPSAwOyBpIDwgYUNvbXBzLmxlbmd0aDsgKytpKQorICB7Cisg ICAgaWYgKCFmbG9hdGluZ1BvaW50RXF1YWwoYUNvbXBzW2ldLCBiQ29tcHNbaV0pKQorICAgICAg cmV0dXJuIGZhbHNlOwogICB9CiAKICAgcmV0dXJuIHRydWU7CmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy90cmFuc2Zvcm1zLzNkL2dlbmVyYWwvM2R0cmFuc2Zvcm0tdmFsdWVzLWV4cGVjdGVkLnR4 dCBiL0xheW91dFRlc3RzL3RyYW5zZm9ybXMvM2QvZ2VuZXJhbC8zZHRyYW5zZm9ybS12YWx1ZXMt ZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjM1M2QzZjg0ZDQ0ODRjNDQ2Mzc3OTY2OTJkYjllNDI4 MzQ5NjUyNmMKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy90cmFuc2Zvcm1zLzNkL2dl bmVyYWwvM2R0cmFuc2Zvcm0tdmFsdWVzLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDEyIEBACit0 cmFuc2Zvcm0gInRyYW5zbGF0ZTNkKDAsIDAsIDEwcHgpIiBleHBlY3RlZCAibWF0cml4M2QoMSwg MCwgMCwgMCwgMCwgMSwgMCwgMCwgMCwgMCwgMSwgMCwgMCwgMCwgMTAsIDEpIiA6IFBBU1MKK3Ry YW5zZm9ybSAidHJhbnNsYXRlWigxMHB4KSIgZXhwZWN0ZWQgIm1hdHJpeDNkKDEsIDAsIDAsIDAs IDAsIDEsIDAsIDAsIDAsIDAsIDEsIDAsIDAsIDAsIDEwLCAxKSIgOiBQQVNTCit0cmFuc2Zvcm0g InJvdGF0ZTNkKDAsIDEsIDAsIDE4MGRlZykiIGV4cGVjdGVkICJtYXRyaXgzZCgtMSwgMCwgMCwg MCwgMCwgMSwgMCwgMCwgMCwgMCwgLTEsIDAsIDAsIDAsIDAsIDEpIiA6IFBBU1MKK3RyYW5zZm9y bSAidHJhbnNsYXRlM2QoMCwgMCwgMTBweCkiIGV4cGVjdGVkICJtYXRyaXgzZCgxLCAwLCAwLCAw LCAwLCAxLCAwLCAwLCAwLCAwLCAxLCAwLCAwLCAwLCAxMCwgMSkiIDogUEFTUwordHJhbnNmb3Jt ICJ0cmFuc2xhdGUzZCgwLCAwLCAxMCUpIiBleHBlY3RlZCAibm9uZSIgOiBQQVNTCit0cmFuc2Zv cm0gInRyYW5zbGF0ZTNkKDAsIDAsIDEwKSIgZXhwZWN0ZWQgIm5vbmUiIDogUEFTUwordHJhbnNm b3JtICJ0cmFuc2xhdGVaKDEwJSkiIGV4cGVjdGVkICJub25lIiA6IFBBU1MKK3RyYW5zZm9ybSAi dHJhbnNsYXRlWigxMCkiIGV4cGVjdGVkICJub25lIiA6IFBBU1MKK3RyYW5zZm9ybSAicm90YXRl M2QoMCwgMSwgMCwgMTgwKSIgZXhwZWN0ZWQgIm5vbmUiIDogUEFTUwordHJhbnNmb3JtICJyb3Rh dGUzZCgwLCAxLCAwLCAxODBweCkiIGV4cGVjdGVkICJub25lIiA6IFBBU1MKK3RyYW5zZm9ybSAi cm90YXRlM2QoMCwgMSwgMCwgMTgwcHgpIiBleHBlY3RlZCAibm9uZSIgOiBQQVNTCisKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL3RyYW5zZm9ybXMvM2QvZ2VuZXJhbC8zZHRyYW5zZm9ybS12YWx1 ZXMuaHRtbCBiL0xheW91dFRlc3RzL3RyYW5zZm9ybXMvM2QvZ2VuZXJhbC8zZHRyYW5zZm9ybS12 YWx1ZXMuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5mNmExZWE5ZmI0M2Q5OTZkOWQ2ZWFjYzNjMTc1YWZhZjU3 MGMyNDIyCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvdHJhbnNmb3Jtcy8zZC9nZW5l cmFsLzNkdHJhbnNmb3JtLXZhbHVlcy5odG1sCkBAIC0wLDAgKzEsNjAgQEAKKzwhRE9DVFlQRSBo dG1sPgorCis8aHRtbD4KKzxoZWFkPgorICA8c3R5bGUgdHlwZT0idGV4dC9jc3MiIG1lZGlhPSJz Y3JlZW4iPgorICAgIC5jb250YWluZXIgeworICAgICAgaGVpZ2h0OiAxMDBweDsKKyAgICAgIHdp ZHRoOiAxMDBweDsKKyAgICAgIG1hcmdpbjogMzBweDsKKyAgICAgIG91dGxpbmU6IDFweCBzb2xp ZCBibGFjazsKKyAgICB9CisgICAgLmJveCB7CisgICAgICBoZWlnaHQ6IDEwMCU7CisgICAgICB3 aWR0aDogMTAwJTsKKyAgICAgIGJhY2tncm91bmQtY29sb3I6IGdyZWVuOworICAgIH0KKyAgICAj cmVzdWx0cyB7CisgICAgICBtYXJnaW4tdG9wOiAxMDBweDsKKyAgICB9CisgIDwvc3R5bGU+Cisg IDxzY3JpcHQgc3JjPSIuLi8uLi8yZC9yZXNvdXJjZXMvdHJhbnNmb3JtLXRlc3QtdXRpbHMuanMi IHR5cGU9InRleHQvamF2YXNjcmlwdCIgY2hhcnNldD0idXRmLTgiPjwvc2NyaXB0PgorICA8c2Ny aXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCI+CisgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29u dHJvbGxlcikgeworICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworICAg ICAgbGF5b3V0VGVzdENvbnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOworICAgIH0KKworICAgIHZh ciBnVGVzdHMgPSBbCisgICAgICB7ICd0cmFuc2Zvcm0nIDogJ3RyYW5zbGF0ZTNkKDAsIDAsIDEw cHgpJywgJ3Jlc3VsdCcgOiAnbWF0cml4M2QoMSwgMCwgMCwgMCwgMCwgMSwgMCwgMCwgMCwgMCwg MSwgMCwgMCwgMCwgMTAsIDEpJyB9LAorICAgICAgeyAndHJhbnNmb3JtJyA6ICd0cmFuc2xhdGVa KDEwcHgpJywgJ3Jlc3VsdCcgOiAnbWF0cml4M2QoMSwgMCwgMCwgMCwgMCwgMSwgMCwgMCwgMCwg MCwgMSwgMCwgMCwgMCwgMTAsIDEpJyB9LAorICAgICAgeyAndHJhbnNmb3JtJyA6ICdyb3RhdGUz ZCgwLCAxLCAwLCAxODBkZWcpJywgJ3Jlc3VsdCcgOiAnbWF0cml4M2QoLTEsIDAsIDAsIDAsIDAs IDEsIDAsIDAsIDAsIDAsIC0xLCAwLCAwLCAwLCAwLCAxKScgfSwKKyAgICAgIHsgJ3RyYW5zZm9y bScgOiAndHJhbnNsYXRlM2QoMCwgMCwgMTBweCknLCAncmVzdWx0JyA6ICdtYXRyaXgzZCgxLCAw LCAwLCAwLCAwLCAxLCAwLCAwLCAwLCAwLCAxLCAwLCAwLCAwLCAxMCwgMSknIH0sCisgICAgICB7 ICd0cmFuc2Zvcm0nIDogJ3RyYW5zbGF0ZTNkKDAsIDAsIDEwJSknLCAncmVzdWx0JyA6ICdub25l JyB9LCAvLyBwZXJjZW50YWdlIHZhbHVlcyBub3QgYWxsb3dlZCBpbiB0aGUgeiBwYXJhbQorICAg ICAgeyAndHJhbnNmb3JtJyA6ICd0cmFuc2xhdGUzZCgwLCAwLCAxMCknLCAncmVzdWx0JyA6ICdu b25lJyB9LCAvLyBtdXN0IGhhdmUgdW5pdHMgZm9yIHRoZSB6IHBhcmFtCisgICAgICB7ICd0cmFu c2Zvcm0nIDogJ3RyYW5zbGF0ZVooMTAlKScsICdyZXN1bHQnIDogJ25vbmUnIH0sIC8vIHBlcmNl bnRhZ2UgdmFsdWVzIG5vdCBhbGxvd2VkIGluIHRoZSB6IHBhcmFtCisgICAgICB7ICd0cmFuc2Zv cm0nIDogJ3RyYW5zbGF0ZVooMTApJywgJ3Jlc3VsdCcgOiAnbm9uZScgfSwgLy8gbXVzdCBoYXZl IHVuaXRzCisgICAgICB7ICd0cmFuc2Zvcm0nIDogJ3JvdGF0ZTNkKDAsIDEsIDAsIDE4MCknLCAn cmVzdWx0JyA6ICdub25lJyB9LCAvLyBsYXN0IHZhbHVlIG11c3QgYmUgYW4gYW5nbGUKKyAgICAg IHsgJ3RyYW5zZm9ybScgOiAncm90YXRlM2QoMCwgMSwgMCwgMTgwcHgpJywgJ3Jlc3VsdCcgOiAn bm9uZScgfSwgLy8gbGFzdCB2YWx1ZSBtdXN0IGJlIGFuIGFuZ2xlCisgICAgICB7ICd0cmFuc2Zv cm0nIDogJ3JvdGF0ZTNkKDAsIDEsIDAsIDE4MHB4KScsICdyZXN1bHQnIDogJ25vbmUnIH0sIC8v IGxhc3QgdmFsdWUgbXVzdCBiZSBhbiBhbmdsZQorICAgIF07CisgICAgCisgICAgZnVuY3Rpb24g cnVuVGVzdHMoKQorICAgIHsKKyAgICAgIHRlc3RUcmFuc2Zvcm1zKCk7CisKKyAgICAgIGlmICh3 aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVy Lm5vdGlmeURvbmUoKTsKKyAgICB9CisgIDwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHkgb25sb2Fk PSJydW5UZXN0cygpIj4KKworICA8ZGl2IGNsYXNzPSJjb250YWluZXIiPgorICAgIDxkaXYgaWQ9 InRlc3QtYm94IiBjbGFzcz0iYm94Ij48L2Rpdj4KKyAgPC9kaXY+CisKKyAgPGRpdiBpZD0icmVz dWx0cyI+CisgIDwvZGl2PgorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9D aGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA1NjlhOTFhYzY1YTZhNTc4ODBhNDU1 NzYyN2QyZjMyY2Q5Yjg3YjA3Li4yZGNiNDEzYTJhMTRlNmM0ZThkYjMwZGEzODgwZjgzY2VhMDE4 Mzg3IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE5IEBACisyMDEwLTEyLTE0ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFz ZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFBlcmNlbnRhZ2UgWiB2YWx1ZXMgaW4gM2QgdHJhbnNmb3JtIGZ1bmN0aW9ucyBhbmQg dHJhbnNmb3JtLW9yaWdpbiBzaG91bGQgY2F1c2UgdGhlIHByb3BlcnR5IHRvIGJlIGludmFsaWQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUxMDcwCisg ICAgICAgIAorICAgICAgICBUcmVhdCBhcyBpbmF2bGlkIC13ZWJraXQtdHJhbnNmb3JtIHZhbHVl cyB0aGF0IGluY2x1ZGUgYSBwZXJjZW50YWdlIHZhbHVlIGluIHRyYW5zbGF0ZVooKQorICAgICAg ICBvciBpbiB0aGUgdGhpcmQgcGFyYW1ldGVyIHRvIHRyYW5zbGF0ZTNkKCkuCisKKyAgICAgICAg VGVzdDogdHJhbnNmb3Jtcy8zZC9nZW5lcmFsLzNkdHJhbnNmb3JtLXZhbHVlcy5odG1sCisKKyAg ICAgICAgKiBjc3MvQ1NTUGFyc2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNTU1BhcnNlcjo6 cGFyc2VUcmFuc2Zvcm0pOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUGFyc2VyOjpwYXJzZVRyYW5z Zm9ybU9yaWdpbik6IFdoaXRlc3BhY2UgY2hhbmdlLgorCiAyMDEwLTEyLTA4ICBOaWNvbGFzIER1 ZnJlc25lICA8bmljb2xhcy5kdWZyZXNuZUBjb2xsYWJvcmEuY28udWs+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgTWFydGluIFJvYmluc29uLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9jc3MvQ1NTUGFy c2VyLmNwcCBiL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKaW5kZXggMTJiOGVlYTE0ODY3YWM2 NDc4NTQxZGM0MzNmZmUyN2FiMGY1YWRkMS4uM2FjMTA0ZWExZTE1MzIxMWMyMTI2ODAyYzk0ODhk ZjdkM2QyNjJmMCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcAorKysgYi9X ZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCkBAIC00OTk1LDEwICs0OTk1LDE4IEBAIFBhc3NSZWZQ dHI8Q1NTVmFsdWVMaXN0PiBDU1NQYXJzZXI6OnBhcnNlVHJhbnNmb3JtKCkKICAgICAgICAgd2hp bGUgKGEpIHsKICAgICAgICAgICAgIENTU1BhcnNlcjo6VW5pdHMgdW5pdCA9IGluZm8udW5pdCgp OwogCi0gICAgICAgICAgICAvLyA0dGggcGFyYW0gb2Ygcm90YXRlM2QoKSBpcyBhbiBhbmdsZSBy YXRoZXIgdGhhbiBhIGJhcmUgbnVtYmVyLCB2YWxpZGF0ZSBpdCBhcyBzdWNoCiAgICAgICAgICAg ICBpZiAoaW5mby50eXBlKCkgPT0gV2ViS2l0Q1NTVHJhbnNmb3JtVmFsdWU6OlJvdGF0ZTNEVHJh bnNmb3JtT3BlcmF0aW9uICYmIGFyZ051bWJlciA9PSAzKSB7CisgICAgICAgICAgICAgICAgLy8g NHRoIHBhcmFtIG9mIHJvdGF0ZTNkKCkgaXMgYW4gYW5nbGUgcmF0aGVyIHRoYW4gYSBiYXJlIG51 bWJlciwgdmFsaWRhdGUgaXQgYXMgc3VjaAogICAgICAgICAgICAgICAgIGlmICghdmFsaWRVbml0 KGEsIEZBbmdsZSwgdHJ1ZSkpCiAgICAgICAgICAgICAgICAgICAgIHJldHVybiAwOworICAgICAg ICAgICAgfSBlbHNlIGlmIChpbmZvLnR5cGUoKSA9PSBXZWJLaXRDU1NUcmFuc2Zvcm1WYWx1ZTo6 VHJhbnNsYXRlM0RUcmFuc2Zvcm1PcGVyYXRpb24gJiYgYXJnTnVtYmVyID09IDIpIHsKKyAgICAg ICAgICAgICAgICAvLyAzcmQgcGFyYW0gb2YgdHJhbnNsYXRlM2QoKSBjYW5ub3QgYmUgYSBwZXJj ZW50YWdlCisgICAgICAgICAgICAgICAgaWYgKCF2YWxpZFVuaXQoYSwgRkxlbmd0aCwgdHJ1ZSkp CisgICAgICAgICAgICAgICAgICAgIHJldHVybiAwOworICAgICAgICAgICAgfSBlbHNlIGlmIChp bmZvLnR5cGUoKSA9PSBXZWJLaXRDU1NUcmFuc2Zvcm1WYWx1ZTo6VHJhbnNsYXRlWlRyYW5zZm9y bU9wZXJhdGlvbiAmJiBhcmdOdW1iZXIgPT0gMCkgeworICAgICAgICAgICAgICAgIC8vIDFzdCBw YXJhbSBvZiB0cmFuc2xhdGVaKCkgY2Fubm90IGJlIGEgcGVyY2VudGFnZQorICAgICAgICAgICAg ICAgIGlmICghdmFsaWRVbml0KGEsIEZMZW5ndGgsIHRydWUpKQorICAgICAgICAgICAgICAgICAg ICByZXR1cm4gMDsKICAgICAgICAgICAgIH0gZWxzZSBpZiAoIXZhbGlkVW5pdChhLCB1bml0LCB0 cnVlKSkKICAgICAgICAgICAgICAgICByZXR1cm4gMDsKIApAQCAtNTA1Miw3ICs1MDYwLDcgQEAg Ym9vbCBDU1NQYXJzZXI6OnBhcnNlVHJhbnNmb3JtT3JpZ2luKGludCBwcm9wSWQsIGludCYgcHJv cElkMSwgaW50JiBwcm9wSWQyLCBpbnQKICAgICAgICAgfQogICAgICAgICBjYXNlIENTU1Byb3Bl cnR5V2Via2l0VHJhbnNmb3JtT3JpZ2luWjogewogICAgICAgICAgICAgaWYgKHZhbGlkVW5pdCht X3ZhbHVlTGlzdC0+Y3VycmVudCgpLCBGTGVuZ3RoLCBtX3N0cmljdCkpCi0gICAgICAgICAgICB2 YWx1ZSA9IENTU1ByaW1pdGl2ZVZhbHVlOjpjcmVhdGUobV92YWx1ZUxpc3QtPmN1cnJlbnQoKS0+ ZlZhbHVlLCAoQ1NTUHJpbWl0aXZlVmFsdWU6OlVuaXRUeXBlcyltX3ZhbHVlTGlzdC0+Y3VycmVu dCgpLT51bml0KTsKKyAgICAgICAgICAgICAgICB2YWx1ZSA9IENTU1ByaW1pdGl2ZVZhbHVlOjpj cmVhdGUobV92YWx1ZUxpc3QtPmN1cnJlbnQoKS0+ZlZhbHVlLCAoQ1NTUHJpbWl0aXZlVmFsdWU6 OlVuaXRUeXBlcyltX3ZhbHVlTGlzdC0+Y3VycmVudCgpLT51bml0KTsKICAgICAgICAgICAgIGlm ICh2YWx1ZSkKICAgICAgICAgICAgICAgICBtX3ZhbHVlTGlzdC0+bmV4dCgpOwogICAgICAgICAg ICAgYnJlYWs7Cg==