51065 2010-12-14 15:36:59 -0800 [git].DS_Store should be in .gitignore 2010-12-14 19:12:01 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Enhancement --- 1 rniwa webkit-unassigned abarth eric evan mihaip ojan webkit.review.bot oldest_to_newest 322295 0 rniwa 2010-12-14 15:36:59 -0800 AFAIK, there's no point in tracking changes to .DS_Store. It should be in .gitignore. 322298 1 76583 rniwa 2010-12-14 15:39:13 -0800 Created attachment 76583 Adds *.DS_Store to .gitignore 322300 2 76583 eric 2010-12-14 15:42:21 -0800 Comment on attachment 76583 Adds *.DS_Store to .gitignore You don't need the * , just .DS_Store 322303 3 76586 rniwa 2010-12-14 15:44:18 -0800 Created attachment 76586 Adds .DS_Store to .gitignore 322308 4 76586 eric 2010-12-14 15:54:45 -0800 Comment on attachment 76586 Adds .DS_Store to .gitignore ok 322327 5 rniwa 2010-12-14 16:19:28 -0800 Committed r74067: <http://trac.webkit.org/changeset/74067> 322371 6 webkit.review.bot 2010-12-14 17:18:34 -0800 http://trac.webkit.org/changeset/74067 might have broken SnowLeopard Intel Release (Tests) The following tests are not passing: fast/css/focus-ring-detached.html fast/css/focus-ring-multiline.html 322449 7 rniwa 2010-12-14 19:12:01 -0800 Thanks for the quick review, Eric. (In reply to comment #4) > (From update of attachment 76586 [details]) > ok 76583 2010-12-14 15:39:13 -0800 2010-12-14 15:44:15 -0800 Adds *.DS_Store to .gitignore bug-51065-20101214153912.patch text/plain 627 rniwa SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDc0MDYz KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTEgQEAKKzIwMTAtMTIt MTQgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgKi5EU19TdG9yZSB0byAuZ2l0aWdu b3JlLgorCisgICAgICAgICogLmdpdGlnbm9yZToKKwogMjAxMC0xMi0xNCAgTHVjYXMgRGUgTWFy Y2hpICA8bHVjYXMuZGVtYXJjaGlAcHJvZnVzaW9uLm1vYmk+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgRXJpYyBTZWlkZWwuCkluZGV4OiAuZ2l0aWdub3JlCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIC5naXRpZ25v cmUJKHJldmlzaW9uIDczODE4KQorKysgLmdpdGlnbm9yZQkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDQgQEAKKyouRFNfU3RvcmUKICoubW9kZSoKICoucGJ4dXNlcgogKi5wZXJzcGVjdGl2ZSoK 76586 2010-12-14 15:44:18 -0800 2010-12-14 15:54:45 -0800 Adds .DS_Store to .gitignore bug-51065-20101214154417.patch text/plain 667 rniwa SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDc0MDYz KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTEgQEAKKzIwMTAtMTIt MTQgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgLkRTX1N0b3JlIHRvIC5naXRpZ25v cmUuCisKKyAgICAgICAgKiAuZ2l0aWdub3JlOgorCiAyMDEwLTEyLTE0ICBMdWNhcyBEZSBNYXJj aGkgIDxsdWNhcy5kZW1hcmNoaUBwcm9mdXNpb24ubW9iaT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBFcmljIFNlaWRlbC4KSW5kZXg6IC5naXRpZ25vcmUKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gLmdpdGlnbm9y ZQkocmV2aXNpb24gNzM4MTgpCisrKyAuZ2l0aWdub3JlCSh3b3JraW5nIGNvcHkpCkBAIC0yLDYg KzIsNyBAQAogKi5wYnh1c2VyCiAqLnBlcnNwZWN0aXZlKgogKi5weWMKKy5EU19TdG9yZQogYnVp bGQvCiAvV2ViS2l0QnVpbGQvCiBhdXRvaW5zdGFsbC5jYWNoZS5kCg==