51036 2010-12-14 07:15:44 -0800 [GTK] Unsigned values substraction bug in SoupCache 2010-12-15 02:36:36 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED WONTFIX P2 Normal --- 0 mpakulavelrutka webkit-unassigned gyuyoung.kim miroslaw.s mrobinson svillar oldest_to_newest 321952 0 mpakulavelrutka 2010-12-14 07:15:44 -0800 There is bug soup-http-input-stream.c in function webkit_soup_http_input_stream_got_chunk at line 270: if (priv->caller_bufsize - priv->caller_nread > 0) { as both of values type is gsize which unsigned int it always will be greater than zero when values are different. 321957 1 76534 mpakulavelrutka 2010-12-14 07:30:41 -0800 Created attachment 76534 [GTK] Unsigned values substraction bug in SoupCache 322081 2 svillar 2010-12-14 11:43:58 -0800 The bug indeed exists but I have already fixed it in libsoup as the SoupCache code was imported there during this year's hackfest. I don't think it makes sense to fix it in WebKit as the SoupCache code will be removed soon. 322090 3 mrobinson 2010-12-14 11:57:07 -0800 Thanks for the update Sergio. There's no point fixing this as the code will be nuked soon. 322521 4 mpakulavelrutka 2010-12-14 23:20:12 -0800 OK, I didn't knew that WebKit SoupCache is going to be removed shortly. Could you estimate when will it happen? 322534 5 svillar 2010-12-15 00:57:14 -0800 (In reply to comment #4) > OK, I didn't knew that WebKit SoupCache is going to be removed shortly. Could you estimate when will it happen? We're waiting for Google guys to update the EWS bots 322552 6 76534 xan.lopez 2010-12-15 02:36:36 -0800 Comment on attachment 76534 [GTK] Unsigned values substraction bug in SoupCache Removing from review queue. 76534 2010-12-14 07:30:41 -0800 2010-12-15 02:36:36 -0800 [GTK] Unsigned values substraction bug in SoupCache unsinged_values_substraction.patch text/plain 1534 mpakulavelrutka ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg N2I5MmZkZS4uZDJhNDA0MyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0xMi0xNCAgTWljaGFsIFBha3Vs YSB2ZWwgUnV0a2EgIDxtLnBha3VsYUBzYW1zdW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR1RLXSBCdWcgd2hlbiBzdWJzdHJhY3Rpbmcg dHdvIHVuc2lnbmVkIHZhbHVlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NTEwMzYKKworICAgICAgICBGaXhlcyBidWcgYnkgcmVwbGFjaW5nIHN1YnN0 cmFjdGluZyB0d28gdW5zaWduZWQgdmFsdWVzIGFuZCB0aGVuIAorICAgICAgICBjb21wYXJpbmcg dGhlIHJlc3VsdCB3aXRoIHplcm8sIHdpdGggZGlyZWN0IGNvbXBhcmlzb24gb2YgdHdvIHZhbHVl cy4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvc291cC9jYWNoZS9zb3VwLWh0dHAtaW5w dXQtc3RyZWFtLmM6CisgICAgICAgICh3ZWJraXRfc291cF9odHRwX2lucHV0X3N0cmVhbV9nb3Rf Y2h1bmspOgorCiAyMDEwLTEyLTE0ICBNYWRzIEFnZXIgIDxhZ2VyQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBSZXZpZXdlZCBieSBQYXZlbCBGZWxkbWFuLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9w bGF0Zm9ybS9uZXR3b3JrL3NvdXAvY2FjaGUvc291cC1odHRwLWlucHV0LXN0cmVhbS5jIGIvV2Vi Q29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvY2FjaGUvc291cC1odHRwLWlucHV0LXN0cmVhbS5j CmluZGV4IDE5NWM0NTguLjJhNWQ5OTUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vbmV0 d29yay9zb3VwL2NhY2hlL3NvdXAtaHR0cC1pbnB1dC1zdHJlYW0uYworKysgYi9XZWJDb3JlL3Bs YXRmb3JtL25ldHdvcmsvc291cC9jYWNoZS9zb3VwLWh0dHAtaW5wdXQtc3RyZWFtLmMKQEAgLTI2 Nyw3ICsyNjcsNyBAQCB3ZWJraXRfc291cF9odHRwX2lucHV0X3N0cmVhbV9nb3RfY2h1bmsgKFNv dXBNZXNzYWdlICptc2csIFNvdXBCdWZmZXIgKmNodW5rX2J1ZgogCQlnX3dhcm5pbmcgKCJ3ZWJr aXRfc291cF9odHRwX2lucHV0X3N0cmVhbV9nb3RfY2h1bmsgY2FsbGVkIGFnYWluIGJlZm9yZSBw cmV2aW91cyBjaHVuayB3YXMgcHJvY2Vzc2VkIik7CiAKIAkvKiBDb3B5IHdoYXQgd2UgY2FuIGlu dG8gcHJpdi0+Y2FsbGVyX2J1ZmZlciAqLwotCWlmIChwcml2LT5jYWxsZXJfYnVmc2l6ZSAtIHBy aXYtPmNhbGxlcl9ucmVhZCA+IDApIHsKKwlpZiAocHJpdi0+Y2FsbGVyX2J1ZnNpemUgPiBwcml2 LT5jYWxsZXJfbnJlYWQpIHsKIAkJZ3NpemUgbnJlYWQgPSBNSU4gKGNodW5rX3NpemUsIHByaXYt PmNhbGxlcl9idWZzaXplIC0gcHJpdi0+Y2FsbGVyX25yZWFkKTsKIAogCQltZW1jcHkgKHByaXYt PmNhbGxlcl9idWZmZXIgKyBwcml2LT5jYWxsZXJfbnJlYWQsIGNodW5rLCBucmVhZCk7Cg==