51034 2010-12-14 06:58:42 -0800 Web Inspector: Rule data not updated in Styles pane after stylesheet gets reverted 2010-12-14 10:06:53 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 apavlov apavlov apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 321947 0 apavlov 2010-12-14 06:58:42 -0800 After a stylesheet is reverted in the Resources panel, the rule data for the current element do not get updated, even if the revert has altered the respective styles. 321979 1 76539 apavlov 2010-12-14 08:25:36 -0800 Created attachment 76539 [PATCH] Suggested fix 321993 2 76539 yurys 2010-12-14 09:08:26 -0800 Comment on attachment 76539 [PATCH] Suggested fix View in context: https://bugs.webkit.org/attachment.cgi?id=76539&action=review > WebCore/inspector/front-end/CSSStyleModel.js:177 > + if (WebInspector.panels.elements) The panel should listen to changes in the model. The model could send such notifications from _styleSheetChanged a change has been successfully committed. 322011 3 76542 apavlov 2010-12-14 09:36:31 -0800 Created attachment 76542 [PATCH] Comment addressed 322027 4 apavlov 2010-12-14 10:06:53 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/CSSStyleModel.js M WebCore/inspector/front-end/ElementsPanel.js Committed r74038 76539 2010-12-14 08:25:36 -0800 2010-12-14 09:36:31 -0800 [PATCH] Suggested fix ruleupdates.patch text/plain 3062 apavlov Y29tbWl0IDhmZGRlOTU1ZDQ2YTZjNjBjZGUwYzRmMTk0NmFkNmZhYzlmNmUxNzMKQXV0aG9yOiBB bGV4YW5kZXIgUGF2bG92IDxhcGF2bG92QGNocm9taXVtLm9yZz4KRGF0ZTogICBUdWUgRGVjIDE0 IDE5OjE5OjQxIDIwMTAgKzAzMDAKCiAgICBVcGRhdGUgc3R5bGVzIGFmdGVyIHJldmVydAoKZGlm ZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODEy MTIwNS4uODU2ZThhMCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29y ZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0xMi0xNCAgQWxleGFuZGVyIFBhdmxv diAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFJ1bGUgZGF0YSBub3QgdXBkYXRlZCBp biBTdHlsZXMgcGFuZSBhZnRlciBzdHlsZXNoZWV0IGdldHMgcmV2ZXJ0ZWQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUxMDM0CisKKyAgICAgICAgRHJp dmUtYnkgZml4OiBtaXhlZC11cCBoYW5kbGVycyBmb3Igc3R5bGVzIGFuZCBtZXRyaWNzIGVkaXRp bmcgZXZlbnRzIHB1dCBpbiBvcmRlci4KKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQv Q1NTU3R5bGVNb2RlbC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5DU1NTdHlsZU1vZGVsLnBy b3RvdHlwZS5fb25SZXZlcnQpOgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvRWxlbWVu dHNQYW5lbC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5FbGVtZW50c1BhbmVsKToKKyAgICAg ICAgKFdlYkluc3BlY3Rvci5FbGVtZW50c1BhbmVsLnByb3RvdHlwZS5fbWV0cmljc1BhbmVFZGl0 ZWQpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkVsZW1lbnRzUGFuZWwucHJvdG90eXBlLnN0eWxl c1BhbmVFZGl0ZWQpOgorCiAyMDEwLTEyLTE0ICBJbHlhIFRpa2hvbm92c2t5ICA8bG9pc2xvQGNo cm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBQYXZlbCBGZWxkbWFuLgpkaWZmIC0t Z2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NTU1N0eWxlTW9kZWwuanMgYi9XZWJD b3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ1NTU3R5bGVNb2RlbC5qcwppbmRleCAyM2VkN2E4Li5l NzQ2OWYyIDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ1NTU3R5bGVN b2RlbC5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ1NTU3R5bGVNb2RlbC5q cwpAQCAtMTc0LDYgKzE3NCw4IEBAIFdlYkluc3BlY3Rvci5DU1NTdHlsZU1vZGVsLnByb3RvdHlw ZSA9IHsKICAgICAgICAgZnVuY3Rpb24gY2FsbGJhY2soc3VjY2VzcykKICAgICAgICAgewogICAg ICAgICAgICAgdGhpcy5fc3R5bGVTaGVldENoYW5nZWQoc3R5bGVTaGVldElkLCB0cnVlKTsKKyAg ICAgICAgICAgIGlmIChXZWJJbnNwZWN0b3IucGFuZWxzLmVsZW1lbnRzKQorICAgICAgICAgICAg ICAgIFdlYkluc3BlY3Rvci5wYW5lbHMuZWxlbWVudHMuc3R5bGVzUGFuZUVkaXRlZCgpOwogICAg ICAgICB9CiAgICAgICAgIEluc3BlY3RvckJhY2tlbmQuc2V0U3R5bGVTaGVldFRleHQyKHN0eWxl U2hlZXRJZCwgY29udGVudFRvUmV2ZXJ0VG8sIGNhbGxiYWNrLmJpbmQodGhpcykpOwogICAgIH0K ZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1BhbmVsLmpz IGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzUGFuZWwuanMKaW5kZXggNjFi YTMzZS4uNDBlZGIzZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0Vs ZW1lbnRzUGFuZWwuanMKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRz UGFuZWwuanMKQEAgLTg1LDggKzg1LDggQEAgV2ViSW5zcGVjdG9yLkVsZW1lbnRzUGFuZWwgPSBm dW5jdGlvbigpCiAKICAgICB0aGlzLnNpZGViYXJQYW5lcy5zdHlsZXMuZXhwYW5kZWQgPSB0cnVl OwogCi0gICAgdGhpcy5zaWRlYmFyUGFuZXMuc3R5bGVzLmFkZEV2ZW50TGlzdGVuZXIoInN0eWxl IGVkaXRlZCIsIHRoaXMuX3N0eWxlc1BhbmVFZGl0ZWQsIHRoaXMpOwotICAgIHRoaXMuc2lkZWJh clBhbmVzLnN0eWxlcy5hZGRFdmVudExpc3RlbmVyKCJzdHlsZSBwcm9wZXJ0eSB0b2dnbGVkIiwg dGhpcy5fc3R5bGVzUGFuZUVkaXRlZCwgdGhpcyk7CisgICAgdGhpcy5zaWRlYmFyUGFuZXMuc3R5 bGVzLmFkZEV2ZW50TGlzdGVuZXIoInN0eWxlIGVkaXRlZCIsIHRoaXMuc3R5bGVzUGFuZUVkaXRl ZCwgdGhpcyk7CisgICAgdGhpcy5zaWRlYmFyUGFuZXMuc3R5bGVzLmFkZEV2ZW50TGlzdGVuZXIo InN0eWxlIHByb3BlcnR5IHRvZ2dsZWQiLCB0aGlzLnN0eWxlc1BhbmVFZGl0ZWQsIHRoaXMpOwog ICAgIHRoaXMuc2lkZWJhclBhbmVzLm1ldHJpY3MuYWRkRXZlbnRMaXN0ZW5lcigibWV0cmljcyBl ZGl0ZWQiLCB0aGlzLl9tZXRyaWNzUGFuZUVkaXRlZCwgdGhpcyk7CiAKICAgICB0aGlzLnNpZGVi YXJFbGVtZW50ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiZGl2Iik7CkBAIC00NDUsMTMgKzQ0 NSwxMyBAQCBXZWJJbnNwZWN0b3IuRWxlbWVudHNQYW5lbC5wcm90b3R5cGUgPSB7CiAgICAgICAg ICAgICB0aGlzLnVwZGF0ZUJyZWFkY3J1bWIodHJ1ZSk7CiAgICAgfSwKIAotICAgIF9zdHlsZXNQ YW5lRWRpdGVkOiBmdW5jdGlvbigpCisgICAgX21ldHJpY3NQYW5lRWRpdGVkOiBmdW5jdGlvbigp CiAgICAgewogICAgICAgICB0aGlzLnNpZGViYXJQYW5lcy5tZXRyaWNzLm5lZWRzVXBkYXRlID0g dHJ1ZTsKICAgICAgICAgdGhpcy51cGRhdGVNZXRyaWNzKCk7CiAgICAgfSwKIAotICAgIF9tZXRy aWNzUGFuZUVkaXRlZDogZnVuY3Rpb24oKQorICAgIHN0eWxlc1BhbmVFZGl0ZWQ6IGZ1bmN0aW9u KCkKICAgICB7CiAgICAgICAgIHRoaXMuc2lkZWJhclBhbmVzLnN0eWxlcy5uZWVkc1VwZGF0ZSA9 IHRydWU7CiAgICAgICAgIHRoaXMudXBkYXRlU3R5bGVzKHRydWUpOwo= 76542 2010-12-14 09:36:31 -0800 2010-12-14 09:56:30 -0800 [PATCH] Comment addressed ruleupdates.patch text/plain 3300 apavlov Y29tbWl0IDM2NTcyZTg2ODZmNGI0NmNjNTI5Y2Q1YzlmNzI3MDUzMGQ1N2M0YTEKQXV0aG9yOiBB bGV4YW5kZXIgUGF2bG92IDxhcGF2bG92QGNocm9taXVtLm9yZz4KRGF0ZTogICBUdWUgRGVjIDE0 IDE5OjE5OjQxIDIwMTAgKzAzMDAKCiAgICBVcGRhdGUgc3R5bGVzIGFmdGVyIHJldmVydAoKZGlm ZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODEy MTIwNS4uMWE3MDk0ZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29y ZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0xMi0xNCAgQWxleGFuZGVyIFBhdmxv diAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFJ1bGUgZGF0YSBub3QgdXBkYXRlZCBp biBTdHlsZXMgcGFuZSBhZnRlciBzdHlsZXNoZWV0IGdldHMgcmV2ZXJ0ZWQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUxMDM0CisKKyAgICAgICAgKiBp bnNwZWN0b3IvZnJvbnQtZW5kL0NTU1N0eWxlTW9kZWwuanM6CisgICAgICAgIChXZWJJbnNwZWN0 b3IuQ1NTU3R5bGVNb2RlbC5wcm90b3R5cGUuX29uUmV2ZXJ0KToKKyAgICAgICAgKiBpbnNwZWN0 b3IvZnJvbnQtZW5kL0VsZW1lbnRzUGFuZWwuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRWxl bWVudHNQYW5lbCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRWxlbWVudHNQYW5lbC5wcm90b3R5 cGUuX21ldHJpY3NQYW5lRWRpdGVkKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5FbGVtZW50c1Bh bmVsLnByb3RvdHlwZS5fc3R5bGVzUGFuZUVkaXRlZCk6CisgICAgICAgIChXZWJJbnNwZWN0b3Iu RWxlbWVudHNQYW5lbC5wcm90b3R5cGUuX3N0eWxlU2hlZXRDaGFuZ2VkKToKKwogMjAxMC0xMi0x NCAgSWx5YSBUaWtob25vdnNreSAgPGxvaXNsb0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgUGF2ZWwgRmVsZG1hbi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9DU1NTdHlsZU1vZGVsLmpzIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NT U1N0eWxlTW9kZWwuanMKaW5kZXggMjNlZDdhOC4uMmQxNTU4MiAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NTU1N0eWxlTW9kZWwuanMKKysrIGIvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL0NTU1N0eWxlTW9kZWwuanMKQEAgLTE3NCwxMSArMTc0LDE0IEBAIFdl Ykluc3BlY3Rvci5DU1NTdHlsZU1vZGVsLnByb3RvdHlwZSA9IHsKICAgICAgICAgZnVuY3Rpb24g Y2FsbGJhY2soc3VjY2VzcykKICAgICAgICAgewogICAgICAgICAgICAgdGhpcy5fc3R5bGVTaGVl dENoYW5nZWQoc3R5bGVTaGVldElkLCB0cnVlKTsKKyAgICAgICAgICAgIHRoaXMuZGlzcGF0Y2hF dmVudFRvTGlzdGVuZXJzKCJzdHlsZXNoZWV0IGNoYW5nZWQiKTsKICAgICAgICAgfQogICAgICAg ICBJbnNwZWN0b3JCYWNrZW5kLnNldFN0eWxlU2hlZXRUZXh0MihzdHlsZVNoZWV0SWQsIGNvbnRl bnRUb1JldmVydFRvLCBjYWxsYmFjay5iaW5kKHRoaXMpKTsKICAgICB9CiB9CiAKK1dlYkluc3Bl Y3Rvci5DU1NTdHlsZU1vZGVsLnByb3RvdHlwZS5fX3Byb3RvX18gPSBXZWJJbnNwZWN0b3IuT2Jq ZWN0LnByb3RvdHlwZTsKKwogV2ViSW5zcGVjdG9yLkNTU1N0eWxlRGVjbGFyYXRpb24gPSBmdW5j dGlvbihwYXlsb2FkKQogewogICAgIHRoaXMuaWQgPSBwYXlsb2FkLnN0eWxlSWQ7CmRpZmYgLS1n aXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRWxlbWVudHNQYW5lbC5qcyBiL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1BhbmVsLmpzCmluZGV4IDYxYmEzM2UuLmEx YzE4MWYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1Bh bmVsLmpzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1BhbmVsLmpz CkBAIC04OCw2ICs4OCw3IEBAIFdlYkluc3BlY3Rvci5FbGVtZW50c1BhbmVsID0gZnVuY3Rpb24o KQogICAgIHRoaXMuc2lkZWJhclBhbmVzLnN0eWxlcy5hZGRFdmVudExpc3RlbmVyKCJzdHlsZSBl ZGl0ZWQiLCB0aGlzLl9zdHlsZXNQYW5lRWRpdGVkLCB0aGlzKTsKICAgICB0aGlzLnNpZGViYXJQ YW5lcy5zdHlsZXMuYWRkRXZlbnRMaXN0ZW5lcigic3R5bGUgcHJvcGVydHkgdG9nZ2xlZCIsIHRo aXMuX3N0eWxlc1BhbmVFZGl0ZWQsIHRoaXMpOwogICAgIHRoaXMuc2lkZWJhclBhbmVzLm1ldHJp Y3MuYWRkRXZlbnRMaXN0ZW5lcigibWV0cmljcyBlZGl0ZWQiLCB0aGlzLl9tZXRyaWNzUGFuZUVk aXRlZCwgdGhpcyk7CisgICAgV2ViSW5zcGVjdG9yLmNzc01vZGVsLmFkZEV2ZW50TGlzdGVuZXIo InN0eWxlc2hlZXQgY2hhbmdlZCIsIHRoaXMuX3N0eWxlU2hlZXRDaGFuZ2VkLCB0aGlzKTsKIAog ICAgIHRoaXMuc2lkZWJhckVsZW1lbnQgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJkaXYiKTsK ICAgICB0aGlzLnNpZGViYXJFbGVtZW50LmlkID0gImVsZW1lbnRzLXNpZGViYXIiOwpAQCAtNDQ1 LDE4ICs0NDYsMjMgQEAgV2ViSW5zcGVjdG9yLkVsZW1lbnRzUGFuZWwucHJvdG90eXBlID0gewog ICAgICAgICAgICAgdGhpcy51cGRhdGVCcmVhZGNydW1iKHRydWUpOwogICAgIH0sCiAKLSAgICBf c3R5bGVzUGFuZUVkaXRlZDogZnVuY3Rpb24oKQorICAgIF9tZXRyaWNzUGFuZUVkaXRlZDogZnVu Y3Rpb24oKQogICAgIHsKICAgICAgICAgdGhpcy5zaWRlYmFyUGFuZXMubWV0cmljcy5uZWVkc1Vw ZGF0ZSA9IHRydWU7CiAgICAgICAgIHRoaXMudXBkYXRlTWV0cmljcygpOwogICAgIH0sCiAKLSAg ICBfbWV0cmljc1BhbmVFZGl0ZWQ6IGZ1bmN0aW9uKCkKKyAgICBfc3R5bGVzUGFuZUVkaXRlZDog ZnVuY3Rpb24oKQogICAgIHsKICAgICAgICAgdGhpcy5zaWRlYmFyUGFuZXMuc3R5bGVzLm5lZWRz VXBkYXRlID0gdHJ1ZTsKICAgICAgICAgdGhpcy51cGRhdGVTdHlsZXModHJ1ZSk7CiAgICAgfSwK IAorICAgIF9zdHlsZVNoZWV0Q2hhbmdlZDogZnVuY3Rpb24oKQorICAgIHsKKyAgICAgICAgdGhp cy5fc3R5bGVzUGFuZUVkaXRlZCgpOworICAgIH0sCisKICAgICBfbW91c2VNb3ZlZEluQ3J1bWJz OiBmdW5jdGlvbihldmVudCkKICAgICB7CiAgICAgICAgIHZhciBub2RlVW5kZXJNb3VzZSA9IGRv Y3VtZW50LmVsZW1lbnRGcm9tUG9pbnQoZXZlbnQucGFnZVgsIGV2ZW50LnBhZ2VZKTsK