51029 2010-12-14 05:14:19 -0800 Would like a pre-commit hook that checks for well-formedness of .vcproj/.vsprops XML files 2015-12-07 10:08:03 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All NEW P2 Normal --- 1 aroben webkit-unassigned abarth ap lforschler mrowe sfalken oldest_to_newest 321907 0 aroben 2010-12-14 05:14:19 -0800 It's very common for people to introduce XML syntax errors when manually editing .vcproj/.vsprops files (see, e.g., <http://trac.webkit.org/changeset/73914> and <http://trac.webkit.org/changeset/73921>). It would be nice to have a pre-commit hook that would check that these files are well-formed. Steve suggested using `xmllint --noout`. 322066 1 ap 2010-12-14 11:30:30 -0800 Maybe this could be as early as svn-create-patch and/or style checker, in addition to commit hook. 322287 2 wsiegrist 2010-12-14 15:25:42 -0800 This is possible, but is a pre-commit hook the right solution? If we wanted pre-commit hooks to verify our syntax, why not have a tool that lints xml as well as C++, Python, IDL, etc. In other words, why does XML linting need to block commits but not C++? 322332 3 sfalken 2010-12-14 16:25:07 -0800 Here are some recent build fixes required after incorrect edits to WebCore.vcproj that would have been caught by an XML well-formedness check: http://trac.webkit.org/changeset/73887/trunk/WebCore/WebCore.vcproj/WebCore.vcproj http://trac.webkit.org/changeset/73773/trunk/WebCore/WebCore.vcproj/WebCore.vcproj http://trac.webkit.org/changeset/72795/trunk/WebCore/WebCore.vcproj/WebCore.vcproj Adding this to the style checker might be an ok place to start. This seems worse than a simple lint or style issue since these aren't stylistic problems (they're fatal errors). Not sure where the line is between pre-commit hook and style checker. We check for tabs in pre-commit hook for example. 322574 4 aroben 2010-12-15 04:54:50 -0800 Let's start with making check-webkit-style catch these errors, and then see if more is needed. I filed bug 51103.