51016 2010-12-13 23:04:00 -0800 Clang fails to build the JSC interpreter 2010-12-20 22:47:18 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 zwarich zwarich eric oldest_to_newest 321705 0 zwarich 2010-12-13 23:04:00 -0800 Clang fails to build the JSC interpreter due to an indirect goto out of a protected scope. Interestingly enough, GCC doesn't emit destructors here, which is generally incorrect code. 321708 1 76507 zwarich 2010-12-13 23:09:55 -0800 Created attachment 76507 Proposed patch 321731 2 76507 eric 2010-12-14 00:47:28 -0800 Comment on attachment 76507 Proposed patch OK. rs=me. 324823 3 eric 2010-12-20 22:47:18 -0800 r74029. Please use webkit-patch land to land your changes so bugs get updated when you do. 76507 2010-12-13 23:09:55 -0800 2010-12-14 00:47:27 -0800 Proposed patch cleanup.patch text/plain 1615 zwarich SW5kZXg6IGludGVycHJldGVyL0ludGVycHJldGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBpbnRlcnBy ZXRlci9JbnRlcnByZXRlci5jcHAJKHJldmlzaW9uIDc0MDA1KQorKysgaW50ZXJwcmV0ZXIvSW50 ZXJwcmV0ZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMTk2LDggKzMxOTYsMTAgQEAKICAgICAg ICAgICAgIHZQQyArPSBPUENPREVfTEVOR1RIKG9wX2dldF9ieV9wbmFtZSk7CiAgICAgICAgICAg ICBORVhUX0lOU1RSVUNUSU9OKCk7CiAgICAgICAgIH0KLSAgICAgICAgSWRlbnRpZmllciBwcm9w ZXJ0eU5hbWUoY2FsbEZyYW1lLCBzdWJzY3JpcHQudG9TdHJpbmcoY2FsbEZyYW1lKSk7Ci0gICAg ICAgIHJlc3VsdCA9IGJhc2VWYWx1ZS5nZXQoY2FsbEZyYW1lLCBwcm9wZXJ0eU5hbWUpOworICAg ICAgICB7CisgICAgICAgICAgICBJZGVudGlmaWVyIHByb3BlcnR5TmFtZShjYWxsRnJhbWUsIHN1 YnNjcmlwdC50b1N0cmluZyhjYWxsRnJhbWUpKTsKKyAgICAgICAgICAgIHJlc3VsdCA9IGJhc2VW YWx1ZS5nZXQoY2FsbEZyYW1lLCBwcm9wZXJ0eU5hbWUpOworICAgICAgICB9CiAgICAgICAgIENI RUNLX0ZPUl9FWENFUFRJT04oKTsKICAgICAgICAgY2FsbEZyYW1lLT51bmNoZWNrZWRSKGRzdCkg PSByZXN1bHQ7CiAgICAgICAgIHZQQyArPSBPUENPREVfTEVOR1RIKG9wX2dldF9ieV9wbmFtZSk7 CkluZGV4OiBDaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gQ2hhbmdlTG9nCShyZXZpc2lvbiA3NDAw NSkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSw1ICsxLDE5IEBACiAyMDEwLTEy LTEzICBDYW1lcm9uIFp3YXJpY2ggIDx6d2FyaWNoQGFwcGxlLmNvbT4KIAorICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDbGFuZyBmYWlscyB0byBidWlsZCB0 aGUgSlNDIGludGVycHJldGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD01MTAxNgorCisgICAgICAgIENsYW5nIGRvZXMgbm90IGFsbG93IGluZGlyZWN0 IGdvdG9zIG91dCBvZiBzY29wZXMgd2l0aCBjbGVhbnVwLiBHQ0MgYWxsb3dzCisgICAgICAgIHRo ZW0sIGJ1dCBpdCBkb2VzIG5vdCBjb3JyZWN0bHkgZ2VuZXJhdGUgdGhlIGNsZWFudXAsIGNhdXNp bmcgYSBsZWFrIGlmIHRoZQorICAgICAgICBjbGVhbnVwIGRlY3JlbWVudHMgYSByZWZlcmVuY2Ug Y291bnQuCisKKyAgICAgICAgKiBpbnRlcnByZXRlci9JbnRlcnByZXRlci5jcHA6CisgICAgICAg IChKU0M6OkludGVycHJldGVyOjpwcml2YXRlRXhlY3V0ZSk6IFB1dCBhbiBJZGVudGlmaWVyIGlu dG8gaXRzIG93biBzY29wZS4KKworMjAxMC0xMi0xMyAgQ2FtZXJvbiBad2FyaWNoICA8endhcmlj aEBhcHBsZS5jb20+CisKICAgICAgICAgUmV2aWV3ZWQgYnkgR2F2aW4gQmFycmFjbG91Z2guCiAK ICAgICAgICAgSmF2YVNjcmlwdENvcmUgc2hvdWxkIG5vdCB1c2UgImFzbSB2b2xhdGlsZSIgb3V0 c2lkZSBvZiBhIGZ1bmN0aW9uCg==