5100 2005-09-22 11:54:02 -0700 -[WebTextRenderer _ATSU_drawRun:...] does not check view flippedness 2005-09-24 11:31:11 -0700 1 1 1 Unclassified WebKit Layout and Rendering 420+ Mac OS X 10.4 VERIFIED FIXED P2 Normal --- 1 mitz hyatt oldest_to_newest 20234 0 mitz 2005-09-22 11:54:02 -0700 -[WebTextRenderer _ATSU_drawRun:style:geometry] does not check and compensate when drawing into a flipped view, resulting in flipped text in some cases. To reproduce: open the testcase in Safari and drag each one of the links. Expected: the link text to appear correctly in the drag image of each link. Actual: in the first link's drag image, the link text is flipped horizontally. 20235 1 4009 mitz 2005-09-22 11:54:39 -0700 Created attachment 4009 testcase 20237 2 4011 mitz 2005-09-22 12:25:40 -0700 Created attachment 4011 flip coordinates when necessary Note that it needs to flip when the view is unflipped, since the ATSUStyle itself always flips (see _initializeATSUStyle). 20284 3 4011 darin 2005-09-23 08:39:39 -0700 Comment on attachment 4011 flip coordinates when necessary Formatting is wrong here. There should not be a space after the "(" in the if statements. Otherwise, this looks great. 20286 4 4016 mitz 2005-09-23 08:50:02 -0700 Created attachment 4016 flip coordinates when necessary 20288 5 4017 mitz 2005-09-23 08:55:15 -0700 Created attachment 4017 flip coordinates when necessary 20290 6 4017 mitz 2005-09-23 08:58:38 -0700 Comment on attachment 4017 flip coordinates when necessary Corrected style and use of params.layout instead of layout 20295 7 4017 darin 2005-09-23 09:09:09 -0700 Comment on attachment 4017 flip coordinates when necessary r=me 20345 8 darin 2005-09-23 18:06:39 -0700 Thinking further on this, I think it's not so great to have the renderer depend on there being a currently- focused NSView. Instead, the flippedness should be applied by the caller, or there should be a boolean passed in. I have no objection to landing this patch first, but it's not a good long-term solution. The renderer code should be independent of NSView. 4009 2005-09-22 11:54:39 -0700 2005-09-22 11:54:39 -0700 testcase flippyATSUI.html text/html 525 mitz PCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMDEgVFJBTlNJVElPTkFM Ly9FTiI+CjxodG1sPgo8aGVhZD4KPHRpdGxlPkZsaXBwZWQgdGV4dCBpbiBsaW5rIGRyYWcgaW1h Z2U8L3RpdGxlPgo8L2hlYWQ+Cjxib2R5Pgo8cD5UcnkgZHJhZ2dpbmcgZWFjaCBvZiB0aGUgZm9s bG93aW5nIGxpbmtzLiBJbiBlYWNoIGNhc2UsIHRoZSBsaW5rIHRleHQgc2hvdWxkIGFwcGVhciBj b3JyZWN0bHkgKG5vdCBmbGlwcGVkKSBpbiB0aGUKZHJhZyBpbWFnZSwgYWJvdmUgdGhlIFVSTC48 L3A+CjxwPldlYktpdCByZW5kZXJlciwgdXNpbmcgQVRTVUk6IDxhIGhyZWY9Ii8iPkRyYWcgbWUg JiN4MDkwNTsgdG8geW91ciBsZWFkZXI8L2E+PC9wPgo8cD5Db2NvYTogPGEgaHJlZj0iLyI+RHJh ZyBtZSAmI3gwOTA1OyB0byB5b3VyIGxlYWRlciE8L2E+PC9wPgo8cD5XZWJLaXQgcmVuZGVyZXIs IHVzaW5nIENHOiA8YSBocmVmPSIvIj5EcmFnIG1lIHRvIHlvdXIgbGVhZGVyPC9hPjwvcD4KPC9i b2R5Pgo8L2h0bWw+ 4011 2005-09-22 12:25:40 -0700 2005-09-23 08:50:02 -0700 flip coordinates when necessary 5100_r1.patch text/plain 1102 mitz SW5kZXg6IFdlYlRleHRSZW5kZXJlci5tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9X ZWJLaXQvV2ViQ29yZVN1cHBvcnQuc3VicHJvai9XZWJUZXh0UmVuZGVyZXIubSx2CnJldHJpZXZp bmcgcmV2aXNpb24gMS4xODkKZGlmZiAtcCAtdSAtcjEuMTg5IFdlYlRleHRSZW5kZXJlci5tCi0t LSBXZWJUZXh0UmVuZGVyZXIubQkyNSBBdWcgMjAwNSAyMzo0NjozMCAtMDAwMAkxLjE4OQorKysg V2ViVGV4dFJlbmRlcmVyLm0JMjIgU2VwIDIwMDUgMTk6MTY6MDkgLTAwMDAKQEAgLTE3MDAsNyAr MTcwMCwxMiBAQCBzdGF0aWMgV2ViQ29yZVRleHRSdW4gYXBwbHlNaXJyb3JpbmdUb1J1CiAgICAg Ly8gQVRTVUkgY2FuJ3QgZHJhdyBiZXlvbmQgLTMyNzY4IHRvICszMjc2NyBzbyB3ZSB0cmFuc2xh dGUgdGhlIENUTSBhbmQgdGVsbCBBVFNVSSB0byBkcmF3IGF0ICgwLCAwKS4KICAgICBDR0NvbnRl eHRSZWYgY29udGV4dCA9IChDR0NvbnRleHRSZWYpW1tOU0dyYXBoaWNzQ29udGV4dCBjdXJyZW50 Q29udGV4dF0gZ3JhcGhpY3NQb3J0XTsKICAgICBDR0NvbnRleHRUcmFuc2xhdGVDVE0oY29udGV4 dCwgZ2VvbWV0cnktPnBvaW50LngsIGdlb21ldHJ5LT5wb2ludC55KTsKLSAgICBzdGF0dXMgPSBB VFNVRHJhd1RleHQobGF5b3V0LCBhUnVuLT5mcm9tLCBydW5MZW5ndGgsIDAsIDApOworICAgIEJP T0wgZmxpcHBlZCA9IFtbTlNWaWV3IGZvY3VzVmlld10gaXNGbGlwcGVkXTsKKyAgICBpZiAoICFm bGlwcGVkICkKKyAgICAgICAgQ0dDb250ZXh0U2NhbGVDVE0oY29udGV4dCwgMS4wLCAtMS4wKTsK KyAgICBzdGF0dXMgPSBBVFNVRHJhd1RleHQocGFyYW1zLmxheW91dCwgYVJ1bi0+ZnJvbSwgcnVu TGVuZ3RoLCAwLCAwKTsKKyAgICBpZiAoICFmbGlwcGVkICkKKyAgICAgICAgQ0dDb250ZXh0U2Nh bGVDVE0oY29udGV4dCwgMS4wLCAtMS4wKTsKICAgICBDR0NvbnRleHRUcmFuc2xhdGVDVE0oY29u dGV4dCwgLWdlb21ldHJ5LT5wb2ludC54LCAtZ2VvbWV0cnktPnBvaW50LnkpOwogCiAgICAgaWYg KHN0YXR1cyAhPSBub0Vycil7Cg== 4016 2005-09-23 08:50:02 -0700 2005-09-23 08:52:20 -0700 flip coordinates when necessary 5100_r2.patch text/plain 1098 mitz SW5kZXg6IFdlYlRleHRSZW5kZXJlci5tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9X ZWJLaXQvV2ViQ29yZVN1cHBvcnQuc3VicHJvai9XZWJUZXh0UmVuZGVyZXIubSx2CnJldHJpZXZp bmcgcmV2aXNpb24gMS4xODkKZGlmZiAtcCAtdSAtcjEuMTg5IFdlYlRleHRSZW5kZXJlci5tCi0t LSBXZWJUZXh0UmVuZGVyZXIubQkyNSBBdWcgMjAwNSAyMzo0NjozMCAtMDAwMAkxLjE4OQorKysg V2ViVGV4dFJlbmRlcmVyLm0JMjMgU2VwIDIwMDUgMTU6NTE6NDUgLTAwMDAKQEAgLTE3MDAsNyAr MTcwMCwxMiBAQCBzdGF0aWMgV2ViQ29yZVRleHRSdW4gYXBwbHlNaXJyb3JpbmdUb1J1CiAgICAg Ly8gQVRTVUkgY2FuJ3QgZHJhdyBiZXlvbmQgLTMyNzY4IHRvICszMjc2NyBzbyB3ZSB0cmFuc2xh dGUgdGhlIENUTSBhbmQgdGVsbCBBVFNVSSB0byBkcmF3IGF0ICgwLCAwKS4KICAgICBDR0NvbnRl eHRSZWYgY29udGV4dCA9IChDR0NvbnRleHRSZWYpW1tOU0dyYXBoaWNzQ29udGV4dCBjdXJyZW50 Q29udGV4dF0gZ3JhcGhpY3NQb3J0XTsKICAgICBDR0NvbnRleHRUcmFuc2xhdGVDVE0oY29udGV4 dCwgZ2VvbWV0cnktPnBvaW50LngsIGdlb21ldHJ5LT5wb2ludC55KTsKLSAgICBzdGF0dXMgPSBB VFNVRHJhd1RleHQobGF5b3V0LCBhUnVuLT5mcm9tLCBydW5MZW5ndGgsIDAsIDApOworICAgIEJP T0wgZmxpcHBlZCA9IFtbTlNWaWV3IGZvY3VzVmlld10gaXNGbGlwcGVkXTsKKyAgICBpZiAoIWZs aXBwZWQpCisgICAgICAgIENHQ29udGV4dFNjYWxlQ1RNKGNvbnRleHQsIDEuMCwgLTEuMCk7Cisg ICAgc3RhdHVzID0gQVRTVURyYXdUZXh0KHBhcmFtcy5sYXlvdXQsIGFSdW4tPmZyb20sIHJ1bkxl bmd0aCwgMCwgMCk7CisgICAgaWYgKCFmbGlwcGVkKQorICAgICAgICBDR0NvbnRleHRTY2FsZUNU TShjb250ZXh0LCAxLjAsIC0xLjApOwogICAgIENHQ29udGV4dFRyYW5zbGF0ZUNUTShjb250ZXh0 LCAtZ2VvbWV0cnktPnBvaW50LngsIC1nZW9tZXRyeS0+cG9pbnQueSk7CiAKICAgICBpZiAoc3Rh dHVzICE9IG5vRXJyKXsK 4017 2005-09-23 08:55:15 -0700 2005-09-23 09:09:09 -0700 flip coordinates when necessary 5100_r3.patch text/plain 1026 mitz SW5kZXg6IFdlYlRleHRSZW5kZXJlci5tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9X ZWJLaXQvV2ViQ29yZVN1cHBvcnQuc3VicHJvai9XZWJUZXh0UmVuZGVyZXIubSx2CnJldHJpZXZp bmcgcmV2aXNpb24gMS4xODkKZGlmZiAtcCAtdSAtcjEuMTg5IFdlYlRleHRSZW5kZXJlci5tCi0t LSBXZWJUZXh0UmVuZGVyZXIubQkyNSBBdWcgMjAwNSAyMzo0NjozMCAtMDAwMAkxLjE4OQorKysg V2ViVGV4dFJlbmRlcmVyLm0JMjMgU2VwIDIwMDUgMTU6NTc6MzAgLTAwMDAKQEAgLTE3MDAsNyAr MTcwMCwxMiBAQCBzdGF0aWMgV2ViQ29yZVRleHRSdW4gYXBwbHlNaXJyb3JpbmdUb1J1CiAgICAg Ly8gQVRTVUkgY2FuJ3QgZHJhdyBiZXlvbmQgLTMyNzY4IHRvICszMjc2NyBzbyB3ZSB0cmFuc2xh dGUgdGhlIENUTSBhbmQgdGVsbCBBVFNVSSB0byBkcmF3IGF0ICgwLCAwKS4KICAgICBDR0NvbnRl eHRSZWYgY29udGV4dCA9IChDR0NvbnRleHRSZWYpW1tOU0dyYXBoaWNzQ29udGV4dCBjdXJyZW50 Q29udGV4dF0gZ3JhcGhpY3NQb3J0XTsKICAgICBDR0NvbnRleHRUcmFuc2xhdGVDVE0oY29udGV4 dCwgZ2VvbWV0cnktPnBvaW50LngsIGdlb21ldHJ5LT5wb2ludC55KTsKKyAgICBCT09MIGZsaXBw ZWQgPSBbW05TVmlldyBmb2N1c1ZpZXddIGlzRmxpcHBlZF07CisgICAgaWYgKCFmbGlwcGVkKQor ICAgICAgICBDR0NvbnRleHRTY2FsZUNUTShjb250ZXh0LCAxLjAsIC0xLjApOwogICAgIHN0YXR1 cyA9IEFUU1VEcmF3VGV4dChsYXlvdXQsIGFSdW4tPmZyb20sIHJ1bkxlbmd0aCwgMCwgMCk7Cisg ICAgaWYgKCFmbGlwcGVkKQorICAgICAgICBDR0NvbnRleHRTY2FsZUNUTShjb250ZXh0LCAxLjAs IC0xLjApOwogICAgIENHQ29udGV4dFRyYW5zbGF0ZUNUTShjb250ZXh0LCAtZ2VvbWV0cnktPnBv aW50LngsIC1nZW9tZXRyeS0+cG9pbnQueSk7CiAKICAgICBpZiAoc3RhdHVzICE9IG5vRXJyKXsK