50991 2010-12-13 15:51:02 -0800 JavaScriptCore should not use "asm volatile" outside of a function 2010-12-20 22:46:46 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 zwarich zwarich eric oldest_to_newest 321510 0 zwarich 2010-12-13 15:51:02 -0800 JavaScriptCore should not use "asm volatile" outside of a function. The 'volatile' does nothing. 321516 1 76461 zwarich 2010-12-13 15:56:59 -0800 Created attachment 76461 Proposed patch 324822 2 eric 2010-12-20 22:46:46 -0800 r73981. Please use webkit-patch land to land your changes so that bugs get closed. :) 76461 2010-12-13 15:56:59 -0800 2010-12-13 16:01:47 -0800 Proposed patch volatile.patch text/plain 2499 zwarich SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDczOTc4 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMTIt MTMgIENhbWVyb24gWndhcmljaCAgPHp3YXJpY2hAYXBwbGUuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEphdmFTY3JpcHRDb3JlIHNob3VsZCBu b3QgdXNlICJhc20gdm9sYXRpbGUiIG91dHNpZGUgb2YgYSBmdW5jdGlvbgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTA5OTEKKworICAgICAgICAqIGpp dC9KSVRTdHVicy5jcHA6IFJlbW92ZSB0aGUgdm9sYXRpbGUga2V5d29yZCBmcm9tIGFzbSBzdGF0 ZW1lbnRzLgorCiAyMDEwLTEyLTEzICBTdGV2ZSBGYWxrZW5idXJnICA8c2ZhbGtlbkBhcHBsZS5j b20+CiAKICAgICAgICAgV2luZG93cyBwcm9kdWN0aW9uIGJ1aWxkIGZpeC4KSW5kZXg6IGppdC9K SVRTdHVicy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gaml0L0pJVFN0dWJzLmNwcAkocmV2aXNpb24gNzM5 NjYpCisrKyBqaXQvSklUU3R1YnMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01NDYsNyArNTQ2LDcg QEAKICNlbmRpZiAvLyBVU0UoSlNWQUxVRTMyXzY0KQogCiAjaWYgQ1BVKE1JUFMpCi1hc20gdm9s YXRpbGUoCithc20gKAogIi50ZXh0IiAiXG4iCiAiLmFsaWduIDIiICJcbiIKICIuc2V0IG5vcmVv cmRlciIgIlxuIgpAQCAtNTg1LDcgKzU4NSw3IEBACiAiLmVuZCAiIFNZTUJPTF9TVFJJTkcoY3Rp VHJhbXBvbGluZSkgIlxuIgogKTsKIAotYXNtIHZvbGF0aWxlKAorYXNtICgKICIudGV4dCIgIlxu IgogIi5hbGlnbiAyIiAiXG4iCiAiLnNldCBub3Jlb3JkZXIiICJcbiIKQEAgLTYxNiw3ICs2MTYs NyBAQAogIi5lbmQgIiBTWU1CT0xfU1RSSU5HKGN0aVZNVGhyb3dUcmFtcG9saW5lKSAiXG4iCiAp OwogCi1hc20gdm9sYXRpbGUoCithc20gKAogIi50ZXh0IiAiXG4iCiAiLmFsaWduIDIiICJcbiIK ICIuc2V0IG5vcmVvcmRlciIgIlxuIgpAQCAtNjM5LDcgKzYzOSw3IEBACiAKICNpZiBDT01QSUxF UihHQ0MpICYmIENQVShBUk1fVEhVTUIyKQogCi1hc20gdm9sYXRpbGUoCithc20gKAogIi50ZXh0 IiAiXG4iCiAiLmFsaWduIDIiICJcbiIKICIuZ2xvYmwgIiBTWU1CT0xfU1RSSU5HKGN0aVRyYW1w b2xpbmUpICJcbiIKQEAgLTY2Niw3ICs2NjYsNyBAQAogICAgICJieCBsciIgIlxuIgogKTsKIAot YXNtIHZvbGF0aWxlKAorYXNtICgKICIudGV4dCIgIlxuIgogIi5hbGlnbiAyIiAiXG4iCiAiLmds b2JsICIgU1lNQk9MX1NUUklORyhjdGlWTVRocm93VHJhbXBvbGluZSkgIlxuIgpAQCAtNjg0LDcg KzY4NCw3IEBACiAgICAgImJ4IGxyIiAiXG4iCiApOwogCi1hc20gdm9sYXRpbGUoCithc20gKAog Ii50ZXh0IiAiXG4iCiAiLmFsaWduIDIiICJcbiIKICIuZ2xvYmwgIiBTWU1CT0xfU1RSSU5HKGN0 aU9wVGhyb3dOb3RDYXVnaHQpICJcbiIKQEAgLTcwMiw3ICs3MDIsNyBAQAogCiAjZWxpZiBDT01Q SUxFUihHQ0MpICYmIENQVShBUk1fVFJBRElUSU9OQUwpCiAKLWFzbSB2b2xhdGlsZSgKK2FzbSAo CiAiLmdsb2JsICIgU1lNQk9MX1NUUklORyhjdGlUcmFtcG9saW5lKSAiXG4iCiBISURFX1NZTUJP TChjdGlUcmFtcG9saW5lKSAiXG4iCiBTWU1CT0xfU1RSSU5HKGN0aVRyYW1wb2xpbmUpICI6IiAi XG4iCkBAIC03MjAsNyArNzIwLDcgQEAKICAgICAibW92IHBjLCBsciIgIlxuIgogKTsKIAotYXNt IHZvbGF0aWxlKAorYXNtICgKICIuZ2xvYmwgIiBTWU1CT0xfU1RSSU5HKGN0aVZNVGhyb3dUcmFt cG9saW5lKSAiXG4iCiBISURFX1NZTUJPTChjdGlWTVRocm93VHJhbXBvbGluZSkgIlxuIgogU1lN Qk9MX1NUUklORyhjdGlWTVRocm93VHJhbXBvbGluZSkgIjoiICJcbiIKQEAgLTExMDgsNyArMTEw OCw3IEBACiAgICAgZXh0ZXJuICJDIiB7IFwKICAgICAgICAgcnR5cGUgSklUU3R1YlRodW5rZWRf IyNvcChTVFVCX0FSR1NfREVDTEFSQVRJT04pOyBcCiAgICAgfTsgXAotICAgIGFzbSB2b2xhdGls ZSggXAorICAgIGFzbSAoIFwKICAgICAgICAgIi50ZXh0IiAiXG4iIFwKICAgICAgICAgIi5hbGln biAyIiAiXG4iIFwKICAgICAgICAgIi5zZXQgbm9yZW9yZGVyIiAiXG4iIFwKQEAgLTExMzgsNyAr MTEzOCw3IEBACiAgICAgZXh0ZXJuICJDIiB7IFwKICAgICAgICAgcnR5cGUgSklUU3R1YlRodW5r ZWRfIyNvcChTVFVCX0FSR1NfREVDTEFSQVRJT04pOyBcCiAgICAgfTsgXAotICAgIGFzbSB2b2xh dGlsZSggXAorICAgIGFzbSAoIFwKICAgICAgICAgIi50ZXh0IiAiXG4iIFwKICAgICAgICAgIi5h bGlnbiAyIiAiXG4iIFwKICAgICAgICAgIi5zZXQgbm9yZW9yZGVyIiAiXG4iIFwK