50989 2010-12-13 15:28:03 -0800 Change SelectionController::setFocusedNodeIfNeeded code to use DOM traversal instead of render tree traversal 2010-12-13 16:25:09 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 eae webkit-unassigned dglazkov webkit.review.bot oldest_to_newest 321493 0 eae 2010-12-13 15:28:03 -0800 Per comment introduced in bug 49977 by dglazkov@chromium.org, we should use DOM traversal in discovering first focusable node, rather than render tree. 321497 1 eae 2010-12-13 15:30:09 -0800 A FIXME comment in setFocusedNodeIfNeeded suggest combining the traversal code with that in EventHandle::dispatchMouseEvent. I don't see how that would simplify things though as they both need to perform different additional checks on the node. 321498 2 76456 eae 2010-12-13 15:32:15 -0800 Created attachment 76456 Patch 321500 3 76456 dglazkov 2010-12-13 15:36:34 -0800 Comment on attachment 76456 Patch ok. 321535 4 76456 webkit.review.bot 2010-12-13 16:25:04 -0800 Comment on attachment 76456 Patch Clearing flags on attachment: 76456 Committed r73984: <http://trac.webkit.org/changeset/73984> 321536 5 webkit.review.bot 2010-12-13 16:25:09 -0800 All reviewed patches have been landed. Closing bug. 76456 2010-12-13 15:32:15 -0800 2010-12-13 16:25:03 -0800 Patch 50989.patch text/plain 2327 eae SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3Mzk3MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMTItMTMgIEVtaWwgRWtsdW5kICA8ZWFlQGNocm9taXVtLm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaGFu Z2UgU2VsZWN0aW9uQ29udHJvbGxlcjo6c2V0Rm9jdXNlZE5vZGVJZk5lZWRlZCB0byB0cmF2ZXJz ZSB0aGUgRE9NCisgICAgICAgIHRyZWUgaW5zdGVhZCBvZiB0aGUgcmVuZGVyIHRyZWUuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MDk4OQorCisgICAg ICAgICogZWRpdGluZy9TZWxlY3Rpb25Db250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlNlbGVjdGlvbkNvbnRyb2xsZXI6OnNldEZvY3VzZWROb2RlSWZOZWVkZWQpOgorICAgICAgICBX YWxrIHVwIERPTS9ob3N0ZWQgdHJlZSByYXRoZXIgdGhhbiByZW5kZXIgdHJlZSBhbmQgcmVtb3Zl IEZJWE1FIGNvbW1lbnQKKyAgICAgICAgdGhhdCBkb2VzJ3QgYXBwbHkgKFNlbGVjdGlvbkNvbnRy b2xsZXIgYW5kIEV2ZW50SGFuZGxlciBuZWVkcyBkaWZmZXJlbnQKKyAgICAgICAgY2hlY2tzKS4K KwogMjAxMC0xMi0xMyAgQ2hyaXMgRmxlaXphY2ggIDxjZmxlaXphY2hAYXBwbGUuY29tPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IEJldGggRGFraW4uCkluZGV4OiBXZWJDb3JlL2VkaXRpbmcvU2Vs ZWN0aW9uQ29udHJvbGxlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9lZGl0aW5nL1NlbGVj dGlvbkNvbnRyb2xsZXIuY3BwCShyZXZpc2lvbiA3MzkzMCkKKysrIFdlYkNvcmUvZWRpdGluZy9T ZWxlY3Rpb25Db250cm9sbGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTU0NywxMiArMTU0Nyw4 IEBAIHZvaWQgU2VsZWN0aW9uQ29udHJvbGxlcjo6c2V0Rm9jdXNlZE5vZGUKICAgICB9CiAKICAg ICBpZiAoTm9kZSogdGFyZ2V0ID0gcm9vdEVkaXRhYmxlRWxlbWVudCgpKSB7Ci0gICAgICAgIFJl bmRlck9iamVjdCogcmVuZGVyZXIgPSB0YXJnZXQtPnJlbmRlcmVyKCk7Ci0KLSAgICAgICAgLy8g V2FsayB1cCB0aGUgcmVuZGVyIHRyZWUgdG8gc2VhcmNoIGZvciBhIG5vZGUgdG8gZm9jdXMuCi0g ICAgICAgIC8vIFdhbGtpbmcgdXAgdGhlIERPTSB0cmVlIHdvdWxkbid0IHdvcmsgZm9yIHNoYWRv dyB0cmVlcywgbGlrZSB0aG9zZSBiZWhpbmQgdGhlIGVuZ2luZS1iYXNlZCB0ZXh0IGZpZWxkcy4K LSAgICAgICAgLy8gRklYTUU6IENvbWJpbmUgd2l0aCB0aGUgc2FtZSB0cmF2ZXJzYWwgY29kZSBp biBFdmVudEhhbmRsZTo6ZGlzcGF0Y2hNb3VzZUV2ZW50LgotICAgICAgICB3aGlsZSAocmVuZGVy ZXIpIHsKKyAgICAgICAgLy8gV2FsayB1cCB0aGUgRE9NIHRyZWUgdG8gc2VhcmNoIGZvciBhIG5v ZGUgdG8gZm9jdXMuIAorICAgICAgICB3aGlsZSAodGFyZ2V0KSB7CiAgICAgICAgICAgICAvLyBX ZSBkb24ndCB3YW50IHRvIHNldCBmb2N1cyBvbiBhIHN1YmZyYW1lIHdoZW4gc2VsZWN0aW5nIGlu IGEgcGFyZW50IGZyYW1lLAogICAgICAgICAgICAgLy8gc28gYWRkIHRoZSAhaXNGcmFtZUVsZW1l bnQgY2hlY2sgaGVyZS4gVGhlcmUncyBwcm9iYWJseSBhIGJldHRlciB3YXkgdG8gbWFrZSB0aGlz CiAgICAgICAgICAgICAvLyB3b3JrIGluIHRoZSBsb25nIHRlcm0sIGJ1dCB0aGlzIGlzIHRoZSBz YWZlc3QgZml4IGF0IHRoaXMgdGltZS4KQEAgLTE1NjAsOSArMTU1Niw3IEBAIHZvaWQgU2VsZWN0 aW9uQ29udHJvbGxlcjo6c2V0Rm9jdXNlZE5vZGUKICAgICAgICAgICAgICAgICBtX2ZyYW1lLT5w YWdlKCktPmZvY3VzQ29udHJvbGxlcigpLT5zZXRGb2N1c2VkTm9kZSh0YXJnZXQsIG1fZnJhbWUp OwogICAgICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgICAgIH0KLSAgICAgICAgICAgIHJl bmRlcmVyID0gcmVuZGVyZXItPnBhcmVudCgpOwotICAgICAgICAgICAgaWYgKHJlbmRlcmVyKQot ICAgICAgICAgICAgICAgIHRhcmdldCA9IHJlbmRlcmVyLT5ub2RlKCk7CisgICAgICAgICAgICB0 YXJnZXQgPSB0YXJnZXQtPnBhcmVudE9ySG9zdE5vZGUoKTsgCiAgICAgICAgIH0KICAgICAgICAg bV9mcmFtZS0+ZG9jdW1lbnQoKS0+c2V0Rm9jdXNlZE5vZGUoMCk7CiAgICAgfQo=