50975 2010-12-13 14:21:19 -0800 WebKit2: Leaks a WebView when opening/closing Web Inspector on Windows 2010-12-13 15:03:27 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED InRadar, PlatformOnly P2 Normal --- 1 bweinstein bweinstein aroben sam oldest_to_newest 321411 0 bweinstein 2010-12-13 14:21:19 -0800 We leak a WebView when opening/closing the Web Inspector on Windows. The fix to this is to use RefPtr<WebView> instead of WebView* for our m_inspectorView member variable. 321412 1 bweinstein 2010-12-13 14:21:35 -0800 <rdar://problem/8763501> 321423 2 76442 bweinstein 2010-12-13 14:27:28 -0800 Created attachment 76442 [PATCH] Fix I will wait for https://bugs.webkit.org/show_bug.cgi?id=50898 to be reviewed and landed, then will land this to prevent more conflicts. 321461 3 bweinstein 2010-12-13 15:03:27 -0800 Landed in r73970. 76442 2010-12-13 14:27:28 -0800 2010-12-13 14:28:04 -0800 [PATCH] Fix no_leak_inspector.patch text/plain 2938 bweinstein SW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hhbmdlTG9n CShyZXZpc2lvbiA3Mzk2MikKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMTItMTMgIEJyaWFuIFdlaW5zdGVpbiAgPGJ3ZWluc3RlaW5A YXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFdlYktpdDI6IExlYWtzIGEgV2ViVmlldyB3aGVuIG9wZW5pbmcvY2xvc2luZyBXZWIgSW5z cGVjdG9yIG9uIFdpbmRvd3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTUwOTc1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84NzYzNTAxPgorICAgICAg ICAKKyAgICAgICAgTWFrZSBtX2luc3BlY3RvclZpZXcgYmUgYSBSZWZQdHI8V2ViVmlldz4sIGlu c3RlYWQgb2YgYSBXZWJWaWV3Ki4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJJbnNwZWN0b3JQ cm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkluc3BlY3RvclByb3h5OjpXZWJJbnNwZWN0 b3JQcm94eSk6IElmIHdlIGFyZSBvbiBXaW5kb3dzLCBpbmNsdWRlIFdlYlZpZXcuaC4KKyAgICAg ICAgKiBVSVByb2Nlc3MvV2ViSW5zcGVjdG9yUHJveHkuaDogQ2hhbmdlIHRoZSB0eXBlIG9mIG1f aW5zcGVjdG9yVmlldyB0byBhIFJlZlB0cjxXZWJWaWV3Pi4KKyAgICAgICAgKiBVSVByb2Nlc3Mv d2luL1dlYkluc3BlY3RvclByb3h5V2luLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViSW5zcGVj dG9yUHJveHk6OnBsYXRmb3JtQ3JlYXRlSW5zcGVjdG9yUGFnZSk6IFJlbW92ZSB0aGUgY2FsbCB0 byBsZWFrUmVmIHdoZW4gY3JlYXRpbmcgdGhlIFdlYlZpZXcuCisKIDIwMTAtMTItMTMgIEJyZW50 IEZ1bGdoYW0gIDxiZnVsZ2hhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgYnVp bGQgZml4IGFmdGVyIHI3MzgwNy4KSW5kZXg6IFdlYktpdDIvVUlQcm9jZXNzL1dlYkluc3BlY3Rv clByb3h5LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQyL1VJUHJvY2Vzcy9XZWJJbnNwZWN0b3JQ cm94eS5jcHAJKHJldmlzaW9uIDczOTI2KQorKysgV2ViS2l0Mi9VSVByb2Nlc3MvV2ViSW5zcGVj dG9yUHJveHkuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMyw2ICszMywxMCBAQAogI2luY2x1ZGUg IldlYlByb2Nlc3NQcm94eS5oIgogI2luY2x1ZGUgIldlYlBhZ2VHcm91cC5oIgogCisjaWYgUExB VEZPUk0oV0lOKQorI2luY2x1ZGUgIldlYlZpZXcuaCIKKyNlbmRpZgorCiAjZGVmaW5lIERJU0FC TEVfTk9UX0lNUExFTUVOVEVEX1dBUk5JTkdTIDEKICNpbmNsdWRlICJOb3RJbXBsZW1lbnRlZC5o IgogCkBAIC01NSw3ICs1OSw2IEBAIFdlYkluc3BlY3RvclByb3h5OjpXZWJJbnNwZWN0b3JQcm94 eShXZWIKICAgICAsIG1faXNQcm9maWxpbmdQYWdlKGZhbHNlKQogI2lmIFBMQVRGT1JNKFdJTikK ICAgICAsIG1faW5zcGVjdG9yV2luZG93KDApCi0gICAgLCBtX2luc3BlY3RvclZpZXcoMCkKICNl bmRpZgogewogfQpJbmRleDogV2ViS2l0Mi9VSVByb2Nlc3MvV2ViSW5zcGVjdG9yUHJveHkuaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJLaXQyL1VJUHJvY2Vzcy9XZWJJbnNwZWN0b3JQcm94eS5oCShyZXZp c2lvbiA3MzkzNSkKKysrIFdlYktpdDIvVUlQcm9jZXNzL1dlYkluc3BlY3RvclByb3h5LmgJKHdv cmtpbmcgY29weSkKQEAgLTMyLDYgKzMyLDcgQEAKICNpbmNsdWRlICJDb25uZWN0aW9uLmgiCiAj aW5jbHVkZSA8d3RmL0ZvcndhcmQuaD4KICNpbmNsdWRlIDx3dGYvUGFzc1JlZlB0ci5oPgorI2lu Y2x1ZGUgPHd0Zi9SZWZQdHIuaD4KIAogI2lmIFBMQVRGT1JNKE1BQykKICNpbmNsdWRlIDx3dGYv UmV0YWluUHRyLmg+CkBAIC0xNDcsNyArMTQ4LDcgQEAgcHJpdmF0ZToKICAgICBSZXRhaW5QdHI8 V2ViSW5zcGVjdG9yUHJveHlPYmpDQWRhcHRlcj4gbV9pbnNwZWN0b3JQcm94eU9iakNBZGFwdGVy OwogI2VsaWYgUExBVEZPUk0oV0lOKQogICAgIEhXTkQgbV9pbnNwZWN0b3JXaW5kb3c7Ci0gICAg V2ViVmlldyogbV9pbnNwZWN0b3JWaWV3OworICAgIFJlZlB0cjxXZWJWaWV3PiBtX2luc3BlY3Rv clZpZXc7CiAjZW5kaWYKIH07CiAKSW5kZXg6IFdlYktpdDIvVUlQcm9jZXNzL3dpbi9XZWJJbnNw ZWN0b3JQcm94eVdpbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0Mi9VSVByb2Nlc3Mvd2luL1dl Ykluc3BlY3RvclByb3h5V2luLmNwcAkocmV2aXNpb24gNzM5MzUpCisrKyBXZWJLaXQyL1VJUHJv Y2Vzcy93aW4vV2ViSW5zcGVjdG9yUHJveHlXaW4uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNTEs NyArMTUxLDcgQEAgV2ViUGFnZVByb3h5KiBXZWJJbnNwZWN0b3JQcm94eTo6cGxhdGZvcgogICAg IEFTU0VSVCghbV9pbnNwZWN0b3JXaW5kb3cpOwogCiAgICAgUkVDVCBlbXB0eVJlY3QgPSB7MH07 Ci0gICAgbV9pbnNwZWN0b3JWaWV3ID0gV2ViVmlldzo6Y3JlYXRlKGVtcHR5UmVjdCwgbV9wYWdl LT5wYWdlTmFtZXNwYWNlKCksIGluc3BlY3RvclBhZ2VHcm91cCgpLCAwKS5sZWFrUmVmKCk7Cisg ICAgbV9pbnNwZWN0b3JWaWV3ID0gV2ViVmlldzo6Y3JlYXRlKGVtcHR5UmVjdCwgbV9wYWdlLT5w YWdlTmFtZXNwYWNlKCksIGluc3BlY3RvclBhZ2VHcm91cCgpLCAwKTsKICAgICAKICAgICByZXR1 cm4gbV9pbnNwZWN0b3JWaWV3LT5wYWdlKCk7CiB9Cg==