50974 2010-12-13 14:13:37 -0800 getComputedStyle() returns wrong values for zoomed elements when display is none 2010-12-14 11:36:43 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 bdakin bdakin bdakin oldest_to_newest 321403 0 bdakin 2010-12-13 14:13:37 -0800 This is a follow-on from https://bugs.webkit.org/show_bug.cgi?id=32230 getComputedStyle() returns different values for different zoom levels. If an element (or one of the element's ancestors) has display:none, this bug still occurs - the value returned by getComputedStyle() is multiplied by the zoom factor. A brief summary of the issue (see the original issue for more detail): The values returned by getComputedStyle() are scaled according to the CSS zoom property, which is different from all other DOM APIs (e.g. offsetHeight/Width) and other browsers (Gecko returns unscaled values). The return values should be unscaled. <rdar://problem/8522731> Patch forthcoming! 321406 1 76437 bdakin 2010-12-13 14:14:36 -0800 Created attachment 76437 Test case 321413 2 76438 bdakin 2010-12-13 14:22:04 -0800 Created attachment 76438 Patch 321630 3 76438 levin 2010-12-13 19:49:40 -0800 Comment on attachment 76438 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=76438&action=review > WebCore/css/CSSComputedStyleDeclaration.cpp:1550 > + I don't know this area but I do see a pattern here. Why not create a function like this: PassRefPtr<CSSValue> get{FillInNameHere}(const Length& length, const RenderStyle* style) { if (length.isFixed()) return zoomAdjustedPixelValue(width.value(), style); return CSSPrimitiveValue::create(width); } and use this in all of these places ? 321684 4 76438 darin 2010-12-13 22:26:28 -0800 Comment on attachment 76438 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=76438&action=review r=me, but please consider factoring out the repetitive code into a function >> WebCore/css/CSSComputedStyleDeclaration.cpp:1550 >> + > > I don't know this area but I do see a pattern here. > > Why not create a function like this: > > PassRefPtr<CSSValue> get{FillInNameHere}(const Length& length, const RenderStyle* style) > { > if (length.isFixed()) > return zoomAdjustedPixelValue(width.value(), style); > return CSSPrimitiveValue::create(width); > } > > and use this in all of these places > ? I was going to make the same suggestion. No need to use the word “get”, though! 322076 5 bdakin 2010-12-14 11:36:43 -0800 Thanks all Fixed with r74045. 76437 2010-12-13 14:14:36 -0800 2010-12-13 14:14:36 -0800 Test case zoom-on-display-none.html text/html 1446 bdakin PGh0bWw+CjxoZWFkPgo8c2NyaXB0PgogICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxl cikKICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7Cjwvc2NyaXB0Pgo8 c3R5bGU+CiAgLnRlc3RfZGl2IHsKICAgIHpvb206IDI7CiAgICB3aWR0aDogMzAwcHg7CiAgfQog IAogICN6b29tZWRfYW5kX2Rpc3BsYXllZCB7CiAgICBiYWNrZ3JvdW5kOiAjY2NjOwogIH0KICAj em9vbWVkX2FuZF9oaWRkZW4gewogICAgZGlzcGxheTogbm9uZTsKICAgIGJhY2tncm91bmQ6IG9y YW5nZTsKICB9Cjwvc3R5bGU+CjwvaGVhZD4KPGJvZHk+CgogIDxkaXYgaWQ9InJlc3VsdCI+RkFJ TC48L2Rpdj4KICA8YnIvPgoKICA8ZGl2IGlkPSJ6b29tZWRfYW5kX2Rpc3BsYXllZCIgY2xhc3M9 InRlc3RfZGl2Ij4KICAgIFRoaXMgZGl2IGhhcyBhIHpvb20gdmFsdWUgb2YgIjIuIiBJdCBoYXMg YSB3aWR0aCBvZiAzMDBweC4KICA8L2Rpdj4KICA8ZGl2IGlkPSJ6b29tZWRfYW5kX2hpZGRlbiIg Y2xhc3M9InRlc3RfZGl2Ij4KICAgIFRoaXMgZGl2IGlzIGhhcyBhIHpvb20gdmFsdWUgb2YgIjIi IGFuZCBpcyBoaWRkZW4uIEl0IGhhcyBhIHdpZHRoIG9mIDMwMHB4LgogIDwvZGl2PgogIAogIDxz Y3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0IiBjaGFyc2V0PSJ1dGYtOCI+CiAgICB2YXIgem9v bWVkQW5kRGlzcGxheWVkID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInpvb21lZF9hbmRfZGlz cGxheWVkIik7CiAgICB2YXIgem9vbWVkQW5kSGlkZGVuID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5 SWQoInpvb21lZF9hbmRfaGlkZGVuIik7CiAgICB2YXIgcmVuZGVyZWRXaWR0aCA9IHpvb21lZEFu ZERpc3BsYXllZC5zY3JvbGxXaWR0aDsKICAgIHZhciBjb21wdXRlZFdpZHRoRGlzcGxheWVkID0g cGFyc2VGbG9hdChkb2N1bWVudC5kZWZhdWx0Vmlldy5nZXRDb21wdXRlZFN0eWxlKHpvb21lZEFu ZERpc3BsYXllZCkud2lkdGgpOwogICAgdmFyIGNvbXB1dGVkV2lkdGhIaWRkZW4gPSBwYXJzZUZs b2F0KGRvY3VtZW50LmRlZmF1bHRWaWV3LmdldENvbXB1dGVkU3R5bGUoem9vbWVkQW5kSGlkZGVu KS53aWR0aCk7CgogICAgdmFyIHJlc3VsdCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJyZXN1 bHQiKTsgICAgCiAgICBpZiAoY29tcHV0ZWRXaWR0aEhpZGRlbiA9PSBjb21wdXRlZFdpZHRoRGlz cGxheWVkICYmIGNvbXB1dGVkV2lkdGhEaXNwbGF5ZWQgPT0gcmVuZGVyZWRXaWR0aCkKICAgICAg ICByZXN1bHQuaW5uZXJIVE1MID0gIlBBU1MhIE5laXRoZXIgdGhlIGNvbXB1dGVkIHdpZHRoIG9m IHRoZSBkaXNwbGF5ZWQgZGl2IG5vciB0aGUgY29tcHV0ZWQgd2lkdGggb2YgdGhlIGRpc3BsYXk6 bm9uZSBkaXYgaGFzIGJlZW4gYWZmZWN0ZWQgYnkgdGhlIHpvb20gZmFjdG9yLiI7CiAgPC9zY3Jp cHQ+Cgo8L2JvZHk+CjwvaHRtbD4K 76438 2010-12-13 14:22:04 -0800 2010-12-13 22:26:28 -0800 Patch for-review.txt text/plain 8146 bdakin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3Mzk2MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMTItMTMgIEJldGggRGFraW4gIDxiZGFraW5AYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBm b3IgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUwOTc0IAorICAgICAg ICBnZXRDb21wdXRlZFN0eWxlKCkgcmV0dXJucyB3cm9uZyB2YWx1ZXMgZm9yIHpvb21lZCBlbGVt ZW50cyB3aGVuIAorICAgICAgICBkaXNwbGF5IGlzIG5vbmUKKyAgICAgICAgLWFuZCBjb3JyZXNw b25kaW5nLQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vODUyMjczMT4KKworICAgICAgICBJZiB0 aGVyZSBpcyBubyByZW5kZXJlciBidXQgdGhlIFJlbmRlclN0eWxlJ3MgdmFsdWUgaXMgYSBmaXhl ZCAKKyAgICAgICAgbGVuZ3RoLCBzZW5kIGl0IHRocm91Z2ggem9vbUFkanVzdGVkUGl4ZWxWYWx1 ZSgpLiBUaGVyZSdzIG5vdCBtdWNoIAorICAgICAgICB3ZSBjYW4gZG8gZm9yIG90aGVyIGxlbmd0 aCB0eXBlcyB3aXRob3V0IGEgcmVuZGVyZXIuCisgICAgICAgICogY3NzL0NTU0NvbXB1dGVkU3R5 bGVEZWNsYXJhdGlvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NDb21wdXRlZFN0eWxlRGVj bGFyYXRpb246OmdldFByb3BlcnR5Q1NTVmFsdWUpOgorCiAyMDEwLTEyLTEzICBFcmljIENhcmxz b24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFudHRp IEtvaXZpc3RvLgpJbmRleDogV2ViQ29yZS9jc3MvQ1NTQ29tcHV0ZWRTdHlsZURlY2xhcmF0aW9u LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2Nzcy9DU1NDb21wdXRlZFN0eWxlRGVjbGFyYXRp b24uY3BwCShyZXZpc2lvbiA3MzkyOCkKKysrIFdlYkNvcmUvY3NzL0NTU0NvbXB1dGVkU3R5bGVE ZWNsYXJhdGlvbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEwNTksMTAgKzEwNTksMTQgQEAgUGFz c1JlZlB0cjxDU1NWYWx1ZT4gQ1NTQ29tcHV0ZWRTdHlsZURlYwogICAgICAgICAgICAgfQogICAg ICAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CiAgICAgICAgICAgICByZXR1cm4gQ1NTUHJp bWl0aXZlVmFsdWU6OmNyZWF0ZUlkZW50aWZpZXIoQ1NTVmFsdWVOb3JtYWwpOwotICAgICAgICBj YXNlIENTU1Byb3BlcnR5SGVpZ2h0OgorICAgICAgICBjYXNlIENTU1Byb3BlcnR5SGVpZ2h0OiB7 CiAgICAgICAgICAgICBpZiAocmVuZGVyZXIpCiAgICAgICAgICAgICAgICAgcmV0dXJuIHpvb21B ZGp1c3RlZFBpeGVsVmFsdWUoc2l6aW5nQm94KHJlbmRlcmVyKS5oZWlnaHQoKSwgc3R5bGUuZ2V0 KCkpOwotICAgICAgICAgICAgcmV0dXJuIENTU1ByaW1pdGl2ZVZhbHVlOjpjcmVhdGUoc3R5bGUt PmhlaWdodCgpKTsKKyAgICAgICAgICAgIGNvbnN0IExlbmd0aCYgaGVpZ2h0ID0gc3R5bGUtPmhl aWdodCgpOworICAgICAgICAgICAgaWYgKGhlaWdodC5pc0ZpeGVkKCkpCisgICAgICAgICAgICAg ICAgcmV0dXJuIHpvb21BZGp1c3RlZFBpeGVsVmFsdWUoaGVpZ2h0LnZhbHVlKCksIHN0eWxlLmdl dCgpKTsKKyAgICAgICAgICAgIHJldHVybiBDU1NQcmltaXRpdmVWYWx1ZTo6Y3JlYXRlKGhlaWdo dCk7CisgICAgICAgIH0KICAgICAgICAgY2FzZSBDU1NQcm9wZXJ0eVdlYmtpdEhpZ2hsaWdodDoK ICAgICAgICAgICAgIGlmIChzdHlsZS0+aGlnaGxpZ2h0KCkgPT0gbnVsbEF0b20pCiAgICAgICAg ICAgICAgICAgcmV0dXJuIENTU1ByaW1pdGl2ZVZhbHVlOjpjcmVhdGVJZGVudGlmaWVyKENTU1Zh bHVlTm9uZSk7CkBAIC0xMjk5LDEwICsxMzAzLDE0IEBAIFBhc3NSZWZQdHI8Q1NTVmFsdWU+IENT U0NvbXB1dGVkU3R5bGVEZWMKICAgICAgICAgICAgIHJldHVybiBDU1NQcmltaXRpdmVWYWx1ZTo6 Y3JlYXRlKHN0eWxlLT53aGl0ZVNwYWNlKCkpOwogICAgICAgICBjYXNlIENTU1Byb3BlcnR5V2lk b3dzOgogICAgICAgICAgICAgcmV0dXJuIENTU1ByaW1pdGl2ZVZhbHVlOjpjcmVhdGUoc3R5bGUt PndpZG93cygpLCBDU1NQcmltaXRpdmVWYWx1ZTo6Q1NTX05VTUJFUik7Ci0gICAgICAgIGNhc2Ug Q1NTUHJvcGVydHlXaWR0aDoKKyAgICAgICAgY2FzZSBDU1NQcm9wZXJ0eVdpZHRoOiB7CiAgICAg ICAgICAgICBpZiAocmVuZGVyZXIpCiAgICAgICAgICAgICAgICAgcmV0dXJuIHpvb21BZGp1c3Rl ZFBpeGVsVmFsdWUoc2l6aW5nQm94KHJlbmRlcmVyKS53aWR0aCgpLCBzdHlsZS5nZXQoKSk7Ci0g ICAgICAgICAgICByZXR1cm4gQ1NTUHJpbWl0aXZlVmFsdWU6OmNyZWF0ZShzdHlsZS0+d2lkdGgo KSk7CisgICAgICAgICAgICBjb25zdCBMZW5ndGgmIHdpZHRoID0gc3R5bGUtPndpZHRoKCk7Cisg ICAgICAgICAgICBpZiAod2lkdGguaXNGaXhlZCgpKQorICAgICAgICAgICAgICAgIHJldHVybiB6 b29tQWRqdXN0ZWRQaXhlbFZhbHVlKHdpZHRoLnZhbHVlKCksIHN0eWxlLmdldCgpKTsKKyAgICAg ICAgICAgIHJldHVybiBDU1NQcmltaXRpdmVWYWx1ZTo6Y3JlYXRlKHdpZHRoKTsKKyAgICAgICAg fQogICAgICAgICBjYXNlIENTU1Byb3BlcnR5V29yZEJyZWFrOgogICAgICAgICAgICAgcmV0dXJu IENTU1ByaW1pdGl2ZVZhbHVlOjpjcmVhdGUoc3R5bGUtPndvcmRCcmVhaygpKTsKICAgICAgICAg Y2FzZSBDU1NQcm9wZXJ0eVdvcmRTcGFjaW5nOgpAQCAtMTQ3NCw4ICsxNDgyLDE4IEBAIFBhc3NS ZWZQdHI8Q1NTVmFsdWU+IENTU0NvbXB1dGVkU3R5bGVEZWMKICAgICAgICAgICAgICAgICBsaXN0 LT5hcHBlbmQoem9vbUFkanVzdGVkUGl4ZWxWYWx1ZShzdHlsZS0+cGVyc3BlY3RpdmVPcmlnaW5Z KCkuY2FsY01pblZhbHVlKGJveC5oZWlnaHQoKSksIHN0eWxlLmdldCgpKSk7CiAgICAgICAgICAg ICB9CiAgICAgICAgICAgICBlbHNlIHsKLSAgICAgICAgICAgICAgICBsaXN0LT5hcHBlbmQoQ1NT UHJpbWl0aXZlVmFsdWU6OmNyZWF0ZShzdHlsZS0+cGVyc3BlY3RpdmVPcmlnaW5YKCkpKTsKLSAg ICAgICAgICAgICAgICBsaXN0LT5hcHBlbmQoQ1NTUHJpbWl0aXZlVmFsdWU6OmNyZWF0ZShzdHls ZS0+cGVyc3BlY3RpdmVPcmlnaW5ZKCkpKTsKKyAgICAgICAgICAgICAgICBjb25zdCBMZW5ndGgm IHggPSBzdHlsZS0+cGVyc3BlY3RpdmVPcmlnaW5YKCk7CisgICAgICAgICAgICAgICAgaWYgKHgu aXNGaXhlZCgpKQorICAgICAgICAgICAgICAgICAgICBsaXN0LT5hcHBlbmQoem9vbUFkanVzdGVk UGl4ZWxWYWx1ZSh4LnZhbHVlKCksIHN0eWxlLmdldCgpKSk7CisgICAgICAgICAgICAgICAgZWxz ZQorICAgICAgICAgICAgICAgICAgICBsaXN0LT5hcHBlbmQoQ1NTUHJpbWl0aXZlVmFsdWU6OmNy ZWF0ZSh4KSk7CisgICAgICAgICAgICAgICAgCisgICAgICAgICAgICAgICAgY29uc3QgTGVuZ3Ro JiB5ID0gc3R5bGUtPnBlcnNwZWN0aXZlT3JpZ2luWSgpOworICAgICAgICAgICAgICAgIGlmICh5 LmlzRml4ZWQoKSkKKyAgICAgICAgICAgICAgICAgICAgbGlzdC0+YXBwZW5kKHpvb21BZGp1c3Rl ZFBpeGVsVmFsdWUoeS52YWx1ZSgpLCBzdHlsZS5nZXQoKSkpOworICAgICAgICAgICAgICAgIGVs c2UKKyAgICAgICAgICAgICAgICAgICAgbGlzdC0+YXBwZW5kKENTU1ByaW1pdGl2ZVZhbHVlOjpj cmVhdGUoeSkpOworICAgICAgICAgICAgICAgIAogICAgICAgICAgICAgfQogICAgICAgICAgICAg cmV0dXJuIGxpc3QucmVsZWFzZSgpOwogICAgICAgICB9CkBAIC0xNTE4LDggKzE1MzYsMTggQEAg UGFzc1JlZlB0cjxDU1NWYWx1ZT4gQ1NTQ29tcHV0ZWRTdHlsZURlYwogICAgICAgICAgICAgICAg IGlmIChzdHlsZS0+dHJhbnNmb3JtT3JpZ2luWigpICE9IDApCiAgICAgICAgICAgICAgICAgICAg IGxpc3QtPmFwcGVuZCh6b29tQWRqdXN0ZWRQaXhlbFZhbHVlKHN0eWxlLT50cmFuc2Zvcm1Pcmln aW5aKCksIHN0eWxlLmdldCgpKSk7CiAgICAgICAgICAgICB9IGVsc2UgewotICAgICAgICAgICAg ICAgIGxpc3QtPmFwcGVuZChDU1NQcmltaXRpdmVWYWx1ZTo6Y3JlYXRlKHN0eWxlLT50cmFuc2Zv cm1PcmlnaW5YKCkpKTsKLSAgICAgICAgICAgICAgICBsaXN0LT5hcHBlbmQoQ1NTUHJpbWl0aXZl VmFsdWU6OmNyZWF0ZShzdHlsZS0+dHJhbnNmb3JtT3JpZ2luWSgpKSk7CisgICAgICAgICAgICAg ICAgY29uc3QgTGVuZ3RoJiB4ID0gc3R5bGUtPnRyYW5zZm9ybU9yaWdpblgoKTsKKyAgICAgICAg ICAgICAgICBpZiAoeC5pc0ZpeGVkKCkpCisgICAgICAgICAgICAgICAgICAgIGxpc3QtPmFwcGVu ZCh6b29tQWRqdXN0ZWRQaXhlbFZhbHVlKHgudmFsdWUoKSwgc3R5bGUuZ2V0KCkpKTsKKyAgICAg ICAgICAgICAgICBlbHNlCisgICAgICAgICAgICAgICAgICAgIGxpc3QtPmFwcGVuZChDU1NQcmlt aXRpdmVWYWx1ZTo6Y3JlYXRlKHgpKTsKKyAgICAgICAgICAgICAgICAKKyAgICAgICAgICAgICAg ICBjb25zdCBMZW5ndGgmIHkgPSBzdHlsZS0+dHJhbnNmb3JtT3JpZ2luWSgpOworICAgICAgICAg ICAgICAgIGlmICh5LmlzRml4ZWQoKSkKKyAgICAgICAgICAgICAgICAgICAgbGlzdC0+YXBwZW5k KHpvb21BZGp1c3RlZFBpeGVsVmFsdWUoeS52YWx1ZSgpLCBzdHlsZS5nZXQoKSkpOworICAgICAg ICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICAgICAgbGlzdC0+YXBwZW5kKENTU1ByaW1p dGl2ZVZhbHVlOjpjcmVhdGUoeSkpOworCiAgICAgICAgICAgICAgICAgaWYgKHN0eWxlLT50cmFu c2Zvcm1PcmlnaW5aKCkgIT0gMCkKICAgICAgICAgICAgICAgICAgICAgbGlzdC0+YXBwZW5kKHpv b21BZGp1c3RlZFBpeGVsVmFsdWUoc3R5bGUtPnRyYW5zZm9ybU9yaWdpblooKSwgc3R5bGUuZ2V0 KCkpKTsKICAgICAgICAgICAgIH0KSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDczOTYxKQorKysgTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMTIt MTMgIEJldGggRGFraW4gIDxiZGFraW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5ldyB0ZXN0IGZvciBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTA5NzQgCisgICAgICAgIGdldENvbXB1dGVkU3R5bGUo KSByZXR1cm5zIHdyb25nIHZhbHVlcyBmb3Igem9vbWVkIGVsZW1lbnRzIHdoZW4gCisgICAgICAg IGRpc3BsYXkgaXMgbm9uZQorICAgICAgICAtYW5kIGNvcnJlc3BvbmRpbmctCisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS84NTIyNzMxPgorCisgICAgICAgICogZmFzdC9jc3MvZ2V0Q29tcHV0ZWRT dHlsZS96b29tLW9uLWRpc3BsYXktbm9uZS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAq IGZhc3QvY3NzL2dldENvbXB1dGVkU3R5bGUvem9vbS1vbi1kaXNwbGF5LW5vbmUuaHRtbDogQWRk ZWQuCisKIDIwMTAtMTItMTMgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4K IAogICAgICAgICBSZXZpZXdlZCBieSBCZXRoIERha2luLgpJbmRleDogTGF5b3V0VGVzdHMvZmFz dC9jc3MvZ2V0Q29tcHV0ZWRTdHlsZS96b29tLW9uLWRpc3BsYXktbm9uZS1leHBlY3RlZC50eHQK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9jc3MvZ2V0Q29tcHV0ZWRTdHlsZS96b29t LW9uLWRpc3BsYXktbm9uZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0 cy9mYXN0L2Nzcy9nZXRDb21wdXRlZFN0eWxlL3pvb20tb24tZGlzcGxheS1ub25lLWV4cGVjdGVk LnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwzIEBACitQQVNTISBOZWl0aGVyIHRoZSBjb21w dXRlZCB3aWR0aCBvZiB0aGUgZGlzcGxheWVkIGRpdiBub3IgdGhlIGNvbXB1dGVkIHdpZHRoIG9m IHRoZSBkaXNwbGF5Om5vbmUgZGl2IGhhcyBiZWVuIGFmZmVjdGVkIGJ5IHRoZSB6b29tIGZhY3Rv ci4KKworVGhpcyBkaXYgaGFzIGEgem9vbSB2YWx1ZSBvZiAiMi4iIEl0IGhhcyBhIHdpZHRoIG9m IDMwMHB4LgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9jc3MvZ2V0Q29tcHV0ZWRTdHlsZS96b29t LW9uLWRpc3BsYXktbm9uZS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvY3Nz L2dldENvbXB1dGVkU3R5bGUvem9vbS1vbi1kaXNwbGF5LW5vbmUuaHRtbAkocmV2aXNpb24gMCkK KysrIExheW91dFRlc3RzL2Zhc3QvY3NzL2dldENvbXB1dGVkU3R5bGUvem9vbS1vbi1kaXNwbGF5 LW5vbmUuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw0NyBAQAorPGh0bWw+Cis8aGVhZD4K KzxzY3JpcHQ+CisgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICAgICAg bGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworPC9zY3JpcHQ+Cis8c3R5bGU+Cisg IC50ZXN0X2RpdiB7CisgICAgem9vbTogMjsKKyAgICB3aWR0aDogMzAwcHg7CisgIH0KKyAgCisg ICN6b29tZWRfYW5kX2Rpc3BsYXllZCB7CisgICAgYmFja2dyb3VuZDogI2NjYzsKKyAgfQorICAj em9vbWVkX2FuZF9oaWRkZW4geworICAgIGRpc3BsYXk6IG5vbmU7CisgICAgYmFja2dyb3VuZDog b3JhbmdlOworICB9Cis8L3N0eWxlPgorPC9oZWFkPgorPGJvZHk+CisKKyAgPGRpdiBpZD0icmVz dWx0Ij5GQUlMLjwvZGl2PgorICA8YnIvPgorCisgIDxkaXYgaWQ9Inpvb21lZF9hbmRfZGlzcGxh eWVkIiBjbGFzcz0idGVzdF9kaXYiPgorICAgIFRoaXMgZGl2IGhhcyBhIHpvb20gdmFsdWUgb2Yg IjIuIiBJdCBoYXMgYSB3aWR0aCBvZiAzMDBweC4KKyAgPC9kaXY+CisgIDxkaXYgaWQ9Inpvb21l ZF9hbmRfaGlkZGVuIiBjbGFzcz0idGVzdF9kaXYiPgorICAgIFRoaXMgZGl2IGlzIGhhcyBhIHpv b20gdmFsdWUgb2YgIjIiIGFuZCBpcyBoaWRkZW4uIEl0IGhhcyBhIHdpZHRoIG9mIDMwMHB4Lgor ICA8L2Rpdj4KKyAgCisgIDxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0IiBjaGFyc2V0PSJ1 dGYtOCI+CisgICAgdmFyIHpvb21lZEFuZERpc3BsYXllZCA9IGRvY3VtZW50LmdldEVsZW1lbnRC eUlkKCJ6b29tZWRfYW5kX2Rpc3BsYXllZCIpOworICAgIHZhciB6b29tZWRBbmRIaWRkZW4gPSBk b2N1bWVudC5nZXRFbGVtZW50QnlJZCgiem9vbWVkX2FuZF9oaWRkZW4iKTsKKyAgICB2YXIgcmVu ZGVyZWRXaWR0aCA9IHpvb21lZEFuZERpc3BsYXllZC5zY3JvbGxXaWR0aDsKKyAgICB2YXIgY29t cHV0ZWRXaWR0aERpc3BsYXllZCA9IHBhcnNlRmxvYXQoZG9jdW1lbnQuZGVmYXVsdFZpZXcuZ2V0 Q29tcHV0ZWRTdHlsZSh6b29tZWRBbmREaXNwbGF5ZWQpLndpZHRoKTsKKyAgICB2YXIgY29tcHV0 ZWRXaWR0aEhpZGRlbiA9IHBhcnNlRmxvYXQoZG9jdW1lbnQuZGVmYXVsdFZpZXcuZ2V0Q29tcHV0 ZWRTdHlsZSh6b29tZWRBbmRIaWRkZW4pLndpZHRoKTsKKworICAgIHZhciByZXN1bHQgPSBkb2N1 bWVudC5nZXRFbGVtZW50QnlJZCgicmVzdWx0Iik7ICAgIAorICAgIGlmIChjb21wdXRlZFdpZHRo SGlkZGVuID09IGNvbXB1dGVkV2lkdGhEaXNwbGF5ZWQgJiYgY29tcHV0ZWRXaWR0aERpc3BsYXll ZCA9PSByZW5kZXJlZFdpZHRoKQorICAgICAgICByZXN1bHQuaW5uZXJIVE1MID0gIlBBU1MhIE5l aXRoZXIgdGhlIGNvbXB1dGVkIHdpZHRoIG9mIHRoZSBkaXNwbGF5ZWQgZGl2IG5vciB0aGUgY29t cHV0ZWQgd2lkdGggb2YgdGhlIGRpc3BsYXk6bm9uZSBkaXYgaGFzIGJlZW4gYWZmZWN0ZWQgYnkg dGhlIHpvb20gZmFjdG9yLiI7CisgIDwvc2NyaXB0PgorCis8L2JvZHk+Cis8L2h0bWw+Cg==