50965 2010-12-13 13:35:48 -0800 [v8] Next round of CSS GC story: proper grouping of CSSStyleDeclarations 2010-12-15 02:58:17 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 antonm antonm commit-queue levin oldest_to_newest 321368 0 antonm 2010-12-13 13:35:48 -0800 [v8] Next round of CSS GC story: proper grouping of CSSStyleDeclarations 321428 1 76443 antonm 2010-12-13 14:31:48 -0800 Created attachment 76443 Patch 321629 2 levin 2010-12-13 19:40:44 -0800 Looks fine, but shouldn't some items be removed from test expectations (for chromium) with this change? 321939 3 antonm 2010-12-14 06:32:29 -0800 Call me paranoid, but I'd prefer to land the fix first and then check on canaries it indeed fixes the trouble for all the platforms. Then I am doing a tiny expectations cleanup. But if you think this commits duplication is stupid, just say so and I'll update the patch, of course. And thanks a lot for review! (In reply to comment #2) > Looks fine, but shouldn't some items be removed from test expectations (for chromium) with this change? 322557 4 76443 commit-queue 2010-12-15 02:58:12 -0800 Comment on attachment 76443 Patch Clearing flags on attachment: 76443 Committed r74106: <http://trac.webkit.org/changeset/74106> 322558 5 commit-queue 2010-12-15 02:58:17 -0800 All reviewed patches have been landed. Closing bug. 76443 2010-12-13 14:31:48 -0800 2010-12-15 02:58:12 -0800 Patch bug-50965-20101214013146.patch text/plain 4730 antonm SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3Mzk1OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMTItMTMgIEFudG9uIE11aGluICA8YW50b25tQGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBb djhdIE5leHQgcm91bmQgb2YgQ1NTIEdDIHN0b3J5OiBwcm9wZXIgZ3JvdXBpbmcgb2YgQ1NTU3R5 bGVEZWNsYXJhdGlvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTUwOTY1CisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOEdDQ29udHJvbGxlci5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpET01PYmplY3RHcm91cGVyVmlzaXRvcjo6dmlzaXRET01XcmFw cGVyKToKKyAgICAgICAgKFdlYkNvcmU6OkRPTU9iamVjdEdyb3VwZXJWaXNpdG9yOjphZGRBbGxJ dGVtcyk6CisKIDIwMTAtMTItMTMgIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5j b20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW50dGkgS29pdmlzdG8uCkluZGV4OiBXZWJDb3Jl L2JpbmRpbmdzL3Y4L1Y4R0NDb250cm9sbGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2Jp bmRpbmdzL3Y4L1Y4R0NDb250cm9sbGVyLmNwcAkocmV2aXNpb24gNzM5MjYpCisrKyBXZWJDb3Jl L2JpbmRpbmdzL3Y4L1Y4R0NDb250cm9sbGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDYsNiAr NDYsNyBAQAogI2luY2x1ZGUgIlY4Q1NTSW1wb3J0UnVsZS5oIgogI2luY2x1ZGUgIlY4Q1NTTWVk aWFSdWxlLmgiCiAjaW5jbHVkZSAiVjhDU1NSdWxlTGlzdC5oIgorI2luY2x1ZGUgIlY4Q1NTU3R5 bGVEZWNsYXJhdGlvbi5oIgogI2luY2x1ZGUgIlY4Q1NTU3R5bGVSdWxlLmgiCiAjaW5jbHVkZSAi VjhDU1NTdHlsZVNoZWV0LmgiCiAjaW5jbHVkZSAiVjhET01NYXAuaCIKQEAgLTM3Niw2ICszNzcs NyBAQCBwdWJsaWM6CiAgICAgICAgIC8vIGFkZGluZyBhIHZpcnR1YWwgbWV0aG9kIHRvIFdyYXBw ZXJUeXBlSW5mbyB3aGljaCB3b3VsZCBrbm93IGhvdyB0byBncm91cCBvYmplY3RzLgogICAgICAg ICAvLyBGSVhNRTogY2hlY2sgaWYgdGhlcmUgYXJlIG90aGVyIFN0eWxlQmFzZSB3cmFwcGVycyB3 ZSBzaG91bGQgY2FyZSBvZi4KICAgICAgICAgaWYgKFY4Q1NTU3R5bGVTaGVldDo6aW5mby5lcXVh bHModHlwZUluZm8pCisgICAgICAgICAgICB8fCBWOENTU1N0eWxlRGVjbGFyYXRpb246OmluZm8u ZXF1YWxzKHR5cGVJbmZvKQogICAgICAgICAgICAgfHwgVjhDU1NDaGFyc2V0UnVsZTo6aW5mby5l cXVhbHModHlwZUluZm8pCiAgICAgICAgICAgICB8fCBWOENTU0ZvbnRGYWNlUnVsZTo6aW5mby5l cXVhbHModHlwZUluZm8pCiAgICAgICAgICAgICB8fCBWOENTU1N0eWxlUnVsZTo6aW5mby5lcXVh bHModHlwZUluZm8pCkBAIC0zOTYsMzEgKzM5OCw0MCBAQCBwdWJsaWM6CiAgICAgICAgICAgICAv LyBHcm91cCBpZCBpcyBhbiBhZGRyZXNzIG9mIHRoZSByb290LgogICAgICAgICAgICAgdWludHB0 cl90IGdyb3VwSWQgPSByZWludGVycHJldF9jYXN0PHVpbnRwdHJfdD4ocm9vdCk7CiAgICAgICAg ICAgICBtX2dyb3VwZXIuYXBwZW5kKEdyb3VwZXJJdGVtKGdyb3VwSWQsIHdyYXBwZXIpKTsKLSAg ICAgICAgfSBlbHNlIGlmIChWOFN0eWxlU2hlZXRMaXN0OjppbmZvLmVxdWFscyh0eXBlSW5mbykp IHsKLSAgICAgICAgICAgIFN0eWxlU2hlZXRMaXN0KiBzdHlsZVNoZWV0TGlzdCA9IHN0YXRpY19j YXN0PFN0eWxlU2hlZXRMaXN0Kj4ob2JqZWN0KTsKLSAgICAgICAgICAgIHVpbnRwdHJfdCBncm91 cElkID0gcmVpbnRlcnByZXRfY2FzdDx1aW50cHRyX3Q+KHN0eWxlU2hlZXRMaXN0KTsKLSAgICAg ICAgICAgIG1fZ3JvdXBlci5hcHBlbmQoR3JvdXBlckl0ZW0oZ3JvdXBJZCwgd3JhcHBlcikpOwot ICAgICAgICAgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IHN0eWxlU2hlZXRMaXN0LT5sZW5n dGgoKTsgaSsrKSB7Ci0gICAgICAgICAgICAgICAgU3R5bGVTaGVldCogc3R5bGVTaGVldCA9IHN0 eWxlU2hlZXRMaXN0LT5pdGVtKGkpOwotICAgICAgICAgICAgICAgIHdyYXBwZXIgPSBzdG9yZS0+ ZG9tT2JqZWN0TWFwKCkuZ2V0KHN0eWxlU2hlZXQpOwotICAgICAgICAgICAgICAgIGlmICghd3Jh cHBlci5Jc0VtcHR5KCkpCi0gICAgICAgICAgICAgICAgICAgIG1fZ3JvdXBlci5hcHBlbmQoR3Jv dXBlckl0ZW0oZ3JvdXBJZCwgd3JhcHBlcikpOworCisgICAgICAgICAgICBpZiAoVjhDU1NTdHls ZURlY2xhcmF0aW9uOjppbmZvLmVxdWFscyh0eXBlSW5mbykpIHsKKyAgICAgICAgICAgICAgICBD U1NTdHlsZURlY2xhcmF0aW9uKiBjc3NTdHlsZURlY2xhcmF0aW9uID0gc3RhdGljX2Nhc3Q8Q1NT U3R5bGVEZWNsYXJhdGlvbio+KHN0eWxlQmFzZSk7CisgICAgICAgICAgICAgICAgaWYgKGNzc1N0 eWxlRGVjbGFyYXRpb24tPmlzTXV0YWJsZVN0eWxlRGVjbGFyYXRpb24oKSkgeworICAgICAgICAg ICAgICAgICAgICBDU1NNdXRhYmxlU3R5bGVEZWNsYXJhdGlvbiogY3NzTXV0YWJsZVN0eWxlRGVj bGFyYXRpb24gPSBzdGF0aWNfY2FzdDxDU1NNdXRhYmxlU3R5bGVEZWNsYXJhdGlvbio+KGNzc1N0 eWxlRGVjbGFyYXRpb24pOworICAgICAgICAgICAgICAgICAgICBDU1NNdXRhYmxlU3R5bGVEZWNs YXJhdGlvbjo6Y29uc3RfaXRlcmF0b3IgZW5kID0gY3NzTXV0YWJsZVN0eWxlRGVjbGFyYXRpb24t PmVuZCgpOworICAgICAgICAgICAgICAgICAgICBmb3IgKENTU011dGFibGVTdHlsZURlY2xhcmF0 aW9uOjpjb25zdF9pdGVyYXRvciBpdCA9IGNzc011dGFibGVTdHlsZURlY2xhcmF0aW9uLT5iZWdp bigpOyBpdCAhPSBlbmQ7ICsraXQpIHsKKyAgICAgICAgICAgICAgICAgICAgICAgIHdyYXBwZXIg PSBzdG9yZS0+ZG9tT2JqZWN0TWFwKCkuZ2V0KGl0LT52YWx1ZSgpKTsKKyAgICAgICAgICAgICAg ICAgICAgICAgIGlmICghd3JhcHBlci5Jc0VtcHR5KCkpCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgbV9ncm91cGVyLmFwcGVuZChHcm91cGVySXRlbShncm91cElkLCB3cmFwcGVyKSk7Cisg ICAgICAgICAgICAgICAgICAgIH0KKyAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICB9Cisg ICAgICAgIH0gZWxzZSBpZiAoVjhTdHlsZVNoZWV0TGlzdDo6aW5mby5lcXVhbHModHlwZUluZm8p KSB7CisgICAgICAgICAgICBhZGRBbGxJdGVtcyhzdG9yZSwgc3RhdGljX2Nhc3Q8U3R5bGVTaGVl dExpc3QqPihvYmplY3QpLCB3cmFwcGVyKTsKICAgICAgICAgfSBlbHNlIGlmIChWOENTU1J1bGVM aXN0OjppbmZvLmVxdWFscyh0eXBlSW5mbykpIHsKLSAgICAgICAgICAgIENTU1J1bGVMaXN0KiBj c3NSdWxlTGlzdCA9IHN0YXRpY19jYXN0PENTU1J1bGVMaXN0Kj4ob2JqZWN0KTsKLSAgICAgICAg ICAgIHVpbnRwdHJfdCBncm91cElkID0gcmVpbnRlcnByZXRfY2FzdDx1aW50cHRyX3Q+KGNzc1J1 bGVMaXN0KTsKLSAgICAgICAgICAgIG1fZ3JvdXBlci5hcHBlbmQoR3JvdXBlckl0ZW0oZ3JvdXBJ ZCwgd3JhcHBlcikpOwotICAgICAgICAgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IGNzc1J1 bGVMaXN0LT5sZW5ndGgoKTsgaSsrKSB7Ci0gICAgICAgICAgICAgICAgQ1NTUnVsZSogY3NzUnVs ZSA9IGNzc1J1bGVMaXN0LT5pdGVtKGkpOwotICAgICAgICAgICAgICAgIHdyYXBwZXIgPSBzdG9y ZS0+ZG9tT2JqZWN0TWFwKCkuZ2V0KGNzc1J1bGUpOwotICAgICAgICAgICAgICAgIGlmICghd3Jh cHBlci5Jc0VtcHR5KCkpCi0gICAgICAgICAgICAgICAgICAgIG1fZ3JvdXBlci5hcHBlbmQoR3Jv dXBlckl0ZW0oZ3JvdXBJZCwgd3JhcHBlcikpOwotICAgICAgICAgICAgfQorICAgICAgICAgICAg YWRkQWxsSXRlbXMoc3RvcmUsIHN0YXRpY19jYXN0PENTU1J1bGVMaXN0Kj4ob2JqZWN0KSwgd3Jh cHBlcik7CiAgICAgICAgIH0KICAgICB9CiAKIHByaXZhdGU6CiAgICAgR3JvdXBlckxpc3QgbV9n cm91cGVyOworCisgICAgdGVtcGxhdGUgPGNsYXNzIEM+CisgICAgdm9pZCBhZGRBbGxJdGVtcyhE T01EYXRhU3RvcmUqIHN0b3JlLCBDKiBjb2xsZWN0aW9uLCB2ODo6UGVyc2lzdGVudDx2ODo6T2Jq ZWN0PiB3cmFwcGVyKQorICAgIHsKKyAgICAgICAgdWludHB0cl90IGdyb3VwSWQgPSByZWludGVy cHJldF9jYXN0PHVpbnRwdHJfdD4oY29sbGVjdGlvbik7CisgICAgICAgIG1fZ3JvdXBlci5hcHBl bmQoR3JvdXBlckl0ZW0oZ3JvdXBJZCwgd3JhcHBlcikpOworICAgICAgICBmb3IgKHVuc2lnbmVk IGkgPSAwOyBpIDwgY29sbGVjdGlvbi0+bGVuZ3RoKCk7IGkrKykgeworICAgICAgICAgICAgd3Jh cHBlciA9IHN0b3JlLT5kb21PYmplY3RNYXAoKS5nZXQoY29sbGVjdGlvbi0+aXRlbShpKSk7Cisg ICAgICAgICAgICBpZiAoIXdyYXBwZXIuSXNFbXB0eSgpKQorICAgICAgICAgICAgICAgIG1fZ3Jv dXBlci5hcHBlbmQoR3JvdXBlckl0ZW0oZ3JvdXBJZCwgd3JhcHBlcikpOworICAgICAgICB9Cisg ICAgfQogfTsKIAogLy8gQ3JlYXRlIG9iamVjdCBncm91cHMgZm9yIERPTSB0cmVlIG5vZGVzLgo=