50935 2010-12-13 10:08:03 -0800 Crash when clicking a download link that targets a new tab 2010-12-13 10:28:37 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 andersca andersca oldest_to_newest 321190 0 andersca 2010-12-13 10:08:03 -0800 Crash when clicking a download link that targets a new tab 321196 1 andersca 2010-12-13 10:09:25 -0800 <rdar://problem/8760572> 321199 2 76402 andersca 2010-12-13 10:09:51 -0800 Created attachment 76402 Patch 321215 3 76402 sullivan 2010-12-13 10:24:34 -0800 Comment on attachment 76402 Patch r+ for the crash fix. Will this function return the wrong result in the new-tab case? If so, that should have a separate bug report (maybe it already does?). 321219 4 andersca 2010-12-13 10:28:37 -0800 Committed r73929: <http://trac.webkit.org/changeset/73929> 76402 2010-12-13 10:09:51 -0800 2010-12-13 10:24:34 -0800 Patch bug-50935-20101213100949.patch text/plain 1648 andersca ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg MjQ2ZDc2OWQ1NzcyZWYwZWRiMzFhN2ZlMGJmZjE2NGM3OTk5YTkyYS4uODFmMDJjZTNmNzFlNzM3 N2M3Yjg5ODg1YjM2YjAzMGRmOTE0YjY3OSAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0xMi0xMyAgQW5k ZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENyYXNoIHdoZW4gY2xpY2tpbmcgYSBkb3dubG9h ZCBsaW5rIHRoYXQgdGFyZ2V0cyBhIG5ldyB0YWIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTUwOTM1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84NzYw NTcyPgorCisgICAgICAgIENoZWNrIGZvciBhIG51bGwgaGlzdG9yeSBpdGVtLgorCisgICAgICAg ICogV2ViUHJvY2Vzcy9Eb3dubG9hZHMvbWFjL0Rvd25sb2FkTWFjLm1tOgorICAgICAgICAoV2Vi S2l0OjpvcmlnaW5hdGluZ1VSTEZyb21CYWNrRm9yd2FyZExpc3QpOgorCiAyMDEwLTEyLTEzICBB bmRyYXMgQmVjc2kgIDxhYmVjc2lAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBD c2FiYSBPc3p0cm9nb27DoWMuCmRpZmYgLS1naXQgYS9XZWJLaXQyL1dlYlByb2Nlc3MvRG93bmxv YWRzL21hYy9Eb3dubG9hZE1hYy5tbSBiL1dlYktpdDIvV2ViUHJvY2Vzcy9Eb3dubG9hZHMvbWFj L0Rvd25sb2FkTWFjLm1tCmluZGV4IDBmM2M2NjkwN2Q0YTU5YjUyYTM1YTA0OGE3ODljY2ZiNmZi ZTQzN2IuLjJmZmEzMjA0ZjQ3YzU1YzM1ZDAxODEyMGU4Yzk5NTM3NzBjMWFiNWUgMTAwNjQ0Ci0t LSBhL1dlYktpdDIvV2ViUHJvY2Vzcy9Eb3dubG9hZHMvbWFjL0Rvd25sb2FkTWFjLm1tCisrKyBi L1dlYktpdDIvV2ViUHJvY2Vzcy9Eb3dubG9hZHMvbWFjL0Rvd25sb2FkTWFjLm1tCkBAIC02OCw3 ICs2OCwxMSBAQCBzdGF0aWMgS1VSTCBvcmlnaW5hdGluZ1VSTEZyb21CYWNrRm9yd2FyZExpc3Qo V2ViUGFnZSAqd2ViUGFnZSkKICAgICBmb3IgKGludCBiYWNrSW5kZXggPSAwOyBiYWNrSW5kZXgg PD0gYmFja0NvdW50OyBiYWNrSW5kZXgrKykgewogICAgICAgICAvLyBGSVhNRTogQXQgb25lIHBv aW50IHdlIGhhZCBjb2RlIGhlcmUgdG8gY2hlY2sgYSAid2FzIHVzZXIgZ2VzdHVyZSIgZmxhZy4K ICAgICAgICAgLy8gRG8gd2UgbmVlZCB0byByZXN0b3JlIHRoYXQgbG9naWM/Ci0gICAgICAgIG9y aWdpbmFsVVJMID0gcGFnZS0+YmFja0ZvcndhcmQoKS0+aXRlbUF0SW5kZXgoLWJhY2tJbmRleCkt Pm9yaWdpbmFsVVJMKCk7IAorICAgICAgICBIaXN0b3J5SXRlbSAqaGlzdG9yeUl0ZW0gPSBwYWdl LT5iYWNrRm9yd2FyZCgpLT5pdGVtQXRJbmRleCgtYmFja0luZGV4KTsKKyAgICAgICAgaWYgKCFo aXN0b3J5SXRlbSkKKyAgICAgICAgICAgIGNvbnRpbnVlOworCisgICAgICAgIG9yaWdpbmFsVVJM ID0gaGlzdG9yeUl0ZW0tPm9yaWdpbmFsVVJMKCk7IAogICAgICAgICBpZiAoIW9yaWdpbmFsVVJM LmlzTnVsbCgpKSAKICAgICAgICAgICAgIHJldHVybiBvcmlnaW5hbFVSTDsKICAgICB9Cg==