50920 2010-12-13 06:17:53 -0800 Fix layout test dom/fast/Geolocation/permission-denied-already-error.html for client-based Geolocation 2010-12-13 09:05:55 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 50562 0 jknotten webkit-unassigned abarth commit-queue eric steveblock webkit.review.bot oldest_to_newest 321085 0 jknotten 2010-12-13 06:17:53 -0800 Use a valid error code (position unavailable == 2) to avoid an assertion failure in Chromium's client-based mock geolocation client. 321086 1 76379 jknotten 2010-12-13 06:19:23 -0800 Created attachment 76379 Patch 321090 2 76379 steveblock 2010-12-13 06:30:56 -0800 Comment on attachment 76379 Patch r=me 321102 3 commit-queue 2010-12-13 07:18:00 -0800 The commit-queue encountered the following flaky tests while processing attachment 76379: fast/profiler/throw-exception-from-eval.html bug 50923 (authors: kmccullough@apple.com, oliver@apple.com, and timothy@apple.com) inspector/syntax-highlight-css.html bug 50924 (authors: keishi@webkit.org, pfeldman@chromium.org, and yurys@chromium.org) The commit-queue is continuing to process your patch. 321120 4 76379 commit-queue 2010-12-13 07:54:46 -0800 Comment on attachment 76379 Patch Clearing flags on attachment: 76379 Committed r73919: <http://trac.webkit.org/changeset/73919> 321122 5 commit-queue 2010-12-13 07:54:51 -0800 All reviewed patches have been landed. Closing bug. 321145 6 webkit.review.bot 2010-12-13 09:05:55 -0800 http://trac.webkit.org/changeset/73919 might have broken GTK Linux 64-bit Debug 76379 2010-12-13 06:19:23 -0800 2010-12-13 07:54:46 -0800 Patch bug-50920-20101213141921.patch text/plain 1518 jknotten ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA4NjA3ZDdhNjAxMTQ5OWUyYjFhYzY1MDk1ZDE5YWYwOTY0Yzg2YmU0Li5iZjI1MzNh MDkzYjFlNGIxNTUzMjU5NzJiZDc3ODQzYjdkYjI2ODQ1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTAtMTItMTMgIEpvaG4gS25vdHRlbmJlbHQgIDxqa25vdHRlbkBjaHJvbWl1bS5vcmc+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IGxheW91 dCB0ZXN0IGRvbS9mYXN0L0dlb2xvY2F0aW9uL3Blcm1pc3Npb24tZGVuaWVkLWFscmVhZHktZXJy b3IuaHRtbCBmb3IgY2xpZW50LWJhc2VkIEdlb2xvY2F0aW9uCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MDkyMAorCisgICAgICAgICogZmFzdC9kb20v R2VvbG9jYXRpb24vc2NyaXB0LXRlc3RzL3Blcm1pc3Npb24tZGVuaWVkLWFscmVhZHktZXJyb3Iu anM6CisKIDIwMTAtMTItMTMgIElseWEgVGlraG9ub3Zza3kgIDxsb2lzbG9AY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFJldmlld2VkIGJ5IFl1cnkgU2VtaWtoYXRza3kuCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9mYXN0L2RvbS9HZW9sb2NhdGlvbi9zY3JpcHQtdGVzdHMvcGVybWlzc2lvbi1k ZW5pZWQtYWxyZWFkeS1lcnJvci5qcyBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL0dlb2xvY2F0aW9u L3NjcmlwdC10ZXN0cy9wZXJtaXNzaW9uLWRlbmllZC1hbHJlYWR5LWVycm9yLmpzCmluZGV4IGNj ZTU3Y2UxZmNjZGRjN2NmNjI0ZGFhNTVhMjg4MDA1YzBhMzI1MGQuLjEwZTI4ZTYwYmNlOGRhNTI0 MmYyMGYzNDRkNWFiY2Y3ZTg1Y2QwNmMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZG9t L0dlb2xvY2F0aW9uL3NjcmlwdC10ZXN0cy9wZXJtaXNzaW9uLWRlbmllZC1hbHJlYWR5LWVycm9y LmpzCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL0dlb2xvY2F0aW9uL3NjcmlwdC10ZXN0cy9w ZXJtaXNzaW9uLWRlbmllZC1hbHJlYWR5LWVycm9yLmpzCkBAIC0yMyw3ICsyMyw3IEBAIGZ1bmN0 aW9uIGNvbnRpbnVlVGVzdCgpCiB7CiAgICAgLy8gTWFrZSBhbm90aGVyIHJlcXVlc3QsIHdpdGgg cGVybWlzc2lvbiBhbHJlYWR5IGRlbmllZC4KICAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250 cm9sbGVyKQotICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5zZXRNb2NrR2VvbG9jYXRpb25F cnJvcigwLCAndGVzdCcpOworICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5zZXRNb2NrR2Vv bG9jYXRpb25FcnJvcigyLCAndGVzdCcpOwogCiAgICAgbmF2aWdhdG9yLmdlb2xvY2F0aW9uLmdl dEN1cnJlbnRQb3NpdGlvbihmdW5jdGlvbihwKSB7CiAgICAgICAgIHRlc3RGYWlsZWQoJ1N1Y2Nl c3MgY2FsbGJhY2sgaW52b2tlZCB1bmV4cGVjdGVkbHknKTsK