50896 2010-12-12 12:31:55 -0800 WebKit2: Implement WebInspector::localizedStringsURL on Windows 2010-12-12 20:42:29 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED InRadar, PlatformOnly P2 Normal --- 0 bweinstein bweinstein apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik sam timothy yurys oldest_to_newest 320869 0 bweinstein 2010-12-12 12:31:55 -0800 This function needs to be implemented. 320870 1 bweinstein 2010-12-12 12:32:17 -0800 <rdar://problem/8759907> 320871 2 76332 bweinstein 2010-12-12 12:37:05 -0800 Created attachment 76332 [PATCH] Fix 320872 3 76332 timothy 2010-12-12 12:41:14 -0800 Comment on attachment 76332 [PATCH] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=76332&action=review > WebKit2/WebProcess/WebPage/win/WebInspectorWin.cpp:38 > + RetainPtr<CFURLRef> htmlURLRef(AdoptCF, CFBundleCopyResourceURL(CFBundleGetBundleWithIdentifier(CFSTR("com.apple.WebKit")), CFSTR("localizedStrings"), CFSTR("js"), 0)); > + if (!htmlURLRef) The variable should be localizedStringsURLRef not htmlURLRef. > WebKit2/WebProcess/WebPage/win/WebInspectorWin.cpp:41 > + return String(CFURLGetString(htmlURLRef.get())); Ditto. 320926 4 76332 bweinstein 2010-12-12 20:39:26 -0800 Comment on attachment 76332 [PATCH] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=76332&action=review >> WebKit2/WebProcess/WebPage/win/WebInspectorWin.cpp:38 >> + if (!htmlURLRef) > > The variable should be localizedStringsURLRef not htmlURLRef. Fixed. 320927 5 bweinstein 2010-12-12 20:42:29 -0800 Landed in r73884. 76332 2010-12-12 12:37:05 -0800 2010-12-12 20:39:26 -0800 [PATCH] Fix localized_win.patch text/plain 1570 bweinstein SW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hhbmdlTG9n CShyZXZpc2lvbiA3Mzg3NykKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMTItMTIgIEJyaWFuIFdlaW5zdGVpbiAgPGJ3ZWluc3RlaW5A YXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFdlYktpdDI6IEltcGxlbWVudCBXZWJJbnNwZWN0b3I6OmxvY2FsaXplZFN0cmluZ3NVUkwg b24gV2luZG93cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NTA4OTYKKyAgICAgICAgCisgICAgICAgIEZpbmQgdGhlIGxvY2FsaXplZCBzdHJpbmdzIGZp bGUgdXNpbmcgQ0ZCdW5kbGVDb3B5UmVzb3VyY2VVUkwuCisKKyAgICAgICAgKiBXZWJQcm9jZXNz L1dlYlBhZ2Uvd2luL1dlYkluc3BlY3Rvcldpbi5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYklu c3BlY3Rvcjo6bG9jYWxpemVkU3RyaW5nc1VSTCk6CisKIDIwMTAtMTItMTEgIEJyaWFuIFdlaW5z dGVpbiAgPGJ3ZWluc3RlaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBX ZWluaWcuCkluZGV4OiBXZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS93aW4vV2ViSW5zcGVjdG9y V2luLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS93aW4vV2Vi SW5zcGVjdG9yV2luLmNwcAkocmV2aXNpb24gNzM4MTgpCisrKyBXZWJLaXQyL1dlYlByb2Nlc3Mv V2ViUGFnZS93aW4vV2ViSW5zcGVjdG9yV2luLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjcsMTcg KzI3LDE4IEBACiAKICNpZiBFTkFCTEUoSU5TUEVDVE9SKQogCisjaW5jbHVkZSA8d3RmL1JldGFp blB0ci5oPgogI2luY2x1ZGUgPHd0Zi90ZXh0L1dURlN0cmluZy5oPgogCi0jZGVmaW5lIERJU0FC TEVfTk9UX0lNUExFTUVOVEVEX1dBUk5JTkdTIDEKLSNpbmNsdWRlICJOb3RJbXBsZW1lbnRlZC5o IgotCiBuYW1lc3BhY2UgV2ViS2l0IHsKIAogU3RyaW5nIFdlYkluc3BlY3Rvcjo6bG9jYWxpemVk U3RyaW5nc1VSTCgpIGNvbnN0CiB7Ci0gICAgbm90SW1wbGVtZW50ZWQoKTsKLSAgICByZXR1cm4g U3RyaW5nKCk7CisgICAgUmV0YWluUHRyPENGVVJMUmVmPiBodG1sVVJMUmVmKEFkb3B0Q0YsIENG QnVuZGxlQ29weVJlc291cmNlVVJMKENGQnVuZGxlR2V0QnVuZGxlV2l0aElkZW50aWZpZXIoQ0ZT VFIoImNvbS5hcHBsZS5XZWJLaXQiKSksIENGU1RSKCJsb2NhbGl6ZWRTdHJpbmdzIiksIENGU1RS KCJqcyIpLCAwKSk7CisgICAgaWYgKCFodG1sVVJMUmVmKQorICAgICAgICByZXR1cm4gU3RyaW5n KCk7CisKKyAgICByZXR1cm4gU3RyaW5nKENGVVJMR2V0U3RyaW5nKGh0bWxVUkxSZWYuZ2V0KCkp KTsKIH0KIAogfSAvLyBuYW1lc3BhY2UgV2ViS2l0Cg==