50892 2010-12-12 06:42:23 -0800 [Qt][WK2] Crash in WebPage constructor 2010-12-13 05:52:49 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 kbalazs webkit-unassigned ossy oldest_to_newest 320832 0 kbalazs 2010-12-12 06:42:23 -0800 WebPage initializing it's Page with a PageClients with zero DeviceMotionClient* that leads to zero pointer dereference. This is how Page using the clients: #if ENABLE(DEVICE_ORIENTATION) , m_deviceMotionController(RuntimeEnabledFeatures::deviceMotionEnabled() ? new DeviceMotionController(pageClients.deviceMotionClient) : 0) , m_deviceOrientationController(RuntimeEnabledFeatures::deviceOrientationEnabled() ? new DeviceOrientationController(this, pageClients.deviceOrientationClient) : 0) #endif That means the correct fix is to disable the device motion and orientation features at runtime. The WebPage contructor also needs a fix for consistency with the enable flags but that should be done in a different patch. 320833 1 76326 kbalazs 2010-12-12 06:52:34 -0800 Created attachment 76326 Patch 320835 2 76326 kling 2010-12-12 07:13:45 -0800 Comment on attachment 76326 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=76326&action=review LGTM, except one small and one big thing: > WebKit2/WebProcess/qt/WebProcessQt.cpp:47 > + // Disable runtime enabled features that has no WebKit2 implementation yet. s/has/have/ > WebKit2/WebProcess/qt/WebProcessQt.cpp:53 > + WebCore::RntimeEnabledFeatures::setSpeechInputEnabled(false); s/Rntime/Runtime/ 320842 3 kbalazs 2010-12-12 08:26:46 -0800 Committed in http://trac.webkit.org/changeset/73876. 321060 4 ossy 2010-12-13 05:28:34 -0800 (In reply to comment #3) > Committed in http://trac.webkit.org/changeset/73876. Thx for the fix. 321076 5 kbalazs 2010-12-13 05:52:49 -0800 (In reply to comment #4) > (In reply to comment #3) > > Committed in http://trac.webkit.org/changeset/73876. > > Thx for the fix. It's an honor to serve you! 76326 2010-12-12 06:52:34 -0800 2010-12-12 08:27:39 -0800 Patch bug-50892-20101212155233.patch text/plain 1854 kbalazs ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg MTkwODA0NzRlYTgxZDdiNDU2ZWNhNDhiMjE0ZmFkYmEzYzc3YjFmNi4uMzU1OWQzMzgzYTE5N2Mw Y2ZiNDM3MjQ2Yzc2Yjg5MTFiMTNjZDgzNSAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0xMi0xMiAgQmFs YXpzIEtlbGVtZW4gIDxrYmFsYXpzQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XVtXSzJdIENyYXNoIGluIFdlYlBhZ2UgY29u c3RydWN0b3IuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD01MDg5MgorCisgICAgICAgICogV2ViUHJvY2Vzcy9xdC9XZWJQcm9jZXNzUXQuY3BwOgorICAg ICAgICAoV2ViS2l0OjpXZWJQcm9jZXNzOjpwbGF0Zm9ybUluaXRpYWxpemVXZWJQcm9jZXNzKToK KyAgICAgICAgRGlzYWJsZSBydW50aW1lIGVuYWJsZWQgZmVhdHVyZXMgdGhhdCBoYXMgbm8gV2Vi S2l0MiBpbXBsZW1lbnRhdGlvbiB5ZXQuCisKIDIwMTAtMTItMTAgIEpvbiBIb25leWN1dHQgIDxq aG9uZXljdXR0QGFwcGxlLmNvbT4KIAogICAgICAgICBTZWxlY3QgbWVudXMgd2l0aCBzaG9ydCBv cHRpb24gdGl0bGVzIGRvIG5vdCBwYWludCBwcm9wZXJseQpkaWZmIC0tZ2l0IGEvV2ViS2l0Mi9X ZWJQcm9jZXNzL3F0L1dlYlByb2Nlc3NRdC5jcHAgYi9XZWJLaXQyL1dlYlByb2Nlc3MvcXQvV2Vi UHJvY2Vzc1F0LmNwcAppbmRleCA4MWZiOTM1NGUzYmFiMGM3YzI2OGEzMjgwYmQ5ODFjNmUyMzgx ZDE4Li42NWFlZjBhMjBmMjA3N2ZkNjUyYjEwZjdjNTY3Y2Q5Y2ZlODIzNzBmIDEwMDY0NAotLS0g YS9XZWJLaXQyL1dlYlByb2Nlc3MvcXQvV2ViUHJvY2Vzc1F0LmNwcAorKysgYi9XZWJLaXQyL1dl YlByb2Nlc3MvcXQvV2ViUHJvY2Vzc1F0LmNwcApAQCAtMjYsNiArMjYsNyBAQAogI2luY2x1ZGUg IldlYlByb2Nlc3MuaCIKIAogI2luY2x1ZGUgIldlYlByb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMu aCIKKyNpbmNsdWRlIDxXZWJDb3JlL1J1bnRpbWVFbmFibGVkRmVhdHVyZXMuaD4KICNpbmNsdWRl IDxRTmV0d29ya0FjY2Vzc01hbmFnZXI+CiAKIG5hbWVzcGFjZSBXZWJLaXQgewpAQCAtNDIsNiAr NDMsMTUgQEAgdm9pZCBXZWJQcm9jZXNzOjpwbGF0Zm9ybUNsZWFyUmVzb3VyY2VDYWNoZXMoKQog dm9pZCBXZWJQcm9jZXNzOjpwbGF0Zm9ybUluaXRpYWxpemVXZWJQcm9jZXNzKGNvbnN0IFdlYlBy b2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMmIHBhcmFtZXRlcnMsIENvcmVJUEM6OkFyZ3VtZW50RGVj b2RlciogYXJndW1lbnRzKQogewogICAgIG1fbmV0d29ya0FjY2Vzc01hbmFnZXIgPSBuZXcgUU5l dHdvcmtBY2Nlc3NNYW5hZ2VyOworCisgICAgLy8gRGlzYWJsZSBydW50aW1lIGVuYWJsZWQgZmVh dHVyZXMgdGhhdCBoYXMgbm8gV2ViS2l0MiBpbXBsZW1lbnRhdGlvbiB5ZXQuCisjaWYgRU5BQkxF KERFVklDRV9PUklFTlRBVElPTikKKyAgICBXZWJDb3JlOjpSdW50aW1lRW5hYmxlZEZlYXR1cmVz OjpzZXREZXZpY2VNb3Rpb25FbmFibGVkKGZhbHNlKTsKKyAgICBXZWJDb3JlOjpSdW50aW1lRW5h YmxlZEZlYXR1cmVzOjpzZXREZXZpY2VPcmllbnRhdGlvbkVuYWJsZWQoZmFsc2UpOworI2VuZGlm CisjaWYgRU5BQkxFKFNQRUVDSF9JTlBVVCkKKyAgICBXZWJDb3JlOjpSbnRpbWVFbmFibGVkRmVh dHVyZXM6OnNldFNwZWVjaElucHV0RW5hYmxlZChmYWxzZSk7CisjZW5kaWYKIH0KIAogdm9pZCBX ZWJQcm9jZXNzOjpwbGF0Zm9ybVNodXRkb3duKCkK