50888 2010-12-12 03:33:27 -0800 build-webkit --minimal --enable-video doesn't enable video 2010-12-13 03:16:05 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED INVALID P2 Normal --- 1 pnormand webkit-unassigned hyatt mrobinson ossy xan.lopez oldest_to_newest 320810 0 pnormand 2010-12-12 03:33:27 -0800 Because configure is called with these options in order: --enable-video --disable-video (because of --minimal) 320820 1 76321 pnormand 2010-12-12 04:20:33 -0800 Created attachment 76321 proposed patch 320861 2 xan.lopez 2010-12-12 11:01:52 -0800 Not really GTK specific. 321019 3 76321 ossy 2010-12-13 03:15:54 -0800 Comment on attachment 76321 proposed patch It doesn't work, because there isn't --enable-video option in build-webkit script. You can use --video to enable and --no-video to disable video support. This code sets the default value or 0 if you passed --minimal option : ... # Initialize values from defaults foreach (@features) { ${$_->{value}} = ($_->{default} && !$minimal) || 0; } ... But the script processes the command line arguments later: ... # Build usage text and options list from features foreach (@features) { my $opt = sprintf("%-35s", " --[no-]$_->{option}"); $usage .= "$opt $_->{desc} (default: $_->{default})\n"; $options{"$_->{option}!"} = $_->{value}; } ... So "build-webkit --minimal --video" will work for you and it isn't a bug. 76321 2010-12-12 04:20:33 -0800 2010-12-13 03:15:54 -0800 proposed patch proposed-patch.patch text/plain 1611 pnormand RnJvbSA5NmNiOGNjNTRjM2RlZGNlNTJhZjA5ZTM1OThmOThhYjQ2ODY5MjlkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBTdW4sIDEyIERlYyAyMDEwIDEzOjIwOjAzICswMTAwClN1YmplY3Q6IFtQQVRDSF0g cHJvcG9zZWQgcGF0Y2gKCi0tLQogV2ViS2l0VG9vbHMvQ2hhbmdlTG9nICAgICAgICAgICAgfCAg IDEwICsrKysrKysrKysKIFdlYktpdFRvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0IHwgICAgNyAr KysrKystCiAyIGZpbGVzIGNoYW5nZWQsIDE2IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0p CgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMvQ2hhbmdl TG9nCmluZGV4IGJmMTFhMDEuLjhjYzQ0ZTUgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0NoYW5n ZUxvZworKysgYi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0x Mi0xMiAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gYnVpbGQtd2Via2l0 IC0tbWluaW1hbCAtLWVuYWJsZS12aWRlbyBkb2Vzbid0IGVuYWJsZSB2aWRlbworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTA4ODgKKworICAgICAgICAq IFNjcmlwdHMvYnVpbGQtd2Via2l0OiBEaXNhYmxlIGZlYXR1cmUgaW4gbWluaW1hbCBidWlsZCBv bmx5IGlmCisgICAgICAgIGl0J3Mgbm90IGJlZW4gZXhwbGljaXRlbHkgZW5hYmxlZCBvbiBjb21t YW5kIGxpbmUuCisKIDIwMTAtMTAtMTEgIERpZWdvIEdvbnphbGV6ICA8ZGllZ29oY2dAd2Via2l0 Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbi4K ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0IGIvV2ViS2l0VG9v bHMvU2NyaXB0cy9idWlsZC13ZWJraXQKaW5kZXggNzUxOGJlYS4uMGM5NzAxMyAxMDA3NTUKLS0t IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQKKysrIGIvV2ViS2l0VG9vbHMvU2Ny aXB0cy9idWlsZC13ZWJraXQKQEAgLTI4NCw3ICsyODQsMTIgQEAgZm9yZWFjaCAoQEFSR1YpIHsK IAogIyBJbml0aWFsaXplIHZhbHVlcyBmcm9tIGRlZmF1bHRzCiBmb3JlYWNoIChAZmVhdHVyZXMp IHsKLSAgICAkeyRfLT57dmFsdWV9fSA9ICgkXy0+e2RlZmF1bHR9ICYmICEkbWluaW1hbCkgfHwg MDsKKyAgICBteSAkb3B0X25hbWUgPSAiLS1lbmFibGUtIiAuICRfLT57b3B0aW9ufTsKKyAgICBp ZiAoIWdyZXAoLyRvcHRfbmFtZS8sQEFSR1YpKSB7CisgICAgICAgICR7JF8tPnt2YWx1ZX19ID0g KCRfLT57ZGVmYXVsdH0gJiYgISRtaW5pbWFsKSB8fCAwOworICAgIH0gZWxzZSB7CisgICAgICAg ICR7JF8tPnt2YWx1ZX19ID0gJF8tPntkZWZhdWx0fTsKKyAgICB9CiB9CiAKICRzdmdTdXBwb3J0 ID0gJHN2Z1N1cHBvcnQgfHwgJHN2Z0FuaW1hdGlvblN1cHBvcnQgfHwgJHN2Z0FzSW1hZ2VTdXBw b3J0Ci0tIAoxLjcuMy4z