50884 2010-12-11 23:59:56 -0800 REGRESSION(r73307): MobileMe mail viewing is broken 2010-12-13 14:20:20 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED http://www.me.com/mail InRadar P2 Normal --- 1 alice.barraclough msaboff ap barraclough ggaren msaboff oldest_to_newest 320759 0 alice.barraclough 2010-12-11 23:59:56 -0800 viewing the contents of mobileme mail messages has broken, beginning with r77307. I hear that r73866 was supposed to be the fix for the bugs.webkit.org regression caused by r77307, but it hasn't fixed the mobileme mail regression, which presumably was unknown until now. steps to repro: 1) login to http://www.me.com/mail 2) view any message results: most messages will appear to be blank, or appear with just one line of text. <rdar://problem/8759479> 321372 1 76429 msaboff 2010-12-13 13:46:15 -0800 Created attachment 76429 Patch to fix backtracking to simple parenthenses Simple parens are those with a fixed quantity and don't capture. There is a special case for these parentheses and that code didn't handle backtracking from nested parentheses. 321410 2 msaboff 2010-12-13 14:20:20 -0800 Committed r73962: <http://trac.webkit.org/changeset/73962> 76429 2010-12-13 13:46:15 -0800 2010-12-13 13:55:52 -0800 Patch to fix backtracking to simple parenthenses 50884-1.patch text/plain 6840 msaboff SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDczOTUzKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTAtMTItMTMgIE1pY2hhZWwg U2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgUkVHUkVTU0lPTjogbW9iaWxlbWUgbWFpbCB2aWV3aW5nIGlz IGJyb2tlbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NTA4ODQKKworICAgICAgICBGaXhlZCBwcm9ibGVtIHdoZXJlIHNpbXBsZSBwYXJlbnRoZXNpcyAo dGhvc2Ugd2l0aG91dCBjYXB0dXJlIGFuZAorICAgICAgICB3aXRoIGEgZml4ZWQgY291bnQpIHdo ZXJlIG5vdCBwcm9wYWdhdGluZyBiYWNrdHJhY2sgdG8gbGFiZWxzIGZvciAKKyAgICAgICAgbmVz dGVkIHBhcmVudGhlc2VzLiAgQWxzbyBhZGRlZCB0aGUgbmVzdGluZyBsZXZlbCBmb3IgdGhlIHBh cmVudGhlc2VzIAorICAgICAgICBzdGF0ZSBjcmVhdGVkIGluIHRoYXQgY2FzZSBhcyB3ZWxsLgor CisgICAgICAgICogeWFyci9SZWdleEpJVC5jcHA6CisgICAgICAgIChKU0M6OllhcnI6OlJlZ2V4 R2VuZXJhdG9yOjpCYWNrdHJhY2tEZXN0aW5hdGlvbjo6Y29weUJhY2t0cmFja1RvTGFiZWwpOgor ICAgICAgICAoSlNDOjpZYXJyOjpSZWdleEdlbmVyYXRvcjo6VGVybUdlbmVyYXRpb25TdGF0ZTo6 aXNMYXN0VGVybSk6CisgICAgICAgIChKU0M6OllhcnI6OlJlZ2V4R2VuZXJhdG9yOjpQYXJlbnRo ZXNlc1RhaWw6OmdlbmVyYXRlQ29kZSk6CisgICAgICAgIChKU0M6OllhcnI6OlJlZ2V4R2VuZXJh dG9yOjpnZW5lcmF0ZVBhcmVudGhlc2VzU2luZ2xlKToKKwogMjAxMC0xMi0xMyAgUGV0ZXIgVmFy Z2EgIDxwdmFyZ2FAaW5mLnUtc3plZ2VkLmh1PgogCiAgICAgICAgIFJldmlld2VkIGJ5IEdhdmlu IEJhcnJhY2xvdWdoLgpJbmRleDogSmF2YVNjcmlwdENvcmUveWFyci9SZWdleEpJVC5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUveWFyci9SZWdleEpJVC5jcHAJKHJldmlzaW9uIDcz OTUzKQorKysgSmF2YVNjcmlwdENvcmUveWFyci9SZWdleEpJVC5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTU3Miw2ICs1NzIsMTIgQEAgY2xhc3MgUmVnZXhHZW5lcmF0b3IgOiBwcml2YXRlIE1hY3Jv QXNzZQogICAgICAgICAgICAgICAgIG1fbmV4dEJhY2t0cmFjay0+c2V0TGFiZWwobGFiZWwpOwog ICAgICAgICB9CiAKKyAgICAgICAgdm9pZCBjb3B5QmFja3RyYWNrVG9MYWJlbChCYWNrdHJhY2tE ZXN0aW5hdGlvbiYgcmhzKQorICAgICAgICB7CisgICAgICAgICAgICBpZiAocmhzLm1fYmFja3Ry YWNrVG9MYWJlbCkKKyAgICAgICAgICAgICAgICBtX2JhY2t0cmFja1RvTGFiZWwgPSByaHMubV9i YWNrdHJhY2tUb0xhYmVsOworICAgICAgICB9CisKICAgICAgICAgdm9pZCBzZXRCYWNrdHJhY2tU b0xhYmVsKExhYmVsKiBiYWNrdHJhY2tUb0xhYmVsKQogICAgICAgICB7CiAgICAgICAgICAgICBp ZiAoIW1fYmFja3RyYWNrVG9MYWJlbCkKQEAgLTgxOSw3ICs4MjUsNyBAQCBjbGFzcyBSZWdleEdl bmVyYXRvciA6IHByaXZhdGUgTWFjcm9Bc3NlCiAgICAgICAgIHsKICAgICAgICAgICAgIEFTU0VS VChhbHRlcm5hdGl2ZVZhbGlkKCkpOwogICAgICAgICAgICAgcmV0dXJuICh0ICsgMSkgPT0gYWx0 ZXJuYXRpdmUoKS0+bV90ZXJtcy5zaXplKCk7Ci0gICAgICAgIH0gICAgICAgIAorICAgICAgICB9 CiAgICAgICAgIHVuc2lnbmVkIGdldFN1YlBhcmVuTnVtKCkKICAgICAgICAgewogICAgICAgICAg ICAgcmV0dXJuIG1fc3ViUGFyZW5OdW0rKzsKQEAgLTgyOCw3ICs4MzQsNyBAQCBjbGFzcyBSZWdl eEdlbmVyYXRvciA6IHByaXZhdGUgTWFjcm9Bc3NlCiAgICAgICAgIHsKICAgICAgICAgICAgIHJl dHVybiAhZGlzanVuY3Rpb24tPm1fcGFyZW50OwogICAgICAgICB9Ci0gICAgICAgIAorCiAgICAg ICAgIHZvaWQgc2V0UGFyZW50aGVzZXNUYWlsKFBhcmVudGhlc2VzVGFpbCogcGFyZW50aGVzZXNU YWlsKQogICAgICAgICB7CiAgICAgICAgICAgICBtX3BhcmVudGhlc2VzVGFpbCA9IHBhcmVudGhl c2VzVGFpbDsKQEAgLTgzOCw3ICs4NDQsNyBAQCBjbGFzcyBSZWdleEdlbmVyYXRvciA6IHByaXZh dGUgTWFjcm9Bc3NlCiAgICAgICAgIHsKICAgICAgICAgICAgIHJldHVybiBtX3BhcmVudGhlc2Vz VGFpbDsKICAgICAgICAgfQotICAgICAgICAKKwogICAgICAgICBQYXR0ZXJuVGVybSYgbG9va2Fo ZWFkVGVybSgpCiAgICAgICAgIHsKICAgICAgICAgICAgIEFTU0VSVChhbHRlcm5hdGl2ZVZhbGlk KCkpOwpAQCAtMTA4Miw3ICsxMDg4LDcgQEAgY2xhc3MgUmVnZXhHZW5lcmF0b3IgOiBwcml2YXRl IE1hY3JvQXNzZQogICAgICAgICAgICAgaWYgKG5lZWRKdW1wRm9yUHJpb3JQYXJlblRhaWwpCiAg ICAgICAgICAgICAgICAgZnJvbVByaW9yQmFja3RyYWNrLmxpbmsoZ2VuZXJhdG9yKTsKICAgICAg ICAgICAgIG1fcGFyZW5CYWNrdHJhY2subGlua0FsdGVybmF0aXZlQmFja3RyYWNrcyhnZW5lcmF0 b3IpOwotICAgICAgICAgICAgbV93aXRoaW5CYWNrdHJhY2tKdW1wcy5saW5rKGdlbmVyYXRvcik7 ICAgICAgICAgICAgCisgICAgICAgICAgICBtX3dpdGhpbkJhY2t0cmFja0p1bXBzLmxpbmsoZ2Vu ZXJhdG9yKTsKIAogICAgICAgICAgICAgaWYgKG1fdGVybS5jYXB0dXJlKCkpCiAgICAgICAgICAg ICAgICAgZ2VuZXJhdG9yLT5zdG9yZTMyKEltbTMyKC0xKSwgQWRkcmVzcyhvdXRwdXQsIChtX3Rl cm0ucGFyZW50aGVzZXMuc3VicGF0dGVybklkIDw8IDEpICogc2l6ZW9mKGludCkpKTsKQEAgLTE2 MDIsMTIgKzE2MDgsMTggQEAgY2xhc3MgUmVnZXhHZW5lcmF0b3IgOiBwcml2YXRlIE1hY3JvQXNz ZQogCiAgICAgICAgIC8vIG9wdGltaXplZCBjYXNlIC0gbm8gY2FwdHVyZSAmIG5vIHF1YW50aWZp ZXIgY2FuIGJlIGhhbmRsZWQgaW4gYSBsaWdodC13ZWlnaHQgbWFubmVyLgogICAgICAgICBpZiAo IXRlcm0uY2FwdHVyZSgpICYmICh0ZXJtLnF1YW50aXR5VHlwZSA9PSBRdWFudGlmaWVyRml4ZWRD b3VudCkpIHsKKyAgICAgICAgICAgIG1fZXhwcmVzc2lvblN0YXRlLmluY3JlbWVudFBhcmVuTmVz dGluZ0xldmVsKCk7CisKICAgICAgICAgICAgIFRlcm1HZW5lcmF0aW9uU3RhdGUgcGFyZW50aGVz ZXNTdGF0ZShkaXNqdW5jdGlvbiwgc3RhdGUuY2hlY2tlZFRvdGFsKTsKICAgICAgICAgICAgIGdl bmVyYXRlUGFyZW50aGVzZXNEaXNqdW5jdGlvbihzdGF0ZS50ZXJtKCksIHBhcmVudGhlc2VzU3Rh dGUsIGFsdGVybmF0aXZlRnJhbWVMb2NhdGlvbik7CiAgICAgICAgICAgICAvLyB0aGlzIGV4cGVj dHMgdGhhdCBhbnkgYmFja3RyYWNrcyBiYWNrIG91dCBvZiB0aGUgcGFyZW50aGVzZXMgd2lsbCBi ZSBpbiB0aGUKICAgICAgICAgICAgIC8vIHBhcmVudGhlc2VzU3RhdGUncyBtX2JhY2tUcmFja0p1 bXBzIHZlY3RvciwgYW5kIHRoYXQgaWYgdGhleSBuZWVkIGJhY2t0cmFja2luZwogICAgICAgICAg ICAgLy8gdGhleSB3aWxsIGhhdmUgc2V0IGFuIGVudHJ5IHBvaW50IG9uIHRoZSBwYXJlbnRoZXNl c1N0YXRlJ3MgbV9iYWNrdHJhY2tMYWJlbC4KLSAgICAgICAgICAgIHN0YXRlLnByb3BhZ2F0ZUJh Y2t0cmFja2luZ0Zyb20odGhpcywgcGFyZW50aGVzZXNTdGF0ZS5nZXRCYWNrdHJhY2tEZXN0aW5h dGlvbigpKTsKKyAgICAgICAgICAgIEJhY2t0cmFja0Rlc3RpbmF0aW9uJiBwYXJlbnRoZXNlc0Jh Y2t0cmFjayA9IHBhcmVudGhlc2VzU3RhdGUuZ2V0QmFja3RyYWNrRGVzdGluYXRpb24oKTsKKyAg ICAgICAgICAgIHN0YXRlLnByb3BhZ2F0ZUJhY2t0cmFja2luZ0Zyb20odGhpcywgcGFyZW50aGVz ZXNCYWNrdHJhY2spOworICAgICAgICAgICAgc3RhdGUuZ2V0QmFja3RyYWNrRGVzdGluYXRpb24o KS5jb3B5QmFja3RyYWNrVG9MYWJlbChwYXJlbnRoZXNlc0JhY2t0cmFjayk7CisKKyAgICAgICAg ICAgIG1fZXhwcmVzc2lvblN0YXRlLmRlY3JlbWVudFBhcmVuTmVzdGluZ0xldmVsKCk7CiAgICAg ICAgIH0gZWxzZSB7CiAgICAgICAgICAgICBKdW1wIG5vbkdyZWVkeVNraXBQYXJlbnRoZXNlczsK ICAgICAgICAgICAgIExhYmVsIG5vbkdyZWVkeVRyeVBhcmVudGhlc2VzOwpAQCAtMTYzNiw3ICsx NjQ4LDcgQEAgY2xhc3MgUmVnZXhHZW5lcmF0b3IgOiBwcml2YXRlIE1hY3JvQXNzZQogICAgICAg ICAgICAgbV9leHByZXNzaW9uU3RhdGUuaW5jcmVtZW50UGFyZW5OZXN0aW5nTGV2ZWwoKTsKIAog ICAgICAgICAgICAgVGVybUdlbmVyYXRpb25TdGF0ZSBwYXJlbnRoZXNlc1N0YXRlKGRpc2p1bmN0 aW9uLCBzdGF0ZS5jaGVja2VkVG90YWwpOwotICAgICAgICAgICAgCisKICAgICAgICAgICAgIC8v IFNhdmUgdGhlIHBhcmVudGhlc2VzVGFpbCBmb3IgYmFja3RyYWNraW5nIGZyb20gbmVzdGVkIHBh cmVucyB0byB0aGlzIG9uZS4KICAgICAgICAgICAgIHBhcmVudGhlc2VzU3RhdGUuc2V0UGFyZW50 aGVzZXNUYWlsKHBhcmVudGhlc2VzVGFpbCk7CiAKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxv Zwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDczOTUzKQor KysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAK KzIwMTAtMTItMTMgIE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUkVHUkVTU0lPTjogbW9i aWxlbWUgbWFpbCB2aWV3aW5nIGlzIGJyb2tlbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTA4ODQKKworICAgICAgICBBZGRlZCBhIHRlc3QgdG8gY2hl Y2sgcGFyZW50aGVzZXMgbmVzdGluZyB3aXRoaW4gcGFyZW50aGVzZXMgdGhhdAorICAgICAgICBk b24ndCBjYXB0dXJlIGFuZCB0aGF0IGFyZSBmaXhlZCBjb3VudC4gIFRoZXJlIGlzIHNwZWNpYWwg aGFuZGxpbmcKKyAgICAgICAgZm9yIHRoaXMgY2FzZSBpbiB0aGUgUmVnRXhwIEpJVCBjb2RlLgor CisgICAgICAgICogZmFzdC9yZWdleC9wYXJlbnRoZXNlcy1leHBlY3RlZC50eHQ6CisgICAgICAg ICogZmFzdC9yZWdleC9zY3JpcHQtdGVzdHMvcGFyZW50aGVzZXMuanM6CisKIDIwMTAtMTItMTMg IEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQu CkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L3JlZ2V4L3BhcmVudGhlc2VzLWV4cGVjdGVkLnR4dAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L3JlZ2V4L3BhcmVudGhlc2VzLWV4cGVjdGVk LnR4dAkocmV2aXNpb24gNzM5NTMpCisrKyBMYXlvdXRUZXN0cy9mYXN0L3JlZ2V4L3BhcmVudGhl c2VzLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMzcsNiArMzcsNyBAQCBQQVNTIHJl Z2V4cDI5LmV4ZWMoJ0NvbW1pdHRlcjonKSBpcyBudWxsCiBQQVNTIHJlZ2V4cDMwLmV4ZWMoJ0Nv bW1pdHRlcjonKSBpcyBudWxsCiBQQVNTIHJlZ2V4cDMxLmV4ZWMoJ0NvbW1pdHRlcjonKSBpcyBu dWxsCiBQQVNTIHJlZ2V4cDMyLmV4ZWMoJ0NvbW1pdHRlcjonKSBpcyBudWxsCitQQVNTIHJlZ2V4 cDMzLmV4ZWMoJz4gPGhlYWQ+JykgaXMgWyc+Jyx1bmRlZmluZWQsdW5kZWZpbmVkLCc+J10KIFBB U1MgJ0hpIEJvYicubWF0Y2goLyhSb2IpfChCb2IpfChSb2JlcnQpfChCb2JieSkvKSBpcyBbJ0Jv YicsdW5kZWZpbmVkLCdCb2InLHVuZGVmaW5lZCx1bmRlZmluZWRdCiBQQVNTIHN1Y2Nlc3NmdWxs eVBhcnNlZCBpcyB0cnVlCiAKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvcmVnZXgvc2NyaXB0LXRl c3RzL3BhcmVudGhlc2VzLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvcmVnZXgv c2NyaXB0LXRlc3RzL3BhcmVudGhlc2VzLmpzCShyZXZpc2lvbiA3Mzk1MykKKysrIExheW91dFRl c3RzL2Zhc3QvcmVnZXgvc2NyaXB0LXRlc3RzL3BhcmVudGhlc2VzLmpzCSh3b3JraW5nIGNvcHkp CkBAIC0xMzcsNiArMTM3LDkgQEAgc2hvdWxkQmVOdWxsKCJyZWdleHAzMS5leGVjKCdDb21taXR0 ZXI6JwogdmFyIHJlZ2V4cDMyID0gL1xzKihtKFxbW15cXV0rXF0pfG0odT8pKCJbXiJdKyIpKVxz Ki87CiBzaG91bGRCZU51bGwoInJlZ2V4cDMyLmV4ZWMoJ0NvbW1pdHRlcjonKSIpOwogCit2YXIg cmVnZXhwMzMgPSBSZWdFeHAoJ14oPzooPzooYSkoeHl6fFtePiJcJ1xzXSopPyl8KC8/Pil8Llte XHdccz5dKiknKTsKK3Nob3VsZEJlKCJyZWdleHAzMy5leGVjKCc+IDxoZWFkPicpIiwiWyc+Jyx1 bmRlZmluZWQsdW5kZWZpbmVkLCc+J10iKTsKKwogc2hvdWxkQmUoIidIaSBCb2InLm1hdGNoKC8o Um9iKXwoQm9iKXwoUm9iZXJ0KXwoQm9iYnkpLykiLCAiWydCb2InLHVuZGVmaW5lZCwnQm9iJyx1 bmRlZmluZWQsdW5kZWZpbmVkXSIpOwogCiB2YXIgc3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsK