50864 2010-12-10 22:00:00 -0800 commit-queue flaky test messages show cryptic version information for mac os x 2010-12-10 22:47:55 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric eric abarth darin eric joepeck ojan tony webkit.review.bot oldest_to_newest 320585 0 eric 2010-12-10 22:00:00 -0800 commit-queue flaky test messages show cryptic version information for mac os x 320586 1 76293 eric 2010-12-10 22:03:32 -0800 Created attachment 76293 Patch 320587 2 eric 2010-12-10 22:04:08 -0800 https://bugs.webkit.org/show_bug.cgi?id=50863#c0 is an example of the current cryptic version information. 320602 3 76293 abarth 2010-12-10 22:27:55 -0800 Comment on attachment 76293 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=76293&action=review > WebKitTools/Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:92 > - self.assertEqual(reporter._bot_information(), "Bot Id: MockBotId Port: MockPort OS: MockPlatform 1.0") > + self.assertEqual(reporter._bot_information(), "Bot: MockBotId Port: MockPort Platform: MockPlatform 1.0") Seems like there's an extra space here. 320605 4 76293 eric 2010-12-10 22:30:07 -0800 Comment on attachment 76293 Patch I intentionally added an extra space between the various pieces. Before "Mac" and "OS" blurred together into "Mac OS", now it would read "Port: Mac Platform: Mac OS X 10.6.5" 320608 5 76293 webkit.review.bot 2010-12-10 22:47:48 -0800 Comment on attachment 76293 Patch Clearing flags on attachment: 76293 Committed r73838: <http://trac.webkit.org/changeset/73838> 320609 6 webkit.review.bot 2010-12-10 22:47:55 -0800 All reviewed patches have been landed. Closing bug. 76293 2010-12-10 22:03:32 -0800 2010-12-10 22:47:48 -0800 Patch bug-50864-20101210220330.patch text/plain 6505 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA5MzI4OGZjMjdlYmM3NzBhNDM5OWU5ZGI3YjU2ZjE2OTdkMDgzMGQ3Li45MjU0Nzc4 YzdmZTZmZDdkODFlYmRiMTUxNWFiNWJlYTY2MjgwMzVkIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjYgQEAK IDIwMTAtMTItMTAgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGNvbW1pdC1xdWV1ZSBmbGFreSB0 ZXN0IG1lc3NhZ2VzIHNob3cgY3J5cHRpYyB2ZXJzaW9uIGluZm9ybWF0aW9uIGZvciBtYWMgb3Mg eAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTA4NjQK KworICAgICAgICBUdXJucyBvdXQgcGxhdGZvcm0ucGxhdGZvcm0oKSByZXR1cm5zIGtlcm5lbCB2 ZXJzaW9uIGluZm9ybWF0aW9uCisgICAgICAgIHdoaWNoIGlzbid0IGhlbHBmdWwsIGFuZCBqdXN0 IHBsYWluIGNvbmZ1c2luZyBvbiBNYWMKKyAgICAgICAgKE9TIFggMTAuNi41IHVzZXMgRGFyd2lu IEtlcm5lbCAxMC41LjApLgorCisgICAgICAgIFNvIEkndmUgdXBkYXRlZCBQbGF0Zm9ybUluZm8u ZGlzcGxheV9uYW1lKCkgdG8gc3BlY2lhbCBjYXNlCisgICAgICAgIG1hYy4gIEkgYWxzbyBmb3Vu ZCBhIGJhZCB1c2Ugb2Ygc3lzLnBsYXRmb3JtIGluIHRoZSBwcm9jZXNzCisgICAgICAgIGFuZCBm aXhlZCB0aGF0LiAgKHN5cy5wbGF0Zm9ybSBhbHdheXMgcmV0dXJucyAnZGFyd2luJyBvbiBtYWMp LgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL3BsYXRmb3JtaW5m by5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vdXNlci5weToK KyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L2ZsYWt5dGVzdHJlcG9ydGVyLnB5 OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3QvZmxha3l0ZXN0cmVwb3J0ZXJf dW5pdHRlc3QucHk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3F1 ZXVlc191bml0dGVzdC5weToKKworMjAxMC0xMi0xMCAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtp dC5vcmc+CisKICAgICAgICAgVW5yZXZpZXdlZC4KIAogICAgICAgICBFeGNlcHRpb24gc2VlbiB3 aGlsZSByZXBvcnRpbmcgZmxha3kgdGVzdCB3aXRoIGNvbW1pdC1xdWV1ZS4KZGlmZiAtLWdpdCBh L1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9wbGF0Zm9ybWluZm8u cHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vcGxhdGZvcm1p bmZvLnB5CmluZGV4IDEyNTZjMDhjYzFlNzRlZWUzODc1ZDZmZTQxNzUzYTk3YjE0NjY4YjIuLmNj MzcwYmFlMWFmYTY5ODJiYjYwMWMwNTZlNTk1YmI0MTg2N2I0NmIgMTAwNjQ0Ci0tLSBhL1dlYktp dFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9wbGF0Zm9ybWluZm8ucHkKKysr IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL3BsYXRmb3JtaW5m by5weQpAQCAtMjksOCArMjksMTUgQEAKIGltcG9ydCBwbGF0Zm9ybQogCiAKLSMgV2UgdXNlIHRo aXMgaW5zdGVhZCBvZiBjYWxscyB0byBwbGF0Zm9ybSBkaXJlY3RseSBzbyBhbGxvdyBtb2NraW5n LgorIyBXZSB1c2UgdGhpcyBpbnN0ZWFkIG9mIGNhbGxzIHRvIHBsYXRmb3JtIGRpcmVjdGx5IHRv IGFsbG93IG1vY2tpbmcuCiBjbGFzcyBQbGF0Zm9ybUluZm8ob2JqZWN0KToKIAogICAgIGRlZiBk aXNwbGF5X25hbWUoc2VsZik6Ci0gICAgICAgIHJldHVybiBwbGF0Zm9ybS5wbGF0Zm9ybShhbGlh c2VkPTEsIHRlcnNlPTEpCisgICAgICAgICMgcGxhdGZvcm0ucGxhdGZvcm0oKSByZXR1cm5zIERh cndpbiBpbmZvcm1hdGlvbiBmb3IgTWFjLCB3aGljaCBpcyBqdXN0IGNvbmZ1c2luZy4KKyAgICAg ICAgaWYgcGxhdGZvcm0uc3lzdGVtKCkgPT0gIkRhcndpbiI6CisgICAgICAgICAgICByZXR1cm4g Ik1hYyBPUyBYICVzIiAlIHBsYXRmb3JtLm1hY192ZXIoKVswXQorCisgICAgICAgICMgUmV0dXJu cyBzdHJpbmdzIGxpa2U6CisgICAgICAgICMgTGludXgtMi42LjE4LTE5NC4zLjEuZWw1LWk2ODYt d2l0aC1yZWRoYXQtNS41LUZpbmFsCisgICAgICAgICMgV2luZG93cy0yMDA4U2VydmVyUjItNi4x Ljc2MDAKKyAgICAgICAgcmV0dXJuIHBsYXRmb3JtLnBsYXRmb3JtKCkKZGlmZiAtLWdpdCBhL1dl YktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS91c2VyLnB5IGIvV2ViS2l0 VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL3VzZXIucHkKaW5kZXggODkxNzEz N2M3ZmZlZmJjYjczYTE0ZGFiNzJmNzBhYjMwYTMzNzc0Yy4uYjc5NTM2Y2M4YzNiNDI4YmZjZGM1 ZjZhMDQ2YjdiNTY4ODc0NDk2ZCAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJr aXRweS9jb21tb24vc3lzdGVtL3VzZXIucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJr aXRweS9jb21tb24vc3lzdGVtL3VzZXIucHkKQEAgLTQ2LDcgKzQ2LDcgQEAgZXhjZXB0IEltcG9y dEVycm9yOgogICAgICAgICBfbG9nLndhcm4oIlVuYWJsZSB0byBpbXBvcnQgcmVhZGxpbmUuIikK ICAgICAjIEZJWE1FOiBXZSBjb3VsZCBnaXZlIGluc3RydWN0aW9ucyBmb3Igbm9uLW1hYyBwbGF0 Zm9ybXMuCiAgICAgIyBMYWNrIG9mIHJlYWRsaW5lIHJlc3VsdHMgaW4gYSB2ZXJ5IGJhZCB1c2Vy IGV4cGVyaWFuY2UuCi0gICAgaWYgc3lzLnBsYXRmb3JtID09ICJtYWMiOgorICAgIGlmIHN5cy5w bGF0Zm9ybSA9PSAiZGFyd2luIjoKICAgICAgICAgX2xvZy53YXJuKCJJZiB5b3UncmUgdXNpbmcg TWFjUG9ydHMsIHRyeSBydW5uaW5nOiIpCiAgICAgICAgIF9sb2cud2FybigiICBzdWRvIHBvcnQg aW5zdGFsbCBweTI1LXJlYWRsaW5lIikKIApkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0 cy93ZWJraXRweS90b29sL2JvdC9mbGFreXRlc3RyZXBvcnRlci5weSBiL1dlYktpdFRvb2xzL1Nj cmlwdHMvd2Via2l0cHkvdG9vbC9ib3QvZmxha3l0ZXN0cmVwb3J0ZXIucHkKaW5kZXggNThiZTVi MjkyZjNjZDY2Yjk4YzhlMWM5NWVkM2MzZDY2Mzg5ZDg3NC4uZmFiMDAxMDM4ZDNhNWRkMjE5ZmVk NDI0MmM2ZmY5MjM2NjcxNGNkNiAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJr aXRweS90b29sL2JvdC9mbGFreXRlc3RyZXBvcnRlci5weQorKysgYi9XZWJLaXRUb29scy9TY3Jp cHRzL3dlYmtpdHB5L3Rvb2wvYm90L2ZsYWt5dGVzdHJlcG9ydGVyLnB5CkBAIC0xMDQsOCArMTA0 LDggQEAgSWYgeW91IHdvdWxkIGxpa2UgdG8gdHJhY2sgdGhpcyB0ZXN0IGZpeCB3aXRoIGFub3Ro ZXIgYnVnLCBwbGVhc2UgY2xvc2UgdGhpcyBidWcKIAogICAgIGRlZiBfYm90X2luZm9ybWF0aW9u KHNlbGYpOgogICAgICAgICBib3RfaWQgPSBzZWxmLl90b29sLnN0YXR1c19zZXJ2ZXIuYm90X2lk Ci0gICAgICAgIGJvdF9pZF9zdHJpbmcgPSAiQm90IElkOiAlcyAiICUgKGJvdF9pZCkgaWYgYm90 X2lkIGVsc2UgIiIKLSAgICAgICAgcmV0dXJuICIlc1BvcnQ6ICVzIE9TOiAlcyIgJSAoYm90X2lk X3N0cmluZywgc2VsZi5fdG9vbC5wb3J0KCkubmFtZSgpLCBzZWxmLl90b29sLnBsYXRmb3JtLmRp c3BsYXlfbmFtZSgpKQorICAgICAgICBib3RfaWRfc3RyaW5nID0gIkJvdDogJXMgICIgJSAoYm90 X2lkKSBpZiBib3RfaWQgZWxzZSAiIgorICAgICAgICByZXR1cm4gIiVzUG9ydDogJXMgIFBsYXRm b3JtOiAlcyIgJSAoYm90X2lkX3N0cmluZywgc2VsZi5fdG9vbC5wb3J0KCkubmFtZSgpLCBzZWxm Ll90b29sLnBsYXRmb3JtLmRpc3BsYXlfbmFtZSgpKQogCiAgICAgZGVmIF9sYXRlc3RfZmxha2Vf bWVzc2FnZShzZWxmLCBmbGFreV90ZXN0LCBwYXRjaCk6CiAgICAgICAgIGZsYWtlX21lc3NhZ2Ug PSAiVGhlICVzIGp1c3Qgc2F3ICVzIGZsYWtlIHdoaWxlIHByb2Nlc3NpbmcgYXR0YWNobWVudCAl cyBvbiBidWcgJXMuIiAlIChzZWxmLl9ib3RfbmFtZSwgZmxha3lfdGVzdCwgcGF0Y2guaWQoKSwg cGF0Y2guYnVnX2lkKCkpCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5 L3Rvb2wvYm90L2ZsYWt5dGVzdHJlcG9ydGVyX3VuaXR0ZXN0LnB5IGIvV2ViS2l0VG9vbHMvU2Ny aXB0cy93ZWJraXRweS90b29sL2JvdC9mbGFreXRlc3RyZXBvcnRlcl91bml0dGVzdC5weQppbmRl eCBkY2ZkM2ZlYzE0NTllMDczMTU4YWFkMjBiNGFhMGM5N2UzNGI3NTQyLi4zYWFmZTEzYzQ1YjRi YTFiYTNiM2JmN2I1NjU4MGFmMmUxN2Y1ZWIzIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3Jp cHRzL3dlYmtpdHB5L3Rvb2wvYm90L2ZsYWt5dGVzdHJlcG9ydGVyX3VuaXR0ZXN0LnB5CisrKyBi L1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3QvZmxha3l0ZXN0cmVwb3J0ZXJf dW5pdHRlc3QucHkKQEAgLTg5LDcgKzg5LDcgQEAgSWYgeW91IHdvdWxkIGxpa2UgdG8gdHJhY2sg dGhpcyB0ZXN0IGZpeCB3aXRoIGFub3RoZXIgYnVnLCBwbGVhc2UgY2xvc2UgdGhpcyBidWcKICAg ICAgICAgdG9vbCA9IE1vY2tUb29sKCkKICAgICAgICAgdG9vbC5zdGF0dXNfc2VydmVyID0gTW9j a1N0YXR1c1NlcnZlcigiTW9ja0JvdElkIikKICAgICAgICAgcmVwb3J0ZXIgPSBGbGFreVRlc3RS ZXBvcnRlcih0b29sLCAnZHVtbXktcXVldWUnKQotICAgICAgICBzZWxmLmFzc2VydEVxdWFsKHJl cG9ydGVyLl9ib3RfaW5mb3JtYXRpb24oKSwgIkJvdCBJZDogTW9ja0JvdElkIFBvcnQ6IE1vY2tQ b3J0IE9TOiBNb2NrUGxhdGZvcm0gMS4wIikKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChyZXBv cnRlci5fYm90X2luZm9ybWF0aW9uKCksICJCb3Q6IE1vY2tCb3RJZCAgUG9ydDogTW9ja1BvcnQg IFBsYXRmb3JtOiBNb2NrUGxhdGZvcm0gMS4wIikKIAogICAgIGRlZiB0ZXN0X2NyZWF0ZV9idWdf Zm9yX2ZsYWt5X3Rlc3Qoc2VsZik6CiAgICAgICAgIHRvb2wgPSBNb2NrVG9vbCgpCkBAIC0xMDUs NyArMTA1LDcgQEAgZm9vL2Jhci5odG1sIHdhcyBhdXRob3JlZCBieSBhYmFydGhAd2Via2l0Lm9y Zy4KIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvYnJvd3Nlci90cnVuay9MYXlvdXRUZXN0cy9mb28v YmFyLmh0bWwKIAogVGhlIGR1bW15LXF1ZXVlIGp1c3Qgc2F3IGZvby9iYXIuaHRtbCBmbGFrZSB3 aGlsZSBwcm9jZXNzaW5nIGF0dGFjaG1lbnQgMTk3IG9uIGJ1ZyA0Mi4KLVBvcnQ6IE1vY2tQb3J0 IE9TOiBNb2NrUGxhdGZvcm0gMS4wCitQb3J0OiBNb2NrUG9ydCAgUGxhdGZvcm06IE1vY2tQbGF0 Zm9ybSAxLjAKIAogVGhlIGJvdHMgd2lsbCB1cGRhdGUgdGhpcyB3aXRoIGluZm9ybWF0aW9uIGZy b20gZWFjaCBuZXcgZmFpbHVyZS4KIApkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93 ZWJraXRweS90b29sL2NvbW1hbmRzL3F1ZXVlc191bml0dGVzdC5weSBiL1dlYktpdFRvb2xzL1Nj cmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9xdWV1ZXNfdW5pdHRlc3QucHkKaW5kZXggNGIw MDY2ODk1NDExMzc1OGRhNmViM2IyZTBkNzMwY2VkNzYwM2Y1MS4uNGUzYTc5M2I3ZTNiM2YxMjM5 ZjllMDJmYWVjYjZlZjE0ODI3MDMxOCAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93 ZWJraXRweS90b29sL2NvbW1hbmRzL3F1ZXVlc191bml0dGVzdC5weQorKysgYi9XZWJLaXRUb29s cy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvcXVldWVzX3VuaXR0ZXN0LnB5CkBAIC0z MjcsMTMgKzMyNywxMyBAQCBNT0NLOiByZWxlYXNlX3dvcmtfaXRlbTogY29tbWl0LXF1ZXVlIDE5 NwogICAgICAgICBleHBlY3RlZF9zdGRlcnIgPSAiIiJNT0NLIGJ1ZyBjb21tZW50OiBidWdfaWQ9 NzYsIGNjPU5vbmUKIC0tLSBCZWdpbiBjb21tZW50IC0tLQogVGhlIGNvbW1pdC1xdWV1ZSBqdXN0 IHNhdyBmb28vYmFyLmh0bWwgZmxha2Ugd2hpbGUgcHJvY2Vzc2luZyBhdHRhY2htZW50IDE5NyBv biBidWcgNDIuCi1Qb3J0OiBNb2NrUG9ydCBPUzogTW9ja1BsYXRmb3JtIDEuMAorUG9ydDogTW9j a1BvcnQgIFBsYXRmb3JtOiBNb2NrUGxhdGZvcm0gMS4wCiAtLS0gRW5kIGNvbW1lbnQgLS0tCiAK IE1PQ0sgYnVnIGNvbW1lbnQ6IGJ1Z19pZD03NiwgY2M9Tm9uZQogLS0tIEJlZ2luIGNvbW1lbnQg LS0tCiBUaGUgY29tbWl0LXF1ZXVlIGp1c3Qgc2F3IGJhci9iYXouaHRtbCBmbGFrZSB3aGlsZSBw cm9jZXNzaW5nIGF0dGFjaG1lbnQgMTk3IG9uIGJ1ZyA0Mi4KLVBvcnQ6IE1vY2tQb3J0IE9TOiBN b2NrUGxhdGZvcm0gMS4wCitQb3J0OiBNb2NrUG9ydCAgUGxhdGZvcm06IE1vY2tQbGF0Zm9ybSAx LjAKIC0tLSBFbmQgY29tbWVudCAtLS0KIAogTU9DSyBidWcgY29tbWVudDogYnVnX2lkPTQyLCBj Yz1Ob25lCg==