<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>50861</bug_id>
          
          <creation_ts>2010-12-10 19:24:55 -0800</creation_ts>
          <short_desc>[Qt][WK2] Make WebKit2 static library compile on Symbian</short_desc>
          <delta_ts>2010-12-15 11:33:22 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Qt</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>S60 Hardware</rep_platform>
          <op_sys>S60 3rd edition</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>WONTFIX</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Qt</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>50866</dependson>
          <blocked>50251</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Siddharth Mathur">s.mathur</reporter>
          <assigned_to name="Siddharth Mathur">s.mathur</assigned_to>
          <cc>abecsi</cc>
    
    <cc>laszlo.gombos</cc>
    
    <cc>ossy</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>320549</commentid>
    <comment_count>0</comment_count>
    <who name="Siddharth Mathur">s.mathur</who>
    <bug_when>2010-12-10 19:24:55 -0800</bug_when>
    <thetext>Mods to WebKit.pro to make the static lib compile on Symbian. 
For now, Netscape plugin features are turned off</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>320561</commentid>
    <comment_count>1</comment_count>
      <attachid>76291</attachid>
    <who name="Siddharth Mathur">s.mathur</who>
    <bug_when>2010-12-10 19:53:07 -0800</bug_when>
    <thetext>Created attachment 76291
Fix include ordering like WebCore.pro and disabling NPAPI support for now</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>320564</commentid>
    <comment_count>2</comment_count>
      <attachid>76291</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-12-10 20:41:43 -0800</bug_when>
    <thetext>Comment on attachment 76291
Fix include ordering like WebCore.pro and disabling NPAPI support for now

OK.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>320568</commentid>
    <comment_count>3</comment_count>
      <attachid>76291</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2010-12-10 20:59:15 -0800</bug_when>
    <thetext>Comment on attachment 76291
Fix include ordering like WebCore.pro and disabling NPAPI support for now

Clearing flags on attachment: 76291

Committed r73834: &lt;http://trac.webkit.org/changeset/73834&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>320569</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2010-12-10 20:59:20 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>320626</commentid>
    <comment_count>5</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2010-12-11 01:44:59 -0800</bug_when>
    <thetext>Reopen, because it was rolled out by http://trac.webkit.org/changeset/73847</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>321124</commentid>
    <comment_count>6</comment_count>
      <attachid>76385</attachid>
    <who name="Siddharth Mathur">s.mathur</who>
    <bug_when>2010-12-13 07:57:08 -0800</bug_when>
    <thetext>Created attachment 76385
Fixed patch with no WK2_DIR</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>321126</commentid>
    <comment_count>7</comment_count>
      <attachid>76385</attachid>
    <who name="Siddharth Mathur">s.mathur</who>
    <bug_when>2010-12-13 08:00:17 -0800</bug_when>
    <thetext>Comment on attachment 76385
Fixed patch with no WK2_DIR

Sorry about the build bust with the previous patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>321174</commentid>
    <comment_count>8</comment_count>
      <attachid>76385</attachid>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2010-12-13 09:56:23 -0800</bug_when>
    <thetext>Comment on attachment 76385
Fixed patch with no WK2_DIR

View in context: https://bugs.webkit.org/attachment.cgi?id=76385&amp;action=review

Non symbian case looks good to me.

&gt; WebKit2/WebKit2.pro:641
&gt; +    !symbian: {
&gt; +            # TODO: Resolve compiler errors with NPEvent/QEvents on Symbian
&gt; +            INCLUDEPATH += WebProcess/Plugins/Netscape
&gt; +            HEADERS += \
&gt; +                WebProcess/Plugins/Netscape/NetscapePlugin.h \
&gt; +                WebProcess/Plugins/Netscape/NetscapePluginModule.h \
&gt; +                WebProcess/Plugins/Netscape/NetscapePluginStream.h
&gt; +
&gt; +            SOURCES += \
&gt; +                WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp \
&gt; +                WebProcess/Plugins/Netscape/NetscapePlugin.cpp \
&gt; +                WebProcess/Plugins/Netscape/NetscapePluginModule.cpp \
&gt; +                WebProcess/Plugins/Netscape/NetscapePluginStream.cpp \
&gt; +                WebProcess/Plugins/Netscape/qt/NetscapePluginQt.cpp
&gt; +        }
&gt;  

&quot;!symbian: {&quot; should be on the beginning of the line</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>321178</commentid>
    <comment_count>9</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2010-12-13 09:59:46 -0800</bug_when>
    <thetext>Laszlo, could you review the symbian case?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>321335</commentid>
    <comment_count>10</comment_count>
      <attachid>76385</attachid>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2010-12-13 12:36:46 -0800</bug_when>
    <thetext>Comment on attachment 76385
Fixed patch with no WK2_DIR

View in context: https://bugs.webkit.org/attachment.cgi?id=76385&amp;action=review

r- because of the unnecessary symbian guards and the expected maintenance burden. Perhaps we should restrict this bug only to enable WebKit2 builds to build without NPAPI support for the Qt port.

&gt; WebKit2/WebKit2.pro:26
&gt; +!symbian {

In general we should aim to minimize the symbian guards to keep the build system manageable. I do not think this guard is essential - we have a similar section in WebCore.pro without symbian guards. Is this section fixing something ?

&gt; WebKit2/WebKit2.pro:38
&gt; +    MMP_RULES += &quot;USERINCLUDE ../WebCore/bridge&quot;

There is a way around this problem by using the PREPEND_INCLUDEPATH variable. r65877 is an example of how this was resolved for WebCore.pro earlier. 
I think we should either follow the WebCore.pro solution here as well or we should delay addressing this problem after we got rid of the WebKit2 static library; in fact the problem might go away after we got rid of WebKit2 library.

&gt; WebKit2/WebKit2.pro:626
&gt; +    !symbian: {

Let&apos;s re-use the &quot;contains(DEFINES, ENABLE_NETSCAPE_PLUGIN_API=1)&quot; guard here the same way as we have in WebCore.pro; this makes the configuration available on all QtWebKit ports and enables us to control this feature build time without changing the source code (e.g. from build-webkit).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>321371</commentid>
    <comment_count>11</comment_count>
      <attachid>76428</attachid>
    <who name="Siddharth Mathur">s.mathur</who>
    <bug_when>2010-12-13 13:45:44 -0800</bug_when>
    <thetext>Created attachment 76428
use Netscape plugin feature flag</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>321444</commentid>
    <comment_count>12</comment_count>
    <who name="Siddharth Mathur">s.mathur</who>
    <bug_when>2010-12-13 14:47:43 -0800</bug_when>
    <thetext>On second thoughts, this patch isn&apos;t need if we add all WK2 files to WebCore.pro, which is what is needed for symbols to be exported correctly on Symbian/RVCT and probably Windows.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>76291</attachid>
            <date>2010-12-10 19:53:07 -0800</date>
            <delta_ts>2010-12-13 13:45:44 -0800</delta_ts>
            <desc>Fix include ordering like WebCore.pro and disabling NPAPI support for now</desc>
            <filename>50861_v1.patch</filename>
            <type>text/plain</type>
            <size>3576</size>
            <attacher name="Siddharth Mathur">s.mathur</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg
ZWE4NWFmZi4uOWUwOTg4NiAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvV2Vi
S2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMC0xMi0xMCAgU2lkZGhhcnRoIE1h
dGh1ciAgPHNpZGRoYXJ0aC5tYXRodXJAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5
IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF1bV0syXSBNYWtlIFdlYktpdDIgc3RhdGlj
IGxpYnJhcnkgY29tcGlsZSBvbiBTeW1iaWFuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu
b3JnL3Nob3dfYnVnLmNnaT9pZD01MDg2MQorCisgICAgICAgICogV2ViS2l0Mi5wcm86CisKIDIw
MTAtMTItMTAgIEpvY2VseW4gVHVyY290dGUgIDxqb2NlbHluLnR1cmNvdHRlQG5va2lhLmNvbT4K
IAogICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbi4KZGlmZiAt
LWdpdCBhL1dlYktpdDIvV2ViS2l0Mi5wcm8gYi9XZWJLaXQyL1dlYktpdDIucHJvCmluZGV4IDc2
N2UxNGMuLjIxODFkMDQgMTAwNjQ0Ci0tLSBhL1dlYktpdDIvV2ViS2l0Mi5wcm8KKysrIGIvV2Vi
S2l0Mi9XZWJLaXQyLnBybwpAQCAtMjMsMTEgKzIzLDIyIEBAIENPTkZJRyArPSBzdGF0aWNsaWIK
IFRBUkdFVCA9ICQkV0VCS0lUMl9UQVJHRVQKIERFU1RESVIgPSAkJFdFQktJVDJfREVTVERJUgog
Ci0hQ09ORklHKHJlbGVhc2UsIGRlYnVnfHJlbGVhc2UpIHsKLSAgICBPQkpFQ1RTX0RJUiA9IG9i
ai9kZWJ1ZwotfSBlbHNlIHsgIyBSZWxlYXNlCi0gICAgT0JKRUNUU19ESVIgPSBvYmovcmVsZWFz
ZQotICAgIERFRklORVMgKz0gTkRFQlVHCishc3ltYmlhbiB7CisgICAgIUNPTkZJRyhyZWxlYXNl
LCBkZWJ1Z3xyZWxlYXNlKSB7CisgICAgICAgIE9CSkVDVFNfRElSID0gb2JqL2RlYnVnCisgICAg
fSBlbHNlIHsgIyBSZWxlYXNlCisgICAgICAgIE9CSkVDVFNfRElSID0gb2JqL3JlbGVhc2UKKyAg
ICAgICAgREVGSU5FUyArPSBOREVCVUcKKyAgICB9Cit9CisKK3N5bWJpYW4geworICAgICMgREVG
SU5FUyArPSBRVF9NQUtFRExMCisgICAgREVGSU5FUyArPSBCVUlMRElOR19XRUJLSVQKKyAgICBN
TVBfUlVMRVMgKz0gIlVTRVJJTkNMVURFIC4uL1dlYkNvcmUvYnJpZGdlIgorICAgIE1NUF9SVUxF
UyArPSAiVVNFUklOQ0xVREUgLi4vV2ViQ29yZS9wbGF0Zm9ybS90ZXh0IgorICAgIE1NUF9SVUxF
UyArPSAiVVNFUklOQ0xVREUgLi4vV2ViQ29yZS9wbGF0Zm9ybS9hbmltYXRpb24iCisgICAgTU1Q
X1JVTEVTICs9ICJVU0VSSU5DTFVERSAuLi9XZWJDb3JlL3JlbmRlcmluZyIKIH0KIAogIyBCdWls
ZCBib3RoIGRlYnVnIGFuZCByZWxlYXNlIGNvbmZpZ3VyYXRpb25zCkBAIC0zNzQsMTAgKzM4NSw2
IEBAIEhFQURFUlMgKz0gXAogICAgIFdlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9OUEpTT2Jq
ZWN0LmggXAogICAgIFdlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9OUFJ1bnRpbWVPYmplY3RN
YXAuaCBcCiAgICAgV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL05QUnVudGltZVV0aWxpdGll
cy5oIFwKLSAgICBXZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvTmV0c2NhcGVCcm93c2VyRnVu
Y3MuY3BwIFwKLSAgICBXZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvTmV0c2NhcGVQbHVnaW4u
aCBcCi0gICAgV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL05ldHNjYXBlUGx1Z2luTW9kdWxl
LmggXAotICAgIFdlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9OZXRzY2FwZVBsdWdpblN0cmVh
bS5oIFwKICAgICBXZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luLmggXAogICAgIFdlYlByb2Nlc3Mv
UGx1Z2lucy9QbHVnaW5Db250cm9sbGVyLmggXAogICAgIFdlYlByb2Nlc3MvUGx1Z2lucy9QbHVn
aW5WaWV3LmggXApAQCAtNTc3LDExICs1ODQsNiBAQCBTT1VSQ0VTICs9IFwKICAgICBXZWJQcm9j
ZXNzL1BsdWdpbnMvTmV0c2NhcGUvTlBKU09iamVjdC5jcHAgXAogICAgIFdlYlByb2Nlc3MvUGx1
Z2lucy9OZXRzY2FwZS9OUFJ1bnRpbWVPYmplY3RNYXAuY3BwIFwKICAgICBXZWJQcm9jZXNzL1Bs
dWdpbnMvTmV0c2NhcGUvTlBSdW50aW1lVXRpbGl0aWVzLmNwcCBcCi0gICAgV2ViUHJvY2Vzcy9Q
bHVnaW5zL05ldHNjYXBlL05ldHNjYXBlQnJvd3NlckZ1bmNzLmNwcCBcCi0gICAgV2ViUHJvY2Vz
cy9QbHVnaW5zL05ldHNjYXBlL05ldHNjYXBlUGx1Z2luLmNwcCBcCi0gICAgV2ViUHJvY2Vzcy9Q
bHVnaW5zL05ldHNjYXBlL05ldHNjYXBlUGx1Z2luTW9kdWxlLmNwcCBcCi0gICAgV2ViUHJvY2Vz
cy9QbHVnaW5zL05ldHNjYXBlL05ldHNjYXBlUGx1Z2luU3RyZWFtLmNwcCBcCi0gICAgV2ViUHJv
Y2Vzcy9QbHVnaW5zL05ldHNjYXBlL3F0L05ldHNjYXBlUGx1Z2luUXQuY3BwIFwKICAgICBXZWJQ
cm9jZXNzL1BsdWdpbnMvUGx1Z2luLmNwcCBcCiAgICAgV2ViUHJvY2Vzcy9QbHVnaW5zL1BsdWdp
blZpZXcuY3BwIFwKICAgICBXZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkNocm9tZUNsaWVu
dC5jcHAgXApAQCAtNjIwLDMgKzYyMiwxOSBAQCBTT1VSQ0VTICs9IFwKICAgICBXZWJQcm9jZXNz
L3F0L1dlYlByb2Nlc3NNYWluUXQuY3BwIFwKICAgICBXZWJQcm9jZXNzL3F0L1dlYlByb2Nlc3NR
dC5jcHAgXAogICAgICQkV0VCS0lUMl9HRU5FUkFURURfU09VUkNFUworCisgICAgIXN5bWJpYW46
IHsKKyAgICAgICAgICAgICMgVE9ETzogUmVzb2x2ZSBjb21waWxlciBlcnJvcnMgd2l0aCBOUEV2
ZW50L1FFdmVudHMgb24gU3ltYmlhbgorICAgICAgICAgICAgSU5DTFVERVBBVEggKz0gJCRXSzJf
RElSL1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZQorICAgICAgICAgICAgSEVBREVSUyArPSBc
CisgICAgICAgICAgICAgICAgJCRXSzJfRElSL1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9O
ZXRzY2FwZVBsdWdpbi5oIFwKKyAgICAgICAgICAgICAgICAkJFdLMl9ESVIvV2ViUHJvY2Vzcy9Q
bHVnaW5zL05ldHNjYXBlL05ldHNjYXBlUGx1Z2luTW9kdWxlLmggXAorICAgICAgICAgICAgICAg
ICQkV0syX0RJUi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvTmV0c2NhcGVQbHVnaW5TdHJl
YW0uaAorCisgICAgICAgICAgICBTT1VSQ0VTICs9IFwKKyAgICAgICAgICAgICAgICAkJFdLMl9E
SVIvV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL05ldHNjYXBlQnJvd3NlckZ1bmNzLmNwcCBc
CisgICAgICAgICAgICAgICAgJCRXSzJfRElSL1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9O
ZXRzY2FwZVBsdWdpbi5jcHAgXAorICAgICAgICAgICAgICAgICQkV0syX0RJUi9XZWJQcm9jZXNz
L1BsdWdpbnMvTmV0c2NhcGUvTmV0c2NhcGVQbHVnaW5Nb2R1bGUuY3BwIFwKKyAgICAgICAgICAg
ICAgICAkJFdLMl9ESVIvV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL05ldHNjYXBlUGx1Z2lu
U3RyZWFtLmNwcCBcCisgICAgICAgICAgICAgICAgJCRXSzJfRElSL1dlYlByb2Nlc3MvUGx1Z2lu
cy9OZXRzY2FwZS9xdC9OZXRzY2FwZVBsdWdpblF0LmNwcAorICAgIH0K
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>76385</attachid>
            <date>2010-12-13 07:57:08 -0800</date>
            <delta_ts>2010-12-13 13:45:44 -0800</delta_ts>
            <desc>Fixed patch with no WK2_DIR</desc>
            <filename>50861_v2.patch</filename>
            <type>text/plain</type>
            <size>3559</size>
            <attacher name="Siddharth Mathur">s.mathur</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg
ZWE4NWFmZi4uN2VhODIyNSAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvV2Vi
S2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMC0xMi0xMyAgU2lkZGhhcnRoIE1h
dGh1ciAgPHNpZGRoYXJ0aC5tYXRodXJAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5
IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF1bV0syXU1ha2UgV2ViS2l0MiBzdGF0aWMg
bGlicmFyeSBjb21waWxlIG9uIFN5bWJpYW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v
cmcvc2hvd19idWcuY2dpP2lkPTUwODYxCisKKyAgICAgICAgKiBXZWJLaXQyLnBybzogRml4IGlu
Y2x1ZGVwYXRoIG9yZGVyaW5nLiBUZW1wb3JhcmlseSBkaXNhYmxlIE5ldHNjYXBlIHBsdWdpbiBz
dXBwb3J0CisKIDIwMTAtMTItMTAgIEpvY2VseW4gVHVyY290dGUgIDxqb2NlbHluLnR1cmNvdHRl
QG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRlIENocmlzdGlh
bnNlbi4KZGlmZiAtLWdpdCBhL1dlYktpdDIvV2ViS2l0Mi5wcm8gYi9XZWJLaXQyL1dlYktpdDIu
cHJvCmluZGV4IDc2N2UxNGMuLjExMzlkNDggMTAwNjQ0Ci0tLSBhL1dlYktpdDIvV2ViS2l0Mi5w
cm8KKysrIGIvV2ViS2l0Mi9XZWJLaXQyLnBybwpAQCAtMjMsMTEgKzIzLDIyIEBAIENPTkZJRyAr
PSBzdGF0aWNsaWIKIFRBUkdFVCA9ICQkV0VCS0lUMl9UQVJHRVQKIERFU1RESVIgPSAkJFdFQktJ
VDJfREVTVERJUgogCi0hQ09ORklHKHJlbGVhc2UsIGRlYnVnfHJlbGVhc2UpIHsKLSAgICBPQkpF
Q1RTX0RJUiA9IG9iai9kZWJ1ZwotfSBlbHNlIHsgIyBSZWxlYXNlCi0gICAgT0JKRUNUU19ESVIg
PSBvYmovcmVsZWFzZQotICAgIERFRklORVMgKz0gTkRFQlVHCishc3ltYmlhbiB7CisgICAgIUNP
TkZJRyhyZWxlYXNlLCBkZWJ1Z3xyZWxlYXNlKSB7CisgICAgICAgIE9CSkVDVFNfRElSID0gb2Jq
L2RlYnVnCisgICAgfSBlbHNlIHsgIyBSZWxlYXNlCisgICAgICAgIE9CSkVDVFNfRElSID0gb2Jq
L3JlbGVhc2UKKyAgICAgICAgREVGSU5FUyArPSBOREVCVUcKKyAgICB9Cit9CisKK3N5bWJpYW4g
eworICAgICMgREVGSU5FUyArPSBRVF9NQUtFRExMCisgICAgREVGSU5FUyArPSBCVUlMRElOR19X
RUJLSVQKKyAgICBNTVBfUlVMRVMgKz0gIlVTRVJJTkNMVURFIC4uL1dlYkNvcmUvYnJpZGdlIgor
ICAgIE1NUF9SVUxFUyArPSAiVVNFUklOQ0xVREUgLi4vV2ViQ29yZS9wbGF0Zm9ybS90ZXh0Igor
ICAgIE1NUF9SVUxFUyArPSAiVVNFUklOQ0xVREUgLi4vV2ViQ29yZS9wbGF0Zm9ybS9hbmltYXRp
b24iCisgICAgTU1QX1JVTEVTICs9ICJVU0VSSU5DTFVERSAuLi9XZWJDb3JlL3JlbmRlcmluZyIK
IH0KIAogIyBCdWlsZCBib3RoIGRlYnVnIGFuZCByZWxlYXNlIGNvbmZpZ3VyYXRpb25zCkBAIC0z
NzQsMTAgKzM4NSw2IEBAIEhFQURFUlMgKz0gXAogICAgIFdlYlByb2Nlc3MvUGx1Z2lucy9OZXRz
Y2FwZS9OUEpTT2JqZWN0LmggXAogICAgIFdlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9OUFJ1
bnRpbWVPYmplY3RNYXAuaCBcCiAgICAgV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL05QUnVu
dGltZVV0aWxpdGllcy5oIFwKLSAgICBXZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvTmV0c2Nh
cGVCcm93c2VyRnVuY3MuY3BwIFwKLSAgICBXZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvTmV0
c2NhcGVQbHVnaW4uaCBcCi0gICAgV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL05ldHNjYXBl
UGx1Z2luTW9kdWxlLmggXAotICAgIFdlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9OZXRzY2Fw
ZVBsdWdpblN0cmVhbS5oIFwKICAgICBXZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luLmggXAogICAg
IFdlYlByb2Nlc3MvUGx1Z2lucy9QbHVnaW5Db250cm9sbGVyLmggXAogICAgIFdlYlByb2Nlc3Mv
UGx1Z2lucy9QbHVnaW5WaWV3LmggXApAQCAtNTc3LDExICs1ODQsNiBAQCBTT1VSQ0VTICs9IFwK
ICAgICBXZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvTlBKU09iamVjdC5jcHAgXAogICAgIFdl
YlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9OUFJ1bnRpbWVPYmplY3RNYXAuY3BwIFwKICAgICBX
ZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvTlBSdW50aW1lVXRpbGl0aWVzLmNwcCBcCi0gICAg
V2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL05ldHNjYXBlQnJvd3NlckZ1bmNzLmNwcCBcCi0g
ICAgV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL05ldHNjYXBlUGx1Z2luLmNwcCBcCi0gICAg
V2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL05ldHNjYXBlUGx1Z2luTW9kdWxlLmNwcCBcCi0g
ICAgV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL05ldHNjYXBlUGx1Z2luU3RyZWFtLmNwcCBc
Ci0gICAgV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL3F0L05ldHNjYXBlUGx1Z2luUXQuY3Bw
IFwKICAgICBXZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luLmNwcCBcCiAgICAgV2ViUHJvY2Vzcy9Q
bHVnaW5zL1BsdWdpblZpZXcuY3BwIFwKICAgICBXZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dl
YkNocm9tZUNsaWVudC5jcHAgXApAQCAtNjIwLDMgKzYyMiwxOSBAQCBTT1VSQ0VTICs9IFwKICAg
ICBXZWJQcm9jZXNzL3F0L1dlYlByb2Nlc3NNYWluUXQuY3BwIFwKICAgICBXZWJQcm9jZXNzL3F0
L1dlYlByb2Nlc3NRdC5jcHAgXAogICAgICQkV0VCS0lUMl9HRU5FUkFURURfU09VUkNFUworCisg
ICAgIXN5bWJpYW46IHsKKyAgICAgICAgICAgICMgVE9ETzogUmVzb2x2ZSBjb21waWxlciBlcnJv
cnMgd2l0aCBOUEV2ZW50L1FFdmVudHMgb24gU3ltYmlhbgorICAgICAgICAgICAgSU5DTFVERVBB
VEggKz0gV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlCisgICAgICAgICAgICBIRUFERVJTICs9
IFwKKyAgICAgICAgICAgICAgICBXZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvTmV0c2NhcGVQ
bHVnaW4uaCBcCisgICAgICAgICAgICAgICAgV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL05l
dHNjYXBlUGx1Z2luTW9kdWxlLmggXAorICAgICAgICAgICAgICAgIFdlYlByb2Nlc3MvUGx1Z2lu
cy9OZXRzY2FwZS9OZXRzY2FwZVBsdWdpblN0cmVhbS5oCisKKyAgICAgICAgICAgIFNPVVJDRVMg
Kz0gXAorICAgICAgICAgICAgICAgIFdlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9OZXRzY2Fw
ZUJyb3dzZXJGdW5jcy5jcHAgXAorICAgICAgICAgICAgICAgIFdlYlByb2Nlc3MvUGx1Z2lucy9O
ZXRzY2FwZS9OZXRzY2FwZVBsdWdpbi5jcHAgXAorICAgICAgICAgICAgICAgIFdlYlByb2Nlc3Mv
UGx1Z2lucy9OZXRzY2FwZS9OZXRzY2FwZVBsdWdpbk1vZHVsZS5jcHAgXAorICAgICAgICAgICAg
ICAgIFdlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9OZXRzY2FwZVBsdWdpblN0cmVhbS5jcHAg
XAorICAgICAgICAgICAgICAgIFdlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9xdC9OZXRzY2Fw
ZVBsdWdpblF0LmNwcAorICAgICAgICB9Cg==
</data>
<flag name="review"
          id="67337"
          type_id="1"
          status="-"
          setter="laszlo.gombos"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>76428</attachid>
            <date>2010-12-13 13:45:44 -0800</date>
            <delta_ts>2010-12-13 13:45:44 -0800</delta_ts>
            <desc>use Netscape plugin feature flag</desc>
            <filename>50861_v3.patch</filename>
            <type>text/plain</type>
            <size>2823</size>
            <attacher name="Siddharth Mathur">s.mathur</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg
ZmJhODU4MS4uNTczY2FmMCAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvV2Vi
S2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMC0xMi0xMyAgU2lkZGhhcnRoIE1h
dGh1ciAgPHNpZGRoYXJ0aC5tYXRodXJAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5
IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF1bV0syXSBQYXJ0aWFsIHN1cHBvcnQgZm9y
IEVOQUJMRV9ORVRTQ0FQRV9QTFVHSU5fQVBJIGZsYWcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUwODYxCisKKyAgICAgICAgKiBXZWJLaXQyLnBybzoK
KwogMjAxMC0xMi0xMyAgRGF2aWQgSHlhdHQgIDxoeWF0dEBhcHBsZS5jb20+CiAKICAgICAgICAg
UmV2aWV3ZWQgYnkgQWRhbSBSb2Jlbi4KZGlmZiAtLWdpdCBhL1dlYktpdDIvV2ViS2l0Mi5wcm8g
Yi9XZWJLaXQyL1dlYktpdDIucHJvCmluZGV4IDYxYzQ5NzcwYi4uNzEzMzc0OCAxMDA2NDQKLS0t
IGEvV2ViS2l0Mi9XZWJLaXQyLnBybworKysgYi9XZWJLaXQyL1dlYktpdDIucHJvCkBAIC0xNTks
NyArMTU5LDcgQEAgSU5DTFVERVBBVEggKz0gXAogUFJFRklYX0hFQURFUiA9ICQkUFdELy4uL1dl
YktpdDIvV2ViS2l0MlByZWZpeC5oCiBRTUFLRV9DWFhGTEFHUyArPSAiLWluY2x1ZGUgJCRQUkVG
SVhfSEVBREVSIgogCi1ERUZJTkVTICs9IEJVSUxESU5HX1FUX18KK0RFRklORVMgKz0gQlVJTERJ
TkdfUVRfXyBCVUlMRElOR19XRUJLSVQKIAogV0VCS0lUMl9HRU5FUkFURURfSEVBREVSUyA9IFwK
ICAgICAkJFdFQktJVDJfR0VORVJBVEVEX1NPVVJDRVNfRElSL0F1dGhlbnRpY2F0aW9uTWFuYWdl
ck1lc3NhZ2VzLmggXApAQCAtMzc5LDEwICszNzksNiBAQCBIRUFERVJTICs9IFwKICAgICBXZWJQ
cm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvTlBKU09iamVjdC5oIFwKICAgICBXZWJQcm9jZXNzL1Bs
dWdpbnMvTmV0c2NhcGUvTlBSdW50aW1lT2JqZWN0TWFwLmggXAogICAgIFdlYlByb2Nlc3MvUGx1
Z2lucy9OZXRzY2FwZS9OUFJ1bnRpbWVVdGlsaXRpZXMuaCBcCi0gICAgV2ViUHJvY2Vzcy9QbHVn
aW5zL05ldHNjYXBlL05ldHNjYXBlQnJvd3NlckZ1bmNzLmNwcCBcCi0gICAgV2ViUHJvY2Vzcy9Q
bHVnaW5zL05ldHNjYXBlL05ldHNjYXBlUGx1Z2luLmggXAotICAgIFdlYlByb2Nlc3MvUGx1Z2lu
cy9OZXRzY2FwZS9OZXRzY2FwZVBsdWdpbk1vZHVsZS5oIFwKLSAgICBXZWJQcm9jZXNzL1BsdWdp
bnMvTmV0c2NhcGUvTmV0c2NhcGVQbHVnaW5TdHJlYW0uaCBcCiAgICAgV2ViUHJvY2Vzcy9QbHVn
aW5zL1BsdWdpbi5oIFwKICAgICBXZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luQ29udHJvbGxlci5o
IFwKICAgICBXZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luVmlldy5oIFwKQEAgLTU4NCwxMSArNTgw
LDYgQEAgU09VUkNFUyArPSBcCiAgICAgV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL05QSlNP
YmplY3QuY3BwIFwKICAgICBXZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvTlBSdW50aW1lT2Jq
ZWN0TWFwLmNwcCBcCiAgICAgV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL05QUnVudGltZVV0
aWxpdGllcy5jcHAgXAotICAgIFdlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9OZXRzY2FwZUJy
b3dzZXJGdW5jcy5jcHAgXAotICAgIFdlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9OZXRzY2Fw
ZVBsdWdpbi5jcHAgXAotICAgIFdlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9OZXRzY2FwZVBs
dWdpbk1vZHVsZS5jcHAgXAotICAgIFdlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9OZXRzY2Fw
ZVBsdWdpblN0cmVhbS5jcHAgXAotICAgIFdlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9xdC9O
ZXRzY2FwZVBsdWdpblF0LmNwcCBcCiAgICAgV2ViUHJvY2Vzcy9QbHVnaW5zL1BsdWdpbi5jcHAg
XAogICAgIFdlYlByb2Nlc3MvUGx1Z2lucy9QbHVnaW5WaWV3LmNwcCBcCiAgICAgV2ViUHJvY2Vz
cy9XZWJDb3JlU3VwcG9ydC9XZWJDaHJvbWVDbGllbnQuY3BwIFwKQEAgLTYyNywzICs2MTgsMTgg
QEAgU09VUkNFUyArPSBcCiAgICAgV2ViUHJvY2Vzcy9xdC9XZWJQcm9jZXNzTWFpblF0LmNwcCBc
CiAgICAgV2ViUHJvY2Vzcy9xdC9XZWJQcm9jZXNzUXQuY3BwIFwKICAgICAkJFdFQktJVDJfR0VO
RVJBVEVEX1NPVVJDRVMKKworY29udGFpbnMoREVGSU5FUywgRU5BQkxFX05FVFNDQVBFX1BMVUdJ
Tl9BUEk9MSkgeworCisgICAgSEVBREVSUyArPSBcCisgICAgICAgIFdlYlByb2Nlc3MvUGx1Z2lu
cy9OZXRzY2FwZS9OZXRzY2FwZVBsdWdpbi5oIFwKKyAgICAgICAgV2ViUHJvY2Vzcy9QbHVnaW5z
L05ldHNjYXBlL05ldHNjYXBlUGx1Z2luTW9kdWxlLmggXAorICAgICAgICBXZWJQcm9jZXNzL1Bs
dWdpbnMvTmV0c2NhcGUvTmV0c2NhcGVQbHVnaW5TdHJlYW0uaAorCisgICAgU09VUkNFUyArPSBc
CisgICAgICAgIFdlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9OZXRzY2FwZUJyb3dzZXJGdW5j
cy5jcHAgXAorICAgICAgICBXZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvTmV0c2NhcGVQbHVn
aW4uY3BwIFwKKyAgICAgICAgV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL05ldHNjYXBlUGx1
Z2luTW9kdWxlLmNwcCBcCisgICAgICAgIFdlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9OZXRz
Y2FwZVBsdWdpblN0cmVhbS5jcHAgXAorICAgICAgICBXZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2Nh
cGUvcXQvTmV0c2NhcGVQbHVnaW5RdC5jcHAKK30K
</data>

          </attachment>
      

    </bug>

</bugzilla>