50852 2010-12-10 15:47:30 -0800 Clean up assertion in Extensions3DOpenGL.cpp 2010-12-10 17:25:58 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 kbr kbr darin jamesr oldest_to_newest 320466 0 kbr 2010-12-10 15:47:30 -0800 There were a couple of mishaps about a new assertion added in Extensions3DOpenGL::ensureEnabled in r73806, r73809 and r73810. Darin pointed out that ASSERT_UNUSED is the preferred way of phrasing this assertion. 320474 1 76276 kbr 2010-12-10 16:03:57 -0800 Created attachment 76276 Patch 320475 2 76276 darin 2010-12-10 16:04:35 -0800 Comment on attachment 76276 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=76276&action=review > WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:33 > +#include <wtf/Assertions.h> Are you sure you need this include? If there’s any other ASSERT in the entire file then it’s not needed. 320506 3 kbr 2010-12-10 17:23:08 -0800 (In reply to comment #2) > (From update of attachment 76276 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=76276&action=review > > > WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:33 > > +#include <wtf/Assertions.h> > > Are you sure you need this include? If there’s any other ASSERT in the entire file then it’s not needed. It seems no, even though it's the only ASSERT in the file. Will remove in landed version. 320509 4 kbr 2010-12-10 17:25:58 -0800 Committed r73821: <http://trac.webkit.org/changeset/73821> 76276 2010-12-10 16:03:57 -0800 2010-12-10 16:04:35 -0800 Patch bug-50852-20101210160355.patch text/plain 1427 kbr SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MzgxNSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMTItMTAgIEtlbm5ldGggUnVzc2VsbCAgPGtickBnb29nbGUu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENs ZWFuIHVwIGFzc2VydGlvbiBpbiBFeHRlbnNpb25zM0RPcGVuR0wuY3BwCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MDg1MgorCisgICAgICAgIEJ1aWx0 IFJlbGVhc2UgbW9kZSB0byB0ZXN0LiBObyBmdW5jdGlvbmFsaXR5IGNoYW5nZS4KKworICAgICAg ICAqIHBsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9FeHRlbnNpb25zM0RPcGVuR0wuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6RXh0ZW5zaW9uczNET3BlbkdMOjplbnN1cmVFbmFibGVkKToKKwogMjAx MC0xMi0xMCAgQnJpYW4gV2VpbnN0ZWluICA8YndlaW5zdGVpbkBhcHBsZS5jb20+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgQWRhIENoYW4uCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L29wZW5nbC9FeHRlbnNpb25zM0RPcGVuR0wuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0V4dGVuc2lvbnMzRE9wZW5HTC5jcHAJKHJldmlzaW9uIDcz ODEwKQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvRXh0ZW5zaW9uczNET3Bl bkdMLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzAsNyArMzAsNyBAQAogI2luY2x1ZGUgIkV4dGVu c2lvbnMzRE9wZW5HTC5oIgogCiAjaW5jbHVkZSAiR3JhcGhpY3NDb250ZXh0M0QuaCIKLSNpbmNs dWRlIDx3dGYvVW51c2VkUGFyYW0uaD4KKyNpbmNsdWRlIDx3dGYvQXNzZXJ0aW9ucy5oPgogI2lu Y2x1ZGUgPHd0Zi9WZWN0b3IuaD4KIAogI2lmIFBMQVRGT1JNKE1BQykKQEAgLTg4LDEwICs4OCw3 IEBAIGJvb2wgRXh0ZW5zaW9uczNET3BlbkdMOjpzdXBwb3J0cyhjb25zdCAKIAogdm9pZCBFeHRl bnNpb25zM0RPcGVuR0w6OmVuc3VyZUVuYWJsZWQoY29uc3QgU3RyaW5nJiBuYW1lKQogewotI2lm ZGVmIE5ERUJVRwotICAgIFVOVVNFRF9QQVJBTShuYW1lKTsKLSNlbmRpZgotICAgIEFTU0VSVChz dXBwb3J0cyhuYW1lKSk7CisgICAgQVNTRVJUX1VOVVNFRChuYW1lLCBzdXBwb3J0cyhuYW1lKSk7 CiB9CiAKIGludCBFeHRlbnNpb25zM0RPcGVuR0w6OmdldEdyYXBoaWNzUmVzZXRTdGF0dXNBUkIo KQo=