50846 2010-12-10 14:42:15 -0800 Some FileWriter progress events should be queued 2011-05-02 17:10:58 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 44358 1 ericu ericu kinuko oldest_to_newest 320430 0 ericu 2010-12-10 14:42:15 -0800 http://www.w3.org/2008/webapps/track/issues/173. When a FileWriter successfully completes a write, currently it: * dispatches a write event * sets readyState to DONE * dispatches a writeend event If you want to start a new write, you can't do it in onwrite, since readyState is still WRITING. Those events should be queued for asynchronous delivery, so that readyState is DONE by the time they get handled. If you set up a new write in onwrite, you'll still run the risk of getting confused by the subsequent writeend from the previous write, but that's detectable. I'll have to look and see what other events should be marked as queued. 380760 1 88499 ericu 2011-04-06 13:13:55 -0700 Created attachment 88499 Patch 391835 2 88499 levin 2011-04-25 10:58:22 -0700 Comment on attachment 88499 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=88499&action=review Not an extensive review as I'm in the middle of something but this should be addressed. > Source/WebCore/fileapi/FileWriter.h:110 > + FileWriterCompletionEventTask(PassRefPtr<FileWriter> fileWriter, FileError::ErrorCode code) Quick comment. This constructor should be private. This should only expose a static create method which returns a PassOwnPtr. 392909 3 88499 eric 2011-04-26 16:00:06 -0700 Comment on attachment 88499 Patch This seems fine. 392911 4 88499 eric 2011-04-26 16:00:29 -0700 Comment on attachment 88499 Patch Should be fixed per levin's comemnt though. 392919 5 ericu 2011-04-26 16:02:47 -0700 (In reply to comment #4) > (From update of attachment 88499 [details]) > Should be fixed per levin's comemnt though. Thanks--I'll fix it before I land it. 396811 6 ericu 2011-05-02 17:10:58 -0700 Committed r85556: <http://trac.webkit.org/changeset/85556> 88499 2011-04-06 13:13:55 -0700 2011-04-26 16:00:28 -0700 Patch bug-50846-20110406131354.patch text/plain 7161 ericu SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgyOTk2KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDQtMDUgIEVyaWMgVWhy aGFuZSAgPGVyaWN1QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBTb21lIEZpbGVXcml0ZXIgcHJvZ3Jlc3MgZXZlbnRzIHNob3Vs ZCBiZSBxdWV1ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTUwODQ2CisKKyAgICAgICAgKiBmaWxlYXBpL0ZpbGVXcml0ZXIuY3BwOgorICAgICAgICAq IGZpbGVhcGkvRmlsZVdyaXRlci5oOgorICAgICAgICBDcmVhdGUgYSBuZXcgYXN5bmNocm9ub3Vz IFRhc2sgW0ZpbGVXcml0ZXJDb21wbGV0aW9uRXZlbnRUYXNrXSB0aGF0IHdpbGwgc2V0IHJlYWR5 U3RhdGUgdG8gRE9ORSBhbmQgZmlyZSBvZmYgdGhlIHJpZ2h0IGV2ZW50cy4KKwogMjAxMS0wNC0w NSAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZp ZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2ZpbGVhcGkvRmlsZVdy aXRlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZmlsZWFwaS9GaWxlV3JpdGVy LmNwcAkocmV2aXNpb24gODI3NTQpCisrKyBTb3VyY2UvV2ViQ29yZS9maWxlYXBpL0ZpbGVXcml0 ZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMzMsNyArMTMzLDYgQEAgdm9pZCBGaWxlV3JpdGVy OjphYm9ydChFeGNlcHRpb25Db2RlJiBlYwogICAgICAgICByZXR1cm47CiAgICAgfQogCi0gICAg bV9lcnJvciA9IEZpbGVFcnJvcjo6Y3JlYXRlKEZpbGVFcnJvcjo6QUJPUlRfRVJSKTsKICAgICB3 cml0ZXIoKS0+YWJvcnQoKTsKIH0KIApAQCAtMTUzLDkgKzE1Miw3IEBAIHZvaWQgRmlsZVdyaXRl cjo6ZGlkV3JpdGUobG9uZyBsb25nIGJ5dGUKICAgICBmaXJlRXZlbnQoZXZlbnROYW1lcygpLnBy b2dyZXNzRXZlbnQpOwogICAgIGlmIChjb21wbGV0ZSkgewogICAgICAgICBtX2Jsb2JCZWluZ1dy aXR0ZW4uY2xlYXIoKTsKLSAgICAgICAgZmlyZUV2ZW50KGV2ZW50TmFtZXMoKS53cml0ZUV2ZW50 KTsKLSAgICAgICAgbV9yZWFkeVN0YXRlID0gRE9ORTsKLSAgICAgICAgZmlyZUV2ZW50KGV2ZW50 TmFtZXMoKS53cml0ZWVuZEV2ZW50KTsKKyAgICAgICAgc2NyaXB0RXhlY3V0aW9uQ29udGV4dCgp LT5wb3N0VGFzayhuZXcgRmlsZVdyaXRlckNvbXBsZXRpb25FdmVudFRhc2sodGhpcywgRmlsZUVy cm9yOjpPSykpOwogICAgIH0KIH0KIApAQCAtMTY3LDIwICsxNjQsMjYgQEAgdm9pZCBGaWxlV3Jp dGVyOjpkaWRUcnVuY2F0ZSgpCiAgICAgaWYgKHBvc2l0aW9uKCkgPiBsZW5ndGgoKSkKICAgICAg ICAgc2V0UG9zaXRpb24obGVuZ3RoKCkpOwogICAgIG1fdHJ1bmNhdGVMZW5ndGggPSAtMTsKLSAg ICBmaXJlRXZlbnQoZXZlbnROYW1lcygpLndyaXRlRXZlbnQpOwotICAgIG1fcmVhZHlTdGF0ZSA9 IERPTkU7Ci0gICAgZmlyZUV2ZW50KGV2ZW50TmFtZXMoKS53cml0ZWVuZEV2ZW50KTsKKyAgICBz Y3JpcHRFeGVjdXRpb25Db250ZXh0KCktPnBvc3RUYXNrKG5ldyBGaWxlV3JpdGVyQ29tcGxldGlv bkV2ZW50VGFzayh0aGlzLCBGaWxlRXJyb3I6Ok9LKSk7CiB9CiAKIHZvaWQgRmlsZVdyaXRlcjo6 ZGlkRmFpbChGaWxlRXJyb3I6OkVycm9yQ29kZSBjb2RlKQogewotICAgIG1fZXJyb3IgPSBGaWxl RXJyb3I6OmNyZWF0ZShjb2RlKTsKLSAgICBmaXJlRXZlbnQoZXZlbnROYW1lcygpLmVycm9yRXZl bnQpOwotICAgIGlmIChGaWxlRXJyb3I6OkFCT1JUX0VSUiA9PSBjb2RlKQotICAgICAgICBmaXJl RXZlbnQoZXZlbnROYW1lcygpLmFib3J0RXZlbnQpOwotICAgIGZpcmVFdmVudChldmVudE5hbWVz KCkuZXJyb3JFdmVudCk7CisgICAgQVNTRVJUKGNvZGUgIT0gRmlsZUVycm9yOjpPSyk7CiAgICAg bV9ibG9iQmVpbmdXcml0dGVuLmNsZWFyKCk7CisgICAgc2NyaXB0RXhlY3V0aW9uQ29udGV4dCgp LT5wb3N0VGFzayhuZXcgRmlsZVdyaXRlckNvbXBsZXRpb25FdmVudFRhc2sodGhpcywgY29kZSkp OworfQorCit2b2lkIEZpbGVXcml0ZXI6OnNpZ25hbENvbXBsZXRpb24oRmlsZUVycm9yOjpFcnJv ckNvZGUgY29kZSkKK3sKICAgICBtX3JlYWR5U3RhdGUgPSBET05FOworICAgIGlmIChGaWxlRXJy b3I6Ok9LICE9IGNvZGUpIHsKKyAgICAgICAgbV9lcnJvciA9IEZpbGVFcnJvcjo6Y3JlYXRlKGNv ZGUpOworICAgICAgICBmaXJlRXZlbnQoZXZlbnROYW1lcygpLmVycm9yRXZlbnQpOworICAgICAg ICBpZiAoRmlsZUVycm9yOjpBQk9SVF9FUlIgPT0gY29kZSkKKyAgICAgICAgICAgIGZpcmVFdmVu dChldmVudE5hbWVzKCkuYWJvcnRFdmVudCk7CisgICAgfSBlbHNlCisgICAgICAgIGZpcmVFdmVu dChldmVudE5hbWVzKCkud3JpdGVFdmVudCk7CiAgICAgZmlyZUV2ZW50KGV2ZW50TmFtZXMoKS53 cml0ZWVuZEV2ZW50KTsKIH0KIApJbmRleDogU291cmNlL1dlYkNvcmUvZmlsZWFwaS9GaWxlV3Jp dGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZmlsZWFwaS9GaWxlV3JpdGVyLmgJ KHJldmlzaW9uIDgyNzU0KQorKysgU291cmNlL1dlYkNvcmUvZmlsZWFwaS9GaWxlV3JpdGVyLmgJ KHdvcmtpbmcgY29weSkKQEAgLTM2LDYgKzM2LDcgQEAKICNpbmNsdWRlICJBY3RpdmVET01PYmpl Y3QuaCIKICNpbmNsdWRlICJFdmVudFRhcmdldC5oIgogI2luY2x1ZGUgIkZpbGVXcml0ZXJCYXNl LmgiCisjaW5jbHVkZSAiU2NyaXB0RXhlY3V0aW9uQ29udGV4dC5oIgogI2luY2x1ZGUgPHd0Zi9Q YXNzUmVmUHRyLmg+CiAjaW5jbHVkZSA8d3RmL1JlZlB0ci5oPgogCkBAIC0xMDIsNiArMTAzLDI1 IEBAIHByaXZhdGU6CiAKICAgICB2b2lkIHNldEVycm9yKEZpbGVFcnJvcjo6RXJyb3JDb2RlLCBF eGNlcHRpb25Db2RlJik7CiAKKyAgICB2b2lkIHNpZ25hbENvbXBsZXRpb24oRmlsZUVycm9yOjpF cnJvckNvZGUpOworCisgICAgY2xhc3MgRmlsZVdyaXRlckNvbXBsZXRpb25FdmVudFRhc2sgOiBw dWJsaWMgU2NyaXB0RXhlY3V0aW9uQ29udGV4dDo6VGFzayB7CisgICAgcHVibGljOgorICAgICAg ICBGaWxlV3JpdGVyQ29tcGxldGlvbkV2ZW50VGFzayhQYXNzUmVmUHRyPEZpbGVXcml0ZXI+IGZp bGVXcml0ZXIsIEZpbGVFcnJvcjo6RXJyb3JDb2RlIGNvZGUpCisgICAgICAgICAgICA6IG1fZmls ZVdyaXRlcihmaWxlV3JpdGVyKQorICAgICAgICAgICAgLCBtX2NvZGUoY29kZSkKKyAgICAgICAg eworICAgICAgICB9CisKKyAgICAgICAgdmlydHVhbCB2b2lkIHBlcmZvcm1UYXNrKFNjcmlwdEV4 ZWN1dGlvbkNvbnRleHQqKQorICAgICAgICB7CisgICAgICAgICAgICBtX2ZpbGVXcml0ZXItPnNp Z25hbENvbXBsZXRpb24obV9jb2RlKTsKKyAgICAgICAgfQorICAgIHByaXZhdGU6CisgICAgICAg IFJlZlB0cjxGaWxlV3JpdGVyPiBtX2ZpbGVXcml0ZXI7CisgICAgICAgIEZpbGVFcnJvcjo6RXJy b3JDb2RlIG1fY29kZTsKKyAgICB9OworCiAgICAgUmVmUHRyPEZpbGVFcnJvcj4gbV9lcnJvcjsK ICAgICBFdmVudFRhcmdldERhdGEgbV9ldmVudFRhcmdldERhdGE7CiAgICAgUmVhZHlTdGF0ZSBt X3JlYWR5U3RhdGU7CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA4Mjk5NSkKKysrIExheW91dFRlc3RzL0No YW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDExLTA0LTA1ICBFcmlj IFVocmhhbmUgIDxlcmljdUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgU29tZSBGaWxlV3JpdGVyIHByb2dyZXNzIGV2ZW50cyBz aG91bGQgYmUgcXVldWVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD01MDg0NgorCisgICAgICAgICogZmFzdC9maWxlc3lzdGVtL3Jlc291cmNlcy9maWxl LXdyaXRlci1ldmVudHMuanM6CisgICAgICAgIChvbldyaXRlKTogRXhwZWN0IHJlYWR5U3RhdGUg YXQgb253cml0ZSB0byBiZSBET05FIG5vdywgbm90IFdSSVRJTkcuCisgICAgICAgICogZmFzdC9m aWxlc3lzdGVtL3Jlc291cmNlcy9maWxlLXdyaXRlci11dGlscy5qczoKKyAgICAgICAgU3dpdGNo IHRvIHVzaW5nIG9ud3JpdGUsIG5vdyB0aGF0IGl0IHdvcmtzLgorCiAyMDExLTA0LTA1ICBKZXNz aWUgQmVybGluICA8amJlcmxpbkBhcHBsZS5jb20+CiAKICAgICAgICAgMyB0ZXN0cyBmYWlsIG9u IGFwcGxlLW1hY3Byby02IChkdWUgdG8gZGlmZmVyZW50IEpTIE1JTUUgdHlwZSkgYnV0IG5vdCBh bnkgb3RoZXIgTGVvcGFyZApJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9maWxlc3lzdGVtL3Jlc291 cmNlcy9maWxlLXdyaXRlci1ldmVudHMuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFz dC9maWxlc3lzdGVtL3Jlc291cmNlcy9maWxlLXdyaXRlci1ldmVudHMuanMJKHJldmlzaW9uIDgy NzU0KQorKysgTGF5b3V0VGVzdHMvZmFzdC9maWxlc3lzdGVtL3Jlc291cmNlcy9maWxlLXdyaXRl ci1ldmVudHMuanMJKHdvcmtpbmcgY29weSkKQEAgLTQ5LDcgKzQ5LDcgQEAgZnVuY3Rpb24gb25Q cm9ncmVzcyhlKSB7CiB9CiAKIGZ1bmN0aW9uIG9uV3JpdGUoZSkgewotICAgIGFzc2VydCh3cml0 ZXIucmVhZHlTdGF0ZSA9PSB3cml0ZXIuV1JJVElORyk7CisgICAgYXNzZXJ0KHdyaXRlci5yZWFk eVN0YXRlID09IHdyaXRlci5ET05FKTsKICAgICBhc3NlcnQoc2F3V3JpdGVTdGFydCk7CiAgICAg YXNzZXJ0KHNhd1Byb2dyZXNzKTsKICAgICBhc3NlcnQobGFzdFByb2dyZXNzID09IGUudG90YWwp OwpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9maWxlc3lzdGVtL3Jlc291cmNlcy9maWxlLXdyaXRl ci11dGlscy5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2ZpbGVzeXN0ZW0vcmVz b3VyY2VzL2ZpbGUtd3JpdGVyLXV0aWxzLmpzCShyZXZpc2lvbiA4Mjc1NCkKKysrIExheW91dFRl c3RzL2Zhc3QvZmlsZXN5c3RlbS9yZXNvdXJjZXMvZmlsZS13cml0ZXItdXRpbHMuanMJKHdvcmtp bmcgY29weSkKQEAgLTExNiw4ICsxMTYsOCBAQCBmdW5jdGlvbiBjcmVhdGVFbXB0eUZpbGUoZmls ZVN5c3RlbSwgZmlsCiAgICAgICAgIHJldHVybiBmdW5jdGlvbihmaWxlV3JpdGVyKSB7CiAgICAg ICAgICAgICB2YXIgc3VjY2Vzc0Z1bmMgPSBnZXRTdWNjZXNzRnVuYyhmaWxlRW50cnkpOwogICAg ICAgICAgICAgZmlsZVdyaXRlci5vbkVycm9yID0gb25FcnJvcjsKLSAgICAgICAgICAgIC8vIEZJ WE1FOiBUaGlzIHNob3VsZCBiZSBvbndyaXRlLCBidXQgdGhlIHNwZWMgYW5kIGNvZGUgbmVlZCB0 byBiZSBjaGFuZ2VkIHRvIGFsbG93IHRoYXQuICBTZWUgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTUwODQ2LgotICAgICAgICAgICAgZmlsZVdyaXRlci5vbndyaXRlZW5k ID0gZnVuY3Rpb24oKSB7CisgICAgICAgICAgICBmaWxlV3JpdGVyLm9ud3JpdGUgPSBmdW5jdGlv bigpIHsKKyAgICAgICAgICAgICAgICBmaWxlV3JpdGVyLm9ud3JpdGUgPSBudWxsOwogICAgICAg ICAgICAgICAgIHZlcmlmeUZpbGVMZW5ndGgoZmlsZUVudHJ5LCAwLCBzdWNjZXNzRnVuYyk7CiAg ICAgICAgICAgICB9OwogICAgICAgICAgICAgZmlsZVdyaXRlci50cnVuY2F0ZSgwKTsKQEAgLTE0 MywxNyArMTQzLDE2IEBAIGZ1bmN0aW9uIHdyaXRlU3RyaW5nKGZpbGVFbnRyeSwgZmlsZVdyaXQK ICAgICBpZiAob2Zmc2V0IDwgMCkKICAgICAgICAgb2Zmc2V0ICs9IGZpbGVXcml0ZXIubGVuZ3Ro OwogICAgIGFzc2VydChvZmZzZXQgPj0gMCk7Ci0gICAgLy8gRklYTUU6IFRoaXMgc2hvdWxkIGJl IG9ud3JpdGUsIGJ1dCB0aGUgc3BlYyBhbmQgY29kZSBuZWVkIHRvIGJlIGNoYW5nZWQgdG8gYWxs b3cgdGhhdC4gIFNlZSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTA4 NDYuCi0gICAgZmlsZVdyaXRlci5vbndyaXRlZW5kID0gZnVuY3Rpb24oKSB7Ci0gICAgICAgIGZp bGVXcml0ZXIub253cml0ZWVuZCA9IG51bGw7CisgICAgZmlsZVdyaXRlci5vbndyaXRlID0gZnVu Y3Rpb24oKSB7CisgICAgICAgIGZpbGVXcml0ZXIub253cml0ZSA9IG51bGw7CiAgICAgICAgIHZl cmlmeUJ5dGVSYW5nZUFzU3RyaW5nKGZpbGVFbnRyeSwgb2Zmc2V0LCBkYXRhLCBvblN1Y2Nlc3Mp OwogICAgIH07CiB9CiAKIGZ1bmN0aW9uIHNldEZpbGVDb250ZW50cyhmaWxlRW50cnksIGZpbGVX cml0ZXIsIGNvbnRlbnRzLCBvblN1Y2Nlc3MpIHsKICAgICBmaWxlV3JpdGVyLm9uZXJyb3IgPSBv bkVycm9yOwotICAgIC8vIEZJWE1FOiBUaGlzIHNob3VsZCBiZSBvbndyaXRlLCBidXQgdGhlIHNw ZWMgYW5kIGNvZGUgbmVlZCB0byBiZSBjaGFuZ2VkIHRvIGFsbG93IHRoYXQuICBTZWUgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUwODQ2LgotICAgIGZpbGVXcml0ZXIu b253cml0ZWVuZCA9IGZ1bmN0aW9uKCkgeworICAgIGZpbGVXcml0ZXIub253cml0ZSA9IGZ1bmN0 aW9uKCkgeworICAgICAgICBmaWxlV3JpdGVyLm9ud3JpdGUgPSBudWxsOwogICAgICAgICB3cml0 ZVN0cmluZyhmaWxlRW50cnksIGZpbGVXcml0ZXIsIDAsIGNvbnRlbnRzLCBvblN1Y2Nlc3MpOwog ICAgIH07CiAgICAgZmlsZVdyaXRlci50cnVuY2F0ZSgwKTsK