50842 2010-12-10 13:56:24 -0800 Shader::loadShader() must initialize variable passed to getShaderiv 2010-12-10 19:01:01 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 0 scheib webkit-unassigned jamesr webkit.review.bot oldest_to_newest 320387 0 scheib 2010-12-10 13:56:24 -0800 Shader::loadShader() must initialize variable passed to getShaderiv 320391 1 76254 scheib 2010-12-10 13:57:41 -0800 Created attachment 76254 Patch 320396 2 scheib 2010-12-10 14:01:08 -0800 Looks like recent additions of debug check logic are now warning us of uninitialized variables passed to getter functions. E.g. this output on a debug build: gpu/command_buffer/client/../client/gles2_c_lib_autogen.h(369): GPU_DCHECK(params && (params[0] == static_cast<GLint>(0) || params[0] == static_cast<GLint>(-1)) (0)) failed. 320398 3 76254 jamesr 2010-12-10 14:02:55 -0800 Comment on attachment 76254 Patch Good catch! R=me 320544 4 76254 webkit.review.bot 2010-12-10 19:00:56 -0800 Comment on attachment 76254 Patch Clearing flags on attachment: 76254 Committed r73832: <http://trac.webkit.org/changeset/73832> 320545 5 webkit.review.bot 2010-12-10 19:01:01 -0800 All reviewed patches have been landed. Closing bug. 76254 2010-12-10 13:57:41 -0800 2010-12-10 19:00:56 -0800 Patch bug-50842-20101210135740.patch text/plain 1424 scheib ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Y2M4OGU0YjZlMzNiMjc1NTU1NjM3YWU4ZmUyMTY3OGNjNDNlYThiOC4uYTFkOTc2Mzk0YzNmMjEz YzRmNGQ3ZWYzNjU0ZThlMmY3YTcxMTEwMCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0xMi0xMCAgVmlu Y2VudCBTY2hlaWIgIDxzY2hlaWJAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNoYWRlcjo6bG9hZFNoYWRlcigpIG11c3QgaW5p dGlhbGl6ZSB2YXJpYWJsZSBwYXNzZWQgdG8gZ2V0U2hhZGVyaXYKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUwODQyCisKKyAgICAgICAgVGVzdDogZmFz dC9jYW52YXMvY2FudmFzLWxhcmdlZHJhd3MuaHRtbAorCisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3MvZ3B1L1NoYWRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTaGFkZXI6OmxvYWRTaGFk ZXIpOgorCiAyMDEwLTEyLTEwICBKb2NlbHluIFR1cmNvdHRlICA8am9jZWx5bi50dXJjb3R0ZUBu b2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgbm9ib2R5LCBidWlsZCBmaXguCmRpZmYg LS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dwdS9TaGFkZXIuY3BwIGIvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9ncHUvU2hhZGVyLmNwcAppbmRleCAxMjBjNjUyYTk3OTVkZWMz NGVmMmY5OTI1NmVjNWUyNTI1ZTE0MjAwLi42OTc4MzIyNzI5NGNlNmI3ZDZkNjgyMzRjMmFlMTA4 ZDlmMjRhODE0IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dwdS9TaGFk ZXIuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1L1NoYWRlci5jcHAKQEAg LTY1LDcgKzY1LDcgQEAgdW5zaWduZWQgU2hhZGVyOjpsb2FkU2hhZGVyKEdyYXBoaWNzQ29udGV4 dDNEKiBjb250ZXh0LCB1bnNpZ25lZCB0eXBlLCBjb25zdCBjaGEKICAgICBTdHJpbmcgc2hhZGVy U291cmNlU3RyKHNoYWRlclNvdXJjZSk7CiAgICAgY29udGV4dC0+c2hhZGVyU291cmNlKHNoYWRl ciwgc2hhZGVyU291cmNlU3RyKTsKICAgICBjb250ZXh0LT5jb21waWxlU2hhZGVyKHNoYWRlcik7 Ci0gICAgaW50IGNvbXBpbGVTdGF0dXM7CisgICAgaW50IGNvbXBpbGVTdGF0dXMgPSAwOwogICAg IGNvbnRleHQtPmdldFNoYWRlcml2KHNoYWRlciwgR3JhcGhpY3NDb250ZXh0M0Q6OkNPTVBJTEVf U1RBVFVTLCAmY29tcGlsZVN0YXR1cyk7CiAgICAgaWYgKCFjb21waWxlU3RhdHVzKSB7CiAgICAg ICAgIFN0cmluZyBpbmZvTG9nID0gY29udGV4dC0+Z2V0U2hhZGVySW5mb0xvZyhzaGFkZXIpOwo=