50830 2010-12-10 10:43:31 -0800 Use FileSystem::remove when cleaning up http lock files 2010-12-10 12:23:32 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 tony tony abarth eric oldest_to_newest 320239 0 tony 2010-12-10 10:43:31 -0800 Use FileSystem::remove when cleaning up http lock files 320241 1 76220 tony 2010-12-10 10:46:01 -0800 Created attachment 76220 Patch 320242 2 tony 2010-12-10 10:47:24 -0800 Here's a more precise description of the problem we were seeing on Windows: When a process is killed, Windows may hold on to the files for a short time after the process has ended. It reminds me of how tcp ports may still be used for a short while after the process using them has been killed. 320244 3 tony 2010-12-10 10:48:13 -0800 (In reply to comment #2) > Here's a more precise description of the problem we were seeing on Windows: > > When a process is killed, Windows may hold on to the files for a short time after the process has ended. It reminds me of how tcp ports may still be used for a short while after the process using them has been killed. Oh, so it's not clear that we want to apply FileSystem.remove everywhere, but I guess it would be harmless to do so. Maybe we should rename it to something more specific for this specific case? 320316 4 eric 2010-12-10 12:18:16 -0800 Generally using Filesysem function is better than os. because they're more easily mockable. 320317 5 76220 eric 2010-12-10 12:18:43 -0800 Comment on attachment 76220 Patch OK. 320322 6 tony 2010-12-10 12:23:32 -0800 Committed r73769: <http://trac.webkit.org/changeset/73769> 76220 2010-12-10 10:46:01 -0800 2010-12-10 12:18:43 -0800 Patch bug-50830-20101210104653.patch text/plain 3408 tony ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA1YWI5MmU0MDE2NWI0MWMyZDg2OWQ1ODllMDUxZDc2Njc1ZDRiYWUyLi4xNzg4MTAz YzEzNzNlNTdmYzhlMWEwZTEzZDFmYWU2YTI4M2U1NTNmIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTAtMTItMTAgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2UgRmlsZVN5c3RlbTo6cmVt b3ZlIHdoZW4gY2xlYW5pbmcgdXAgaHR0cCBsb2NrIGZpbGVzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MDgzMAorCisgICAgICAgICogU2NyaXB0cy93 ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9odHRwX2xvY2sucHk6CisKIDIwMTAtMTItMTAgIEFs ZWphbmRybyBHLiBDYXN0cm8gIDxhbGV4QGlnYWxpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgTWFydGluIFJvYmluc29uLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJr aXRweS9jb21tb24vc3lzdGVtL2ZpbGVzeXN0ZW0ucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dl YmtpdHB5L2NvbW1vbi9zeXN0ZW0vZmlsZXN5c3RlbS5weQppbmRleCBkMzE0M2ZkMmUwZDhjZmZk MzY3ZjA2YWM3YmYyODk3MTliYWY1NzkyLi5mMGI1ZTQ0ZmNhYzdmNmYwNzNmZTY3NzRhZWMxZTY0 YjEyYjZjOGQ0IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1v bi9zeXN0ZW0vZmlsZXN5c3RlbS5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5 L2NvbW1vbi9zeXN0ZW0vZmlsZXN5c3RlbS5weQpAQCAtMTAzLDEyICsxMDMsMTAgQEAgY2xhc3Mg RmlsZVN5c3RlbShvYmplY3QpOgogICAgICAgICBwYXNzCiAKICAgICBkZWYgcmVtb3ZlKHNlbGYs IHBhdGgsIG9zcmVtb3ZlPW9zLnJlbW92ZSk6Ci0gICAgICAgICIiIk9uIFdpbmRvd3MsIG9zLnJl bW92ZSBjYW4gc29tZXRpbWVzIGZhaWwuICBXZSBzZWUgdGhpcyBiZWhhdmlvciBpbgotICAgICAg ICBDaHJvbWl1bSB0ZXN0cyBhcyB3ZWxsIGFuZCBhcmUgdW5zdXJlIHdoeS4gIE90aGVycyBvbiB0 aGUgaW50ZXJuZXQgYXJlCi0gICAgICAgIGVxdWFsbHkgY29uZnVzZWQ6Ci0gICAgICAgIGh0dHA6 Ly9zb2NpYWwubXNkbi5taWNyb3NvZnQuY29tL0ZvcnVtcy9lbi93aW5kb3dzc2VhcmNoL3RocmVh ZC81NTU4MmQ5ZC03N2VhLTQ3ZDktOTFjZS1jZmY3Y2E3ZWY1MjgKLSAgICAgICAgaHR0cDovL2Nv ZGVzZWFyY2guZ29vZ2xlLmNvbS9jb2Rlc2VhcmNoL3A/aGw9ZW4jT0FNbHhfam8tY2svc3JjL2Jh c2UvdGVzdC90ZXN0X2ZpbGVfdXRpbF93aW4uY2MmcT1kaWVmaWxlZGllJmV4YWN0X3BhY2thZ2U9 Y2hyb21pdW0mbD0yMgotICAgICAgICAiIiIKKyAgICAgICAgIiIiT24gV2luZG93cywgaWYgYSBw cm9jZXNzIHdhcyByZWNlbnRseSBraWxsZWQgYW5kIGl0IGhlbGQgb24gdG8gYQorICAgICAgICBm aWxlLCB0aGUgT1Mgd2lsbCBob2xkIG9uIHRvIHRoZSBmaWxlIGZvciBhIHNob3J0IHdoaWxlLiAg VGhpcyBtYWtlcworICAgICAgICBhdHRlbXB0cyB0byBkZWxldGUgdGhlIGZpbGUgZmFpbC4gIFRv IHdvcmsgYXJvdW5kIHRoYXQsIHRoaXMgbWV0aG9kCisgICAgICAgIHdpbGwgcmV0cnkgZm9yIGEg ZmV3IHNlY29uZHMgdW50aWwgV2luZG93cyBpcyBkb25lIHdpdGggdGhlIGZpbGUuIiIiCiAgICAg ICAgIHRyeToKICAgICAgICAgICAgIGV4Y2VwdGlvbnMuV2luZG93c0Vycm9yCiAgICAgICAgIGV4 Y2VwdCBBdHRyaWJ1dGVFcnJvcjoKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvaHR0cF9sb2NrLnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0 cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9odHRwX2xvY2sucHkKaW5kZXggODk5NWIyMThl Y2JmYmQ1Zjc1MWIyNzZhNjJhZmJhOWE4NGM0MzIzOC4uZjU5NDZiNjZhMTU0NzRjYWVhZDdjMTY0 MTYwYTFiYjk1NTA0MjA1NSAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvcG9ydC9odHRwX2xvY2sucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0 cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9odHRwX2xvY2sucHkKQEAgLTM3LDYgKzM3LDcg QEAgaW1wb3J0IHRpbWUKIAogZnJvbSB3ZWJraXRweS5jb21tb24uc3lzdGVtLmV4ZWN1dGl2ZSBp bXBvcnQgRXhlY3V0aXZlCiBmcm9tIHdlYmtpdHB5LmNvbW1vbi5zeXN0ZW0uZmlsZV9sb2NrIGlt cG9ydCBGaWxlTG9jaworZnJvbSB3ZWJraXRweS5jb21tb24uc3lzdGVtLmZpbGVzeXN0ZW0gaW1w b3J0IEZpbGVTeXN0ZW0KIAogCiBfbG9nID0gbG9nZ2luZy5nZXRMb2dnZXIoIndlYmtpdHB5Lmxh eW91dF90ZXN0cy5wb3J0Lmh0dHBfbG9jayIpCkBAIC02MSw3ICs2Miw3IEBAIGNsYXNzIEh0dHBM b2NrKG9iamVjdCk6CiAgICAgICAgICIiIkRlbGV0ZSB0aGUgbG9jayBmaWxlIGlmIGV4aXN0cy4i IiIKICAgICAgICAgaWYgb3MucGF0aC5leGlzdHMoc2VsZi5fcHJvY2Vzc19sb2NrX2ZpbGVfbmFt ZSk6CiAgICAgICAgICAgICBfbG9nLmRlYnVnKCJSZW1vdmluZyBsb2NrIGZpbGU6ICVzIiAlIHNl bGYuX3Byb2Nlc3NfbG9ja19maWxlX25hbWUpCi0gICAgICAgICAgICBvcy51bmxpbmsoc2VsZi5f cHJvY2Vzc19sb2NrX2ZpbGVfbmFtZSkKKyAgICAgICAgICAgIEZpbGVTeXN0ZW0oKS5yZW1vdmUo c2VsZi5fcHJvY2Vzc19sb2NrX2ZpbGVfbmFtZSkKIAogICAgIGRlZiBfZXh0cmFjdF9sb2NrX251 bWJlcihzZWxmLCBsb2NrX2ZpbGVfbmFtZSk6CiAgICAgICAgICIiIlJldHVybiB0aGUgbG9jayBu dW1iZXIgZnJvbSBsb2NrIGZpbGUuIiIiCkBAIC05Myw3ICs5NCw3IEBAIGNsYXNzIEh0dHBMb2Nr KG9iamVjdCk6CiAgICAgICAgICAgICBjdXJyZW50X2xvY2tfZmlsZS5jbG9zZSgpCiAgICAgICAg ICAgICBpZiBub3QgKGN1cnJlbnRfcGlkIGFuZCBzZWxmLl9leGVjdXRpdmUuY2hlY2tfcnVubmlu Z19waWQoaW50KGN1cnJlbnRfcGlkKSkpOgogICAgICAgICAgICAgICAgIF9sb2cuZGVidWcoIlJl bW92aW5nIHN0dWNrIGxvY2sgZmlsZTogJXMiICUgbG9ja19saXN0WzBdKQotICAgICAgICAgICAg ICAgIG9zLnVubGluayhsb2NrX2xpc3RbMF0pCisgICAgICAgICAgICAgICAgRmlsZVN5c3RlbSgp LnJlbW92ZShsb2NrX2xpc3RbMF0pCiAgICAgICAgICAgICAgICAgcmV0dXJuCiAgICAgICAgIGV4 Y2VwdCAoSU9FcnJvciwgT1NFcnJvcik6CiAgICAgICAgICAgICByZXR1cm4K